)]}'
{"neutronclient/neutron/v2_0/fw/firewallpolicy.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ee8eb7156feb87fde9c1a903dcec33e17c7dcab3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FXCY%3D","line":177,"updated":"2013-09-28 11:57:29.000000000","message":"what if the parsed_args.id is invalid? the call_api will return something or raise?\n\nhere the printed message assumes this action will always success, which may not right","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3059f2b60ec6bb28b4601605c8ab44c925d4d670","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FWpM%3D","line":177,"in_reply_to":"AAAAS3%2F%2FXCY%3D","updated":"2013-09-28 18:36:01.000000000","message":"If the id is invalid call_api will raise. When the code path reaches here everything is good.","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ee8eb7156feb87fde9c1a903dcec33e17c7dcab3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class FirewallPolicyRemoveRule(neutronv20.UpdateCommand):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FXCs%3D","line":178,"updated":"2013-09-28 11:57:29.000000000","message":"-1: why the return is needed?","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3059f2b60ec6bb28b4601605c8ab44c925d4d670","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":"        return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"class FirewallPolicyRemoveRule(neutronv20.UpdateCommand):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FWpI%3D","line":178,"in_reply_to":"AAAAS3%2F%2FXCs%3D","updated":"2013-09-28 18:36:01.000000000","message":"Done","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ee8eb7156feb87fde9c1a903dcec33e17c7dcab3","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                                       self.resource,"},{"line_number":216,"context_line":"                                                       parsed_args.id)"},{"line_number":217,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":218,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":219,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":220,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":221,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FXCU%3D","line":218,"updated":"2013-09-28 11:57:29.000000000","message":"ditto","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3059f2b60ec6bb28b4601605c8ab44c925d4d670","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                                       self.resource,"},{"line_number":216,"context_line":"                                                       parsed_args.id)"},{"line_number":217,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":218,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":219,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":220,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":221,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FWpE%3D","line":218,"in_reply_to":"AAAAS3%2F%2FXCU%3D","updated":"2013-09-28 18:36:01.000000000","message":"See comment earlier.","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ee8eb7156feb87fde9c1a903dcec33e17c7dcab3","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":219,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":220,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":221,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FXCo%3D","line":221,"updated":"2013-09-28 11:57:29.000000000","message":"ditto","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3059f2b60ec6bb28b4601605c8ab44c925d4d670","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":219,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":220,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":221,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FWpA%3D","line":221,"in_reply_to":"AAAAS3%2F%2FXCo%3D","updated":"2013-09-28 18:36:01.000000000","message":"Done","commit_id":"6ae39ce57de94e4f5ec27dd1129c350c99bfe2a2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de67f001d526abc97a15c12c729fb945d4423c72","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                                       parsed_args.id)"},{"line_number":174,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FVnA%3D","line":176,"updated":"2013-09-29 18:30:35.000000000","message":"A colon looks unnecessary.","commit_id":"ac431370de169a8d295cb5be6eee61d0665e27e8"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fd1ce2be42fb8ef48376cdd0e640ddd853d44a84","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                                       parsed_args.id)"},{"line_number":174,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":175,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":176,"context_line":"            _(\u0027Inserted firewall rule in firewall policy: %(id)s\u0027) %"},{"line_number":177,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FU20%3D","line":176,"in_reply_to":"AAAAS3%2F%2FVnA%3D","updated":"2013-09-30 07:14:47.000000000","message":"Done","commit_id":"ac431370de169a8d295cb5be6eee61d0665e27e8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"de67f001d526abc97a15c12c729fb945d4423c72","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                                       parsed_args.id)"},{"line_number":216,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":217,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":218,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":219,"context_line":"            {\u0027id\u0027: parsed_args.id})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FVm8%3D","line":218,"updated":"2013-09-29 18:30:35.000000000","message":"Ditto","commit_id":"ac431370de169a8d295cb5be6eee61d0665e27e8"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fd1ce2be42fb8ef48376cdd0e640ddd853d44a84","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                                       parsed_args.id)"},{"line_number":216,"context_line":"        self.call_api(neutron_client, _id, body)"},{"line_number":217,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":218,"context_line":"            _(\u0027Removed firewall rule from firewall policy: %(id)s\u0027) %"},{"line_number":219,"context_line":"            {\u0027id\u0027: parsed_args.id})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FU2w%3D","line":218,"in_reply_to":"AAAAS3%2F%2FVm8%3D","updated":"2013-09-30 07:14:47.000000000","message":"Done","commit_id":"ac431370de169a8d295cb5be6eee61d0665e27e8"}]}