)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8c74d70ec81ce1dbcd6090a7724cb729b4677b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df3967d1_f4645be7","updated":"2017-08-01 19:55:28.000000000","message":"This commit message no longer reflects what the patchset does, now that we are adding unit tests. At the very least, the commit message should be updated. Maybe, the patchset should be split in two. On this last comment, I\u0027ll let other reviewers chime in","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5661a1f39ffa94abf24a11946ffb37f2e3090410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf3e73b7_a8880171","in_reply_to":"df3967d1_1cb92fcb","updated":"2017-08-06 23:15:40.000000000","message":"Added in patch set 6","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"73a6a2cfd37ae582d093ad9a942ad54065ffc2c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df3967d1_85f156d0","in_reply_to":"df3967d1_65fe72af","updated":"2017-08-01 22:49:09.000000000","message":"I think so","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0bbf9a37b3bc653439404fc2f5a58adf49f83845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df3967d1_1cb92fcb","in_reply_to":"df3967d1_85f156d0","updated":"2017-08-02 12:01:05.000000000","message":"I am okay with either. It is usual to add or change unit tests when we have some feature.","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"368603f08a3116d89e7a8cfdc21fa4376f78f948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df3967d1_65fe72af","in_reply_to":"df3967d1_f4645be7","updated":"2017-08-01 22:42:31.000000000","message":"Are you saying the commit message must state that I\u0027m adding unit tests?","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0bbf9a37b3bc653439404fc2f5a58adf49f83845","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Igor Duarte Cardoso \u003cigor.duarte.cardoso@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-01 15:19:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add missing correlation type \"mpls\" to PP help"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add missing correlation type \"mpls\" to Port Pair create"},{"line_number":10,"context_line":"command\u0027s help (PortPairCreate)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_7cc71b47","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":41},"updated":"2017-08-02 12:01:05.000000000","message":"nit: personally \u0027port pair\u0027 would be preferred (as abbrev has several meanings)","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"8a8bbbae5277d57364639d554644b25d1c3fae23","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Igor Duarte Cardoso \u003cigor.duarte.cardoso@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-01 15:19:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add missing correlation type \"mpls\" to PP help"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add missing correlation type \"mpls\" to Port Pair create"},{"line_number":10,"context_line":"command\u0027s help (PortPairCreate)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_f1c78d95","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":41},"in_reply_to":"df3967d1_7cc71b47","updated":"2017-08-03 11:11:04.000000000","message":"\"port pair\" is above 50 char limit, which is why I use \"PP\" here.","commit_id":"e7190c774a0d2a9faf9dbf416bb89f347eba1b9c"}],"neutronclient/osc/v2/sfc/sfc_port_pair.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1e875da9e5b9fc1f7f7cf8ce0e76bc5d0c147ecf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027weight\u0027],"},{"line_number":60,"context_line":"            help\u003d_(\u0027Dictionary of service function parameters. \u0027"},{"line_number":61,"context_line":"                   \u0027Currently, only correlation\u003dNone|mpls and weight \u0027"},{"line_number":62,"context_line":"                   \u0027is supported. Weight is an integer that influences \u0027"},{"line_number":63,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":64,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"},{"line_number":65,"context_line":"                   \u0027hash to the port pair. The default weight is 1.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_78a23cfe","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":22},"updated":"2017-07-27 20:49:44.000000000","message":"This should be \u0027are\u0027. I know you didn\u0027t introduce this error but since you are fixing this help text, we can also fix this error","commit_id":"6398ca577dc4bdf454f27061440cd22a873a2305"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a90fa9c3d6cf8e0f3760be078878fdd39a1584c4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027weight\u0027],"},{"line_number":60,"context_line":"            help\u003d_(\u0027Dictionary of service function parameters. \u0027"},{"line_number":61,"context_line":"                   \u0027Currently, only correlation\u003dNone|mpls and weight \u0027"},{"line_number":62,"context_line":"                   \u0027is supported. Weight is an integer that influences \u0027"},{"line_number":63,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":64,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"},{"line_number":65,"context_line":"                   \u0027hash to the port pair. The default weight is 1.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_ab7f1b64","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":22},"in_reply_to":"ff346bd7_78a23cfe","updated":"2017-07-28 10:24:43.000000000","message":"No problem,","commit_id":"6398ca577dc4bdf454f27061440cd22a873a2305"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88aa2edc77f9060a43e497c70e6938e4f5e61509","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":59,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027weight\u0027],"},{"line_number":60,"context_line":"            help\u003d_(\u0027Dictionary of service function parameters. \u0027"},{"line_number":61,"context_line":"                   \u0027Currently, only correlation\u003dNone|mpls and weight \u0027"},{"line_number":62,"context_line":"                   \u0027are supported. Weight is an integer that influences \u0027"},{"line_number":63,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":64,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_0b9fcc5f","line":61,"range":{"start_line":61,"start_character":48,"end_line":61,"end_character":57},"updated":"2017-08-01 11:52:53.000000000","message":"(None|mpls)  is better.\n\nIn addition, \"only\" looks unnecessary.","commit_id":"64466c97ef921f3a5c64c075217b2dd96169da2f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"dd8562e2d5eed98cdb981b9bd8ecbc548398348c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":59,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027weight\u0027],"},{"line_number":60,"context_line":"            help\u003d_(\u0027Dictionary of service function parameters. \u0027"},{"line_number":61,"context_line":"                   \u0027Currently, only correlation\u003dNone|mpls and weight \u0027"},{"line_number":62,"context_line":"                   \u0027are supported. Weight is an integer that influences \u0027"},{"line_number":63,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":64,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_77951ae4","line":61,"range":{"start_line":61,"start_character":48,"end_line":61,"end_character":57},"in_reply_to":"df3967d1_0b9fcc5f","updated":"2017-08-01 14:10:30.000000000","message":"OK","commit_id":"64466c97ef921f3a5c64c075217b2dd96169da2f"}],"neutronclient/tests/unit/osc/v2/sfc/test_port_pair.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88aa2edc77f9060a43e497c70e6938e4f5e61509","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                          \u0027egress\u0027: self._port_pair[\u0027egress\u0027],"},{"line_number":111,"context_line":"                          \u0027description\u0027: self._port_pair[\u0027description\u0027],"},{"line_number":112,"context_line":"                          \u0027service_function_parameters\u0027:"},{"line_number":113,"context_line":"                              [{\u0027correlation\u0027: str(correlation), \u0027weight\u0027:"},{"line_number":114,"context_line":"                                  \u00271\u0027}],"},{"line_number":115,"context_line":"                          }"},{"line_number":116,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_4ba3949f","line":113,"range":{"start_line":113,"start_character":47,"end_line":113,"end_character":63},"updated":"2017-08-01 11:52:53.000000000","message":"If \"None\" is passed below, str() will be unnecessary.","commit_id":"64466c97ef921f3a5c64c075217b2dd96169da2f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88aa2edc77f9060a43e497c70e6938e4f5e61509","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_create_port_pair_all_options(self):"},{"line_number":121,"context_line":"        self._test_create_port_pair_all_options(None)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_create_port_pair_all_options_mpls(self):"},{"line_number":124,"context_line":"        self._test_create_port_pair_all_options(\u0027mpls\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_ab92004a","line":121,"range":{"start_line":121,"start_character":48,"end_line":121,"end_character":52},"updated":"2017-08-01 11:52:53.000000000","message":"In my understanding, None is a string, so how about passing \"None\" rather than None.","commit_id":"64466c97ef921f3a5c64c075217b2dd96169da2f"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"dd8562e2d5eed98cdb981b9bd8ecbc548398348c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_create_port_pair_all_options(self):"},{"line_number":121,"context_line":"        self._test_create_port_pair_all_options(None)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_create_port_pair_all_options_mpls(self):"},{"line_number":124,"context_line":"        self._test_create_port_pair_all_options(\u0027mpls\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_571d7671","line":121,"range":{"start_line":121,"start_character":48,"end_line":121,"end_character":52},"in_reply_to":"df3967d1_ab92004a","updated":"2017-08-01 14:10:30.000000000","message":"True, my plan was to have the test as close to the code as possible, but since I end up converting the input to string in line 94 anyway, might as well just pass the \u0027None\u0027 string here and simplify.","commit_id":"64466c97ef921f3a5c64c075217b2dd96169da2f"}]}