)]}'
{"neutronclient/osc/v2/sfc/sfc_port_pair_group.py":[{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027tap_enabled\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_LONG_ONLY)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_c9d7c423","line":39,"range":{"start_line":39,"start_character":48,"end_line":39,"end_character":62},"updated":"2017-08-07 07:17:10.000000000","message":"IMO Tab enabled option can display for both :) just for better display. If you feel LIST_LONG_ONLY makes good still it\u0027s okay","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027tap_enabled\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_LONG_ONLY)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_65529d3d","line":39,"range":{"start_line":39,"start_character":48,"end_line":39,"end_character":62},"in_reply_to":"bf3e73b7_c9d7c423","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"02ae7d3cd9ffca8557a9f901090dc6eb98c653ea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":64,"context_line":"        tap_enable \u003d parser.add_mutually_exclusive_group()"},{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--tap-enabled\u0027,"},{"line_number":67,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":68,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_ba03ae0f","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":28},"updated":"2017-08-05 14:57:14.000000000","message":"From OSC convention, this should be \u0027--enable-tap\u0027","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":64,"context_line":"        tap_enable \u003d parser.add_mutually_exclusive_group()"},{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--tap-enabled\u0027,"},{"line_number":67,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":68,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_25482585","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":28},"in_reply_to":"bf3e73b7_ba03ae0f","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":68,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":70,"context_line":"                   \u0027passive Tap service function.\u0027)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_09514cd9","line":70,"range":{"start_line":70,"start_character":48,"end_line":70,"end_character":49},"updated":"2017-08-07 07:17:10.000000000","message":"Period not necessary for single sentence as per OSC convention","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":68,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":70,"context_line":"                   \u0027passive Tap service function.\u0027)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_295410ca","line":70,"range":{"start_line":70,"start_character":28,"end_line":70,"end_character":32},"updated":"2017-08-07 07:17:10.000000000","message":"Tab \u003d\u003e tab","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":68,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":70,"context_line":"                   \u0027passive Tap service function.\u0027)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_e55d6d47","line":70,"range":{"start_line":70,"start_character":48,"end_line":70,"end_character":49},"in_reply_to":"bf3e73b7_09514cd9","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"02ae7d3cd9ffca8557a9f901090dc6eb98c653ea","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                   \u0027passive Tap service function.\u0027)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_8dfe7603","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":29},"updated":"2017-08-05 14:57:14.000000000","message":"\u003d\u003e --disable-tap","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                   \u0027passive Tap service function.\u0027)"},{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_a553f538","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":29},"in_reply_to":"bf3e73b7_8dfe7603","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function. (default)\u0027)"},{"line_number":78,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_4973d4e8","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":32},"updated":"2017-08-07 07:17:10.000000000","message":"shall we make \"default\u003dTrue\" here?","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--tap-disabled\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function. (default)\u0027)"},{"line_number":78,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_8532390f","line":75,"range":{"start_line":75,"start_character":31,"end_line":75,"end_character":32},"in_reply_to":"bf3e73b7_4973d4e8","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function. (default)\u0027)"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027--port-pair-group-parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_69733882","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":37},"updated":"2017-08-07 07:17:10.000000000","message":"can remove period","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            dest\u003d\u0027tap_disabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function. (default)\u0027)"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027--port-pair-group-parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_65373d01","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":37},"in_reply_to":"bf3e73b7_69733882","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a2d2efd0d434de3506aa0090c50b9d665bef3e57","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_3e38843b","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":31},"updated":"2017-10-21 07:30:18.000000000","message":"It is better to use separate destination for --enable-tap and --disable-tap. Looking at _get_attrs() below, \u0027tap_enabled\u0027 field is always sent when creating a PPG. IMHO, it is better not to send the attribute if no option is specified.\n\nThus, my suggestion is (help is omitted):\n\n  tap_enable.add_argument(\u0027--enable-tap\u0027, action\u003d\u0027store_true\u0027)\n  tap_enable.add_argument(\u0027--disable-tap\u0027, action\u003d\u0027store_true\u0027)\n\nand\n\n  def _get_attrs(...):\n    ...\n    if parsed_args.enable_tap:\n      attrs[\u0027tap_enabled\u0027] \u003d True\n    if parsed_args.disable_tap:\n      attrs[\u0027tap_enabled\u0027] \u003d False","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"540cbf89f9ae4bd67e8e60d688d5fddca205d736","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":"        tap_enable.add_argument("},{"line_number":73,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":74,"context_line":"            dest\u003d\u0027tap_enabled\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":77,"context_line":"                   \u0027service function (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_7463bbb2","line":74,"range":{"start_line":74,"start_character":11,"end_line":74,"end_character":31},"in_reply_to":"3f4b6375_3e38843b","updated":"2017-10-21 13:44:22.000000000","message":"Done","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027tap_enabled\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_221bb481","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":17},"updated":"2017-10-23 10:10:09.000000000","message":"tap_enabled \u003d\u003e enable_tap","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e6bedec85887bc89720c465984db8ea9c18369a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027tap_enabled\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_68086d2b","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":17},"in_reply_to":"3f4b6375_221bb481","updated":"2017-10-23 11:24:56.000000000","message":"Done","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_42c5905a","line":68,"range":{"start_line":68,"start_character":55,"end_line":68,"end_character":57},"updated":"2017-10-23 10:10:09.000000000","message":"are?","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_82f4a8d0","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":54},"updated":"2017-10-23 10:10:09.000000000","message":"port-pair-group \u003d\u003e port pair group","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e6bedec85887bc89720c465984db8ea9c18369a7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_65ad3687","line":68,"range":{"start_line":68,"start_character":55,"end_line":68,"end_character":57},"in_reply_to":"3f4b6375_42c5905a","updated":"2017-10-23 11:24:56.000000000","message":"Done","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e6bedec85887bc89720c465984db8ea9c18369a7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        tap_enable.add_argument("},{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_e5e7e6e3","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":54},"in_reply_to":"3f4b6375_82f4a8d0","updated":"2017-10-23 11:24:56.000000000","message":"Done","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_e228fc34","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":31},"updated":"2017-10-23 10:10:09.000000000","message":"Tap \u003d\u003e tab","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e6bedec85887bc89720c465984db8ea9c18369a7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027--enable-tap\u0027,"},{"line_number":67,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as \u0027"},{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_2b4eef6e","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":31},"in_reply_to":"3f4b6375_e228fc34","updated":"2017-10-23 11:24:56.000000000","message":"Done","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":73,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":75,"context_line":"                   \u0027service function (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_427c70b4","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":26},"updated":"2017-10-23 10:10:09.000000000","message":"IMO, we can set \"TRUE\" as default value  for this arg( \"default\u003dTrue\")","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9141d5e375769d1d43262b18fae4f74e7e33b9b4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   \u0027passive Tap service function\u0027)"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":73,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":75,"context_line":"                   \u0027service function (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_71adf42f","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":26},"in_reply_to":"3f4b6375_427c70b4","updated":"2017-10-23 13:08:01.000000000","message":"Why do we need to specify the default value? The server side implementation determines the default value. CLI implementation should not mirror the server side implementation and lets the server determine the default value if not value is specified.","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e7218babfbc8f59f5877eeabde7c03b0cf7b51f4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":73,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":75,"context_line":"                   \u0027service function (default)\u0027)"},{"line_number":76,"context_line":"        )"},{"line_number":77,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_4217d0ee","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":54},"updated":"2017-10-23 10:10:09.000000000","message":"same","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e6bedec85887bc89720c465984db8ea9c18369a7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        tap_enable.add_argument("},{"line_number":72,"context_line":"            \u0027--disable-tap\u0027,"},{"line_number":73,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":74,"context_line":"            help\u003d_(\u0027Port pairs of this port-pair-group is deployed as L3 \u0027"},{"line_number":75,"context_line":"                   \u0027service function (default)\u0027)"},{"line_number":76,"context_line":"        )"},{"line_number":77,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_0518c2d0","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":54},"in_reply_to":"3f4b6375_4217d0ee","updated":"2017-10-23 11:24:56.000000000","message":"Done","commit_id":"0bc74cd3d01f7f0e3624663e34b7c5e4522b6110"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9141d5e375769d1d43262b18fae4f74e7e33b9b4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027enable_tap\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_b1a24c4a","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":17},"updated":"2017-10-23 13:08:01.000000000","message":"There are \u0027enable_tap\u0027 and \u0027tap_enabled\u0027 (L.303).\nI don\u0027t think there are two different attributes. Which is correct?","commit_id":"a1d4690544a127f0bc59550dccb08902fdf90696"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"1611fcd8a66f63affb9413b038af0d4d9e58454a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027enable_tap\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_cca52e06","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":17},"in_reply_to":"3f4b6375_69ff4c34","updated":"2017-10-23 14:38:59.000000000","message":"Sure I will revert that. But look like my previous comment about the change was not conveyed well. The argument was, that \u0027enable_tap\u0027 in attr. suits more than \u0027tap_enabled\u0027 looking to the options.\n\nBut at same time it has caused confusion, I will revert back to \u0027tap_enabled\u0027 right away. Thanks.","commit_id":"a1d4690544a127f0bc59550dccb08902fdf90696"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"e379a868dc2bc1181867e48c3cd81318bb9522bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027enable_tap\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_b75a3c27","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":17},"in_reply_to":"3f4b6375_b1a24c4a","updated":"2017-10-23 13:43:07.000000000","message":"@mohankumar commented that instead of \u0027tap_enbaled\u0027, \u0027enable_tap\u0027 will be more suitable for CLI. Extension only recognise \u0027tap_enabled\u0027 attribute though. In _get_attrs() L - 207, the patch is sending \u0027tap_enabled\u0027 to the server. @amotoki @bcafarel @mohankumar - If it looks like confusing, should I revert back to \u0027tap_enabled\u0027? Much chances are it is inducing some confusion.","commit_id":"a1d4690544a127f0bc59550dccb08902fdf90696"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"0a9b35718d7630610573117f72cdcb5641b75c45","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027enable_tap\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_7c46eb23","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":17},"in_reply_to":"3f4b6375_b1a24c4a","updated":"2017-10-23 13:18:19.000000000","message":"Maybe a typo in recent patchsets (I think it was correct before), the attribute is \"tap_enabled\" (related API review: https://review.openstack.org/#/c/449954/ )","commit_id":"a1d4690544a127f0bc59550dccb08902fdf90696"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b87162061fc749fb03a55371dfbee59cfac59087","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":37,"context_line":"    (\u0027group_id\u0027, \u0027Loadbalance ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027enable_tap\u0027, \u0027Tap Enabled\u0027, nc_osc_utils.LIST_BOTH)"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_69ff4c34","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":17},"in_reply_to":"3f4b6375_b75a3c27","updated":"2017-10-23 14:23:57.000000000","message":"The first column of _attr_map corresponds to an attribute name in the API and the second column specifies a user visible string, so I believe \u0027tap_enabled\u0027 is the correct one for the first column.\n\nRegarding CLI option name, we need to follow OSC convention, but \u0027tap_enabled\u0027 in the API req/resp is a different topic.\n\nAs a conclusion, could you revert back to \u0027tap_enabled\"?","commit_id":"a1d4690544a127f0bc59550dccb08902fdf90696"}],"neutronclient/tests/unit/osc/v2/sfc/test_port_pair_group.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"02ae7d3cd9ffca8557a9f901090dc6eb98c653ea","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        ]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":122,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.neutronclient.create_port_pair_group.assert_called_once_with({"},{"line_number":125,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_da067221","line":122,"updated":"2017-08-05 14:57:14.000000000","message":"the return value of create_port_pari_group is defined at L.57.\nyou need to define the return value properly.","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    _ppgs \u003d fakes.FakeSfcPortPairGroup.create_port_pair_groups(count\u003d1)"},{"line_number":169,"context_line":"    columns \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Port Pair\u0027, \u0027Port Pair Group Parameters\u0027)"},{"line_number":170,"context_line":"    columns_long \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Port Pair\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":171,"context_line":"                    \u0027Description\u0027, \u0027Loadbalance ID\u0027, \u0027Project\u0027)"},{"line_number":172,"context_line":"    _port_pair_group \u003d _ppgs[0]"},{"line_number":173,"context_line":"    data \u003d ["},{"line_number":174,"context_line":"        _port_pair_group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_294890ca","line":171,"range":{"start_line":171,"start_character":61,"end_line":171,"end_character":63},"updated":"2017-08-07 07:17:10.000000000","message":"Include \"Tap Enabled\" in the columns_long tuple and assign corresponding data reference in L209-L214\n\n[Py27 error snip]\n\n\nreference \u003d [\u0027ID\u0027,\n \u0027Name\u0027,\n \u0027Port Pair\u0027,\n \u0027Port Pair Group Parameters\u0027,\n \u0027Description\u0027,\n \u0027Loadbalance ID\u0027,\n \u0027Project\u0027]\nactual    \u003d [\u0027ID\u0027,\n \u0027Name\u0027,\n \u0027Port Pair\u0027,\n \u0027Port Pair Group Parameters\u0027,\n \u0027Description\u0027,\n \u0027Loadbalance ID\u0027,\n \u0027Project\u0027,\n \u0027Tap Enabled\u0027]","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    _ppgs \u003d fakes.FakeSfcPortPairGroup.create_port_pair_groups(count\u003d1)"},{"line_number":169,"context_line":"    columns \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Port Pair\u0027, \u0027Port Pair Group Parameters\u0027)"},{"line_number":170,"context_line":"    columns_long \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Port Pair\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":171,"context_line":"                    \u0027Description\u0027, \u0027Loadbalance ID\u0027, \u0027Project\u0027)"},{"line_number":172,"context_line":"    _port_pair_group \u003d _ppgs[0]"},{"line_number":173,"context_line":"    data \u003d ["},{"line_number":174,"context_line":"        _port_pair_group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_253dc5dc","line":171,"range":{"start_line":171,"start_character":61,"end_line":171,"end_character":63},"in_reply_to":"bf3e73b7_294890ca","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80901d2c493b65227c79bbf159df9290b152b77a","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self.assertIsNone(result)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestShowSfcPortPairGroup(fakes.TestNeutronClientOSCV2):"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    _ppg \u003d fakes.FakeSfcPortPairGroup.create_port_pair_group()"},{"line_number":325,"context_line":"    data \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3e73b7_09e14c9b","line":322,"range":{"start_line":322,"start_character":6,"end_line":322,"end_character":30},"updated":"2017-08-07 07:17:10.000000000","message":"same comment as L171","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"622b1ecdf1fef0096f3443d0aa40dd93caf52ac7","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self.assertIsNone(result)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"class TestShowSfcPortPairGroup(fakes.TestNeutronClientOSCV2):"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    _ppg \u003d fakes.FakeSfcPortPairGroup.create_port_pair_group()"},{"line_number":325,"context_line":"    data \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_052649cf","line":322,"range":{"start_line":322,"start_character":6,"end_line":322,"end_character":30},"in_reply_to":"bf3e73b7_09e14c9b","updated":"2017-10-16 08:13:17.000000000","message":"Done","commit_id":"bd38d3f77ed8889fa71fd9eb1c2f15939543fd68"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a2d2efd0d434de3506aa0090c50b9d665bef3e57","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        ]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":124,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.neutronclient.create_sfc_port_pair_group.assert_called_once_with({"},{"line_number":127,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_1e2828e0","line":124,"updated":"2017-10-21 07:30:18.000000000","message":"In a PPG created FakeSfcPortPairGroup.create_port_pair_group,\nthe default tap_enabled is False, so IIRC take_action() at L.124 returns a PPG with tap_enabled\u003dFalse.\nIn this case, --enable-tap is passed, so I think tap_enabled\u003dTrue should be returned from take_action and L.135 should be called as expected parameter.","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"540cbf89f9ae4bd67e8e60d688d5fddca205d736","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        ]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":124,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.neutronclient.create_sfc_port_pair_group.assert_called_once_with({"},{"line_number":127,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_342b0331","line":124,"in_reply_to":"3f4b6375_1e2828e0","updated":"2017-10-21 13:44:22.000000000","message":"I understood your concern. I added the method to update the fake response. I didn\u0027t understood the following comment - \"L. 135 should be called as expected parameter\" .","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8f1143119b97ddc917c4b22ef1756e61d48ec160","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        ]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":124,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.neutronclient.create_sfc_port_pair_group.assert_called_once_with({"},{"line_number":127,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_99554bc9","line":124,"in_reply_to":"3f4b6375_342b0331","updated":"2017-10-22 11:38:49.000000000","message":"What I mean is the return value of take_action should return the appropriate value. PERHAPS self.neutronclient.create_sfc_port_pair_group.return_value needs to be tweaked. I haven\u0027t checked more than this.","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"82fb3b81821f371497ba04a3233381b43f091371","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        ]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":124,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.neutronclient.create_sfc_port_pair_group.assert_called_once_with({"},{"line_number":127,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e474966a","line":124,"in_reply_to":"3f4b6375_39bc17ba","updated":"2017-10-22 14:37:20.000000000","message":"Thanks. I missed that. I commented on patch set 7.","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"79dba040984a6d5decfe87e31219a18fdd95e038","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        ]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":124,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        self.neutronclient.create_sfc_port_pair_group.assert_called_once_with({"},{"line_number":127,"context_line":"            \u0027port_pair_group\u0027: {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_39bc17ba","line":124,"in_reply_to":"3f4b6375_99554bc9","updated":"2017-10-22 12:10:24.000000000","message":"If that was the comment then I have changed/tewaked that in PS 7.","commit_id":"14521307eb7b749931f6189f7adaee0e0a1e73d0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"82fb3b81821f371497ba04a3233381b43f091371","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        })"},{"line_number":134,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":135,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _update_expected_response(self, data):"},{"line_number":138,"context_line":"        # REVISIT(vks1) - This method can be common for other test functions."},{"line_number":139,"context_line":"        resp \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_045e92e5","line":136,"updated":"2017-10-22 14:37:20.000000000","message":"I think you can use fakes.FakeSfcPortPairGroup.create_port_pair_group().\n\n  ppg \u003d fakes.FakeSfcPortPairGroup.create_port_pair_group(tap_enabled\u003dTrue)\n self.neutronclient.create_sfc_port_pair_group.return_value \u003d {\u0027port_pair_group\u0027: ppg}\n\nFor self.data, I think it is better to change self.get_data to accept a port pair group and then,\n\n  expected_data \u003d self.get_data(ppg)\n\nDoes it make sense?","commit_id":"3c31a18d95975dba51517fdd0ee77401f166c422"},{"author":{"_account_id":14744,"name":"Vikash Kumar","email":"vikash.kumar@oneconvergence.com","username":"vks"},"change_message_id":"4043ab090b680fd39b8841da02d346c1c09047cb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        })"},{"line_number":134,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":135,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _update_expected_response(self, data):"},{"line_number":138,"context_line":"        # REVISIT(vks1) - This method can be common for other test functions."},{"line_number":139,"context_line":"        resp \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_442feaf5","line":136,"in_reply_to":"3f4b6375_045e92e5","updated":"2017-10-22 15:07:40.000000000","message":"OK. We can use the existing fake method. I have updated as you suggested in PS 8. Thanks.","commit_id":"3c31a18d95975dba51517fdd0ee77401f166c422"}]}