)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"01a3099568cc77422424b93c273f267e81b9caac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add support to delete existing extra-dhcp-opt(s) for a port"},{"line_number":10,"context_line":"via the port-update operation. To use it, set the opt_value\u003dnull"},{"line_number":11,"context_line":"of the opt_name that you want deleted (i.e. neutron port-update"},{"line_number":12,"context_line":"--extra-dhcp-opt opt_name\u003dtftp-server,opt_value\u003dnull), which will"},{"line_number":13,"context_line":"delete this DHCP option from the port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9c2c2474b2bfe8c8f8c3c3cc1513d2b999643d14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2FZ%2BQ%3D","line":12,"updated":"2014-01-14 03:07:26.000000000","message":"why not \u003dNone? That\u0027s usually what we do in the client to clear things. It would be nice if this patch added a testcase.","commit_id":"210b72c0da7e9f3fd07b279f5d60d763dca0730e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"12575a8c5bfcb445f0c801647b1bb6c137754c9d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add support to delete existing extra-dhcp-opt(s) for a port"},{"line_number":10,"context_line":"via the port-update operation. To use it, set the opt_value\u003dnull"},{"line_number":11,"context_line":"of the opt_name that you want deleted (i.e. neutron port-update"},{"line_number":12,"context_line":"--extra-dhcp-opt opt_name\u003dtftp-server,opt_value\u003dnull), which will"},{"line_number":13,"context_line":"delete this DHCP option from the port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9c2c2474b2bfe8c8f8c3c3cc1513d2b999643d14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUH%2F%2B3yM%3D","line":12,"in_reply_to":"AAAAUH%2F%2FZ%2BQ%3D","updated":"2014-01-21 08:39:20.000000000","message":"hi Aaron - see https://review.openstack.org/#/c/49166/4/neutronclient/neutron/v2_0/port.py","commit_id":"210b72c0da7e9f3fd07b279f5d60d763dca0730e"}],"neutronclient/neutron/v2_0/port.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"6e5fd7a1dd7037504db93013ca83b0f2441b3491","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    opt_ele.update(utils.str2dict(opt))"},{"line_number":128,"context_line":"                    if ((\u0027opt_name\u0027 in opt_ele) and"},{"line_number":129,"context_line":"                        (\u0027opt_value\u0027 in opt_ele)):"},{"line_number":130,"context_line":"                        if opt_ele[\u0027opt_value\u0027] \u003d\u003d \u0027null\u0027:"},{"line_number":131,"context_line":"                            opt_ele[\u0027opt_value\u0027] \u003d None"},{"line_number":132,"context_line":"                        ops.append(opt_ele)"},{"line_number":133,"context_line":"                        opt_ele \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8yss%3D","line":130,"updated":"2013-12-20 09:18:31.000000000","message":"is this really needed? seems to me from I75baeff91575cac6546fe2cc6fcf7a0d8e92853f that if client passes in None for the value, the option will be deleted? Or do we expect that a client may use the string \u0027null\u0027 to specify the delete, in which case do we need a DocImpact in the commit message?\n\nOR, i could be completely wrong...","commit_id":"7864d62de19badb7a89a772247d855ae0452c8b1"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"5fc5f892a9e8f47334c7b469963873548f12665d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    opt_ele.update(utils.str2dict(opt))"},{"line_number":128,"context_line":"                    if ((\u0027opt_name\u0027 in opt_ele) and"},{"line_number":129,"context_line":"                        (\u0027opt_value\u0027 in opt_ele)):"},{"line_number":130,"context_line":"                        if opt_ele[\u0027opt_value\u0027] \u003d\u003d \u0027null\u0027:"},{"line_number":131,"context_line":"                            opt_ele[\u0027opt_value\u0027] \u003d None"},{"line_number":132,"context_line":"                        ops.append(opt_ele)"},{"line_number":133,"context_line":"                        opt_ele \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8oG8%3D","line":130,"in_reply_to":"AAAATn%2F8yss%3D","updated":"2013-12-24 05:15:05.000000000","message":"We\u0027ve decided that \u0027null\u0027 would be the value that the user will need to enter in order to delete a record, Mark McClain felt that \u0027None\u0027 has been used as a server name whereas he had never seen \u0027null\u0027 used.\n\nWill modify the commit message accordingly.","commit_id":"7864d62de19badb7a89a772247d855ae0452c8b1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"520da02152b0f850e5c449e1b91ba7f4bbf0a1db","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # both must be thrown out."},{"line_number":120,"context_line":"            opt_ele \u003d {}"},{"line_number":121,"context_line":"            edo_err_msg \u003d _(\"Invalid --extra-dhcp-opt option, can only be: \""},{"line_number":122,"context_line":"                            \"opt_name\u003d\u003cdhcp_option_name\u003e,opt_value\u003d\u003cvalue\u003e, \""},{"line_number":123,"context_line":"                            \"(This option can be repeated.\")"},{"line_number":124,"context_line":"            for opt in parsed_args.extra_dhcp_opts:"},{"line_number":125,"context_line":"                if opt.split(\u0027\u003d\u0027)[0] in [\u0027opt_value\u0027, \u0027opt_name\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2F3Rc%3D","line":122,"updated":"2014-02-27 18:28:54.000000000","message":"what if we allow the following:\n\nopt_name\u003d\u003cdhcp_option_name\u003e,[opt_value\u003d\u003cvalue\u003e|clear_value]\n\nOr is this something we discarded before?","commit_id":"3a9bd27f338b57f913cf61bb3df48dbc7ee5215c"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"de217bc404d13148d62d0fbf303938ce7c38e9ec","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # both must be thrown out."},{"line_number":120,"context_line":"            opt_ele \u003d {}"},{"line_number":121,"context_line":"            edo_err_msg \u003d _(\"Invalid --extra-dhcp-opt option, can only be: \""},{"line_number":122,"context_line":"                            \"opt_name\u003d\u003cdhcp_option_name\u003e,opt_value\u003d\u003cvalue\u003e, \""},{"line_number":123,"context_line":"                            \"(This option can be repeated.\")"},{"line_number":124,"context_line":"            for opt in parsed_args.extra_dhcp_opts:"},{"line_number":125,"context_line":"                if opt.split(\u0027\u003d\u0027)[0] in [\u0027opt_value\u0027, \u0027opt_name\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAVX%2F%2FwAA%3D","line":122,"in_reply_to":"AAAAVX%2F%2F3Rc%3D","updated":"2014-02-28 15:18:10.000000000","message":"a long time ago, we discussed this and the null trigger words was what we came up with, a clear character was discussed, but we felt, actually you, felt that we need something to indicate a directive to delete.","commit_id":"3a9bd27f338b57f913cf61bb3df48dbc7ee5215c"}]}
