)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f56835807fa11ecfcd9d043bd8ee3d23f961fe9c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch provides the support for the same in OSC."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: I312f7f572dab33bd56b0edf395e0e076d3203f5f"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0e5c90b06fba82b8c8e04a72fb3919264654feba"},{"line_number":15,"context_line":"Related-Bug: #1669956"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_764016a6","line":13,"updated":"2017-08-29 07:47:34.000000000","message":"Please add \u0027Depends-On: I312f7f572dab33bd56b0edf395e0e076d3203f5f\u0027","commit_id":"9162c6e30274187542dee25ea96bed27623da5f5"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4148e70bfc22b682326a208599dd6e94e5d7e9bd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch provides the support for the same in OSC."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: I312f7f572dab33bd56b0edf395e0e076d3203f5f"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0e5c90b06fba82b8c8e04a72fb3919264654feba"},{"line_number":15,"context_line":"Related-Bug: #1669956"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_aee95ee6","line":13,"in_reply_to":"7f287b81_764016a6","updated":"2017-08-30 12:09:04.000000000","message":"+1","commit_id":"9162c6e30274187542dee25ea96bed27623da5f5"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f89818afb055ffb5a452c5211bd71e5c3cd90ca5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003creedip.banerjee@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-11 08:33:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for DCCP and SCTP in Firewalls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Firewalls support filtering DCCP and SCTP with [1]."},{"line_number":10,"context_line":"This patch provides the support for the same in OSC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_36d0d01f","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"updated":"2018-08-08 06:34:46.000000000","message":"Please align phrase with \u0027FWaaS v2\u0027.","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28fcc397aabb36233c4752aa7512d50baca6638a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003creedip.banerjee@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-11 08:33:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for DCCP and SCTP in Firewalls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Firewalls support filtering DCCP and SCTP with [1]."},{"line_number":10,"context_line":"This patch provides the support for the same in OSC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_990e2230","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"3f79a3b5_36d0d01f","updated":"2018-09-07 11:36:57.000000000","message":"+1","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f89818afb055ffb5a452c5211bd71e5c3cd90ca5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for DCCP and SCTP in Firewalls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Firewalls support filtering DCCP and SCTP with [1]."},{"line_number":10,"context_line":"This patch provides the support for the same in OSC."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: I312f7f572dab33bd56b0edf395e0e076d3203f5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_b6a140ac","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"updated":"2018-08-08 06:34:46.000000000","message":"ditto","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"}],"neutronclient/tests/unit/osc/v2/fwaas/test_firewallrule.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46c92dc806a36a7f53898567bd5bf7f734bdf591","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_create_with_all_params_protocol_upper_capitalized(self):"},{"line_number":280,"context_line":"        for protocol in (\u0027TCP\u0027, \u0027Tcp\u0027, \u0027ANY\u0027, \u0027AnY\u0027, \u0027Sctp\u0027, \u0027dccp\u0027, \u0027iCMp\u0027):"},{"line_number":281,"context_line":"            arglist, verifylist \u003d self._set_all_params({\u0027protocol\u0027: protocol})"},{"line_number":282,"context_line":"            self.assertRaises("},{"line_number":283,"context_line":"                testtools.matchers._impl.MismatchError,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_0df1b895","line":280,"range":{"start_line":280,"start_character":62,"end_line":280,"end_character":66},"updated":"2017-08-29 13:14:43.000000000","message":"One letter in dccp should be capitalized.","commit_id":"9162c6e30274187542dee25ea96bed27623da5f5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"f9630efe60d8581d88e330f01eeef721ea3dd25e","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def test_create_with_all_params_protocol_any(self):"},{"line_number":261,"context_line":"        self._test_create_with_all_params({\u0027protocol\u0027: \u0027any\u0027})"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_create_with_all_params_ip_version_6(self):"},{"line_number":264,"context_line":"        self._test_create_with_all_params({\u0027ip_version\u0027: \u00276\u0027})"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_31704a08","line":262,"updated":"2017-12-11 12:55:11.000000000","message":"Is it better to add UTs covering the protocols newly adds?","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f89818afb055ffb5a452c5211bd71e5c3cd90ca5","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def test_create_with_all_params_protocol_any(self):"},{"line_number":261,"context_line":"        self._test_create_with_all_params({\u0027protocol\u0027: \u0027any\u0027})"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_create_with_all_params_ip_version_6(self):"},{"line_number":264,"context_line":"        self._test_create_with_all_params({\u0027ip_version\u0027: \u00276\u0027})"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_367e9019","line":262,"in_reply_to":"df87a7cf_31704a08","updated":"2018-08-08 06:34:46.000000000","message":"+1 : In addition, it will be great if you can add \u0027all protocol type\u0027 as testcase.","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28fcc397aabb36233c4752aa7512d50baca6638a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_create_with_all_params_protocol_upper_capitalized(self):"},{"line_number":280,"context_line":"        for protocol in (\u0027TCP\u0027, \u0027Tcp\u0027, \u0027ANY\u0027, \u0027AnY\u0027, \u0027Sctp\u0027, \u0027dcCp\u0027, \u0027iCMp\u0027):"},{"line_number":281,"context_line":"            arglist, verifylist \u003d self._set_all_params({\u0027protocol\u0027: protocol})"},{"line_number":282,"context_line":"            self.assertRaises("},{"line_number":283,"context_line":"                testtools.matchers._impl.MismatchError,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_595baa20","line":280,"range":{"start_line":280,"start_character":53,"end_line":280,"end_character":68},"updated":"2018-09-07 11:36:57.000000000","message":"I don\u0027t think you need to cover all protocols in this test.\nAdding more protocols does not improve the test coverage for upper/capitalization input.","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"}],"releasenotes/notes/fwaas-additional-protocol-support-499a94fbcad2a202.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c35b57941fbf274ca89f5c699392ed9d13154f03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to filter DCCP and SCTP packets by Firewall v2."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f5c4f37_33bc9368","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":62},"updated":"2017-09-21 05:05:15.000000000","message":"I think we usually call it as FWaaS v2 (not Firewall v2).","commit_id":"9e7cbcae992b5f66aba6f40bbc194101d94b3d6c"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f89818afb055ffb5a452c5211bd71e5c3cd90ca5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to filter DCCP and SCTP packets by FWaaS v2."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_7699686c","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":60},"updated":"2018-08-08 06:34:46.000000000","message":"Is it better to inform that we can specify \u0027dccp\u0027 and \u0027sctp\u0027 as \u0027protocol\u0027 for firewall rule?","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28fcc397aabb36233c4752aa7512d50baca6638a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to filter DCCP and SCTP packets by FWaaS v2."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_39326ef3","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":60},"in_reply_to":"3f79a3b5_7699686c","updated":"2018-09-07 11:36:57.000000000","message":"+1. firewall rule makes more sense.\nThis is a release note for CLI users, so it is recommended to which command is enhanced.","commit_id":"d104311092c47e6bafe644f28b31495fc6b10836"}]}