)]}'
{"neutronclient/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"069c074e177b7681cb19e3bf08af631b73f4cdff","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                             \u0027tenantName\u0027: self.tenant_name, }, }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.auth_url is None:"},{"line_number":230,"context_line":"            raise exceptions.InvalidAuthURLProvided()"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        token_url \u003d self.auth_url + \"/tokens\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F2%2BY%3D","line":230,"updated":"2013-10-26 19:18:36.000000000","message":"auth_url None means auth_url is not provided, so IMO NoAuthURLProvided is a better name than InvalidAuthURLProvided.","commit_id":"29a15b002fb4a3bdd04056ae60a2482d26398238"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"26d3d20b0f0a4d7ac2b392022fd7b835c1c15b8c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                             \u0027tenantName\u0027: self.tenant_name, }, }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        if self.auth_url is None:"},{"line_number":230,"context_line":"            raise exceptions.InvalidAuthURLProvided()"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        token_url \u003d self.auth_url + \"/tokens\""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F0SI%3D","line":230,"in_reply_to":"AAAATn%2F%2F2%2BY%3D","updated":"2013-10-28 14:58:24.000000000","message":"Agree.  Will update.","commit_id":"29a15b002fb4a3bdd04056ae60a2482d26398238"}],"neutronclient/common/exceptions.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"376455b1446f3bbe746a204b1657978f2262b8ca","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"class NoAuthURLProvided(BadInputError):"},{"line_number":153,"context_line":"    \"\"\"Occurs when auth_url passed into client is not provided.\"\"\""},{"line_number":154,"context_line":"    pass"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fx0A%3D","line":153,"updated":"2013-10-29 07:42:33.000000000","message":"The explanation looks odd. Consider \u0027Occurs when auth_url is not provided to the client\u0027. Also why not making this as error message rather than a docstring?","commit_id":"4bae20e98fd553997a420730326dae7b465572f1"}],"neutronclient/tests/unit/test_auth.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"069c074e177b7681cb19e3bf08af631b73f4cdff","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        ).AndReturn((res200, \u0027\u0027))"},{"line_number":132,"context_line":"        self.mox.ReplayAll()"},{"line_number":133,"context_line":"        self.client.do_request(\u0027/resource\u0027, \u0027GET\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_invalid_auth_url(self):"},{"line_number":136,"context_line":"        # Handle the case where a client passes in a None for the auth_url"},{"line_number":137,"context_line":"        self.client.auth_url \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F2%2BQ%3D","line":134,"updated":"2013-10-26 19:18:36.000000000","message":"Could you add a test to check if InvalidAuthURLProvided is raised when auth_url is not provided (auth_url \u003d\u003d None) and a token is expired?","commit_id":"29a15b002fb4a3bdd04056ae60a2482d26398238"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"26d3d20b0f0a4d7ac2b392022fd7b835c1c15b8c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        ).AndReturn((res200, \u0027\u0027))"},{"line_number":132,"context_line":"        self.mox.ReplayAll()"},{"line_number":133,"context_line":"        self.client.do_request(\u0027/resource\u0027, \u0027GET\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_invalid_auth_url(self):"},{"line_number":136,"context_line":"        # Handle the case where a client passes in a None for the auth_url"},{"line_number":137,"context_line":"        self.client.auth_url \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F0Rw%3D","line":134,"in_reply_to":"AAAATn%2F%2F2%2BQ%3D","updated":"2013-10-28 14:58:24.000000000","message":"I will work on that now.","commit_id":"29a15b002fb4a3bdd04056ae60a2482d26398238"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"376455b1446f3bbe746a204b1657978f2262b8ca","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                          \u0027GET\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_invalid_auth_url(self):"},{"line_number":157,"context_line":"        # Handle the case where a client passes in a None for the auth_url"},{"line_number":158,"context_line":"        self.client.auth_url \u003d None"},{"line_number":159,"context_line":"        self.assertRaises(exceptions.NoAuthURLProvided,"},{"line_number":160,"context_line":"                          self.client._get_endpoint_url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fxzk%3D","line":157,"updated":"2013-10-29 07:42:33.000000000","message":"nit: client does not pass anything, also remove \u0027a\u0027 before None. Consider \u0027Handle the case when auth_url is not provided\u0027","commit_id":"4bae20e98fd553997a420730326dae7b465572f1"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0a819ad00f31a63b60cc5c1061a95ea2340aa67e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                          \u0027/resource\u0027,"},{"line_number":154,"context_line":"                          \u0027GET\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_invalid_auth_url(self):"},{"line_number":157,"context_line":"        # Handle the case when auth_url is not provided"},{"line_number":158,"context_line":"        self.client.auth_url \u003d None"},{"line_number":159,"context_line":"        self.assertRaises(exceptions.NoAuthURLProvided,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B6GA%3D","line":156,"updated":"2013-11-18 17:51:26.000000000","message":"maybe rename to test_get_endpoint_url_with_invalid_auth_url","commit_id":"c781959c385dd0afd8160ac4702cbec41cc224ff"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d8c9b8c0f3358c61b15a1e8794ec7d159f3f3e77","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                          \u0027/resource\u0027,"},{"line_number":154,"context_line":"                          \u0027GET\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_invalid_auth_url(self):"},{"line_number":157,"context_line":"        # Handle the case when auth_url is not provided"},{"line_number":158,"context_line":"        self.client.auth_url \u003d None"},{"line_number":159,"context_line":"        self.assertRaises(exceptions.NoAuthURLProvided,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8ojs%3D","line":156,"in_reply_to":"AAAATn%2F%2B6GA%3D","updated":"2013-12-23 23:45:09.000000000","message":"agreed","commit_id":"c781959c385dd0afd8160ac4702cbec41cc224ff"}]}