)]}'
{"neutronclient/v2_0/client.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"48a220356e0e7ea186d7e19ab435cb6fdc722ceb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                # raise the appropriate error!"},{"line_number":76,"context_line":"                ex \u003d neutron_errors[error_type](message\u003derror_message)"},{"line_number":77,"context_line":"                ex.args \u003d ([dict(status_code\u003dstatus_code,"},{"line_number":78,"context_line":"                                 message\u003derror_message)], )"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fwag%3D","side":"PARENT","line":77,"updated":"2013-10-29 14:21:51.000000000","message":"we no longer need args? What if something uses it? Can you be 100% sure that\u0027s not the case? Wouldn\u0027t it be safer to leave this as is and add status_code to line 76?","commit_id":"a8c5c650ea7d51461c6311fb477b733b2f7c36a0"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fe1c15d810d5426ec714e4b39671cd01408d18ec","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                # raise the appropriate error!"},{"line_number":76,"context_line":"                ex \u003d neutron_errors[error_type](message\u003derror_message)"},{"line_number":77,"context_line":"                ex.args \u003d ([dict(status_code\u003dstatus_code,"},{"line_number":78,"context_line":"                                 message\u003derror_message)], )"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FpgY%3D","side":"PARENT","line":77,"in_reply_to":"AAAATn%2F%2FuiI%3D","updated":"2013-10-30 22:04:49.000000000","message":"I\u0027m sure this is fine as this method raises this exception outside of the python-neutronclient therefore we can see that nothing uses args after line 82","commit_id":"a8c5c650ea7d51461c6311fb477b733b2f7c36a0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3c0ae6e147509fb48aacb61bba39fc560060f984","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                # raise the appropriate error!"},{"line_number":76,"context_line":"                ex \u003d neutron_errors[error_type](message\u003derror_message)"},{"line_number":77,"context_line":"                ex.args \u003d ([dict(status_code\u003dstatus_code,"},{"line_number":78,"context_line":"                                 message\u003derror_message)], )"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FuiI%3D","side":"PARENT","line":77,"in_reply_to":"AAAATn%2F%2Fulk%3D","updated":"2013-10-29 20:19:48.000000000","message":"I agree but I wonder if this change fixes an issue and introduces another.","commit_id":"a8c5c650ea7d51461c6311fb477b733b2f7c36a0"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"59c1b2f0250f63df1b557aa83ef825cbb1611bdd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                # raise the appropriate error!"},{"line_number":76,"context_line":"                ex \u003d neutron_errors[error_type](message\u003derror_message)"},{"line_number":77,"context_line":"                ex.args \u003d ([dict(status_code\u003dstatus_code,"},{"line_number":78,"context_line":"                                 message\u003derror_message)], )"},{"line_number":79,"context_line":"            except Exception:"},{"line_number":80,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fulk%3D","side":"PARENT","line":77,"in_reply_to":"AAAATn%2F%2Fwag%3D","updated":"2013-10-29 20:03:47.000000000","message":"I suppose though I don\u0027t think that ex.args even makes sense here. What does that even do? ex is an instance of exceptions.PortNotFoundClient() and then an args is added to it.","commit_id":"a8c5c650ea7d51461c6311fb477b733b2f7c36a0"}]}