)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9835a2b91b0e6cd52c9a03cbaabbfe83579136c9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"I then changed update_dict so that values are sent on to the"},{"line_number":20,"context_line":"API call if they are not None (So False values are sent as well)."},{"line_number":21,"context_line":"The issue, however, was that \u0027shared\u0027 and \u0027audited\u0027 were then"},{"line_number":22,"context_line":"always sent (Even if they\u0027re the default False) but the unit"},{"line_number":23,"context_line":"tests weren\u0027t expecting a False value since it wasn\u0027t explicitly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2B7%2B4%3D","line":20,"updated":"2013-11-18 11:37:40.000000000","message":"I prefer to moving L.19-20 at the beginning of the 1st paragraph because L.19-20 is a solution for the issue described in the 1st paragraph.\n\nL.21-24 describes the background why argparse.SUPPRESS is introduced, so it is better to make L.21-24 and L.26-29 a single paragraph. At least it is better to have a blank line between L.20 and L.21.","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f42130d6a3da36fb346a024d1b895637fe515d2c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"I then changed update_dict so that values are sent on to the"},{"line_number":20,"context_line":"API call if they are not None (So False values are sent as well)."},{"line_number":21,"context_line":"The issue, however, was that \u0027shared\u0027 and \u0027audited\u0027 were then"},{"line_number":22,"context_line":"always sent (Even if they\u0027re the default False) but the unit"},{"line_number":23,"context_line":"tests weren\u0027t expecting a False value since it wasn\u0027t explicitly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2B7Gk%3D","line":20,"in_reply_to":"AAAATn%2F%2B7%2B4%3D","updated":"2013-11-18 14:57:10.000000000","message":"Done","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9835a2b91b0e6cd52c9a03cbaabbfe83579136c9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The issue, however, was that \u0027shared\u0027 and \u0027audited\u0027 were then"},{"line_number":22,"context_line":"always sent (Even if they\u0027re the default False) but the unit"},{"line_number":23,"context_line":"tests weren\u0027t expecting a False value since it wasn\u0027t explicitly"},{"line_number":24,"context_line":"stated."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The solution is to only send the value if it is not the default"},{"line_number":27,"context_line":"value, using argparse\u0027s default mechanism. If it is the default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2B798%3D","line":24,"updated":"2013-11-18 11:37:40.000000000","message":"I think the issue we need to address here is not to keep the unit test unchanged but to avoid sending an attribute (shared, audited) whose value is the default value. It is better to reword.","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f42130d6a3da36fb346a024d1b895637fe515d2c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The issue, however, was that \u0027shared\u0027 and \u0027audited\u0027 were then"},{"line_number":22,"context_line":"always sent (Even if they\u0027re the default False) but the unit"},{"line_number":23,"context_line":"tests weren\u0027t expecting a False value since it wasn\u0027t explicitly"},{"line_number":24,"context_line":"stated."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The solution is to only send the value if it is not the default"},{"line_number":27,"context_line":"value, using argparse\u0027s default mechanism. If it is the default,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2B7Go%3D","line":24,"in_reply_to":"AAAATn%2F%2B798%3D","updated":"2013-11-18 14:57:10.000000000","message":"Done","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"dcd49cd7222a279d80059c1749e6fdc581a3f4f8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"After the change to update_dict the issue, however, was that"},{"line_number":22,"context_line":"\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if they\u0027re"},{"line_number":23,"context_line":"the default False) but the unit tests weren\u0027t expecting a False"},{"line_number":24,"context_line":"value since it wasn\u0027t explicitly stated. Instead of changing"},{"line_number":25,"context_line":"the unit tests, the solution is to only send the value in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2B6CE%3D","line":22,"updated":"2013-11-18 18:07:22.000000000","message":"Not clear what you mean, maybe the following? \n\nthey\u0027re the default -\u003e their default was False","commit_id":"4c6aa0ede730b90206fd2639158d8e8174d3272d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"582d24085c746acf98fbf563625367bb0c2170b0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"After the change to update_dict the issue, however, was that"},{"line_number":22,"context_line":"\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if they\u0027re"},{"line_number":23,"context_line":"the default False) but the unit tests weren\u0027t expecting a False"},{"line_number":24,"context_line":"value since it wasn\u0027t explicitly stated. Instead of changing"},{"line_number":25,"context_line":"the unit tests, the solution is to only send the value in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2B5tc%3D","line":22,"in_reply_to":"AAAATn%2F%2B5t8%3D","updated":"2013-11-18 19:38:16.000000000","message":"It does, you can choose the base version from the \"older version\" drop down just about the patch sets.","commit_id":"4c6aa0ede730b90206fd2639158d8e8174d3272d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5c325497dae42dbdf66c5aab1fd571e765473494","unresolved":false,"context_lines":[{"line_number":19,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"After the change to update_dict the issue, however, was that"},{"line_number":22,"context_line":"\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if they\u0027re"},{"line_number":23,"context_line":"the default False) but the unit tests weren\u0027t expecting a False"},{"line_number":24,"context_line":"value since it wasn\u0027t explicitly stated. Instead of changing"},{"line_number":25,"context_line":"the unit tests, the solution is to only send the value in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2B3as%3D","line":22,"in_reply_to":"AAAATn%2F%2B5tc%3D","updated":"2013-11-19 07:23:14.000000000","message":"Ahh, there it is.\n\nCheck it out on the ovirt gerrit:\nhttp://gerrit.ovirt.org/#/c/17726/8..13/lib/vdsm/tool/upgrade.py\n\nMuch more user friendly in my mind.","commit_id":"4c6aa0ede730b90206fd2639158d8e8174d3272d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e66cca5aa4a4169f876380b994f0b48ddc907e14","unresolved":false,"context_lines":[{"line_number":19,"context_line":"That means that sending enable\u003dFalse wouldn\u0027t work."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"After the change to update_dict the issue, however, was that"},{"line_number":22,"context_line":"\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if they\u0027re"},{"line_number":23,"context_line":"the default False) but the unit tests weren\u0027t expecting a False"},{"line_number":24,"context_line":"value since it wasn\u0027t explicitly stated. Instead of changing"},{"line_number":25,"context_line":"the unit tests, the solution is to only send the value in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2B5t8%3D","line":22,"in_reply_to":"AAAATn%2F%2B6CE%3D","updated":"2013-11-18 19:35:37.000000000","message":"Meh, must be a copy/paste error when I changed the commit message. Interestingly this Gerrit installation doesn\u0027t allow you to diff between patch sets?","commit_id":"4c6aa0ede730b90206fd2639158d8e8174d3272d"}],"neutronclient/tests/unit/fw/test_cli20_firewallrule.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f450d3c64a42db01702d8de7d1feed4c40e6d443","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        my_id \u003d \u0027myid\u0027"},{"line_number":36,"context_line":"        protocol \u003d \u0027tcp\u0027"},{"line_number":37,"context_line":"        action \u003d \u0027allow\u0027"},{"line_number":38,"context_line":"        enabledFlag \u003d \u0027--enabled\u0027 if enabled else \u0027--disabled\u0027"},{"line_number":39,"context_line":"        args \u003d [\u0027--tenant-id\u0027, tenant_id,"},{"line_number":40,"context_line":"                \u0027--admin-state-up\u0027,"},{"line_number":41,"context_line":"                \u0027--protocol\u0027, protocol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B79s%3D","line":38,"updated":"2013-11-18 11:35:59.000000000","message":"Even though it\u0027s not said explicitly in PEP8, I\u0027d still go with local variables naming convention as it\u0027s for instance variables to keep the same format in the module. i.e. enabled_flag","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"dfcc827be4d20082c3bb5b82d5cdc8b13497c47f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        my_id \u003d \u0027myid\u0027"},{"line_number":36,"context_line":"        protocol \u003d \u0027tcp\u0027"},{"line_number":37,"context_line":"        action \u003d \u0027allow\u0027"},{"line_number":38,"context_line":"        enabledFlag \u003d \u0027--enabled\u0027 if enabled else \u0027--disabled\u0027"},{"line_number":39,"context_line":"        args \u003d [\u0027--tenant-id\u0027, tenant_id,"},{"line_number":40,"context_line":"                \u0027--admin-state-up\u0027,"},{"line_number":41,"context_line":"                \u0027--protocol\u0027, protocol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B760%3D","line":38,"in_reply_to":"AAAATn%2F%2B77k%3D","updated":"2013-11-18 11:44:09.000000000","message":"+1","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f42130d6a3da36fb346a024d1b895637fe515d2c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        my_id \u003d \u0027myid\u0027"},{"line_number":36,"context_line":"        protocol \u003d \u0027tcp\u0027"},{"line_number":37,"context_line":"        action \u003d \u0027allow\u0027"},{"line_number":38,"context_line":"        enabledFlag \u003d \u0027--enabled\u0027 if enabled else \u0027--disabled\u0027"},{"line_number":39,"context_line":"        args \u003d [\u0027--tenant-id\u0027, tenant_id,"},{"line_number":40,"context_line":"                \u0027--admin-state-up\u0027,"},{"line_number":41,"context_line":"                \u0027--protocol\u0027, protocol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B7Jg%3D","line":38,"in_reply_to":"AAAATn%2F%2B79s%3D","updated":"2013-11-18 14:57:10.000000000","message":"Eep, sorry about that - I foresee a difficult oVirt/OpenStack naming convention battle raging inside of me in the near future.","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"3a056cedab25c44bb904c244d8dc961175a6360c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        my_id \u003d \u0027myid\u0027"},{"line_number":36,"context_line":"        protocol \u003d \u0027tcp\u0027"},{"line_number":37,"context_line":"        action \u003d \u0027allow\u0027"},{"line_number":38,"context_line":"        enabledFlag \u003d \u0027--enabled\u0027 if enabled else \u0027--disabled\u0027"},{"line_number":39,"context_line":"        args \u003d [\u0027--tenant-id\u0027, tenant_id,"},{"line_number":40,"context_line":"                \u0027--admin-state-up\u0027,"},{"line_number":41,"context_line":"                \u0027--protocol\u0027, protocol,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B77k%3D","line":38,"in_reply_to":"AAAATn%2F%2B79s%3D","updated":"2013-11-18 11:40:59.000000000","message":"I agree, this is good point.","commit_id":"468d1cdb11af0476202dae5fd32b4965b12b4f0e"}]}