)]}'
{"id":"openstack%2Fpython-neutronclient~55826","triplet_id":"openstack%2Fpython-neutronclient~master~I142089ffd612fb52a326e8951a385920af852a2c","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1250028","hashtags":[],"change_id":"I142089ffd612fb52a326e8951a385920af852a2c","subject":"[fwaas] Can now create disabled firewall rules","status":"MERGED","created":"2013-11-11 12:13:04.000000000","updated":"2013-11-28 14:54:11.000000000","submitted":"2013-11-28 14:54:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9709f6d36f60a792e3ad70fccd83853b3a1a3323","_number":55826,"virtual_id_number":55826,"owner":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":2,"date":"2013-11-28 14:54:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},{"value":0,"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"all":[{"value":2,"date":"2013-11-28 13:58:23.000000000","_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},{"value":2,"date":"2013-11-24 18:39:05.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},{"value":1,"date":"2013-11-20 09:22:45.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"all":[{"value":1,"date":"2013-11-28 13:58:23.000000000","_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},{"value":0,"date":"2013-11-24 18:38:01.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},{"value":0,"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},{"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-11 12:25:43.000000000","updated_by":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"reviewer":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"state":"REVIEWER"},{"updated":"2013-11-13 04:40:17.000000000","updated_by":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"reviewer":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"state":"REVIEWER"},{"updated":"2013-11-18 11:12:53.000000000","updated_by":{"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"},"reviewer":{"_account_id":8950,"name":"Dan Kenigsberg","email":"danken@gmail.com","username":"danken"},"state":"REVIEWER"},{"updated":"2013-11-18 19:38:16.000000000","updated_by":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"reviewer":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"state":"REVIEWER"},{"updated":"2013-11-20 09:22:45.000000000","updated_by":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"reviewer":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"state":"REVIEWER"},{"updated":"2013-11-24 18:38:01.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2013-11-28 13:58:23.000000000","updated_by":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"reviewer":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"state":"REVIEWER"},{"updated":"2013-11-28 14:54:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dada1e5ca1d34d0b1a256b84d3968dcfed177102","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-11 12:50:25.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-pep8/20b2aaa : SUCCESS in 47s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/1/check/gate-python-neutronclient-docs/5f18b45/doc/build/html/ : SUCCESS in 51s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python26/2d5f280 : SUCCESS in 41s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python27/1a31f3a : SUCCESS in 45s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python33/3414a41 : FAILURE in 23s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-pypy/ce8e3cb : SUCCESS in 1m 46s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-full/2235c88 : SUCCESS in 34m 17s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-postgres-full/efcd984 : SUCCESS in 34m 31s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron/a1949b5 : SUCCESS in 26m 35s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-pg/91afdf8 : FAILURE in 31m 42s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-isolated/3ff7c8d : SUCCESS in 31m 27s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-pg-isolated/9c07e8a : SUCCESS in 29m 20s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/1/check/gate-tempest-devstack-vm-large-ops/fe25688 : SUCCESS in 13m 38s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/1/check/gate-tempest-devstack-vm-neutron-large-ops/e4b0a4a : FAILURE in 18m 22s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/1/check/check-grenade-devstack-vm/d83a141 : SUCCESS in 37m 16s\n","accounts_in_message":[],"_revision_number":1},{"id":"a44b767bcf3716c87d3e2cf8c56ada910a162783","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-11-13 04:40:17.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"9035216a6dcf6e3b9bc561eb099d57e45198eba6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-13 05:31:01.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-pep8/229fb7b : SUCCESS in 45s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/1/check/gate-python-neutronclient-docs/3e86215/doc/build/html/ : SUCCESS in 43s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python26/fa3b53a : SUCCESS in 1m 08s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python27/7f8432c : SUCCESS in 58s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-python33/89c5869 : FAILURE in 22s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/1/check/gate-python-neutronclient-pypy/ffb4054 : SUCCESS in 1m 44s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-full/b10abbc : SUCCESS in 42m 50s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-postgres-full/e6fd002 : SUCCESS in 34m 36s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron/0084939 : SUCCESS in 29m 39s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-pg/8179058 : SUCCESS in 27m 05s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-isolated/b609afa : FAILURE in 27m 38s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/1/check/check-tempest-devstack-vm-neutron-pg-isolated/04d2516 : SUCCESS in 31m 33s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/1/check/gate-tempest-devstack-vm-large-ops/38f0710 : SUCCESS in 13m 39s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/1/check/gate-tempest-devstack-vm-neutron-large-ops/2fcf412 : FAILURE in 18m 53s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/1/check/check-grenade-devstack-vm/6510192 : SUCCESS in 50m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"98bae538bd0eabe1eb02cf326fc8c4f91d445904","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-11-13 05:31:13.000000000","message":"Patch Set 1:\n\nI noticed tempest failed, I think you hit bug(s): https://bugs.launchpad.net/bugs/1244255","accounts_in_message":[],"_revision_number":1},{"id":"8ece7e5826ee96f07ff9c71b317089061515fd85","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-14 19:10:17.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThe proposed solution is a good workaround for a seeming deficiency in the update_dict method, but is there a reason not to fix update_dict to properly handle values that evaluate to boolean false?","accounts_in_message":[],"_revision_number":1},{"id":"98c1b0b9551a9960757e68791fc9e94e86c348e7","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-16 10:36:59.000000000","message":"Patch Set 1:\n\nThat\u0027s the money question. The reason I did not do that is that I\u0027m afraid I don\u0027t have the ability to know what will be the effect of such a change at this time. Any False values will now be explicitly sent, and as I\u0027m unfamiliar with the coverage and functionality of our tests I think that it\u0027s unwise to send a patch that has the potential to introduce regressions that will not be caught by our testing suite.\n\nOn the other hand, theoretically, any regression introduced by such a change is a bug in its own right and should be caught and handled ASAP.\n\nAny thoughts, or hunches as to what such a change might do?","accounts_in_message":[],"_revision_number":1},{"id":"25f30f28c8cf92cb9ecf66445eb75069b6e5dc0b","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-17 06:08:03.000000000","message":"Patch Set 1:\n\nI think the best approach is to always fix inconsistencies in the code unless you have direct evidence that the cost will outweigh the benefit.  If the tests don\u0027t exhibit problems, assume that there are none and rely on your reviewers to fact-check your assumption.  The alternative is that developers are afraid to change the codebase and things will never get better.\n\nSo, please submit a fix for the underlying problem.","accounts_in_message":[],"_revision_number":1},{"id":"a00d77edd311268e91b1aad0c62d0d3e22a341b0","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-17 14:38:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d2fb608e47654f9e5fb0c0f2be6d1a892ab44b35","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-17 14:46:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a6d68ed08039fef000cbdd11818d59c5e8f2378b","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-11-17 14:46:11.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"4b7f235026485389cd14acb2a1993329e43dc657","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-17 14:46:46.000000000","message":"Patch Set 3:\n\nPatch 2 fixes the bug in a generic way, patch 3 updated the commit message.","accounts_in_message":[],"_revision_number":3},{"id":"d1ca3365e87012ed50b9d06a65d40a88cf2a625d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-17 16:03:03.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-pep8/6c68d21 : SUCCESS in 46s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/3/check/gate-python-neutronclient-docs/1c8937f/doc/build/html/ : SUCCESS in 50s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python26/9b317e6 : SUCCESS in 1m 03s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python27/7769622 : SUCCESS in 44s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python33/3c7aaab : FAILURE in 23s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-pypy/2c7af26 : SUCCESS in 1m 44s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-full/5a06178 : FAILURE in 1h 16m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-postgres-full/95239f1 : SUCCESS in 33m 52s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron/1911691 : SUCCESS in 27m 01s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-pg/e43dae0 : FAILURE in 45m 56s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-isolated/0cdf2c3 : SUCCESS in 33m 42s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-pg-isolated/cca9f09 : SUCCESS in 49m 28s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/3/check/gate-tempest-devstack-vm-large-ops/b758708 : SUCCESS in 13m 56s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/3/check/gate-tempest-devstack-vm-neutron-large-ops/f2e4bb7 : SUCCESS in 14m 53s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/3/check/check-grenade-devstack-vm/569efb7 : FAILURE in 25m 56s\n","accounts_in_message":[],"_revision_number":3},{"id":"57f7df45d998f581f965f91eddca7d6e75c7023b","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-18 08:30:34.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"6d95399c2c7b9e7ac11c06a1513848b327d2ad40","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-18 08:33:04.000000000","message":"Patch Set 3:\n\nI have a feeling that if I push master without any changes it\u0027ll fail a bunch of CI tests randomly...","accounts_in_message":[],"_revision_number":3},{"id":"484e82e88fc14206e9ed855d24ac84cf9392e021","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 09:05:59.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nSadly, that is likely the case right now.\n\nFunctionally, the patch is done, good work!  \n\nBefore approval, I would like to see the commit message revised to indicate the \u0027why\u0027 of the change rather than the details of how the solution was arrived at.  Just as a patch submitted for review might hide the details of interim patches, so the commit message can exclude the thought process behind the interim patches.","accounts_in_message":[],"_revision_number":3},{"id":"c1c7b2daadd7dfa3222c9697d8f6853c1b2e3c9c","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-18 09:14:22.000000000","message":"Patch Set 3:\n\nI think that the \u0027why\u0027 is covered in the 2nd paragraph?\n\nThe next two explain the implementation changes - I think it would be beneficial to keep that explanation, because I\u0027ve often caught myself looking at patches from 1-2 years ago to understand the rationale of whatever inane code I happen to be looking at.\n\nPlus, I\u0027ve never heard someone say: \"Man, this open source project has too much documentation!\"","accounts_in_message":[],"_revision_number":3},{"id":"ef681d8a7111a4eb2ac506ec8e9ce6c37c26a292","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2013-11-18 10:51:20.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nThanks Assaf for your work on this. I can confirm that the original intention was indeed to achieve what you have arrived at with this fix. It was obviously broken for the enabled\u003dFalse like cases as you have pointed out. Thanks also for the detailed documentation, it is very helpful for the reasons you mention.","accounts_in_message":[],"_revision_number":3},{"id":"f450d3c64a42db01702d8de7d1feed4c40e6d443","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2013-11-18 11:35:59.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"15da1f521c36f4e3283ae438403328e9f45ab808","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 11:36:56.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nFair enough, I can agree to disagree.  For non-trivial patches, though, the level of description provided doesn\u0027t scale, and I would encourage succinctness over a work log.  Brevity is the soul of both wit and effective documentation.","accounts_in_message":[],"_revision_number":3},{"id":"88980c5a1bba29c56e748ecc50aaf743d4cd909d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-18 11:37:05.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"b7309b2dd14290dd89f38ec9dc577e520013b3d6","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 11:37:05.000000000","message":"Patch Set 3: Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"9835a2b91b0e6cd52c9a03cbaabbfe83579136c9","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-18 11:37:40.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nThe code itself looks good and works.\n\nI have the same feeling as Maru. it is better to improve the commit message. The detail of my view is described inline.","accounts_in_message":[],"_revision_number":3},{"id":"a61563af3f78b098ad1a2bb5eb7c081d056d320e","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-18 11:37:57.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"3a056cedab25c44bb904c244d8dc961175a6360c","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2013-11-18 11:40:59.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a3351fc682378e64b2a71f961d42954bcab16bac","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 11:42:34.000000000","message":"Patch Set 3: No score; No score\n\nAkihiro: Oops, sorry for approving when you had a -1, I didn\u0027t see it in time.  I suggest leaving your -1 if you want to see things change and if the patch doesn\u0027t merge because of gate failure Assaf will have a chance to address your concerns.","accounts_in_message":[],"_revision_number":3},{"id":"dfcc827be4d20082c3bb5b82d5cdc8b13497c47f","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 11:44:09.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nGood catch by Kuba on the variable naming.","accounts_in_message":[],"_revision_number":3},{"id":"3f96462240bdea8993bb59ea17de356c6c944d38","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-18 12:19:31.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nHonestly it is a difficult choice if only the commit message needs to be improved and it is not critical. I didn\u0027t really deciced which is better... \n\nOn a second thought it is better to improve the commit message, so I will score -1 again.","accounts_in_message":[],"_revision_number":3},{"id":"e0a49de063cfcbbd885612311f4c49f1dc452dcf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-18 13:46:50.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-pep8/27567b5 : SUCCESS in 44s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/3/check/gate-python-neutronclient-docs/795ba7f/doc/build/html/ : SUCCESS in 46s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python26/4e28121 : SUCCESS in 1m 01s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python27/0ce297f : SUCCESS in 58s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-python33/76c3377 : FAILURE in 27s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/3/check/gate-python-neutronclient-pypy/c181ca7 : SUCCESS in 1m 49s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-full/7890ef5 : SUCCESS in 33m 52s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-postgres-full/110a803 : FAILURE in 35m 56s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron/9fb76ff : SUCCESS in 34m 40s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-pg/f60ca37 : FAILURE in 36m 36s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-isolated/a49d4de : SUCCESS in 1h 10m 42s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/3/check/check-tempest-devstack-vm-neutron-pg-isolated/3e5f65b : FAILURE in 59m 16s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/3/check/gate-tempest-devstack-vm-large-ops/ccc476c : SUCCESS in 17m 32s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/3/check/gate-tempest-devstack-vm-neutron-large-ops/8fc28ee : SUCCESS in 17m 51s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/3/check/check-grenade-devstack-vm/4063fef : FAILURE in 25m 44s\n","accounts_in_message":[],"_revision_number":3},{"id":"f42130d6a3da36fb346a024d1b895637fe515d2c","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-18 14:57:10.000000000","message":"Patch Set 3: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"822e23e25ebab32e6b4f0d0ce422256098a0bdc4","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-18 14:58:44.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"265d2425c4459ba63b0a8e8c1faf69b90b3600b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-18 17:30:51.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/4/check/gate-python-neutronclient-pep8/6424bd9 : SUCCESS in 40s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/4/check/gate-python-neutronclient-docs/da3343e/doc/build/html/ : SUCCESS in 42s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/4/check/gate-python-neutronclient-python26/2920054 : SUCCESS in 1m 02s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/4/check/gate-python-neutronclient-python27/3ac5df2 : SUCCESS in 39s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/4/check/gate-python-neutronclient-python33/df55dd0 : FAILURE in 23s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/4/check/gate-python-neutronclient-pypy/4393127 : SUCCESS in 1m 45s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-full/ff1d5cd : SUCCESS in 45m 54s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-postgres-full/6de8b3a : SUCCESS in 51m 53s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-neutron/c059769 : SUCCESS in 37m 32s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-neutron-pg/951a509 : SUCCESS in 38m 12s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-neutron-isolated/56eb080 : SUCCESS in 45m 08s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/4/check/check-tempest-devstack-vm-neutron-pg-isolated/7dd2ae7 : SUCCESS in 32m 38s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/4/check/gate-tempest-devstack-vm-large-ops/782dcf2 : SUCCESS in 23m 09s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/4/check/gate-tempest-devstack-vm-neutron-large-ops/cf8010a : SUCCESS in 24m 29s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/4/check/check-grenade-devstack-vm/3b9339f : FAILURE in 41m 46s\n","accounts_in_message":[],"_revision_number":4},{"id":"dcd49cd7222a279d80059c1749e6fdc581a3f4f8","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-18 18:07:22.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nMinor nit in the commit message, but otherwise looks good to me.  Akihiro will of course have to confirm.","accounts_in_message":[],"_revision_number":4},{"id":"e66cca5aa4a4169f876380b994f0b48ddc907e14","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-18 19:35:37.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"582d24085c746acf98fbf563625367bb0c2170b0","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2013-11-18 19:38:16.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"5c325497dae42dbdf66c5aab1fd571e765473494","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-19 07:23:14.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"ed054e39bcb5c13488bb16910880ce2c7926cad6","author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"date":"2013-11-20 07:31:20.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f8565c4b131f336a1e592bd78335a46774e349be","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-11-20 07:31:26.000000000","message":"Patch Set 5:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":5},{"id":"cb9a97ea6481e8072ed9067fcb8fc2889594eafb","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-20 08:33:46.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nLooks good to me, if Akihiro scores +2 I will approve.","accounts_in_message":[],"_revision_number":5},{"id":"026de0cbe3a079ae58dfcc266c6a1b3412488edf","author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"date":"2013-11-20 09:22:45.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"35d42a780b7db1a4567bec2af4d86ba0633c26f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-20 09:25:15.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-pep8/d2843f5 : SUCCESS in 51s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/5/check/gate-python-neutronclient-docs/fb95b0b/doc/build/html/ : SUCCESS in 57s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python26/0e84626 : SUCCESS in 1m 25s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python27/d63a244 : SUCCESS in 49s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python33/a2d5706 : FAILURE in 29s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-pypy/264fb32 : SUCCESS in 1m 52s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-full/e12a836 : SUCCESS in 47m 32s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-postgres-full/fe66aa8 : SUCCESS in 46m 27s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron/eab1c7e : SUCCESS in 36m 45s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-pg/50dc29e : SUCCESS in 37m 27s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-isolated/a1a3096 : SUCCESS in 41m 39s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-pg-isolated/c68ea0e : SUCCESS in 40m 01s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/5/check/gate-tempest-devstack-vm-large-ops/fdfcde5 : SUCCESS in 24m 35s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/5/check/gate-tempest-devstack-vm-neutron-large-ops/fa7450d : SUCCESS in 27m 31s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/5/check/check-grenade-devstack-vm/07c25c8 : FAILURE in 39m 41s\n","accounts_in_message":[],"_revision_number":5},{"id":"cc8cdc1dc580aff5022cbe3c2db7473fc0393afe","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-24 18:38:01.000000000","message":"Patch Set 5:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":5},{"id":"e7bd41fe65547da025cdd22d2a0c252da8c1f5df","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-11-24 18:39:05.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\nThanks for updating the commit message! It is much easier to understand.","accounts_in_message":[],"_revision_number":5},{"id":"03d27528611656c49e885a2af0f4eca52c721f55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-24 19:34:39.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-pep8/8d9404e : SUCCESS in 39s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/5/check/gate-python-neutronclient-docs/993bee5/doc/build/html/ : SUCCESS in 44s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python26/18c80b7 : SUCCESS in 51s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python27/2c5875b : SUCCESS in 56s\n- gate-python-neutronclient-python33 http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-python33/228453b : FAILURE in 21s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/5/check/gate-python-neutronclient-pypy/59bf377 : SUCCESS in 1m 44s\n- check-tempest-devstack-vm-full http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-full/c68f470 : SUCCESS in 56m 34s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-postgres-full/b95a91f : SUCCESS in 44m 48s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron/020f7be : SUCCESS in 25m 05s\n- check-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-pg/27e91e2 : SUCCESS in 27m 02s\n- check-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-isolated/8754a48 : SUCCESS in 28m 41s\n- check-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/5/check/check-tempest-devstack-vm-neutron-pg-isolated/eab2549 : SUCCESS in 45m 40s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/5/check/gate-tempest-devstack-vm-large-ops/f06aed5 : SUCCESS in 13m 40s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/5/check/gate-tempest-devstack-vm-neutron-large-ops/4bf4647 : SUCCESS in 16m 37s\n- check-grenade-devstack-vm http://logs.openstack.org/26/55826/5/check/check-grenade-devstack-vm/1a00c57 : SUCCESS in 32m 26s\n","accounts_in_message":[],"_revision_number":5},{"id":"dc5acb86fef9a3592129f06a0d463cedc176a701","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-28 13:58:23.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"059452150ccbbbb89f11d41f91bcfca0761aa3ac","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-11-28 13:58:23.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"dd0c5fe442c099095e131cb3b1a087b9744ed3da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-28 14:54:11.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/26/55826/5/gate/gate-python-neutronclient-docs/cc9f159/doc/build/html/ : SUCCESS in 45s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/26/55826/5/gate/gate-python-neutronclient-pep8/0e4b577 : SUCCESS in 54s\n- gate-python-neutronclient-python26 http://logs.openstack.org/26/55826/5/gate/gate-python-neutronclient-python26/0836696 : SUCCESS in 56s\n- gate-python-neutronclient-python27 http://logs.openstack.org/26/55826/5/gate/gate-python-neutronclient-python27/d9c6f50 : SUCCESS in 44s\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/55826/5/gate/gate-python-neutronclient-pypy/8ee1240 : SUCCESS in 1m 43s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-full/7f04a3c : SUCCESS in 32m 33s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-postgres-full/504e513 : SUCCESS in 48m 55s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-neutron/75c9861 : SUCCESS in 27m 10s\n- gate-tempest-devstack-vm-neutron-pg http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-neutron-pg/acca8ca : SUCCESS in 27m 01s\n- gate-tempest-devstack-vm-neutron-isolated http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-neutron-isolated/32894a3 : SUCCESS in 28m 10s\n- gate-tempest-devstack-vm-neutron-pg-isolated http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-neutron-pg-isolated/f1baa99 : SUCCESS in 28m 21s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-large-ops/f61fedb : SUCCESS in 14m 20s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/26/55826/5/gate/gate-tempest-devstack-vm-neutron-large-ops/4514aec : SUCCESS in 16m 55s\n- gate-grenade-devstack-vm http://logs.openstack.org/26/55826/5/gate/gate-grenade-devstack-vm/fbd8de7 : SUCCESS in 23m 13s\n","accounts_in_message":[],"_revision_number":5},{"id":"e9e033ffe14e3ec89c3b22fbd66dd38459332548","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-28 14:54:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"45c4d87910f40acb98f9b2579780f47043d076a4","revisions":{"b095de8f9b693fd81d29af39239f80a33db06dbe":{"kind":"REWORK","_number":1,"created":"2013-11-11 12:13:04.000000000","uploader":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"ref":"refs/changes/26/55826/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/55826/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/1"}}},"commit":{"parents":[{"commit":"feda92ff0b28514b27e8e05713368962366c9fa4","subject":"Fix status_code not passed in code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4"}]}],"author":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 09:47:19.000000000","tz":120},"committer":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 12:08:53.000000000","tz":120},"subject":"[fwaas] Can now create disabled firewall rules","message":"[fwaas] Can now create disabled firewall rules\n\nPreviously, the --disabled flag was ignored when creating\nfirewall rules. This patch fixes that problem, closes the bug\nand adds a test.\n\nCloses-Bug: 1250028\nChange-Id: I142089ffd612fb52a326e8951a385920af852a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b095de8f9b693fd81d29af39239f80a33db06dbe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b095de8f9b693fd81d29af39239f80a33db06dbe"}]},"branch":"refs/heads/master"},"4b7cffe190adb6ede3fde8f19546471e172ff58c":{"kind":"REWORK","_number":2,"created":"2013-11-17 14:38:53.000000000","uploader":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"ref":"refs/changes/26/55826/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/55826/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/2"}}},"commit":{"parents":[{"commit":"feda92ff0b28514b27e8e05713368962366c9fa4","subject":"Fix status_code not passed in code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4"}]}],"author":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 09:47:19.000000000","tz":120},"committer":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-17 14:30:05.000000000","tz":120},"subject":"[fwaas] Can now create disabled firewall rules","message":"[fwaas] Can now create disabled firewall rules\n\nPreviously, the --disabled flag was ignored when creating\nfirewall rules. This patch fixes that problem, closes the bug\nand adds a test.\n\nCloses-Bug: 1250028\nChange-Id: I142089ffd612fb52a326e8951a385920af852a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4b7cffe190adb6ede3fde8f19546471e172ff58c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4b7cffe190adb6ede3fde8f19546471e172ff58c"}]},"branch":"refs/heads/master"},"468d1cdb11af0476202dae5fd32b4965b12b4f0e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-11-17 14:46:06.000000000","uploader":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"ref":"refs/changes/26/55826/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/55826/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/3"}}},"commit":{"parents":[{"commit":"feda92ff0b28514b27e8e05713368962366c9fa4","subject":"Fix status_code not passed in code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4"}]}],"author":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 09:47:19.000000000","tz":120},"committer":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-17 14:42:39.000000000","tz":120},"subject":"[fwaas] Can now create disabled firewall rules","message":"[fwaas] Can now create disabled firewall rules\n\nPreviously, the --disabled flag was ignored when creating\nfirewall rules. This patch fixes that problem, closes the bug\nand adds a test.\n\nBefore this patch, when creating a resource, values were\ninserted into the API call only if their value was not None\nor False. This worked fine for values whose default value\nwas False. \u0027enabled\u0027, however, has a default value of True.\nThat means that sending enable\u003dFalse wouldn\u0027t work.\n\nI then changed update_dict so that values are sent on to the\nAPI call if they are not None (So False values are sent as well).\nThe issue, however, was that \u0027shared\u0027 and \u0027audited\u0027 were then\nalways sent (Even if they\u0027re the default False) but the unit\ntests weren\u0027t expecting a False value since it wasn\u0027t explicitly\nstated.\n\nThe solution is to only send the value if it is not the default\nvalue, using argparse\u0027s default mechanism. If it is the default,\nthen it is written as None and so is not sent, and not checked\nby the unit tests either.\n\nCloses-Bug: 1250028\nChange-Id: I142089ffd612fb52a326e8951a385920af852a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/468d1cdb11af0476202dae5fd32b4965b12b4f0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/468d1cdb11af0476202dae5fd32b4965b12b4f0e"}]},"branch":"refs/heads/master"},"4c6aa0ede730b90206fd2639158d8e8174d3272d":{"kind":"REWORK","_number":4,"created":"2013-11-18 14:58:44.000000000","uploader":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"ref":"refs/changes/26/55826/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/55826/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/4"}}},"commit":{"parents":[{"commit":"feda92ff0b28514b27e8e05713368962366c9fa4","subject":"Fix status_code not passed in code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4"}]}],"author":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 09:47:19.000000000","tz":120},"committer":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-18 14:53:07.000000000","tz":120},"subject":"[fwaas] Can now create disabled firewall rules","message":"[fwaas] Can now create disabled firewall rules\n\nPreviously, the --disabled flag was ignored when creating\nfirewall rules. This patch fixes that problem, closes the bug\nand adds a test. I changed update_dict so that values are sent\non to the API call if they are not None (So False values are\nsent as well).\n\nBefore this patch, when creating a resource, values were\ninserted into the API call only if their value was not None\nor False. This worked fine for values whose default value\nwas False. \u0027enabled\u0027, however, has a default value of True.\nThat means that sending enable\u003dFalse wouldn\u0027t work.\n\nAfter the change to update_dict the issue, however, was that\n\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if they\u0027re\nthe default False) but the unit tests weren\u0027t expecting a False\nvalue since it wasn\u0027t explicitly stated. Instead of changing\nthe unit tests, the solution is to only send the value in the\nfirst place if it is not the default value, using argparse\u0027s\ndefault mechanism. If it is the default, then it is written as\nNone and so is not sent, and not checked by the unit tests either.\n\nCloses-Bug: 1250028\nChange-Id: I142089ffd612fb52a326e8951a385920af852a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4c6aa0ede730b90206fd2639158d8e8174d3272d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4c6aa0ede730b90206fd2639158d8e8174d3272d"}]},"branch":"refs/heads/master"},"45c4d87910f40acb98f9b2579780f47043d076a4":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2013-11-20 07:31:20.000000000","uploader":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"ref":"refs/changes/26/55826/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/55826/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/55826/5"}}},"commit":{"parents":[{"commit":"feda92ff0b28514b27e8e05713368962366c9fa4","subject":"Fix status_code not passed in code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4"}]}],"author":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-11 09:47:19.000000000","tz":120},"committer":{"name":"Assaf Muller","email":"amuller@redhat.com","date":"2013-11-20 07:31:40.000000000","tz":120},"subject":"[fwaas] Can now create disabled firewall rules","message":"[fwaas] Can now create disabled firewall rules\n\nPreviously, the --disabled flag was ignored when creating\nfirewall rules. This patch fixes that problem, closes the bug\nand adds a test. I changed update_dict so that values are sent\non to the API call if they are not None (So False values are\nsent as well).\n\nBefore this patch, when creating a resource, values were\ninserted into the API call only if their value was not None\nor False. This worked fine for values whose default value\nwas False. \u0027enabled\u0027, however, has a default value of True.\nThat means that sending enable\u003dFalse wouldn\u0027t work.\n\nAfter the change to update_dict the issue, however, was that\n\u0027shared\u0027 and \u0027audited\u0027 were then always sent (Even if their\ndefault was False) but the unit tests weren\u0027t expecting a False\nvalue since it wasn\u0027t explicitly stated. Instead of changing\nthe unit tests, the solution is to only send the value in the\nfirst place if it is not the default value, using argparse\u0027s\ndefault mechanism. If it is the default, then it is written as\nNone and so is not sent, and not checked by the unit tests either.\n\nCloses-Bug: 1250028\nChange-Id: I142089ffd612fb52a326e8951a385920af852a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/45c4d87910f40acb98f9b2579780f47043d076a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/45c4d87910f40acb98f9b2579780f47043d076a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}