)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aaf6d052234ccf705ef2ea4be9ba55cb24f71fea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-07-27 00:26:20 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix broken unittests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1783789"},{"line_number":10,"context_line":"Change-Id: Ic8e03db85dc08cfdcac5507e99ecdf7eac8eb972"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_75dcd670","line":8,"updated":"2018-07-26 15:30:04.000000000","message":"we also need to mention the failure around ProtocolColumn.","commit_id":"ad2308859f19e278192237637491412389801269"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4de785f7587f48196ea3e098370a1187586e3aaf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutronclient UT fails with two reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Change on FormattableColumn in osc-lib 1.11.0 breaks a special"},{"line_number":12,"context_line":"  behavior in FWaaS v2 rule ProtocolColumn. We need to declare"},{"line_number":13,"context_line":"  to use osc-lib \u003e\u003d1.11.0 and its dependencies (openstacksdk and"},{"line_number":14,"context_line":"  keystoneauth1)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_c5b3aaeb","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":47},"updated":"2018-07-27 06:05:46.000000000","message":"do you mean this change? https://review.openstack.org/#/c/581886/\nto me it seems that this \"fix\" in osc-lib is broken.","commit_id":"2960855a9e9f6584276daff88bbec4aa23c55266"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9214c9dd91bf6ed371c0b0ec524eefa9864a6423","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutronclient UT fails with two reasons:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Change on FormattableColumn in osc-lib 1.11.0 breaks a special"},{"line_number":12,"context_line":"  behavior in FWaaS v2 rule ProtocolColumn. We need to declare"},{"line_number":13,"context_line":"  to use osc-lib \u003e\u003d1.11.0 and its dependencies (openstacksdk and"},{"line_number":14,"context_line":"  keystoneauth1)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_5db4461d","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":47},"in_reply_to":"5f7c97a3_c5b3aaeb","updated":"2018-07-27 17:04:36.000000000","message":"You are right. I was confused with another change.\nI filed a bug https://storyboard.openstack.org/#!/story/2003133 and proposed a revert of the change. Thanks!","commit_id":"2960855a9e9f6584276daff88bbec4aa23c55266"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4de785f7587f48196ea3e098370a1187586e3aaf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  behavior in FWaaS v2 rule ProtocolColumn. We need to declare"},{"line_number":13,"context_line":"  to use osc-lib \u003e\u003d1.11.0 and its dependencies (openstacksdk and"},{"line_number":14,"context_line":"  keystoneauth1)."},{"line_number":15,"context_line":"- _clean() method is renamed to clean() in osprofiler 2.3.0."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1783789"},{"line_number":18,"context_line":"Co-Authored-By: Akihiro Motoki \u003camotoki@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_c5cdeaba","line":15,"updated":"2018-07-27 06:05:46.000000000","message":"https://review.openstack.org/#/c/578362/","commit_id":"2960855a9e9f6584276daff88bbec4aa23c55266"}],"lower-constraints.txt":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aaf6d052234ccf705ef2ea4be9ba55cb24f71fea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"oslo.service\u003d\u003d1.24.0"},{"line_number":64,"context_line":"oslo.utils\u003d\u003d3.33.0"},{"line_number":65,"context_line":"oslotest\u003d\u003d3.2.0"},{"line_number":66,"context_line":"osprofiler\u003d\u003d2.3.0"},{"line_number":67,"context_line":"paramiko\u003d\u003d2.0.0"},{"line_number":68,"context_line":"Paste\u003d\u003d2.0.2"},{"line_number":69,"context_line":"PasteDeploy\u003d\u003d1.5.0"}],"source_content_type":"text/plain","patch_set":2,"id":"5f7c97a3_f53ea688","line":66,"updated":"2018-07-26 15:30:04.000000000","message":"osprofiler in test-requirements.txt needs to be updated too.","commit_id":"ad2308859f19e278192237637491412389801269"}],"neutronclient/tests/unit/osc/v2/fwaas/test_firewallrule.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89ff65e09a0910ea4010796afe43308d52e18c22","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _replace_display_columns(key, val):"},{"line_number":51,"context_line":"    if key \u003d\u003d \u0027protocol\u0027:"},{"line_number":52,"context_line":"        return firewallrule.ProtocolColumn(val) if val else None"},{"line_number":53,"context_line":"    return val"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_52f8d048","line":52,"updated":"2018-07-26 15:13:02.000000000","message":"note: The current failure is http://paste.openstack.org/show/726698/ . This is caused by the fact that ProtocolColumn is passed as an expected data even when val is None. assertItemEqual expects that \u0027None\u0027 is passed as an expected data when an actual data is None. Thus, this fix looks correct.","commit_id":"14fd9ecdf5864ccf1cd1cf6f4bf61d413448b205"}]}
