)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b3eb2f3f40ae48d3d670b4cced5a7b0cd98e5987","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Change-Id: I0f3d478fcce6b9ada1c85a13115042ac4634b59b"},{"line_number":14,"context_line":"Co-Authored-By: Nguyen Phuong An \u003cAnNP@vn.fujitsu.com\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Yushiro FURUKAWA \u003cy.furukawa_2@jp.fujitsu.com\u003e"},{"line_number":16,"context_line":"Partial-Bug: #1752290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_f5046415","line":16,"updated":"2018-11-20 15:35:48.000000000","message":"Could you add Depends-On to clarify which patch in neutron completes the feature? Until then, we cannot merge this. Depends-On helps us understand when it is ready for merge.","commit_id":"039f41e321cc280ba96b9ba1e8616b6997d5d0cb"}],"neutronclient/osc/v2/logging/constants.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b3eb2f3f40ae48d3d670b4cced5a7b0cd98e5987","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DROP_EVENT \u003d \u0027DROP\u0027"},{"line_number":19,"context_line":"ALL_EVENT \u003d \u0027ALL\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Log events for SNAT Logging"},{"line_number":22,"context_line":"BEFORE_SNAT \u003d \u0027BEFORE_SNAT\u0027"},{"line_number":23,"context_line":"AFTER_SNAT \u003d \u0027AFTER_SNAT\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG_EVENTS \u003d [ALL_EVENT, ACCEPT_EVENT, DROP_EVENT]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_156fa0c7","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":25},"updated":"2018-11-20 15:35:48.000000000","message":"They are not used....","commit_id":"039f41e321cc280ba96b9ba1e8616b6997d5d0cb"}],"neutronclient/osc/v2/logging/network_log.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            cmd_resource \u003d None"},{"line_number":84,"context_line":"            if resource_type \u003d\u003d fwaas_const.FWG:"},{"line_number":85,"context_line":"                cmd_resource \u003d fwaas_const.CMD_FWG"},{"line_number":86,"context_line":"            elif resource_type \u003d\u003d \u0027snat\u0027:"},{"line_number":87,"context_line":"                resource_type \u003d \u0027router\u0027"},{"line_number":88,"context_line":"            attrs[\u0027resource_id\u0027] \u003d client.find_resource("},{"line_number":89,"context_line":"                resource_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c4793593","line":86,"range":{"start_line":86,"start_character":34,"end_line":86,"end_character":40},"updated":"2018-09-19 04:15:08.000000000","message":"I think you should update the constants file with this value","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if resource_type \u003d\u003d fwaas_const.FWG:"},{"line_number":85,"context_line":"                cmd_resource \u003d fwaas_const.CMD_FWG"},{"line_number":86,"context_line":"            elif resource_type \u003d\u003d \u0027snat\u0027:"},{"line_number":87,"context_line":"                resource_type \u003d \u0027router\u0027"},{"line_number":88,"context_line":"            attrs[\u0027resource_id\u0027] \u003d client.find_resource("},{"line_number":89,"context_line":"                resource_type,"},{"line_number":90,"context_line":"                parsed_args.resource,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_646aa1b5","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":40},"updated":"2018-09-19 04:15:08.000000000","message":"I guess this one too","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"fba2eda71f984aa6f7cd1f1d87e4f4a52674d138","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        parser.add_argument("},{"line_number":122,"context_line":"            \u0027--event\u0027,"},{"line_number":123,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":124,"context_line":"            choices\u003d[\u0027ALL\u0027, \u0027ACCEPT\u0027, \u0027DROP\u0027, \u0027BEFORE_SNAT\u0027, \u0027AFTER_SNAT\u0027],"},{"line_number":125,"context_line":"            type\u003dnc_utils.convert_to_uppercase,"},{"line_number":126,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":127,"context_line":"        # NOTE(yushiro) \u0027--resource-type\u0027 is managed by following command:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2426e917","line":124,"range":{"start_line":124,"start_character":47,"end_line":124,"end_character":58},"updated":"2018-09-19 06:52:21.000000000","message":"Done. I have mentioned these event in release note :)","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        parser.add_argument("},{"line_number":122,"context_line":"            \u0027--event\u0027,"},{"line_number":123,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":124,"context_line":"            choices\u003d[\u0027ALL\u0027, \u0027ACCEPT\u0027, \u0027DROP\u0027, \u0027BEFORE_SNAT\u0027, \u0027AFTER_SNAT\u0027],"},{"line_number":125,"context_line":"            type\u003dnc_utils.convert_to_uppercase,"},{"line_number":126,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":127,"context_line":"        # NOTE(yushiro) \u0027--resource-type\u0027 is managed by following command:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_846fbdc2","line":124,"updated":"2018-09-19 04:15:08.000000000","message":"These options are not mentioned in the release note","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        parser.add_argument("},{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c42b757f","line":141,"range":{"start_line":141,"start_character":58,"end_line":141,"end_character":70},"updated":"2018-09-19 04:15:08.000000000","message":", firewall","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"fba2eda71f984aa6f7cd1f1d87e4f4a52674d138","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        parser.add_argument("},{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_04196dcf","line":141,"range":{"start_line":141,"start_character":58,"end_line":141,"end_character":70},"in_reply_to":"3f79a3b5_c42b757f","updated":"2018-09-19 06:52:21.000000000","message":"Done","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_443765e4","line":142,"range":{"start_line":142,"start_character":70,"end_line":142,"end_character":73},"updated":"2018-09-19 04:15:08.000000000","message":"s/the ?","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8421fda0","line":142,"range":{"start_line":142,"start_character":31,"end_line":142,"end_character":35},"updated":"2018-09-19 04:15:08.000000000","message":"should either delete \u0027that\u0027 or change to \u0027that is\u0027","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"fba2eda71f984aa6f7cd1f1d87e4f4a52674d138","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a4775908","line":142,"range":{"start_line":142,"start_character":70,"end_line":142,"end_character":73},"in_reply_to":"3f79a3b5_443765e4","updated":"2018-09-19 06:52:21.000000000","message":"Done","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":28174,"name":"Kim Bao Long","email":"longkb@vn.fujitsu.com","username":"longkb.fvl"},"change_message_id":"fba2eda71f984aa6f7cd1f1d87e4f4a52674d138","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027--resource\u0027,"},{"line_number":140,"context_line":"            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":141,"context_line":"            help\u003d_(\u0027Name or ID of resource (security group or firewall group\u0027"},{"line_number":142,"context_line":"                   \u0027or router) that used for logging. You can control for\u0027"},{"line_number":143,"context_line":"                   \u0027logging target combination with --target option.\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c47cd5ec","line":142,"range":{"start_line":142,"start_character":31,"end_line":142,"end_character":35},"in_reply_to":"3f79a3b5_8421fda0","updated":"2018-09-19 06:52:21.000000000","message":"Thanks Brian :)","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"}],"releasenotes/notes/support-snat-resource-type-7500e04ca63a8a49.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for the \"snat\" as a loggable resource type for packet logging"},{"line_number":5,"context_line":"    feature, which is enhanced Neutron functionality, as OSC plugin commands."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_c450550d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2018-09-19 04:15:08.000000000","message":"s/Add CLI","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for the \"snat\" as a loggable resource type for packet logging"},{"line_number":5,"context_line":"    feature, which is enhanced Neutron functionality, as OSC plugin commands."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_6451410d","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":30},"updated":"2018-09-19 04:15:08.000000000","message":"s/``snat``","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f270ab39272985c05cd5952922e402eaac0ce6b9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for the \"snat\" as a loggable resource type for packet logging"},{"line_number":5,"context_line":"    feature, which is enhanced Neutron functionality, as OSC plugin commands."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_443c45be","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":76},"updated":"2018-09-19 04:15:08.000000000","message":"I would delete this second part of the sentence and maybe mention the option where \u0027snat\u0027 can be specified.","commit_id":"8d859bb40e5c44efe2a5b6e113ceea13758ace8b"}]}