)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f5cb2398fe94b2bca926e8dbf7c25f83174bb109","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is a POST. This can lead to orphaned objects being created that we"},{"line_number":11,"context_line":"don\u0027t know about. This patch sets httplib2.RETRIES to 1 to avoid this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: httplib2.RETRIES is only available in new versions of httplib2."},{"line_number":14,"context_line":"See: https://code.google.com/p/httplib2/issues/detail?id\u003d124 for more"},{"line_number":15,"context_line":"details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2B9sk%3D","line":13,"updated":"2014-02-17 23:45:44.000000000","message":"so do we need to pin httplib2 in requirements.txt or try/catch your assignment below in case RETRIES is not defined?","commit_id":"f2ec7d06e02ae3f470a6ba191ab5cb9722670d72"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4a308e0ccf4cc1acc71f4fceea6d334f124eef39","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is a POST. This can lead to orphaned objects being created that we"},{"line_number":11,"context_line":"don\u0027t know about. This patch sets httplib2.RETRIES to 1 to avoid this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: httplib2.RETRIES is only available in new versions of httplib2."},{"line_number":14,"context_line":"See: https://code.google.com/p/httplib2/issues/detail?id\u003d124 for more"},{"line_number":15,"context_line":"details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2B9io%3D","line":13,"in_reply_to":"AAAAUX%2F%2B9qU%3D","updated":"2014-02-18 00:15:04.000000000","message":"right, but don\u0027t we need to sync up with it?\nmaster version shows it unpinned it.\nhttps://github.com/openstack/python-neutronclient/blob/master/requirements.txt","commit_id":"f2ec7d06e02ae3f470a6ba191ab5cb9722670d72"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"500f8d0aa0d4adede8a4281cebcf5b35718d0b95","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is a POST. This can lead to orphaned objects being created that we"},{"line_number":11,"context_line":"don\u0027t know about. This patch sets httplib2.RETRIES to 1 to avoid this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: httplib2.RETRIES is only available in new versions of httplib2."},{"line_number":14,"context_line":"See: https://code.google.com/p/httplib2/issues/detail?id\u003d124 for more"},{"line_number":15,"context_line":"details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2B9qM%3D","line":13,"in_reply_to":"AAAAUX%2F%2B9sk%3D","updated":"2014-02-17 23:51:12.000000000","message":"Good catch. I made the same comment on requirements.txt in the previous patch set but totally forgot it.\n\nRegarding try/catch on RETRIES, try/catch is unnecessary because defining a module-level attribute does not raise an exception and it has no effect in older versions of httlib2.","commit_id":"f2ec7d06e02ae3f470a6ba191ab5cb9722670d72"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d0b5b82379e6dd6b9b4a985e2e5045a0ef573982","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is a POST. This can lead to orphaned objects being created that we"},{"line_number":11,"context_line":"don\u0027t know about. This patch sets httplib2.RETRIES to 1 to avoid this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: httplib2.RETRIES is only available in new versions of httplib2."},{"line_number":14,"context_line":"See: https://code.google.com/p/httplib2/issues/detail?id\u003d124 for more"},{"line_number":15,"context_line":"details."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2B9qU%3D","line":13,"in_reply_to":"AAAAUX%2F%2B9sk%3D","updated":"2014-02-17 23:50:36.000000000","message":"already done :) https://review.openstack.org/#/c/66486/\n\nWe don\u0027t need the a try: except statement because we are just setting the value and never reading it.","commit_id":"f2ec7d06e02ae3f470a6ba191ab5cb9722670d72"}],"neutronclient/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"228f28698b6ebe2314aa1df1a93656ead9e35a03","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # See: https://code.google.com/p/httplib2/issues/detail?id\u003d124"},{"line_number":37,"context_line":"    httplib2.RETRIES \u003d 1"},{"line_number":38,"context_line":"except AttributeError:"},{"line_number":39,"context_line":"    pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"if os.environ.get(\u0027NEUTRONCLIENT_DEBUG\u0027):"},{"line_number":42,"context_line":"    ch \u003d logging.StreamHandler()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FaTU%3D","line":39,"updated":"2014-01-14 01:32:02.000000000","message":"When is AttributeError raised? AFAIK, Adding a new module-level variable does not raise an exception.","commit_id":"f525840767b83fe2d9edb9b2a0daf5ce5ac99d58"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8c38f5755d451d7fad24cb1f0f2e31bd6e3a6ff6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # See: https://code.google.com/p/httplib2/issues/detail?id\u003d124"},{"line_number":37,"context_line":"    httplib2.RETRIES \u003d 1"},{"line_number":38,"context_line":"except AttributeError:"},{"line_number":39,"context_line":"    pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"if os.environ.get(\u0027NEUTRONCLIENT_DEBUG\u0027):"},{"line_number":42,"context_line":"    ch \u003d logging.StreamHandler()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FaAE%3D","line":39,"in_reply_to":"AAAAUH%2F%2FaC8%3D","updated":"2014-01-14 03:01:25.000000000","message":"Doh you\u0027re right ... don\u0027t know what i was thinking.....","commit_id":"f525840767b83fe2d9edb9b2a0daf5ce5ac99d58"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"e1bcbc75ff3843368a41c5f388989d2f1133c404","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # See: https://code.google.com/p/httplib2/issues/detail?id\u003d124"},{"line_number":37,"context_line":"    httplib2.RETRIES \u003d 1"},{"line_number":38,"context_line":"except AttributeError:"},{"line_number":39,"context_line":"    pass"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"if os.environ.get(\u0027NEUTRONCLIENT_DEBUG\u0027):"},{"line_number":42,"context_line":"    ch \u003d logging.StreamHandler()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FaC8%3D","line":39,"in_reply_to":"AAAAUH%2F%2FaTU%3D","updated":"2014-01-14 02:46:52.000000000","message":"It\u0027s raised if httplib2 doesn\u0027t have RETRIES which isn\u0027t available via the version from ubuntu\u0027s cloud repo by default.","commit_id":"f525840767b83fe2d9edb9b2a0daf5ce5ac99d58"}]}