)]}'
{"id":"openstack%2Fpython-neutronclient~65924","triplet_id":"openstack%2Fpython-neutronclient~master~Idccd66599fc022fbd41ce61795003da81b6fe25d","project":"openstack/python-neutronclient","branch":"master","topic":"useSix","hashtags":[],"change_id":"Idccd66599fc022fbd41ce61795003da81b6fe25d","subject":"Python 3: use six","status":"ABANDONED","created":"2014-01-10 11:51:11.000000000","updated":"2014-01-26 06:03:08.000000000","total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8708e9cc445f24e15d3b59c35bdd8b8fdd0a5b1a","_number":65924,"virtual_id_number":65924,"owner":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":1,"date":"2014-01-14 18:55:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"disliked":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":1,"date":"2014-01-14 14:50:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":1,"date":"2014-01-14 14:23:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":-1,"date":"2014-01-14 14:29:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},{"value":0,"date":"2014-01-14 15:02:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"value":1,"date":"2014-01-14 14:45:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2014-01-14 14:57:36.000000000","_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"date":"2014-01-14 14:56:38.000000000","_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-01-14 14:58:08.000000000","_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"date":"2014-01-14 14:56:48.000000000","_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2014-01-14 14:56:10.000000000","_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"date":"2014-01-14 14:56:19.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},{"date":"2014-01-14 14:58:24.000000000","_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"date":"2014-01-14 14:57:17.000000000","_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-13 11:38:54.000000000","updated_by":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"reviewer":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"state":"REVIEWER"},{"updated":"2014-01-13 16:14:36.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2014-01-14 13:23:37.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2014-01-14 14:05:32.000000000","updated_by":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"reviewer":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"state":"REVIEWER"},{"updated":"2014-01-14 14:23:08.000000000","updated_by":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"reviewer":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"state":"REVIEWER"},{"updated":"2014-01-14 14:29:48.000000000","updated_by":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"reviewer":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"state":"REVIEWER"},{"updated":"2014-01-14 14:45:57.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2014-01-14 14:50:11.000000000","updated_by":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"reviewer":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"state":"REVIEWER"},{"updated":"2014-01-14 14:56:10.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2014-01-14 14:56:19.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2014-01-14 14:56:38.000000000","updated_by":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"reviewer":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"state":"REVIEWER"},{"updated":"2014-01-14 14:56:48.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2014-01-14 14:57:17.000000000","updated_by":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"reviewer":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"state":"REVIEWER"},{"updated":"2014-01-14 14:57:36.000000000","updated_by":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"reviewer":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"state":"REVIEWER"},{"updated":"2014-01-14 14:58:08.000000000","updated_by":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"reviewer":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"state":"REVIEWER"},{"updated":"2014-01-14 14:58:24.000000000","updated_by":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"reviewer":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"state":"REVIEWER"},{"updated":"2014-01-14 18:55:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7535738cbaa087c75d0a78e61f4a3a9e8b6350a2","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-10 12:08:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"431f2ec5d63c83f87b3add12a4e79881a65d251c","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-10 12:29:26.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\ndictionaries support .items() for both py2x and 3x\nsix usage is unnecessary","accounts_in_message":[],"_revision_number":2},{"id":"d2a14ad8f336edd3c4162996f108c047db2e9ed9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 13:17:43.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-pep8/f9368fb : SUCCESS in 59s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/2/check/gate-python-neutronclient-docs/b0e3066/doc/build/html/ : SUCCESS in 53s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python26/8fbfe66 : SUCCESS in 1m 01s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python27/1b1f6c6 : SUCCESS in 48s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python33/e3e6af6 : FAILURE in 24s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-pypy/af87cd4 : SUCCESS in 2m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-full/2926852 : FAILURE in 50m 35s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-postgres-full/c19c822 : SUCCESS in 51m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron/d9f0ce3 : SUCCESS in 39m 37s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-pg/9c68c53 : FAILURE in 43m 30s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-isolated/0ad1cdf : SUCCESS in 42m 11s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-pg-isolated/d3e5e89 : SUCCESS in 39m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/2/check/gate-tempest-dsvm-large-ops/0adfbb1 : SUCCESS in 12m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/2/check/gate-tempest-dsvm-neutron-large-ops/2fed48a : SUCCESS in 12m 50s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/2/check/check-grenade-dsvm/b7ede77 : SUCCESS in 31m 45s\n","accounts_in_message":[],"_revision_number":2},{"id":"613e96ac1168c57320f3ead7b1ec90dccf26bb17","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-10 13:17:58.000000000","message":"Patch Set 2:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1265672\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1265672\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1265672","accounts_in_message":[],"_revision_number":2},{"id":"b686ae24c64ba247411e64533f77696c7604c8e1","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-10 13:28:35.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"0e036f5b5431e5f08a2c851dfe0232de5e5409b4","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-10 15:48:57.000000000","message":"Patch Set 2:\n\n@enikanorov: thanks for your remark, the function .items() is not doing the same thing in Py2 and Py3. In Py2 it returns a copy of the dictionary and in Py3 it returns a view of the dictionary. In addition, using an iterator is much efficient in this case.","accounts_in_message":[],"_revision_number":2},{"id":"cec1cbc10c81692bd0c685a97fe616b73077e201","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2014-01-10 17:35:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nWhile I agree that using six is better than blanket-converting to items(), I am curious why you are not addressing the iteritems() in neutronclient/common/utils.py?","accounts_in_message":[],"_revision_number":2},{"id":"cfc07cbfc4338e204357e1d6fc43917cd59f7979","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-13 07:52:19.000000000","message":"Patch Set 2: No score\n\nrecheck bug 1265672","accounts_in_message":[],"_revision_number":2},{"id":"43d19af94e841d61174e337cc3abc34e1a7cbba2","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-13 07:52:42.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a8bc9fa2c391ebb9749246855ce2e6d5fa9756cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 08:38:42.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-pep8/85f3d64 : SUCCESS in 40s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/2/check/gate-python-neutronclient-docs/dda2257/doc/build/html/ : SUCCESS in 51s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python26/c9be6c1 : SUCCESS in 59s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python27/ddb18b2 : SUCCESS in 42s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-python33/37534e1 : FAILURE in 24s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/2/check/gate-python-neutronclient-pypy/2963ee9 : SUCCESS in 2m 02s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-full/a069aeb : SUCCESS in 43m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-postgres-full/d4e6073 : SUCCESS in 46m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron/99baaf3 : SUCCESS in 42m 30s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-pg/5c5b45c : SUCCESS in 42m 29s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-isolated/9959d4d : SUCCESS in 38m 45s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/2/check/check-tempest-dsvm-neutron-pg-isolated/c6aa1ca : SUCCESS in 41m 03s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/2/check/gate-tempest-dsvm-large-ops/ca3f895 : SUCCESS in 11m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/2/check/gate-tempest-dsvm-neutron-large-ops/58ac352 : SUCCESS in 13m 52s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/2/check/check-grenade-dsvm/0664f80 : SUCCESS in 30m 17s\n","accounts_in_message":[],"_revision_number":2},{"id":"90e5687cc0cc3e5302637bf0f1607183febeb6e5","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 11:35:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"61c243e949e8a8594834b33d71ea8fc934b35658","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 11:36:02.000000000","message":"Patch Set 3:\n\n@Henry: Thanks for your remark! I updated the patch :).","accounts_in_message":[],"_revision_number":3},{"id":"29a602397fefdfa75190831d46c667afaecd3efd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 12:27:03.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/3/check/gate-python-neutronclient-pep8/e5c8f9c : SUCCESS in 49s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/3/check/gate-python-neutronclient-docs/b571f58/doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/3/check/gate-python-neutronclient-python26/b3ce420 : SUCCESS in 1m 20s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/3/check/gate-python-neutronclient-python27/9b0acb1 : SUCCESS in 39s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/3/check/gate-python-neutronclient-python33/1f4e6f8 : FAILURE in 26s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/3/check/gate-python-neutronclient-pypy/9dbb24d : SUCCESS in 2m 04s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-full/9ead01f : SUCCESS in 51m 47s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-postgres-full/339c4c2 : SUCCESS in 44m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-neutron/9cf836c : SUCCESS in 37m 27s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-neutron-pg/70b2c02 : SUCCESS in 37m 02s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-neutron-isolated/562eb09 : SUCCESS in 43m 45s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/3/check/check-tempest-dsvm-neutron-pg-isolated/f1496d9 : SUCCESS in 38m 46s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/3/check/gate-tempest-dsvm-large-ops/37de548 : SUCCESS in 12m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/3/check/gate-tempest-dsvm-neutron-large-ops/27716af : SUCCESS in 12m 39s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/3/check/check-grenade-dsvm/b762c14 : SUCCESS in 29m 37s\n","accounts_in_message":[],"_revision_number":3},{"id":"62c7000c771e614287788a83ee84b75532066add","author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"date":"2014-01-13 12:42:11.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"1eb8bfba838bf0fedda8cd75221256884dd24e70","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-13 13:16:48.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"0ae9be4ef24b0428b27d47cb1322cae4579fa7b6","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2014-01-13 14:16:17.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nSee my comment inline, and also you have missed an iteritems in neutronclient/tests/unit/test_cli20.py","accounts_in_message":[],"_revision_number":3},{"id":"0a6ac5f2269624dca316f5a59ec4289841950cd5","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 15:34:03.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"37edfe8026989429d755102a70a723e750b32c1b","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 15:43:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1d432d66efcdb5569c2b36e08cc904017f8244cc","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-01-13 16:14:36.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nthanks!","accounts_in_message":[],"_revision_number":4},{"id":"23aa9821276ce458439345bf77befa7b7edd6251","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 17:01:18.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-pep8/274ac12 : SUCCESS in 1m 04s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/4/check/gate-python-neutronclient-docs/bdd94f8/doc/build/html/ : SUCCESS in 47s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python26/6a24a56 : SUCCESS in 43s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python27/d0797fe : SUCCESS in 1m 02s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python33/5776e4e : FAILURE in 25s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-pypy/b0ee8af : SUCCESS in 2m 04s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-full/db97de7 : SUCCESS in 48m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-postgres-full/b5d0964 : SUCCESS in 44m 42s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron/4221687 : SUCCESS in 46m 12s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-pg/98139f0 : FAILURE in 1h 05m 56s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-isolated/e69ca43 : SUCCESS in 41m 49s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-pg-isolated/4ed2685 : SUCCESS in 40m 30s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/4/check/gate-tempest-dsvm-large-ops/0d35968 : SUCCESS in 13m 11s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/4/check/gate-tempest-dsvm-neutron-large-ops/b4dc564 : SUCCESS in 16m 46s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/4/check/check-grenade-dsvm/d1e1739 : SUCCESS in 32m 53s\n","accounts_in_message":[],"_revision_number":4},{"id":"7efbdebd663dfb1e5b11f57f65427e5f00f37e70","author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"date":"2014-01-13 17:26:17.000000000","message":"Patch Set 4:\n\nrecheck bug 1254890","accounts_in_message":[],"_revision_number":4},{"id":"0b19109f4b840f43208162f6822bf9e8258f1c0e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 18:25:24.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-pep8/028ea91 : SUCCESS in 1m 04s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/4/check/gate-python-neutronclient-docs/f8066ab/doc/build/html/ : SUCCESS in 51s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python26/7a500fc : SUCCESS in 1m 09s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python27/7e67dd6 : SUCCESS in 53s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-python33/b4a579a : FAILURE in 24s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/4/check/gate-python-neutronclient-pypy/8cd8ef2 : SUCCESS in 2m 02s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-full/107685d : SUCCESS in 46m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-postgres-full/12a8f68 : SUCCESS in 56m 08s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron/7ce2490 : SUCCESS in 44m 45s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-pg/a8d1642 : SUCCESS in 58m 57s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-isolated/85a68dd : SUCCESS in 41m 48s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/4/check/check-tempest-dsvm-neutron-pg-isolated/153ab4e : SUCCESS in 41m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/4/check/gate-tempest-dsvm-large-ops/36c804a : SUCCESS in 11m 00s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/4/check/gate-tempest-dsvm-neutron-large-ops/0322a11 : SUCCESS in 13m 18s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/4/check/check-grenade-dsvm/f107ea3 : SUCCESS in 33m 22s\n","accounts_in_message":[],"_revision_number":4},{"id":"50bb83e03056c43e65ab4a2ae6d1748851e33255","author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"date":"2014-01-13 18:25:45.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"82e40f41c5dffab513a33a0a16e13b94aa2786fb","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2014-01-13 19:56:57.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"8cf7c82948fd39d92df687aa08d7e2ac9021951f","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2014-01-14 01:52:59.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nIs there any hacking guide about Python 3 compatibility this patch fixes? If not, it should be documented AND checked by hacking. I don\u0027t think reviewers can check this every time and it is worth checked automatically.","accounts_in_message":[],"_revision_number":4},{"id":"a343e56ec295fbc3296967821507f8ec0a8b7ba7","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-14 07:56:36.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n\"Is there any hacking guide about Python 3 compatibility this patch fixes? If not, it should be documented AND checked by hacking. I don\u0027t think reviewers can check this every time and it is worth checked automatically.\"\n\nHi, you can find information about Python 3 and how to port Python 2 code to Python 3 on the following wiki page:\nhttps://wiki.openstack.org/wiki/Python3","accounts_in_message":[],"_revision_number":4},{"id":"b4efbdb1d3b0c1a2754259b493a15b3ca65e290b","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-14 08:41:44.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nI tend to agree with Akihiro. \nPersonally I think that it\u0027s better to use language constructs which work both or python 2.x and 3.0 at the cost of losing a bit of performance (like with iteritems-\u003eitems, xrange-\u003exrange). \n\nIt\u0027s not critical at all especially for such application as client.","accounts_in_message":[],"_revision_number":4},{"id":"33697e67276e3c6ba70b6f9f19c7744fbf412e16","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 10:32:19.000000000","message":"Patch Set 4:\n\n@Akihiro: Thank you for your remark. As Victor said you can find the guide about Python 3 compatibility at https://wiki.openstack.org/wiki/Python3.\n\nAccording to that page, \"OpenStack project chose to use the same code base for Python 2 and Python 3. The Six: Python 2 and 3 Compatibility Library helps to write code working on both versions.\", so this patch is just using six...\n\nI agree that it would be more efficient to automatize it.\n\nBut even if its done by hacking since flake8 is run against the whole code we need that kind of patch to \"clean up\" the code before to put in place hacking...\n\n@enikanorov: I don\u0027t like that kind of hack, i prefer to have a consistent solution by using six as said in the OpenStack wiki.","accounts_in_message":[],"_revision_number":4},{"id":"6c3bf528bb9478f0aaf56444193a0ccb8919d0a1","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-14 10:35:54.000000000","message":"Patch Set 4:\n\nThat would not be a hack, that exactly what is \u0027writing compatible code\u0027","accounts_in_message":[],"_revision_number":4},{"id":"f77f270172c4f82b5aa135ee8f1201ea2331313a","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 10:37:49.000000000","message":"Patch Set 4: (4 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"4e02d52150087e39f2c1dd5a5b1776015e05134b","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 10:37:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"23624015e0f24dc86a3ab224b933949051637f07","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-14 13:19:02.000000000","message":"Patch Set 5: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"2651a59d9c8f24082dbbf7be2fcc02cb8aa56a05","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2014-01-14 13:23:37.000000000","message":"Patch Set 5:\n\nThanks for your work. I am okay with this patch because it is a clean patch and my -1 in the previous patch set came from wrong placement of \"import six\". It has been addressed now.\n\nAbout Python3 compatibility, during reviews so far, I see several cases where it is better to use \"six\" (e.g., iteritmes, keys, basesstring, text_type, add_metaclass, ...). I believe it would be very nice if these kinds of recipes are listed in Py3 compat pages. six docs describes available methods, but I think there are not so many cases where six is actually needed and some recipes may help contributors.\n\nIt is not a requirement of this patch of course. I just thought it is a good chance to discuss :-)","accounts_in_message":[],"_revision_number":5},{"id":"9e3a352f674359653156bb550477664df3fa50d0","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 13:45:04.000000000","message":"Patch Set 5: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"1c8afa172507ff0cfc1d4ce52613d36a9fccc7cc","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 13:45:17.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"8efbacbc169f333a21e54a4dbd7216e18760063a","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 13:52:22.000000000","message":"Patch Set 6:\n\n@Akihiro: Agreed, we should definitely put some recipes on that page :) !\n\nThanks!","accounts_in_message":[],"_revision_number":6},{"id":"10c9d7ddb98c8137375155ae08f1e9c81c480bcc","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2014-01-14 14:05:32.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"3471597a549e7235d8d593dc7531b9b7f666d186","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 14:14:15.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"cf4af52787b9fcf224c625a3b4f4d9539674ebaa","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 14:14:36.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b59207041dfe9805e75a6a95b6c7adad7a20c32d","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-14 14:18:09.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"9a0e105b785e15c56ab495d13c1f11c6ced31c7d","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-14 14:23:08.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"26d41f6b22c26426d4fee7dfa037169c243e9a41","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-14 14:29:48.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\nI\u0027m -1 on this patch. I don\u0027t like 3rd party library is used for what is achievable by pure language.\nIt also pollutes code a lot. I don\u0027t see a reason why developer should use six.iteritems instead of dict.items. I am well aware of the difference between items and iteritems and i think that in absolute most of the cases the difference is not worth making code ugly. \nI\u0027d like ho see more opinions from community before approving that.","accounts_in_message":[],"_revision_number":7},{"id":"6dd345ce9bb61a64206efcb096f3ce92911baf06","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2014-01-14 14:45:57.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"718ebcd1fdc2f095eff5867f764b0e47be4a70c8","author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"date":"2014-01-14 14:50:11.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"a8eb6aa5c446a4b11c2aba5651963fd9f71b881d","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 15:02:22.000000000","message":"Patch Set 7:\n\nCould a core-dev please gives his opinion about this patch ?\n\nThanks!","accounts_in_message":[],"_revision_number":7},{"id":"0e58ab39fa526f699c942f236173c3d132d6e7fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-14 18:55:26.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/24/65924/7/check/gate-python-neutronclient-pep8/e8a36d3 : SUCCESS in 40s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/24/65924/7/check/gate-python-neutronclient-docs/e5b1080/doc/build/html/ : SUCCESS in 45s\n- gate-python-neutronclient-python26 http://logs.openstack.org/24/65924/7/check/gate-python-neutronclient-python26/2d715da : SUCCESS in 1m 05s\n- gate-python-neutronclient-python27 http://logs.openstack.org/24/65924/7/check/gate-python-neutronclient-python27/40e26be : SUCCESS in 51s\n- gate-python-neutronclient-python33 http://logs.openstack.org/24/65924/7/check/gate-python-neutronclient-python33/f63103e : FAILURE in 25s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/24/65924/7/check/gate-python-neutronclient-pypy/7e0d2f7 : SUCCESS in 2m 04s\n- check-tempest-dsvm-full http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-full/743fe9b : SUCCESS in 49m 34s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-postgres-full/c1554b2 : SUCCESS in 47m 27s\n- check-tempest-dsvm-neutron http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-neutron/140871d : SUCCESS in 40m 22s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-neutron-pg/8555562 : SUCCESS in 39m 25s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-neutron-isolated/c8964ad : SUCCESS in 40m 30s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/24/65924/7/check/check-tempest-dsvm-neutron-pg-isolated/bf64762 : SUCCESS in 39m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/24/65924/7/check/gate-tempest-dsvm-large-ops/307bcdf : SUCCESS in 11m 14s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/24/65924/7/check/gate-tempest-dsvm-neutron-large-ops/0fe6759 : SUCCESS in 13m 21s\n- check-grenade-dsvm http://logs.openstack.org/24/65924/7/check/check-grenade-dsvm/9b16d00 : SUCCESS in 38m 39s\n","accounts_in_message":[],"_revision_number":7},{"id":"043c387288bdf7b3d1836b4a57b541b52f91b9f1","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-15 09:25:56.000000000","message":"Patch Set 7:\n\n\"I don\u0027t like 3rd party library is used for what is achievable by pure language.\"\n\nThe library is required in all OpenStack components since Olso Incubator requires it. So it\u0027s not like it add a new dependency. six is the official option chosen by OpenStack. Example of projects using six:\n\n- Olso Incubator (\"openstack.common\")\n- Ceilometer\n- Cinder\n- Keystone\n- Neutron\n- Nova\n- Oslo Config\n- Olso Messaging\n- cinderclient\n- glanceclient\n- heatclient\n- keystoneclient\n- novaclient\n- openstackclient","accounts_in_message":[],"_revision_number":7},{"id":"9c15e41315a28d56e9c609b031aa6dbd60bbae5c","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2014-01-18 22:01:12.000000000","message":"Patch Set 7:\n\nright, it is required;\nIn most cases it is used for metaclasses only.\nOslo project uses more capabilities of six, but it is justified since oslo is a common library (even if the code is just copied in each project).\n\nI\u0027d like to see a discussion in the community on the extent of six usage.  To me a requirement to import six in most of the files wherever developer plans to use dict.items/iteritems seems very strict, and if it is not a requirement, then there is no point in changing the code in a few places in one project.","accounts_in_message":[],"_revision_number":7},{"id":"fd49baa4f0af2e7925b1b50a67ca96bac6b9bc94","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-26 06:03:08.000000000","message":"Patch Set 7: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":7},{"id":"c71918c09100ce7307d7bfa4c500ca28b23048c8","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-26 06:03:08.000000000","message":"Patch Set 7:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"8d6213ea0693c6cbbc720eb1de5acee246725643","revisions":{"2dbca372d2c13d4cc172f6aa91ab68b92a1a5900":{"kind":"REWORK","_number":1,"created":"2014-01-10 11:51:11.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/1"}}},"commit":{"parents":[{"commit":"6b44e6060ebec3671cce72ba450d100ee8c987fa","subject":"Merge \"Misc typo in neutronclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6b44e6060ebec3671cce72ba450d100ee8c987fa"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:51:09.000000000","tz":60},"subject":"Python 3: use six.iteritems() instead of iteritems()","message":"Python 3: use six.iteritems() instead of iteritems()\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2dbca372d2c13d4cc172f6aa91ab68b92a1a5900"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2dbca372d2c13d4cc172f6aa91ab68b92a1a5900"}]},"branch":"refs/heads/master"},"ccb1f4cd8675f33f56c9ef8a510f2e1a79024731":{"kind":"REWORK","_number":2,"created":"2014-01-10 12:08:33.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/2"}}},"commit":{"parents":[{"commit":"6b44e6060ebec3671cce72ba450d100ee8c987fa","subject":"Merge \"Misc typo in neutronclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6b44e6060ebec3671cce72ba450d100ee8c987fa"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 12:05:10.000000000","tz":60},"subject":"Python 3: use six when iterating over dictionaries","message":"Python 3: use six when iterating over dictionaries\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ccb1f4cd8675f33f56c9ef8a510f2e1a79024731"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ccb1f4cd8675f33f56c9ef8a510f2e1a79024731"}]},"branch":"refs/heads/master"},"8f14f3bc433609374671c6a8890489d5dca28056":{"kind":"REWORK","_number":3,"created":"2014-01-13 11:35:07.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/3"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-13 11:35:05.000000000","tz":60},"subject":"Python 3: use six","message":"Python 3: use six\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8f14f3bc433609374671c6a8890489d5dca28056"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8f14f3bc433609374671c6a8890489d5dca28056"}]},"branch":"refs/heads/master"},"ca557f333cadc703c74664a383340cb1f7369110":{"kind":"REWORK","_number":4,"created":"2014-01-13 15:43:49.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/4"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-13 15:43:01.000000000","tz":60},"subject":"Python 3: use six","message":"Python 3: use six\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ca557f333cadc703c74664a383340cb1f7369110"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ca557f333cadc703c74664a383340cb1f7369110"}]},"branch":"refs/heads/master"},"82597f8f630ee268946a40616858c3f3778ca9ac":{"kind":"REWORK","_number":5,"created":"2014-01-14 10:37:57.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/5"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-14 10:37:11.000000000","tz":60},"subject":"Python 3: use six","message":"Python 3: use six\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/82597f8f630ee268946a40616858c3f3778ca9ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/82597f8f630ee268946a40616858c3f3778ca9ac"}]},"branch":"refs/heads/master"},"fb76df3d702397a743405c5d75732073e0c79528":{"kind":"REWORK","_number":6,"created":"2014-01-14 13:45:17.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/6"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-14 13:44:30.000000000","tz":60},"subject":"Python 3: use six","message":"Python 3: use six\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/fb76df3d702397a743405c5d75732073e0c79528"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/fb76df3d702397a743405c5d75732073e0c79528"}]},"branch":"refs/heads/master"},"8d6213ea0693c6cbbc720eb1de5acee246725643":{"kind":"REWORK","_number":7,"created":"2014-01-14 14:14:36.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/24/65924/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/24/65924/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/24/65924/7"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 11:49:13.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-14 14:14:28.000000000","tz":60},"subject":"Python 3: use six","message":"Python 3: use six\n\nsix.iteritems() replaces dictionary.iteritems() on Python 2 and\ndictionary.items() on Python 3.\n\nsix.iterkeys() replaces dictionary.iterkeys() on Python 2 and\ndictionary.keys() on Python 3.\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Idccd66599fc022fbd41ce61795003da81b6fe25d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8d6213ea0693c6cbbc720eb1de5acee246725643"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8d6213ea0693c6cbbc720eb1de5acee246725643"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}