)]}'
{"id":"openstack%2Fpython-neutronclient~67359","triplet_id":"openstack%2Fpython-neutronclient~master~I94a8633d839946bd395ce4bc0f16e58a55fb0dba","project":"openstack/python-neutronclient","branch":"master","topic":"bp/py33-support","hashtags":[],"change_id":"I94a8633d839946bd395ce4bc0f16e58a55fb0dba","subject":"Use mox3 instead of mox","status":"ABANDONED","created":"2014-01-17 02:30:15.000000000","updated":"2014-02-04 06:03:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0444ca4e54ca47fad62d2ae199950c6a8e91c8f0","_number":67359,"virtual_id_number":67359,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-01-26 18:26:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-01-26 17:12:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":1,"date":"2014-01-27 13:36:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":-1,"date":"2014-01-26 15:04:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-26 15:04:15.000000000","updated_by":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"reviewer":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"state":"REVIEWER"},{"updated":"2014-01-26 18:26:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-01-27 13:36:09.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"}],"messages":[{"id":"da0b23f84913e3d3b8abfa55aa4b7b2d81cf91b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-17 07:59:44.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pep8/db83682 : SUCCESS in 1m 11s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/59/67359/1/check/gate-python-neutronclient-docs/6a7f22a/doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-neutronclient-python26 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python26/424998b : FAILURE in 1m 06s\n- gate-python-neutronclient-python27 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python27/756b2ab : FAILURE in 58s\n- gate-python-neutronclient-requirements http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-requirements/087ed08 : SUCCESS in 10s\n- gate-python-neutronclient-python33 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python33/fe29448 : FAILURE in 29s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pypy/0876fcd : FAILURE in 1m 58s\n- check-tempest-dsvm-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-full/0677652 : SUCCESS in 1h 03m 31s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-postgres-full/5253943 : SUCCESS in 1h 04m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron/779a6cd : SUCCESS in 34m 44s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg/5702891 : SUCCESS in 38m 16s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-isolated/c52e02a : SUCCESS in 42m 01s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg-isolated/01b30e6 : SUCCESS in 38m 15s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-large-ops/daca72f : SUCCESS in 14m 36s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-neutron-large-ops/63dfbcc : SUCCESS in 12m 17s\n- check-grenade-dsvm http://logs.openstack.org/59/67359/1/check/check-grenade-dsvm/8b90bb5 : SUCCESS in 34m 45s\n","accounts_in_message":[],"_revision_number":1},{"id":"d1cf170bda0afe9c44faa6be5151685293e995bf","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-17 08:37:33.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"84305737679a729d158a9113456eb17fc82dce85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-17 12:28:12.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pep8/853d87c : SUCCESS in 59s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/59/67359/1/check/gate-python-neutronclient-docs/0f90e75/doc/build/html/ : SUCCESS in 59s\n- gate-python-neutronclient-python26 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python26/39720e4 : FAILURE in 58s\n- gate-python-neutronclient-python27 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python27/71bf78f : FAILURE in 49s\n- gate-python-neutronclient-requirements http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-requirements/10dd726 : SUCCESS in 6s\n- gate-python-neutronclient-python33 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python33/f312bcf : FAILURE in 28s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pypy/0541abb : FAILURE in 1m 53s\n- check-tempest-dsvm-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-full/e007189 : SUCCESS in 1h 03m 03s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-postgres-full/6460007 : SUCCESS in 1h 28m 40s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron/9382479 : SUCCESS in 37m 04s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg/6f82e86 : SUCCESS in 41m 11s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-isolated/2e71f41 : SUCCESS in 41m 34s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg-isolated/127ed05 : SUCCESS in 39m 36s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-large-ops/c80e77d : SUCCESS in 12m 53s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-neutron-large-ops/20ec17e : SUCCESS in 14m 07s\n- check-grenade-dsvm http://logs.openstack.org/59/67359/1/check/check-grenade-dsvm/b555a8d : SUCCESS in 39m 17s\n","accounts_in_message":[],"_revision_number":1},{"id":"c4a45acadf63535e8ad4addca29a76611cff338e","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-25 06:03:18.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"6bc91191ece29bf0d10fb1f704d9b4a9bfb25764","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-25 06:03:18.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"25d8ae9e48ba21004f1b0658d88ecb0086335401","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-25 07:13:20.000000000","message":"Patch Set 1: Restored\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"d15f0cf8addc86980ecbd8a34d9bb0e3f619438e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-25 08:09:11.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pep8/046f0bd : SUCCESS in 54s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/59/67359/1/check/gate-python-neutronclient-docs/2c32496/doc/build/html/ : SUCCESS in 56s\n- gate-python-neutronclient-python26 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python26/8bf409d : FAILURE in 1m 06s\n- gate-python-neutronclient-python27 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python27/2125142 : FAILURE in 1m 04s\n- gate-python-neutronclient-requirements http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-requirements/28e3daa : SUCCESS in 4s\n- gate-python-neutronclient-python33 http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-python33/96f29f8 : FAILURE in 27s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/59/67359/1/check/gate-python-neutronclient-pypy/f9780b4 : FAILURE in 1m 55s\n- check-tempest-dsvm-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-full/03060a1 : SUCCESS in 55m 34s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-postgres-full/ea621a9 : SUCCESS in 48m 22s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron/20b550b : SUCCESS in 33m 33s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg/5a9ea32 : FAILURE in 35m 19s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-isolated/6ab9fe7 : FAILURE in 37m 23s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/59/67359/1/check/check-tempest-dsvm-neutron-pg-isolated/bd10f58 : SUCCESS in 31m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-large-ops/d23888f : SUCCESS in 13m 15s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/59/67359/1/check/gate-tempest-dsvm-neutron-large-ops/0cf55b3 : SUCCESS in 12m 12s\n- check-grenade-dsvm http://logs.openstack.org/59/67359/1/check/check-grenade-dsvm/fcf0763 : SUCCESS in 31m 30s\n","accounts_in_message":[],"_revision_number":1},{"id":"be9480b600ab9d5773f47858f024ab364691aa0f","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 13:30:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cce23f1a81dedbe0ff1ff37515eab7a2f2e80148","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-26 13:43:44.000000000","message":"Patch Set 2:\n\nCan I get some more detail in the commit message? OpenStack projects have been moving from mock to mox specifically because mox works with python3. Can you supply some details on why mox won\u0027t work and why mox3 is required?","accounts_in_message":[],"_revision_number":2},{"id":"a2adafb72dea2d64f4a1f9fee7191e9a37989224","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 14:07:11.000000000","message":"Patch Set 2:\n\n@Anito\n\nYes the commit message doesn\u0027t provide so much detail, I assume the fact that mox is out of date and will not support python3 is a common issue.\n\nIn fact, mox is not recommanded any more, new code should use mock and old code should use mox3 to provide python 3 compatibility\n\nYou can read http://lists.openstack.org/pipermail/openstack-dev/2013-July/012474.html or http://lists.openstack.org/pipermail/openstack-dev/2013-December/021148.html","accounts_in_message":[],"_revision_number":2},{"id":"5025141cc02ed4769293b7f44acf22556189093e","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 14:26:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b3dc52883f8b3c5932ae4b2e3a3e95bc64a77898","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-01-26 14:26:25.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"ddecb1b3bd0c2e973635a5a032dfeb3f4a8048d4","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-26 15:04:15.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nYes, I agree with a move away from mox: https://pypi.python.org/pypi/mox\n\nI disagree that mox3 is the correct direction: https://pypi.python.org/pypi/mox3\nAn unofficial port that included the warning \"Use at your own risk ;)\" doesn\u0027t fill me with much confidence.\n\nBoth mailing list posts you link to mention the use of mock: https://pypi.python.org/pypi/mock/\nwhich is now part of the python standard library and works with python3.3, which mox3 has not been tested against.\n\nI think a better direction is to move to mock.","accounts_in_message":[],"_revision_number":3},{"id":"3e90ea50a0a7a98e10e15b989828271eb772f878","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-26 15:30:13.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-pep8/fb10e85 : SUCCESS in 36s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/59/67359/3/check/gate-python-neutronclient-docs/80823c4/doc/build/html/ : SUCCESS in 49s\n- gate-python-neutronclient-python26 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python26/1a84802 : SUCCESS in 1m 10s\n- gate-python-neutronclient-python27 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python27/f969f7f : SUCCESS in 1m 04s\n- gate-python-neutronclient-requirements http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-requirements/2921420 : SUCCESS in 5s\n- gate-python-neutronclient-python33 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python33/e636581 : FAILURE in 27s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-pypy/58e63c1 : SUCCESS in 2m 19s\n- check-tempest-dsvm-full http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-full/8bc7f4d : SUCCESS in 1h 00m 02s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-postgres-full/068c933 : SUCCESS in 1h 03m 46s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron/439e5e5 : SUCCESS in 33m 13s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-pg/a692397 : FAILURE in 39m 15s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-isolated/5398abc : SUCCESS in 31m 48s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-pg-isolated/5211697 : SUCCESS in 29m 25s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/59/67359/3/check/gate-tempest-dsvm-large-ops/5b84c84 : SUCCESS in 10m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/59/67359/3/check/gate-tempest-dsvm-neutron-large-ops/45717b9 : SUCCESS in 13m 05s\n- check-grenade-dsvm http://logs.openstack.org/59/67359/3/check/check-grenade-dsvm/b916f09 : SUCCESS in 34m 12s\n","accounts_in_message":[],"_revision_number":3},{"id":"be80d369219281818b6bf5a59ab24c79b728ae4a","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-26 15:30:32.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1254890\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1254890\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1254890","accounts_in_message":[],"_revision_number":3},{"id":"017b4fb1adae18bc14902d2583cd568a42ad82e5","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 17:12:03.000000000","message":"Patch Set 3:\n\n@Anita Kuno\n\nyes, mock is good, I like it too, but do you notice how heavily neutronclient use mox? This patch aims at enable py33 unit test, so it just fix mox issue to partial enable it, migrate to mock is another topic which needs a mount of work and test. mox3 is an acceptable choice.\n\nyes, mox3 is not a official module of mox, but it is in the global requirements which means it is not so danger(https://github.com/openstack/requirements/blob/master/global-requirements.txt#L128)\n\nSome projects have already use mox3 as a workaround, for, i.e. python-keystoneclient (https://github.com/openstack/python-keystoneclient/blob/master/test-requirements.txt), python-glanceclient(https://github.com/openstack/python-glanceclient/blob/master/test-requirements.txt), python-heatclient(https://github.com/openstack/python-heatclient/blob/master/test-requirements.txt), yes, they all xxxclient because they are more possiable facing the py3 compatibility problem.\n\nas for the risk, please note that this package\u0027s author is OpenStack. I think all modules have risk and bugs, but a module with bug but can meet our need is better than totally disable what we need.\n\nas for the two links I provide, I think it clearly said that even though mock is the good choice but mox3 is another too\n\nwelcome to contribute to py33 for neutronclient, the mox migration for python3 support needs a lot work to do\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"c5c20115ff1e06c31cdd7cb25b85386494ef7a32","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 17:12:39.000000000","message":"Patch Set 3:\n\nrecheck bug 1254890","accounts_in_message":[],"_revision_number":3},{"id":"ffdab39194cd8240af0c3fb6a9a564e0fddc95f2","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-26 17:19:31.000000000","message":"Patch Set 3: Work In Progress\n\nwaiting for other patches to enable py33, so this mox migration work can be done in the end","accounts_in_message":[],"_revision_number":3},{"id":"813c76380cfd2f26e22cd4b4259b161ddcb5b2d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-26 18:26:43.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-pep8/83114c9 : SUCCESS in 1m 02s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/59/67359/3/check/gate-python-neutronclient-docs/0936519/doc/build/html/ : SUCCESS in 58s\n- gate-python-neutronclient-python26 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python26/2481dc0 : SUCCESS in 54s\n- gate-python-neutronclient-python27 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python27/57efd86 : SUCCESS in 1m 09s\n- gate-python-neutronclient-requirements http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-requirements/3bd931d : SUCCESS in 6s\n- gate-python-neutronclient-python33 http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-python33/936fddc : FAILURE in 26s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/59/67359/3/check/gate-python-neutronclient-pypy/558c0f6 : SUCCESS in 2m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-full/42029d5 : SUCCESS in 53m 51s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-postgres-full/0681832 : SUCCESS in 48m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron/66a7185 : SUCCESS in 33m 35s\n- check-tempest-dsvm-neutron-pg http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-pg/7871425 : SUCCESS in 37m 42s\n- check-tempest-dsvm-neutron-isolated http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-isolated/25e8dad : SUCCESS in 35m 59s\n- check-tempest-dsvm-neutron-pg-isolated http://logs.openstack.org/59/67359/3/check/check-tempest-dsvm-neutron-pg-isolated/1243382 : SUCCESS in 34m 45s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/59/67359/3/check/gate-tempest-dsvm-large-ops/b5e4188 : SUCCESS in 17m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/59/67359/3/check/gate-tempest-dsvm-neutron-large-ops/3319754 : SUCCESS in 17m 30s\n- check-grenade-dsvm http://logs.openstack.org/59/67359/3/check/check-grenade-dsvm/6c3c2a5 : SUCCESS in 41m 26s\n","accounts_in_message":[],"_revision_number":3},{"id":"6d57a06ea74482dd1df139dd4a0b809bf7927f5d","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 00:57:48.000000000","message":"Patch Set 3:\n\nThe blueprint that was approved for this work references work done on novaclient as an example of what to expect from this blueprint: https://blueprints.launchpad.net/python-neutronclient/+spec/py33-support\n\nCorrect me if I am wrong, but I see novaclient using mock, not mox and not mox3. http://git.openstack.org/cgit/openstack/python-novaclient/tree/test-requirements.txt","accounts_in_message":[],"_revision_number":3},{"id":"8801821ea73edc924ba506ce1163d5de1e028556","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-27 01:24:35.000000000","message":"Patch Set 3:\n\n@Anito\n\nYes, novaclient did a very good job, thanks for Kui Shi\u0027s work.\n\nIn the blueprint, I said that there is a work for py33 support done in novaclient project, but not saying there is a good job in novaclient migrate from mox to mock. In fact novaclient doesn\u0027t use mox from the beginning AFAIK:\n\n    zqfan@openstack-dev:~/openstack/python-novaclient$ git checkout master\n    Already on \u0027master\u0027\n    zqfan@openstack-dev:~/openstack/python-novaclient$ git pull --ff-only \n    Already up-to-date.\n    zqfan@openstack-dev:~/openstack/python-novaclient$ git log -p test-requirements.txt | grep mox\n    zqfan@openstack-dev:~/openstack/python-novaclient$\n\nAnd even there are some projects else have done a great job for migrate mox to mock, that is not saying we\u0027re not plan to do it, in this change for what I\u0027m talking about we should take a smooth change, such as enable py33 firstly, then if some test use mox3 fails, we can replace it with mock particularly, and finally, all code even those works in mox3 can be replaced with mock, then maybe everyone is happy\n\nI already give a link in openstack/requirements, I trust those contributors that they will consider seriously for introducing new modules, in fact, they\u0027re a bit strict even for a module verion update. And the example of keystoneclient, glanceclient and heatclient show us that mox3 is a choice of workaround, I\u0027m not saying they are absolutely good for everyone, I think at least it may be not so bad\n\nLastly, I already set this to WIP, which means other issue will be fixed before this one, and when this issue blocks the whole progress, this can open again.\n\nsince you\u0027re so loving mock, maybe you can give a hand for the mox migrate, I\u0027m glad with your help, (In fact, there is a refactor for mox to mock done by me but was abandoned: https://review.openstack.org/#/c/41615/)\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"7db19e3bb0035de44ef05f9c9450d1c83a3ea5e9","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 01:30:02.000000000","message":"Patch Set 3:\n\nI think the details you discuss belong in the blueprint, not in the comment for a patch.\n\nThe design of the code needs to be outlined in more detail in the blueprint. The additional detail also needs to be approved.\n\nThe code you offer does not conform to the blueprint in the spirit with which it was approved, in my opinion. If you can get approval for a blueprint with more detail for what work you actually want to do, I will consider changing my vote.","accounts_in_message":[],"_revision_number":3},{"id":"f7c975858029e8c34b9469127c057ed7092a0cc2","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 01:33:33.000000000","message":"Patch Set 3:\n\nYou mis-understand. I\u0027m not loving mock, but I do like to see work done in the manner of building a strong foundation for future work. In my opinion, changing code to work with python3.3 is work that needs to provide a strong example for code which is to follow it.","accounts_in_message":[],"_revision_number":3},{"id":"1aa77b21ccbb166cf33afd6105940e3a04d34cfa","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-27 01:53:18.000000000","message":"Patch Set 3:\n\n@Anita\n\nI\u0027m not familiar with the blueprint workflow, can you provide some detailed links for blueprint guide so I can learn from them?\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"b16c5a124d2b1b52743ed78edd7afd55dca50b1c","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-27 02:03:25.000000000","message":"Patch Set 3:\n\n@Anita\n\nI already said that we can use mox3 to let py33 and py27 unit test works, if some code using mox3 doesn\u0027t work as good as mox, then we can change it to mock, is this not strong enough?\n\nAll I want is a smooth change, and I already mentioned that this is a workaround, not a final solution, as the mox3 has no official support from Google team, just a release of OpenStack its own\n\nAfter try to enable py33 unittest in neutronclient, after several steps, the mox blocks me. If I can use mox3 as a workaround, other issue in source code instead of unit test code can be fixed firstly, I think that is urgent than migrate mox to mock\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"b1e35508bb4ed12c85657196cb944cd90dafc4c7","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2014-01-27 13:36:09.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nWe did decide in December [1] that new test cases should be implemented using mock, but moving to our fork of mox (mox3) as a short-term fix for existing test cases would result in less code churn and more progress. \n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2013-December/021148.html","accounts_in_message":[],"_revision_number":3},{"id":"2f596e5e05607f90aa3cc46e4ccc8a9fd90cc4d3","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 13:52:06.000000000","message":"Patch Set 3:\n\nIf we have decided that new test cases should be written using mock, shouldn\u0027t mock be included in test-requirements for python-neutronclient as part of supporting python3 compatibility?","accounts_in_message":[],"_revision_number":3},{"id":"7d43706cf86bacb7e49898586329f4d3b2ace6c3","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 13:53:37.000000000","message":"Patch Set 3:\n\nHere is a start for blueprint documentation: https://wiki.openstack.org/wiki/Blueprints","accounts_in_message":[],"_revision_number":3},{"id":"7e1c3611430fab08ea78cf36baf18b11a21527c6","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-27 13:56:54.000000000","message":"Patch Set 3:\n\n@Anita Kuno\n\nneutronclient has not used mock, the review link[1] I provided is a start point\n\n[1]: https://review.openstack.org/#/c/41615\n\nthanks","accounts_in_message":[],"_revision_number":3},{"id":"62421706f048e9f56dc0bd2e1eb2ac594c2dee45","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 13:59:08.000000000","message":"Patch Set 3:\n\nMy point is that mock should be included and be part of the blueprint.","accounts_in_message":[],"_revision_number":3},{"id":"3df4bf21ab422b583ae3e18b8d1b845280e9ff3a","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-01-27 14:00:24.000000000","message":"Patch Set 3:\n\nAnytime you want to discuss anything with a faster turn around than comments on a patch, do join #openstack-neutron and we can talk there. My nick is anteaya.","accounts_in_message":[],"_revision_number":3},{"id":"ce47e7bfa789988d839174dd0b1918465fad2bb0","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-02-04 06:03:15.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"c10a60f26629517a0e8ccd2a9d1431150956ee43","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-02-04 06:03:15.000000000","message":"Patch Set 3:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6b4da8506ab6a44e6049b433f2ed5fc4999319fa","revisions":{"0e57193f673331fff166881d33008f82d2d9fd02":{"kind":"REWORK","_number":1,"created":"2014-01-17 02:30:15.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/59/67359/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/59/67359/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/1"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"ZhiQiang Fan","email":"zhiqiang.fan@huawei.com","date":"2014-01-17 02:27:27.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"zhiqiang.fan@huawei.com","date":"2014-01-17 02:27:27.000000000","tz":480},"subject":"Use mox3 instead of mox","message":"Use mox3 instead of mox\n\nTo support python3.3, the mox should be switched to mox3.\n\nChange-Id: I94a8633d839946bd395ce4bc0f16e58a55fb0dba\nImplements: blueprint py33-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/0e57193f673331fff166881d33008f82d2d9fd02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/0e57193f673331fff166881d33008f82d2d9fd02"}]},"branch":"refs/heads/master"},"5547ae9dc1831daad202b27c16e8dd6a87304c5e":{"kind":"REWORK","_number":2,"created":"2014-01-26 13:30:39.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/59/67359/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/59/67359/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/2"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"ZhiQiang Fan","email":"zhiqiang.fan@huawei.com","date":"2014-01-17 02:27:27.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2014-01-26 13:23:58.000000000","tz":480},"subject":"Use mox3 instead of mox","message":"Use mox3 instead of mox\n\nTo support python3.3, the mox should be switched to mox3.\n\nChange-Id: I94a8633d839946bd395ce4bc0f16e58a55fb0dba\nImplements: blueprint py33-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/5547ae9dc1831daad202b27c16e8dd6a87304c5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/5547ae9dc1831daad202b27c16e8dd6a87304c5e"}]},"branch":"refs/heads/master"},"6b4da8506ab6a44e6049b433f2ed5fc4999319fa":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2014-01-26 14:26:20.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/59/67359/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/59/67359/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/59/67359/3"}}},"commit":{"parents":[{"commit":"8aacb125df8b1739f2225f62bc0172693c35d3f7","subject":"Merge \"Fix description of ListSubnet\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8aacb125df8b1739f2225f62bc0172693c35d3f7"}]}],"author":{"name":"ZhiQiang Fan","email":"zhiqiang.fan@huawei.com","date":"2014-01-17 02:27:27.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2014-01-26 14:17:11.000000000","tz":480},"subject":"Use mox3 instead of mox","message":"Use mox3 instead of mox\n\nmox doesn\u0027t have a release in over 3 years and it will not be ported\nto python 3, we should use mock or mox3 for python 3 compatibility. To\nsimplify the migrate work, this patch repalces mox with mox3.\n\nChange-Id: I94a8633d839946bd395ce4bc0f16e58a55fb0dba\nImplements: blueprint py33-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6b4da8506ab6a44e6049b433f2ed5fc4999319fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6b4da8506ab6a44e6049b433f2ed5fc4999319fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}