)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c00c857b7e6b5e2ca2ed16a4a812a7a721c9c32a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"$ neutron agent-list --field agent_type"},{"line_number":13,"context_line":"\u0027alive\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I59b313494605f64c5588324d1153614b1c11920f"},{"line_number":16,"context_line":"Closes-Bug: #1271948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F9WaE%3D","line":14,"updated":"2014-02-07 15:06:20.000000000","message":"Could you please elaborate how your fix helps fixing the issue in the commit message? It\u0027s not clear on first sight.","commit_id":"7ee3757a34513af7b734dd20ef3975c15cf0588d"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"b9764aada9bd451a94137e88eefb502ceed07101","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"$ neutron agent-list --field agent_type"},{"line_number":13,"context_line":"\u0027alive\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I59b313494605f64c5588324d1153614b1c11920f"},{"line_number":16,"context_line":"Closes-Bug: #1271948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUX%2F%2FPyc%3D","line":14,"in_reply_to":"AAAAUH%2F9WaE%3D","updated":"2014-02-14 15:09:29.000000000","message":"Done","commit_id":"7ee3757a34513af7b734dd20ef3975c15cf0588d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a77e058620d1a0bc591ca735ae843669c29f7503","unresolved":false,"context_lines":[{"line_number":12,"context_line":"$ neutron agent-list --field agent_type"},{"line_number":13,"context_line":"\u0027alive\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The problem is that the \u0027alive\u0027 field is not checked for instanciate"},{"line_number":16,"context_line":"before to check its value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I59b313494605f64c5588324d1153614b1c11920f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2FE9k%3D","line":15,"updated":"2014-02-17 09:24:19.000000000","message":"It was hard to me to understand where this \u0027alive\u0027 comes from, so I\u0027ve fired up a debugger and spent 5 mins tracing the program to realize this is a KeyError exception converted to unicode at shell.py:522 (run_subcommand) *without* traceback. Could you please mention this fact in your commit message so that it\u0027s more clear what was going on wrong?\n\nF.e.:\n\u0027alive\u0027 text shown on stdout is string representation of KeyError raised in ListAgent class and logged by catch-all exception handler.","commit_id":"cd44bad314ad8b8b0b8aa63989e188d509d56881"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"2f499af92ec64ec9d259eb3bf8cadafa63abda67","unresolved":false,"context_lines":[{"line_number":12,"context_line":"$ neutron agent-list --field agent_type"},{"line_number":13,"context_line":"\u0027alive\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The problem is that the \u0027alive\u0027 field is not checked for instanciate"},{"line_number":16,"context_line":"before to check its value."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I59b313494605f64c5588324d1153614b1c11920f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2BlWM%3D","line":15,"in_reply_to":"AAAAUX%2F%2FE9k%3D","updated":"2014-02-20 11:23:46.000000000","message":"Done","commit_id":"cd44bad314ad8b8b0b8aa63989e188d509d56881"}],"neutronclient/neutron/v2_0/agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31a379110e018a972b80dfa52a9677ebfa595efe","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":39,"context_line":"        for agent in data:"},{"line_number":40,"context_line":"            if agent.get(\u0027alive\u0027) is not None:"},{"line_number":41,"context_line":"                agent[\u0027alive\u0027] \u003d \":-)\" if agent[\u0027alive\u0027] else \u0027xxx\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FFWA%3D","line":40,"updated":"2014-02-17 08:42:28.000000000","message":"Consider:\n\n  if \u0027alive\u0027 in agent:","commit_id":"8e6cc5cfc5b1eeb2af6652473d9e422396cd4a72"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"3f8d60c0f8b8773f6b76e954f0bd9f440d92e300","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":39,"context_line":"        for agent in data:"},{"line_number":40,"context_line":"            if agent.get(\u0027alive\u0027) is not None:"},{"line_number":41,"context_line":"                agent[\u0027alive\u0027] \u003d \":-)\" if agent[\u0027alive\u0027] else \u0027xxx\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FFKY%3D","line":40,"in_reply_to":"AAAAUX%2F%2FFWA%3D","updated":"2014-02-17 08:59:36.000000000","message":"Done","commit_id":"8e6cc5cfc5b1eeb2af6652473d9e422396cd4a72"}]}