)]}'
{"neutronclient/v2_0/client.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"6bade44c7c08c331ef340ccf5ddf4020bb791472","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        return self.get(self.metering_label_rule_path %"},{"line_number":1115,"context_line":"                        (metering_label_rule), params\u003d_params)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def __init__(self, retries\u003d3, retry_interval\u003d1, **kwargs):"},{"line_number":1118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":1119,"context_line":"        super(Client, self).__init__()"},{"line_number":1120,"context_line":"        self.httpclient \u003d client.HTTPClient(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9cew%3D","line":1117,"updated":"2014-02-06 21:23:14.000000000","message":"Why changing  of retries to 3?\nIMO that may hide some real problem when running the tests. I\u0027d prefer to leave it \u003d1 and probably change neutronclient consumers to be configurable with neutronclient retries.","commit_id":"d55b622ec10a89b480afdb9b3dda92709edbaa25"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"788187ae47b685faf7c9c8cad34f67fc14523e6b","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        return self.get(self.metering_label_rule_path %"},{"line_number":1115,"context_line":"                        (metering_label_rule), params\u003d_params)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def __init__(self, retries\u003d3, retry_interval\u003d1, **kwargs):"},{"line_number":1118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":1119,"context_line":"        super(Client, self).__init__()"},{"line_number":1120,"context_line":"        self.httpclient \u003d client.HTTPClient(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F%2F0U%3D","line":1117,"in_reply_to":"AAAAUH%2F9ZYQ%3D","updated":"2014-02-07 21:00:41.000000000","message":"that\u0027s why I\u0027d prefer to pass # of retries from the consumer configuration. Make it 3 for production conf on consumer side (say, in nova).\n\nOn the other hand, can you provide an example, when increased retry count actually helps? All I can think of is the case when neutron server is overloaded, but then even 3 retries will not make a big difference.","commit_id":"d55b622ec10a89b480afdb9b3dda92709edbaa25"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"0c202ec866442d6085c9c70e205b3e5d520ee30c","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        return self.get(self.metering_label_rule_path %"},{"line_number":1115,"context_line":"                        (metering_label_rule), params\u003d_params)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def __init__(self, retries\u003d3, retry_interval\u003d1, **kwargs):"},{"line_number":1118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":1119,"context_line":"        super(Client, self).__init__()"},{"line_number":1120,"context_line":"        self.httpclient \u003d client.HTTPClient(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9ZYQ%3D","line":1117,"in_reply_to":"AAAAUH%2F9cew%3D","updated":"2014-02-07 07:25:59.000000000","message":"May be, but it makes the production usage more reliable.","commit_id":"d55b622ec10a89b480afdb9b3dda92709edbaa25"},{"author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"change_message_id":"b7108a4e2d370a2de415c74e1a2dce63ce6ff7d6","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        return self.get(self.metering_label_rule_path %"},{"line_number":1115,"context_line":"                        (metering_label_rule), params\u003d_params)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def __init__(self, retries\u003d3, retry_interval\u003d1, **kwargs):"},{"line_number":1118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":1119,"context_line":"        super(Client, self).__init__()"},{"line_number":1120,"context_line":"        self.httpclient \u003d client.HTTPClient(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F9Xdw%3D","line":1117,"in_reply_to":"AAAAUH%2F9cew%3D","updated":"2014-02-07 12:21:53.000000000","message":"So optimize for tests and real consumers have to specify explicitly instead of having sane default? What about having production-sane default and changing to 1 in tests?","commit_id":"d55b622ec10a89b480afdb9b3dda92709edbaa25"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"948cbc0b55cfb28581eb326dbf9f99401b1bcd37","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":138,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":139,"context_line":"    :param integer retries: Number of connection attempts. Default: 3"},{"line_number":140,"context_line":"    :param float retry_interval: Number of seconds beetween connection"},{"line_number":141,"context_line":"        attempts. Default: 1"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    Example::"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FwF0%3D","line":140,"updated":"2014-04-17 17:57:01.000000000","message":"beetween \u003d\u003e between","commit_id":"1a1836a988f8dfa2278d8caf42f82662e4f504fb"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b0ec6c19dd294427523d0827add0c367120923d0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            http requests. (optional)"},{"line_number":129,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":130,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":131,"context_line":"    :param integer retries: Number of connection attempts. Default: 3"},{"line_number":132,"context_line":"    :param float retry_interval: Number of seconds between connection"},{"line_number":133,"context_line":"        attempts. Default: 1"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_b490b4ed","line":131,"updated":"2014-05-27 21:46:49.000000000","message":"Actually, this is the number of retries, not the number of connection attempts which is retries + 1.  Since the client reports connection attempts below on L1309, maybe you should rename this to --connection-attempts with a default of 4?","commit_id":"66fecbf1708266377f39a85fbf89fc4c28fc2191"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cef65c4df136350d0759d47b8752ff09bad9098d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            http requests. (optional)"},{"line_number":129,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":130,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":131,"context_line":"    :param integer retries: Number of connection attempts. Default: 3"},{"line_number":132,"context_line":"    :param float retry_interval: Number of seconds between connection"},{"line_number":133,"context_line":"        attempts. Default: 1"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_55412a38","line":131,"in_reply_to":"3ae8d1ca_6f10194f","updated":"2014-05-27 22:47:35.000000000","message":"I\u0027ll go either way.  If the comment is changed then this parameter description should be changed as well.  Just as long as it is consistent.","commit_id":"66fecbf1708266377f39a85fbf89fc4c28fc2191"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ffbe5bca12ab781b3d138e6ce52af1417c6915b2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            http requests. (optional)"},{"line_number":129,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":130,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":131,"context_line":"    :param integer retries: Number of connection attempts. Default: 3"},{"line_number":132,"context_line":"    :param float retry_interval: Number of seconds between connection"},{"line_number":133,"context_line":"        attempts. Default: 1"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_6f10194f","line":131,"in_reply_to":"3ae8d1ca_b490b4ed","updated":"2014-05-27 21:50:55.000000000","message":"I\u0027d argue that comment should be changed, not the parameter or its semantics.\n\nAlso, there\u0027s another patch on gerrit that uses \u0027retries\u0027","commit_id":"66fecbf1708266377f39a85fbf89fc4c28fc2191"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dd6fa00f9cb52aace6ea6beb9473907ce8d48340","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"        \"\"\"Delete the specified packet filter.\"\"\""},{"line_number":1190,"context_line":"        return self.delete(self.packet_filter_path % packet_filter_id)"},{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"    def __init__(self, retries\u003d3, retry_interval\u003d1, **kwargs):"},{"line_number":1193,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":1194,"context_line":"        super(Client, self).__init__()"},{"line_number":1195,"context_line":"        self.httpclient \u003d client.HTTPClient(**kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_07478c1e","line":1192,"updated":"2014-06-07 13:28:25.000000000","message":"imho the default values should not be modified.","commit_id":"66fecbf1708266377f39a85fbf89fc4c28fc2191"}]}