)]}'
{"neutronclient/tests/functional/core/test_cli_formatter.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"724c24515ada8d5e5acd0920485af1367e80a456","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        result \u003d self._create_net(\u0027yaml\u0027, [\u0027name\u0027, \u0027admin_state_up\u0027])"},{"line_number":44,"context_line":"        self.assertDictEqual({\u0027name\u0027: self.net_name,"},{"line_number":45,"context_line":"                              \u0027admin_state_up\u0027: True},"},{"line_number":46,"context_line":"                             yaml.load(result, Loader\u003dyaml.FullLoader))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_net_create_with_value_formatter(self):"},{"line_number":49,"context_line":"        # NOTE(amotoki): In \u0027value\u0027 formatter, there is no guarantee"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e4d89be_aa96815b","line":46,"updated":"2021-09-01 08:08:48.000000000","message":"Why not using the safe loader? I think yaml.safe_load() is enough here.\nAt least I don\u0027t see the reason we need to use FullLoader (i.e. yaml.full_load).","commit_id":"ab2fe000c13475e3366515dc428f523deb119351"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"120eb4586921f1913445b987372cedd094267232","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        result \u003d self._create_net(\u0027yaml\u0027, [\u0027name\u0027, \u0027admin_state_up\u0027])"},{"line_number":44,"context_line":"        self.assertDictEqual({\u0027name\u0027: self.net_name,"},{"line_number":45,"context_line":"                              \u0027admin_state_up\u0027: True},"},{"line_number":46,"context_line":"                             yaml.load(result, Loader\u003dyaml.FullLoader))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_net_create_with_value_formatter(self):"},{"line_number":49,"context_line":"        # NOTE(amotoki): In \u0027value\u0027 formatter, there is no guarantee"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ede0d68_e7efdb57","line":46,"in_reply_to":"1e4d89be_aa96815b","updated":"2021-09-01 08:55:23.000000000","message":"I selected FullLoader as a \"safe-side\" option which would block the least usage, but as is pointed out, safe_load would be enough here as long as we expect very usual json.\nI\u0027ve updated the change to use safe_load.","commit_id":"ab2fe000c13475e3366515dc428f523deb119351"}]}