)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"55140f158aff49cd6c72f90802ad053585fcd421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ee53b2e_59fefb14","updated":"2022-04-13 14:42:34.000000000","message":"recheck","commit_id":"d71a8d8891f82a9722b42215260bda9c4620c52f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cf9359f6248a12456b67b3024c99185a258fea2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc514d74_d1a01ff5","updated":"2022-07-13 13:38:49.000000000","message":"I will ask the same as in the OSC patch: what happens when we update a PF with a port range that had before a single port?\n\nWhy don\u0027t you check the port ranges as in the OSC patch? IMO, what you did in [1] was what we should expect here too.\n\n[1]https://review.opendev.org/c/openstack/python-openstackclient/+/836870/2/openstackclient/network/v2/floating_ip_port_forwarding.py","commit_id":"4d27939022a9fde38f5147595dfaaddf76fadbc6"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"56feea1df77ce3468dbb01434ac547cb2edafab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f42c335e_a7fe859f","in_reply_to":"cc514d74_d1a01ff5","updated":"2022-07-13 21:48:44.000000000","message":"Sure, I added the validations, thx 😊","commit_id":"4d27939022a9fde38f5147595dfaaddf76fadbc6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"af031bab389bfd581106fa9d8cc7726b4c84c5c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74a6a48c_40f9284d","updated":"2022-07-14 14:31:36.000000000","message":"neutron cLI is deprecated, please do not propose new code to it (see [1]), only the client code can be accepted \n\n[1]: https://docs.openstack.org/releasenotes/python-neutronclient/xena.html","commit_id":"2f2a13e5cf43bf0eb202c753688dcd918aa7b269"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3f12715747e60784b36dc75852f4a7bc38fc4394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70d3df9e_68742a63","in_reply_to":"2ba9a7ba_67860cf7","updated":"2022-07-15 09:44:01.000000000","message":"that is sadly true, but as in previous patches you can just push the client code and a releasenote (i.e.: https://review.opendev.org/c/openstack/python-neutronclient/+/812132 )","commit_id":"2f2a13e5cf43bf0eb202c753688dcd918aa7b269"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"4aafe3012cbb77b7278aa13763355f1b6a91f927","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2ba9a7ba_67860cf7","in_reply_to":"74a6a48c_40f9284d","updated":"2022-07-14 15:40:48.000000000","message":"No problem, in deed, what I will need in Horizon, are the changes in the \u0027neutronclient/v2_0/client.py\u0027. But I do not know any other way to create tests to it but using the \u0027command line\u0027 framework to create unit tests.","commit_id":"2f2a13e5cf43bf0eb202c753688dcd918aa7b269"}],"neutronclient/tests/unit/test_cli20_floatingip_portforwardings.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cf9359f6248a12456b67b3024c99185a258fea2e","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CLITestV20FloatingIpPortForwardingsJSON(test_cli20.CLITestV20Base):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    non_admin_status_resources \u003d [\u0027port_forwarding\u0027]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a6cdb1e4_4511cfba","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":45},"updated":"2022-07-13 13:38:49.000000000","message":"nit, just a comment: I was going to say that each implemented class should have its own testing class. But I see this is not the case in neutron testing, so let\u0027s skip that.","commit_id":"4d27939022a9fde38f5147595dfaaddf76fadbc6"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3f12715747e60784b36dc75852f4a7bc38fc4394","unresolved":true,"context_lines":[{"line_number":1041,"context_line":"        return self.delete(self.port_forwarding_path % (floatingip,"},{"line_number":1042,"context_line":"                                                        portforwarding))"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def update_port_forwarding(self, portforwarding, floatingip, body\u003dNone):"},{"line_number":1045,"context_line":"        \"\"\"Updates a portforwarding.\"\"\""},{"line_number":1046,"context_line":"        return self.put(self.port_forwarding_path % (floatingip,"},{"line_number":1047,"context_line":"                                                     portforwarding),"}],"source_content_type":"text/x-python","patch_set":4,"id":"d4c1672b_46c70c64","line":1044,"range":{"start_line":1044,"start_character":37,"end_line":1044,"end_character":63},"updated":"2022-07-15 09:44:01.000000000","message":"nit: I like better the method with floatingip, portforwarding signature, as we add port forwarding to a FIP, and that sounds like first param.","commit_id":"ccf714d1c4a832d9e2a843575303dbf42e9ae886"},{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"a8cb94ec62f270dbed324dfbd2840eb3dd77c554","unresolved":true,"context_lines":[{"line_number":1041,"context_line":"        return self.delete(self.port_forwarding_path % (floatingip,"},{"line_number":1042,"context_line":"                                                        portforwarding))"},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    def update_port_forwarding(self, portforwarding, floatingip, body\u003dNone):"},{"line_number":1045,"context_line":"        \"\"\"Updates a portforwarding.\"\"\""},{"line_number":1046,"context_line":"        return self.put(self.port_forwarding_path % (floatingip,"},{"line_number":1047,"context_line":"                                                     portforwarding),"}],"source_content_type":"text/x-python","patch_set":4,"id":"6c90dcce_e1aa7121","line":1044,"range":{"start_line":1044,"start_character":37,"end_line":1044,"end_character":63},"in_reply_to":"d4c1672b_46c70c64","updated":"2022-07-15 13:18:48.000000000","message":"yes, it seems better that way, I will change it, thanks.","commit_id":"ccf714d1c4a832d9e2a843575303dbf42e9ae886"}]}