)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c2cd3e55c1c076466975d53e101e7115260393d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option for retry number of connection attempts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds option -r or --retries to specify how many times should"},{"line_number":10,"context_line":"client attempt connecting to Neutron server. Also gives more"},{"line_number":11,"context_line":"user-friendly message when it\u0027s impossible to connect to Neutron server."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1ae5cdf2_ab2a9a8e","line":9,"updated":"2014-06-26 15:43:46.000000000","message":"I think there has been some confusion about what this patch attempts to do.  Please make it clear in the commit message and the parameter documentation that only idempotent (GET, PUT, DELETE) REST operations will be retried when a non-zero value is specified for the \u0027retries\u0027 parameter.","commit_id":"f1e8c686456eb9f6ab004333b475489149f0473b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d16c28af279e49e47c97bc5e9a4d643dac91ec2d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"},{"line_number":13,"context_line":"not CLI)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1312225"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id74d7cf9a0e8c5d2cd3ee4851c883d5286bea19d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1ae5cdf2_1832d95d","line":14,"updated":"2014-06-27 14:52:29.000000000","message":"Doc Impact? (Not sure how this works for clients)","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"},{"line_number":13,"context_line":"not CLI)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1312225"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id74d7cf9a0e8c5d2cd3ee4851c883d5286bea19d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"baada198_673bfceb","line":14,"in_reply_to":"1ae5cdf2_1832d95d","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"8fafb47757e121f7883789978ea45bd74c9dcd6d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option for retry number of connection attempts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds option -r or --retries to specify how many times should"},{"line_number":10,"context_line":"client attempt connecting to Neutron server when using GET, PUT or"},{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baada198_19e880b3","line":9,"updated":"2014-07-10 18:26:50.000000000","message":"adds option -r or --retries -\u003e adds a new option (-r | --retries)\n\nshould client attempt connecting to -\u003e the client should attempt to connect to the\n\nusing GET, PUT or DELETE methods. -\u003e using idempotent methods (GET, PUT and DELETE).","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ddb7b0e28418fc0058f0affe73525d47ec06b1cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option for retry number of connection attempts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds option -r or --retries to specify how many times should"},{"line_number":10,"context_line":"client attempt connecting to Neutron server when using GET, PUT or"},{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baada198_cea2a7fb","line":9,"in_reply_to":"baada198_19e880b3","updated":"2014-07-11 08:23:34.000000000","message":"Done","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"8fafb47757e121f7883789978ea45bd74c9dcd6d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds option -r or --retries to specify how many times should"},{"line_number":10,"context_line":"client attempt connecting to Neutron server when using GET, PUT or"},{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"},{"line_number":13,"context_line":"not CLI)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baada198_f963cc3e","line":12,"updated":"2014-07-10 18:26:50.000000000","message":"Also gives more -\u003e This patch also provides a more \n\nprovides error to caller (when not CLI) -\u003e ensures that connection-related exceptions are raised to the caller by default when neutronclient is used as a library.","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ddb7b0e28418fc0058f0affe73525d47ec06b1cb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds option -r or --retries to specify how many times should"},{"line_number":10,"context_line":"client attempt connecting to Neutron server when using GET, PUT or"},{"line_number":11,"context_line":"DELETE methods. Also gives more user-friendly message when it\u0027s impossible"},{"line_number":12,"context_line":"to connect to Neutron server from CLI and provides error to caller (when"},{"line_number":13,"context_line":"not CLI)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baada198_eea76b09","line":12,"in_reply_to":"baada198_f963cc3e","updated":"2014-07-11 08:23:34.000000000","message":"Done","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"}],"neutronclient/common/clientmanager.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2923e1cc497355a1d44134a5138d4a990b5512d6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ca_cert\u003dNone,"},{"line_number":65,"context_line":"                 log_credentials\u003dFalse,"},{"line_number":66,"context_line":"                 service_type\u003dNone,"},{"line_number":67,"context_line":"                 retries\u003dNone,"},{"line_number":68,"context_line":"                 ):"},{"line_number":69,"context_line":"        self._token \u003d token"},{"line_number":70,"context_line":"        self._url \u003d url"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_8981e591","line":67,"updated":"2014-05-27 21:00:36.000000000","message":"why None and not 0?","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"aa6cfca06e45ac1f1a8237d960ee5852f180412d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ca_cert\u003dNone,"},{"line_number":65,"context_line":"                 log_credentials\u003dFalse,"},{"line_number":66,"context_line":"                 service_type\u003dNone,"},{"line_number":67,"context_line":"                 retries\u003dNone,"},{"line_number":68,"context_line":"                 ):"},{"line_number":69,"context_line":"        self._token \u003d token"},{"line_number":70,"context_line":"        self._url \u003d url"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_c7791195","line":67,"in_reply_to":"3ae8d1ca_8981e591","updated":"2014-05-27 23:28:23.000000000","message":"+1.  Prefer 0 since the argument is strictly on integer.","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"887997cfb840d176c611e2c35495a2f4147a9541","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 ca_cert\u003dNone,"},{"line_number":65,"context_line":"                 log_credentials\u003dFalse,"},{"line_number":66,"context_line":"                 service_type\u003dNone,"},{"line_number":67,"context_line":"                 retries\u003dNone,"},{"line_number":68,"context_line":"                 ):"},{"line_number":69,"context_line":"        self._token \u003d token"},{"line_number":70,"context_line":"        self._url \u003d url"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_e65284dc","line":67,"in_reply_to":"3ae8d1ca_c7791195","updated":"2014-05-28 11:49:26.000000000","message":"Done","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"}],"neutronclient/shell.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b0cf518a819d2599d391c3acad52098785cc3e98","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry connecting to \""},{"line_number":377,"context_line":"                   \"neutron server after failed attempt.\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_9b1760ed","line":376,"updated":"2014-05-28 02:33:19.000000000","message":"I think this help string is a little misleading. I would say to retry the Operation as using this option is not idempotent. Honestly I think it might be better to remove the retry logic from the client all together since using this will require one to garbage collect some how.","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"887997cfb840d176c611e2c35495a2f4147a9541","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry connecting to \""},{"line_number":377,"context_line":"                   \"neutron server after failed attempt.\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_4ce9997f","line":376,"in_reply_to":"3ae8d1ca_9b1760ed","updated":"2014-05-28 11:49:26.000000000","message":"I don\u0027t understand what you mean by garbage collecting. What do you want to remove?\nRetry happens only when connection fails and I think no objects are left in memory.","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"edb71f57dc3dc43220b0bf1c8c6bc8c824d533f6","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_4d0b2525","line":371,"updated":"2014-05-29 12:47:29.000000000","message":"I don\u0027t know what\u0027s our policy on validating arguments... but what if retries value is negative?","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b7c89eac3c8ce351d25f6ea3409bacd4223eb92f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_629b0218","line":371,"in_reply_to":"1ae5cdf2_0ddb617c","updated":"2014-06-06 07:58:13.000000000","message":"I consider this correct behavior, if user provides negative value then he can\u0027t expect response(e.g. neutron -r -1 net-list). What would be the correct step in your opinion?","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0331c1101feeab6080b1077881d035db3282f78d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_cd48872f","line":371,"in_reply_to":"1ae5cdf2_629b0218","updated":"2014-06-06 08:08:21.000000000","message":"Validating input before proceeding with request?","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"00eebdaa591c2cafd0a6bf77d32f1989720232ba","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_cdcb2770","line":371,"in_reply_to":"1ae5cdf2_cd48872f","updated":"2014-06-06 08:13:46.000000000","message":"That leads to not connecting to neutron-server and error message too.","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"63bf6e4c586d8a9ca542f6b5ec3169d3f18c9e5e","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_1107e182","line":371,"in_reply_to":"1ae5cdf2_cdcb2770","updated":"2014-06-06 12:27:38.000000000","message":"Done","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3b0589ea91dbf24d23a581fad43d33df476cafc0","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_add90985","line":371,"in_reply_to":"3ae8d1ca_4d0b2525","updated":"2014-05-29 12:53:06.000000000","message":"I guess it won\u0027t try to connect and print \"Failed to connect -(value) times\".","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8676dfbe837b5f7ce73501827fe0f06bf3d692cb","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            nargs\u003d0,"},{"line_number":369,"context_line":"            default\u003dself,  # tricky"},{"line_number":370,"context_line":"            help\u003d_(\"Show this help message and exit\"))"},{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027-r\u0027, \u0027--retries\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"NUM\","},{"line_number":374,"context_line":"            type\u003dint,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_0ddb617c","line":371,"in_reply_to":"3ae8d1ca_add90985","updated":"2014-06-05 17:57:17.000000000","message":"The behavior seems odd to me. Users expect neutronclient talks to neutron-server at least once. A failure without attempt seems confusing.","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8676dfbe837b5f7ce73501827fe0f06bf3d692cb","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":377,"context_line":"                   \"to Neutron server\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_ad40ad07","line":377,"updated":"2014-06-05 17:57:17.000000000","message":"Please end a comment with a period. The patch from Andreas which is approved and under the gate makes all comments end with a colon.","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92cb6478318643f4e5dcaf94a1e03650a06fed87","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":377,"context_line":"                   \"to Neutron server\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e8045119","line":377,"in_reply_to":"1ae5cdf2_02579e26","updated":"2014-06-06 09:00:17.000000000","message":"I don\u0027t know whether Akihiro really meant we should connect even if argument is invalid. [I guess not.]\n\nMy point is that arguments should be properly validated on input. Once proper validation is done, we may use them safely in other places.\n\nIn your particular case, yes, nothing will probably break (even though odd message will be shown). But I wouldn\u0027t guarantee that another developer three months from now will add another feature relying on that argument value and assuming it has a sane value, and in case of insane value, his feature will behave badly or expose some security flaw or blow the world. :)\n\nSo I think it\u0027s better to be validate arguments on the boundary of interaction with outside world and feel safe.","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"63bf6e4c586d8a9ca542f6b5ec3169d3f18c9e5e","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":377,"context_line":"                   \"to Neutron server\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_310a1d8a","line":377,"in_reply_to":"1ae5cdf2_53533616","updated":"2014-06-06 12:27:38.000000000","message":"Done","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b7c89eac3c8ce351d25f6ea3409bacd4223eb92f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":377,"context_line":"                   \"to Neutron server\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_02579e26","line":377,"in_reply_to":"1ae5cdf2_ad40ad07","updated":"2014-06-06 07:58:13.000000000","message":"Will do, thanks. If you mean H404 then I think this doesn\u0027t belong to that.","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"55d7873b48b058810726f40dc1ad65cef934fc06","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            type\u003dint,"},{"line_number":375,"context_line":"            default\u003d0,"},{"line_number":376,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":377,"context_line":"                   \"to Neutron server\"))"},{"line_number":378,"context_line":"        # Global arguments"},{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_53533616","line":377,"in_reply_to":"1ae5cdf2_e8045119","updated":"2014-06-06 09:00:51.000000000","message":"Sorry, this belongs to above. :|","commit_id":"99096f40777a5f659e89559ae28f91f98cd894d3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    return kwargs.get(\u0027default\u0027, \u0027\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def check_positive_int(value):"},{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        value \u003d int(value)"},{"line_number":103,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_d8d07155","line":100,"updated":"2014-06-27 14:51:03.000000000","message":"Pedantic nit picking: a more correct name would be \u0027check_non_negative_int\u0027","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"34ae600ba1ab81c90af4f662bb32aced0f03f3bd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    return kwargs.get(\u0027default\u0027, \u0027\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def check_positive_int(value):"},{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        value \u003d int(value)"},{"line_number":103,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab895d6_ae940b45","line":100,"in_reply_to":"1ae5cdf2_d8d07155","updated":"2014-06-29 15:08:38.000000000","message":"Not so pedantic to someone who codes using this assuming a correct name....","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    return kwargs.get(\u0027default\u0027, \u0027\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def check_positive_int(value):"},{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        value \u003d int(value)"},{"line_number":103,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_1248bc5a","line":100,"in_reply_to":"dab895d6_ae940b45","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            type\u003dcheck_positive_int,"},{"line_number":386,"context_line":"            default\u003d0,"},{"line_number":387,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":388,"context_line":"                   \"to Neutron server.\"))"},{"line_number":389,"context_line":"        # Global arguments"},{"line_number":390,"context_line":"        parser.add_argument("},{"line_number":391,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_d82cf14c","line":388,"updated":"2014-06-27 14:51:03.000000000","message":"Grammar: \"How many times the request to the Neutron server should be retried if it fails.\"","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            type\u003dcheck_positive_int,"},{"line_number":386,"context_line":"            default\u003d0,"},{"line_number":387,"context_line":"            help\u003d_(\"How many times should neutron client retry operation sent \""},{"line_number":388,"context_line":"                   \"to Neutron server.\"))"},{"line_number":389,"context_line":"        # Global arguments"},{"line_number":390,"context_line":"        parser.add_argument("},{"line_number":391,"context_line":"            \u0027--os-auth-strategy\u0027, metavar\u003d\u0027\u003cauth-strategy\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_b2dc7076","line":388,"in_reply_to":"1ae5cdf2_d82cf14c","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"6b2405a659a58351c5f1bc42c7831c780fd5c000","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"                    time.sleep(self.retry_interval)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        if self.retries:"},{"line_number":1308,"context_line":"            msg \u003d (_(\"All of %d attempts to connect to Neutron server failed\")"},{"line_number":1309,"context_line":"                   % max_attempts)"},{"line_number":1310,"context_line":"        else:"},{"line_number":1311,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_bf8336cb","line":1308,"updated":"2014-05-27 18:26:05.000000000","message":"Nit: This wording is a bit wonky. How about this:\n\n\"Failed to connect %d times to Neutron server\"","commit_id":"8ddc88f21e79c5ea26d07bb28e67c1c12b110f65"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6f7d30916251e0d946f74da2e5c3e171c8df3324","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"                    time.sleep(self.retry_interval)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        if self.retries:"},{"line_number":1308,"context_line":"            msg \u003d (_(\"All of %d attempts to connect to Neutron server failed\")"},{"line_number":1309,"context_line":"                   % max_attempts)"},{"line_number":1310,"context_line":"        else:"},{"line_number":1311,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ae8d1ca_0384d4d2","line":1308,"in_reply_to":"3ae8d1ca_bf8336cb","updated":"2014-05-27 19:52:11.000000000","message":"Oh my English. Thanks for correction.","commit_id":"8ddc88f21e79c5ea26d07bb28e67c1c12b110f65"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"aa6cfca06e45ac1f1a8237d960ee5852f180412d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                            instantiation.(optional)"},{"line_number":128,"context_line":"    :param integer timeout: Allows customization of the timeout for client"},{"line_number":129,"context_line":"                            http requests. (optional)"},{"line_number":130,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Example::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_c7a671c1","line":130,"updated":"2014-05-27 23:28:23.000000000","message":"Please document the retries option.","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"887997cfb840d176c611e2c35495a2f4147a9541","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                            instantiation.(optional)"},{"line_number":128,"context_line":"    :param integer timeout: Allows customization of the timeout for client"},{"line_number":129,"context_line":"                            http requests. (optional)"},{"line_number":130,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Example::"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ae8d1ca_12e323da","line":130,"in_reply_to":"3ae8d1ca_c7a671c1","updated":"2014-05-28 11:49:26.000000000","message":"Done","commit_id":"60686b9b2746f1ec9ac133cf605d36e71d3686ea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c2cd3e55c1c076466975d53e101e7115260393d1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            http requests. (optional)"},{"line_number":130,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":"    :param integer retries: How many times should neutron client retry"},{"line_number":133,"context_line":"                            operation sent to Neutron server (optional)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    Example::"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_eb7822fa","line":132,"updated":"2014-06-26 15:43:46.000000000","message":"Please make it clear that only idempotent operations will be retried.","commit_id":"f1e8c686456eb9f6ab004333b475489149f0473b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":"    :param integer retries: How many times should neutron client retry"},{"line_number":133,"context_line":"                            idempotent (GET, PUT, DELETE) operations sent to"},{"line_number":134,"context_line":"                            Neutron server (optional)"},{"line_number":135,"context_line":"    :param bool raise_errors: If it\u0027s set to True then exceptions caused by"},{"line_number":136,"context_line":"                              connection failure are propagated to the"},{"line_number":137,"context_line":"                              caller. (optional)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_b8e805e0","line":134,"updated":"2014-06-27 14:51:03.000000000","message":"Grammar: \"How many times idempotent (GET, PUT, DELETE) requests to Neutron server should be retried if they fail (optional).\"","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":"    :param integer retries: How many times should neutron client retry"},{"line_number":133,"context_line":"                            idempotent (GET, PUT, DELETE) operations sent to"},{"line_number":134,"context_line":"                            Neutron server (optional)"},{"line_number":135,"context_line":"    :param bool raise_errors: If it\u0027s set to True then exceptions caused by"},{"line_number":136,"context_line":"                              connection failure are propagated to the"},{"line_number":137,"context_line":"                              caller. (optional)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_1200bca9","line":134,"in_reply_to":"1ae5cdf2_b8e805e0","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    :param integer retries: How many times should neutron client retry"},{"line_number":133,"context_line":"                            idempotent (GET, PUT, DELETE) operations sent to"},{"line_number":134,"context_line":"                            Neutron server (optional)"},{"line_number":135,"context_line":"    :param bool raise_errors: If it\u0027s set to True then exceptions caused by"},{"line_number":136,"context_line":"                              connection failure are propagated to the"},{"line_number":137,"context_line":"                              caller. (optional)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_187f3918","line":135,"updated":"2014-06-27 14:51:03.000000000","message":"Nit\" \"If True then exceptions...\"","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    :param integer retries: How many times should neutron client retry"},{"line_number":133,"context_line":"                            idempotent (GET, PUT, DELETE) operations sent to"},{"line_number":134,"context_line":"                            Neutron server (optional)"},{"line_number":135,"context_line":"    :param bool raise_errors: If it\u0027s set to True then exceptions caused by"},{"line_number":136,"context_line":"                              connection failure are propagated to the"},{"line_number":137,"context_line":"                              caller. (optional)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_322ce04a","line":135,"in_reply_to":"1ae5cdf2_187f3918","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"                    raise"},{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"        if self.retries:"},{"line_number":1317,"context_line":"            msg \u003d (_(\"Failed to connect %d times to Neutron server\")"},{"line_number":1318,"context_line":"                   % max_attempts)"},{"line_number":1319,"context_line":"        else:"},{"line_number":1320,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_f8928d49","line":1317,"updated":"2014-06-27 14:51:03.000000000","message":"Grammar: \"Failed to connect to Neutron server after %d attempts\"","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"                    raise"},{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"        if self.retries:"},{"line_number":1317,"context_line":"            msg \u003d (_(\"Failed to connect %d times to Neutron server\")"},{"line_number":1318,"context_line":"                   % max_attempts)"},{"line_number":1319,"context_line":"        else:"},{"line_number":1320,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_f2198823","line":1317,"in_reply_to":"1ae5cdf2_f8928d49","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afb4f40e13b364a6add6fd36d4c295eebfff5038","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"            msg \u003d (_(\"Failed to connect %d times to Neutron server\")"},{"line_number":1318,"context_line":"                   % max_attempts)"},{"line_number":1319,"context_line":"        else:"},{"line_number":1320,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        raise exceptions.ConnectionFailed(reason\u003dmsg)"},{"line_number":1323,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_789e7d55","line":1320,"updated":"2014-06-27 14:51:03.000000000","message":"Grammar: \"Failed to connect to Neutron server\"","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c2b60e9f5dbe838092eadac11737111971cd4802","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"            msg \u003d (_(\"Failed to connect %d times to Neutron server\")"},{"line_number":1318,"context_line":"                   % max_attempts)"},{"line_number":1319,"context_line":"        else:"},{"line_number":1320,"context_line":"            msg \u003d _(\"Cannot connect to Neutron server\")"},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"        raise exceptions.ConnectionFailed(reason\u003dmsg)"},{"line_number":1323,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_1217dcee","line":1320,"in_reply_to":"1ae5cdf2_789e7d55","updated":"2014-06-30 16:46:28.000000000","message":"Done","commit_id":"82823883f2e62bd97dfea3cca0fe9dd260cbada7"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"8fafb47757e121f7883789978ea45bd74c9dcd6d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            http requests. (optional)"},{"line_number":130,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":"    :param integer retries: How many times idempotent (GET, PUT, DELETE)"},{"line_number":133,"context_line":"                            requests to Neutron server should be retried if"},{"line_number":134,"context_line":"                            they fail (optional)."},{"line_number":135,"context_line":"    :param bool raise_errors: If True then exceptions caused by connection"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_1927a065","line":132,"updated":"2014-07-10 18:26:50.000000000","message":"(Suggestion only) Would it make sense to document the default for each of these new parameters?  No is an acceptable answer, given that none of the existing optional parameters are documented in this way, but maybe you want to deviate from the (bad) norm.","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ddb7b0e28418fc0058f0affe73525d47ec06b1cb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            http requests. (optional)"},{"line_number":130,"context_line":"    :param bool insecure: SSL certificate validation. (optional)"},{"line_number":131,"context_line":"    :param string ca_cert: SSL CA bundle file to use. (optional)"},{"line_number":132,"context_line":"    :param integer retries: How many times idempotent (GET, PUT, DELETE)"},{"line_number":133,"context_line":"                            requests to Neutron server should be retried if"},{"line_number":134,"context_line":"                            they fail (optional)."},{"line_number":135,"context_line":"    :param bool raise_errors: If True then exceptions caused by connection"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_cb09b985","line":132,"in_reply_to":"baada198_1927a065","updated":"2014-07-11 08:23:34.000000000","message":"I\u0027m always inclined to improvement.","commit_id":"6b78b33616ca03089dc5c1db73033da675bca474"}]}