)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c84606e5a0693fce1cf9ec77a91772c82f49675d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c97b4c2c_ef86da28","updated":"2024-03-15 19:08:39.000000000","message":"Adding Lajos as he made the sdk changes related to this.","commit_id":"74bf9c7aa1fe53f7d293aa24dd285da9872eadb6"},{"author":{"_account_id":31823,"name":"Benjamin Reichel","email":"b.reichel@syseleven.de","username":"benj200"},"change_message_id":"faab005492f814163befc2a5b453e722080ec8fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60fae72a_0ac2fc2b","updated":"2024-04-12 11:10:39.000000000","message":"Thanks for the reviews","commit_id":"2169b2bbab1b09c320d4eeeb2b341c99b4c3ef87"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a82c1a9d3fcca5e50bca40a5183f5acebd61c4db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cfc8d81_321c9e6f","updated":"2024-04-15 07:30:17.000000000","message":"thanks","commit_id":"2169b2bbab1b09c320d4eeeb2b341c99b4c3ef87"}],"neutronclient/osc/v2/fwaas/firewallpolicy.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c84606e5a0693fce1cf9ec77a91772c82f49675d","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        except Exception as e:"},{"line_number":222,"context_line":"            msg \u003d (_(\"Failed to add rule to firewall \""},{"line_number":223,"context_line":"                     \"policy \u0027%(policy)s\u0027: %(e)s\")"},{"line_number":224,"context_line":"                   % {\u0027policy\u0027: parsed_args.firewall_policy, \u0027e\u0027: e})"},{"line_number":225,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        rule_id \u003d _get_required_firewall_rule(client, parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"66195a54_5aa60b84","line":224,"updated":"2024-03-15 19:08:39.000000000","message":"Should the error more be about failure to find the policy?","commit_id":"74bf9c7aa1fe53f7d293aa24dd285da9872eadb6"},{"author":{"_account_id":31823,"name":"Benjamin Reichel","email":"b.reichel@syseleven.de","username":"benj200"},"change_message_id":"faab005492f814163befc2a5b453e722080ec8fe","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        except Exception as e:"},{"line_number":222,"context_line":"            msg \u003d (_(\"Failed to add rule to firewall \""},{"line_number":223,"context_line":"                     \"policy \u0027%(policy)s\u0027: %(e)s\")"},{"line_number":224,"context_line":"                   % {\u0027policy\u0027: parsed_args.firewall_policy, \u0027e\u0027: e})"},{"line_number":225,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        rule_id \u003d _get_required_firewall_rule(client, parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bf11bbc_8e45d1cd","line":224,"in_reply_to":"66195a54_5aa60b84","updated":"2024-04-12 11:10:39.000000000","message":"Done","commit_id":"74bf9c7aa1fe53f7d293aa24dd285da9872eadb6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ceb4b5376140d97b0c4d79556887689fde837346","unresolved":true,"context_lines":[{"line_number":235,"context_line":"        policy_id \u003d client.find_firewall_policy("},{"line_number":236,"context_line":"            parsed_args.firewall_policy)[\u0027id\u0027]"},{"line_number":237,"context_line":"        body \u003d self.args2body(parsed_args)"},{"line_number":238,"context_line":"        client.insert_rule_into_policy(policy_id, body)"},{"line_number":239,"context_line":"        rule_id \u003d body[\u0027firewall_rule_id\u0027]"},{"line_number":240,"context_line":"        policy \u003d parsed_args.firewall_policy"},{"line_number":241,"context_line":"        print((_(\u0027Inserted firewall rule %(rule)s in firewall policy \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5e2a62d_91bf79b6","side":"PARENT","line":238,"range":{"start_line":238,"start_character":50,"end_line":238,"end_character":54},"updated":"2024-03-19 13:36:53.000000000","message":"Just thinking calling the SDK method with **body won\u0027t work in this case?\n\nJust for reference the method definition insert_rule_into_policy:\nhttps://opendev.org/openstack/openstacksdk/src/branch/master/openstack/network/v2/_proxy.py#L4495-L4500","commit_id":"4e48e90788365cdb166f16edbd893b55fdb85993"},{"author":{"_account_id":31823,"name":"Benjamin Reichel","email":"b.reichel@syseleven.de","username":"benj200"},"change_message_id":"faab005492f814163befc2a5b453e722080ec8fe","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        policy_id \u003d client.find_firewall_policy("},{"line_number":236,"context_line":"            parsed_args.firewall_policy)[\u0027id\u0027]"},{"line_number":237,"context_line":"        body \u003d self.args2body(parsed_args)"},{"line_number":238,"context_line":"        client.insert_rule_into_policy(policy_id, body)"},{"line_number":239,"context_line":"        rule_id \u003d body[\u0027firewall_rule_id\u0027]"},{"line_number":240,"context_line":"        policy \u003d parsed_args.firewall_policy"},{"line_number":241,"context_line":"        print((_(\u0027Inserted firewall rule %(rule)s in firewall policy \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e53f5b1_724673b4","side":"PARENT","line":238,"range":{"start_line":238,"start_character":50,"end_line":238,"end_character":54},"in_reply_to":"b5e2a62d_91bf79b6","updated":"2024-04-12 11:10:39.000000000","message":"Yes, this is a good hint. I updated the change, Thanks","commit_id":"4e48e90788365cdb166f16edbd893b55fdb85993"}]}