)]}'
{"id":"openstack%2Fpython-novaclient~12972","triplet_id":"openstack%2Fpython-novaclient~master~Ie90cb49b8f11e3283fe509e95a8e9fd468cc9892","project":"openstack/python-novaclient","branch":"master","topic":"bug/934081","hashtags":[],"change_id":"Ie90cb49b8f11e3283fe509e95a8e9fd468cc9892","subject":"Add support for Unicode secgroup names","status":"MERGED","created":"2012-09-13 19:15:47.000000000","updated":"2012-09-14 15:01:04.000000000","submitted":"2012-09-14 15:01:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9ce9730b3fb4f610b47123b90df04f0360bae1fd","_number":12972,"virtual_id_number":12972,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-09-14 15:01:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":2,"date":"2012-09-13 20:38:02.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-09-14 14:17:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2012-09-13 20:38:02.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-09-14 14:17:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-13 20:38:02.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-09-14 14:17:43.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-09-14 15:01:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e3a7719b89a016507c23ac8c3524aeeda2d3ba29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 19:44:40.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12972/1/check/gate-python-novaclient-merge/485 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-python-novaclient-docs/166 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-python-novaclient-pep8/474 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-python-novaclient-python26/277 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-python-novaclient-python27/486 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-tempest-devstack-vm/11545 : SUCCESS\n- http://logs.openstack.org/12972/1/check/gate-tempest-devstack-vm-cinder/1525 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"89820d3936459f282f0ff3491bfb323ab9461b5a","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-09-13 20:38:02.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nlooks good, although I wonder if we could generalize this to support all entities.","accounts_in_message":[],"_revision_number":1},{"id":"5592074f8b93220cc046f36922f5e67c6e4ad4d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 14:17:43.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e209eed0d06bc7e0c32ecbfdca5e3f43fc2a4d70","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-09-14 14:17:43.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0163d59f4265d0a8c6286bcf45646ee44cf3d3e3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 14:43:18.000000000","message":"Patch Set 1: Fails\n\nBuild failed\n\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-merge/492 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-docs/173 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-pep8/481 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-python26/284 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-python27/493 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-tempest-devstack-vm/11640 : FAILURE\n- http://logs.openstack.org/12972/1/gate/gate-tempest-devstack-vm-cinder/1620 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b08d316bfce04cf15ced0c97a7ea2017dff98b95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 14:44:16.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d8389f68c035e8e1526d3959198e474612b39daa","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-09-14 14:44:16.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"50eabf5b98c2c005a60053c0a4b1a8da1f3e9464","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 15:01:04.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-merge/493 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-docs/174 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-pep8/482 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-python26/285 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-python-novaclient-python27/494 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-tempest-devstack-vm/11641 : SUCCESS\n- http://logs.openstack.org/12972/1/gate/gate-tempest-devstack-vm-cinder/1621 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"3e1d2748183c7ba88a7821fa50af6f6e0f1dd03c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-14 15:01:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5cdc584efd30467aaac6b859eb51d6749127194c","revisions":{"5cdc584efd30467aaac6b859eb51d6749127194c":{"kind":"REWORK","_number":1,"created":"2012-09-13 19:15:47.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/72/12972/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/72/12972/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/12972/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/12972/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/12972/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/72/12972/1"}}},"commit":{"parents":[{"commit":"40cb8ef8337eaff3704ccacae3131ca908620897","subject":"Merge \"Makes handling of nic args more robust\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/40cb8ef8337eaff3704ccacae3131ca908620897"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2012-09-13 19:01:50.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2012-09-13 19:14:40.000000000","tz":-240},"subject":"Add support for Unicode secgroup names","message":"Add support for Unicode secgroup names\n\nFixes bug 934081.\n\nPreviously, manipulating secgroups with Unicode names would fail\nin _get_secgroup, due to the command-line argument being a raw\nbyte string, and the secgroup name from cs.security_groups.list()\nbeing a Unicode string.  This causes a UnicodeWarning and the\n\"if secgroup \u003d\u003d s.name\" test to fail for the desired secgroup, so\nsecgroup-add-rule and secgroup-delete would fail.\n\nThis change converts them to byte strings for comparison, fixing\nthese commands.\n\nLikewise, error messages containing Unicode secgroup names would\nfail to print. (i.e. \"Security group \u003cx\u003e already exists\")\n\nChange-Id: Ie90cb49b8f11e3283fe509e95a8e9fd468cc9892\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5cdc584efd30467aaac6b859eb51d6749127194c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5cdc584efd30467aaac6b859eb51d6749127194c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}