)]}'
{"novaclient/v1_1/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a8466d5a3697a7814e611cdfe19ccafd846bf790","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1097,"context_line":"def do_volume_list(cs, args):"},{"line_number":1098,"context_line":"    \"\"\"List all the volumes.\"\"\""},{"line_number":1099,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1100,"context_line":"    search_opts \u003d {\u0027all_tenants\u0027: all_tenants}"},{"line_number":1101,"context_line":"    volumes \u003d cs.volumes.list(search_opts\u003dsearch_opts)"},{"line_number":1102,"context_line":"    _translate_volume_keys(volumes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FRxE%3D","line":1099,"updated":"2012-09-26 14:29:37.000000000","message":"So, we prefer the environment variable ALL_TENANTS to the command line argument?  That seems backwards to me.  Also, if the environment variable is not an integer, this will raise a ValueError that I expect would be visible to the user; they might not understand that the traceback they\u0027re getting is related to a bogus value for this environment variable.","commit_id":"c01fae73700047072a1a27add416eb61ee5cb1b0"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"d4595a7fddfbb79feca0430c4f1ee7dbfd23dd9a","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1097,"context_line":"def do_volume_list(cs, args):"},{"line_number":1098,"context_line":"    \"\"\"List all the volumes.\"\"\""},{"line_number":1099,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1100,"context_line":"    search_opts \u003d {\u0027all_tenants\u0027: all_tenants}"},{"line_number":1101,"context_line":"    volumes \u003d cs.volumes.list(search_opts\u003dsearch_opts)"},{"line_number":1102,"context_line":"    _translate_volume_keys(volumes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FQWQ%3D","line":1099,"in_reply_to":"AAAALH%2F%2FRxE%3D","updated":"2012-09-28 10:23:41.000000000","message":"Good points, I merely copied that part of the code from do_list/do_secgroup_list without much thinking -- always a bad idea ;-) I\u0027ll fix the issue in the three places, but in another commit if that works for you. Will submit that in a few minutes.","commit_id":"c01fae73700047072a1a27add416eb61ee5cb1b0"}]}