)]}'
{"id":"openstack%2Fpython-novaclient~15056","triplet_id":"openstack%2Fpython-novaclient~master~I3275e4bba103b14081becf91f723f1be060391e5","project":"openstack/python-novaclient","branch":"master","topic":"bug/1059414","hashtags":[],"change_id":"I3275e4bba103b14081becf91f723f1be060391e5","subject":"Validate that boolean parameters are boolean","status":"MERGED","created":"2012-10-30 19:37:41.000000000","updated":"2012-10-31 18:07:41.000000000","submitted":"2012-10-31 18:07:41.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"672bc9ae6d5163f44a5f7296eb2b9a892ad0c735","_number":15056,"virtual_id_number":15056,"owner":{"_account_id":5995,"name":"Russell Cloran","email":"russell@nimbula.com","username":"russell"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2012-10-31 18:07:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":2,"date":"2012-10-30 21:28:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-10-31 15:20:40.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":0,"date":"2012-10-30 21:28:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2012-10-31 15:20:40.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-10-30 21:28:06.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-10-31 15:20:40.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-10-31 18:07:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7a36df6cade8a27292c77a3a9e662108d5f9b636","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-30 20:11:05.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15056/1/check/gate-python-novaclient-merge/579 : SUCCESS\n- http://logs.openstack.org/15056/1/check/gate-python-novaclient-docs/259 : SUCCESS\n- http://logs.openstack.org/15056/1/check/gate-python-novaclient-pep8/567 : SUCCESS\n- http://logs.openstack.org/15056/1/check/gate-python-novaclient-python26/370 : SUCCESS\n- http://logs.openstack.org/15056/1/check/gate-python-novaclient-python27/579 : SUCCESS\n- http://logs.openstack.org/15056/1/check/gate-tempest-devstack-vm/16135 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"cef8669308eac653195b3741d1f3ae69606c9829","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-10-30 21:28:06.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1dfe56b78ee3bf1792b83b3b2b80dadfca8bc8b7","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-10-31 15:20:40.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"c953f6218f188dc79b9ced62914c74820114a35b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-31 15:22:59.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":1},{"id":"ccea4cef615c35f2d0bcb2ee03d0b6d5530dccc8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-31 18:07:41.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15056/1/gate/gate-python-novaclient-merge/588 : SUCCESS\n- http://logs.openstack.org/15056/1/gate/gate-python-novaclient-docs/267 : SUCCESS\n- http://logs.openstack.org/15056/1/gate/gate-python-novaclient-pep8/575 : SUCCESS\n- http://logs.openstack.org/15056/1/gate/gate-python-novaclient-python26/374 : SUCCESS\n- http://logs.openstack.org/15056/1/gate/gate-python-novaclient-python27/587 : SUCCESS\n- http://logs.openstack.org/15056/1/gate/gate-tempest-devstack-vm/16339 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"1438787bf544a2908204e1c48daee996ba797c50","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-10-31 18:07:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7bf93a52f8828822c8949fe66bc79e8c035d1330","revisions":{"7bf93a52f8828822c8949fe66bc79e8c035d1330":{"kind":"REWORK","_number":1,"created":"2012-10-30 19:37:41.000000000","uploader":{"_account_id":5995,"name":"Russell Cloran","email":"russell@nimbula.com","username":"russell"},"ref":"refs/changes/56/15056/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/56/15056/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/56/15056/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/56/15056/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/56/15056/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/56/15056/1"}}},"commit":{"parents":[{"commit":"05bbe0fa0efc9abe5461e7e2d3fef7b72d625955","subject":"Merge \"Pull in latest openstack-common changes and fix a minor PEP8 issue.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/05bbe0fa0efc9abe5461e7e2d3fef7b72d625955"}]}],"author":{"name":"Russell Cloran","email":"russell@nimbula.com","date":"2012-10-30 06:09:26.000000000","tz":-420},"committer":{"name":"Russell Cloran","email":"russell@nimbula.com","date":"2012-10-30 18:38:58.000000000","tz":-420},"subject":"Validate that boolean parameters are boolean","message":"Validate that boolean parameters are boolean\n\nEnsure that values which are supposed to be boolean look like correct\nuser input, instead of assuming that any non true-looking input is\nFalse.\n\nAlso, update the flavor manager to raise a CommandError if is_public is\nnot a boolean value.\n\nFixes bug 1059414\n\nChange-Id: I3275e4bba103b14081becf91f723f1be060391e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7bf93a52f8828822c8949fe66bc79e8c035d1330"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7bf93a52f8828822c8949fe66bc79e8c035d1330"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"05bbe0fa0efc9abe5461e7e2d3fef7b72d625955","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}