)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b1bc0c9fc4505e93d9bc8bfd18717eb2be8ee3bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikola Dipanov \u003cndipanov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-11-16 10:13:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Imporved quota output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch makes the output of quota show a bit more informative"},{"line_number":10,"context_line":"by not setting a simple None to a non existant quota, but marking it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAMH%2F%2F5Fg%3D","line":7,"updated":"2012-11-16 19:41:54.000000000","message":"Improved","commit_id":"98fddd4d1c491a86a5b6de33d41ebf530c668b27"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b1bc0c9fc4505e93d9bc8bfd18717eb2be8ee3bd","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"def _quota_show(quotas):"},{"line_number":2151,"context_line":"    quota_dict \u003d {}"},{"line_number":2152,"context_line":"    for resource in _quota_resources:"},{"line_number":2153,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, \"Not implemented\")"},{"line_number":2154,"context_line":"    utils.print_dict(quota_dict)"},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2F5E8%3D","line":2153,"updated":"2012-11-16 19:41:54.000000000","message":"Not Implemented generally implies it should/can be implemented. But that is not the case for volume quotas in nova.  Perhaps it should say something like \u0027unused\u0027 or \u0027not available in this version\u0027","commit_id":"98fddd4d1c491a86a5b6de33d41ebf530c668b27"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a4760dc94d33f0b81a81817a1191a7c39019f88f","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"def _quota_show(quotas):"},{"line_number":2151,"context_line":"    quota_dict \u003d {}"},{"line_number":2152,"context_line":"    for resource in _quota_resources:"},{"line_number":2153,"context_line":"        quota_dict[resource] \u003d getattr(quotas, resource, \"Quotas not used\")"},{"line_number":2154,"context_line":"    utils.print_dict(quota_dict)"},{"line_number":2155,"context_line":""},{"line_number":2156,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2F3A8%3D","line":2153,"updated":"2012-11-19 21:05:06.000000000","message":"I wonder if this code should be changed to:\n\n    for resource in _quota_resources:\n        try:\n            quota_dict[resource] \u003d getattr(quotas, resource)\n        except AttributeError:\n            continue\n\nThat would completely omit those resources for which quotas aren\u0027t available.\n\n(I also wonder if there\u0027s some way of making novaclient\u0027s quota support more flexible, so that it can accommodate any quota nova understands.  For instance, I see that security_groups and security_group_rules are not available in the QuotaSetManager.update() routine, nor would they be shown by this loop, even though they should be present in the \u0027quotas\u0027 object.  Something for the future, perhaps…)","commit_id":"6ad0d2ac2d9ba507da05c140bf2d4524d5631513"}]}