)]}'
{"id":"openstack%2Fpython-novaclient~163280","triplet_id":"openstack%2Fpython-novaclient~master~I8f44e92f2a0f25a75926b1813a8b374e79b4f5db","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I8f44e92f2a0f25a75926b1813a8b374e79b4f5db","subject":"Add Client object to documentation","status":"MERGED","created":"2015-03-11 04:32:40.000000000","updated":"2015-03-12 18:32:50.000000000","submitted":"2015-03-12 18:32:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bb17e604070134eeef3ecadd03d38faa5e3640eb","_number":163280,"virtual_id_number":163280,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-03-12 18:32:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-03-12 14:45:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2015-03-12 17:36:37.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2015-03-12 17:36:37.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-11 14:24:25.000000000","updated_by":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"reviewer":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"state":"REVIEWER"},{"updated":"2015-03-12 14:45:27.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-03-12 17:36:37.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-03-12 18:32:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e773078630ffaf71cacf83d3b62bb4202e19688c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-03-11 04:32:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"834f55b84392df57818afe317dce7517931d9796","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 05:29:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/80/163280/1/check/gate-python-novaclient-python26/0d12efb/ : SUCCESS in 1m 01s\n- gate-python-novaclient-pep8 http://logs.openstack.org/80/163280/1/check/gate-python-novaclient-pep8/c97d3a5/ : SUCCESS in 54s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/80/163280/1/check/gate-python-novaclient-docs/3273929//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-novaclient-python27 http://logs.openstack.org/80/163280/1/check/gate-python-novaclient-python27/e0f5aff/ : SUCCESS in 1m 11s\n- gate-python-novaclient-python34 http://logs.openstack.org/80/163280/1/check/gate-python-novaclient-python34/18c59f5/ : SUCCESS in 3m 21s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/80/163280/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/c2085d1/ : SUCCESS in 23m 16s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/80/163280/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/5217101/ : SUCCESS in 39m 08s\n- gate-python-novaclient-pypy http://logs.openstack.org/80/163280/1/check/gate-python-novaclient-pypy/5451b4f/ : SUCCESS in 2m 18s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/80/163280/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/d3aa446/ : SUCCESS in 56m 27s\n- check-novaclient-dsvm-functional http://logs.openstack.org/80/163280/1/check/check-novaclient-dsvm-functional/bf781c5/ : SUCCESS in 19m 26s","accounts_in_message":[],"_revision_number":1},{"id":"41cb797ff34f811f683a84871d06f640776fa9ef","author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"date":"2015-03-11 14:24:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"58bffc16475988cc79271e531f5a7cc6d7d13fdb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-11 15:26:28.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n+1 on improving our documentation, FTR…","accounts_in_message":[],"_revision_number":1},{"id":"e4eea7e771cabb7f37a1800df2dde0803433250d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-03-12 00:43:19.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5eab90fc131cfa9062b9b9171144ab6fe6786c4d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-03-12 00:49:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d4e9663367f22ae878ec7f14ba99f856eadb7996","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-12 02:20:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/80/163280/2/check/gate-python-novaclient-python26/3f4c5f1/ : SUCCESS in 1m 13s\n- gate-python-novaclient-pep8 http://logs.openstack.org/80/163280/2/check/gate-python-novaclient-pep8/47007fd/ : SUCCESS in 50s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/80/163280/2/check/gate-python-novaclient-docs/d967754//doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-novaclient-python27 http://logs.openstack.org/80/163280/2/check/gate-python-novaclient-python27/b2fa0bc/ : SUCCESS in 1m 55s\n- gate-python-novaclient-python34 http://logs.openstack.org/80/163280/2/check/gate-python-novaclient-python34/0e6795d/ : SUCCESS in 3m 17s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/80/163280/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/96b9e98/ : SUCCESS in 27m 51s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/80/163280/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/82fab0d/ : SUCCESS in 40m 48s\n- gate-python-novaclient-pypy http://logs.openstack.org/80/163280/2/check/gate-python-novaclient-pypy/0b0ce72/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/80/163280/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/0599cac/ : SUCCESS in 57m 56s\n- check-novaclient-dsvm-functional http://logs.openstack.org/80/163280/2/check/check-novaclient-dsvm-functional/37ceca3/ : SUCCESS in 24m 51s","accounts_in_message":[],"_revision_number":2},{"id":"0c87afc70e83b8c5b6bf78d3295ea83886295f72","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-12 14:45:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b4a1eb22863079299c0769c2cd93f875d6b14a83","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-03-12 17:36:37.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ea57a3e990771cbb33bd3a5892b2dc61d33ddfab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-12 17:36:38.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0f5da0a4426d47f6a95813ee6220d53831e9a8c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-12 18:32:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/80/163280/2/gate/gate-python-novaclient-python26/f4cdcd0/ : SUCCESS in 1m 01s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/80/163280/2/gate/gate-python-novaclient-docs/6ecaffb//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-novaclient-pep8 http://logs.openstack.org/80/163280/2/gate/gate-python-novaclient-pep8/594d259/ : SUCCESS in 34s\n- gate-python-novaclient-python27 http://logs.openstack.org/80/163280/2/gate/gate-python-novaclient-python27/f4c587d/ : SUCCESS in 1m 10s\n- gate-python-novaclient-python34 http://logs.openstack.org/80/163280/2/gate/gate-python-novaclient-python34/259f59e/ : SUCCESS in 2m 45s\n- gate-python-novaclient-pypy http://logs.openstack.org/80/163280/2/gate/gate-python-novaclient-pypy/3ab3086/ : SUCCESS in 1m 38s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/80/163280/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient/5093d1d/ : SUCCESS in 48m 24s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/80/163280/2/gate/gate-novaclient-dsvm-functional/4632bc3/ : SUCCESS in 20m 44s","accounts_in_message":[],"_revision_number":2},{"id":"bb17e604070134eeef3ecadd03d38faa5e3640eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-12 18:32:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e9c70598f33af40791c2c14a9c84b415ac374c58","revisions":{"32da111c5c351a6092f479f84014647d432af5a2":{"kind":"REWORK","_number":1,"created":"2015-03-11 04:32:40.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/80/163280/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/80/163280/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/1"}}},"commit":{"parents":[{"commit":"876a3bd80ae59baec9a924d1a6843d5f8e23bb6d","subject":"Merge \"Add functional testing README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/876a3bd80ae59baec9a924d1a6843d5f8e23bb6d"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-03-11 04:29:14.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-03-11 04:29:14.000000000","tz":660},"subject":"Add Client object to documentation","message":"Add Client object to documentation\n\nAfter wanting to do a rather simple thing -- figure out of the\n\"timeout\" argument to nodepool was a int or a float, it lead me down\nthe rabbit-hole to python-novaclient.\n\nIt turns out the timeout does get passed through to requests as a\nfloat so that mystery was solved.\n\nBut the \"Client\" class seems to be missing from the documentation as\nit\u0027s not included in the class list.  So add that and also at least\ndocument the types of the arguments.\n\nHowever, then I noticd that this wasn\u0027t showing up; turns out sphinx\nrequires \"autoclass_content \u003d both\" if you want it to document\n__init__() functions.  Several other classes had their init args\ndocumented but they weren\u0027t showing up because of this.\n\nChange-Id: I8f44e92f2a0f25a75926b1813a8b374e79b4f5db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/32da111c5c351a6092f479f84014647d432af5a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/32da111c5c351a6092f479f84014647d432af5a2"}]},"branch":"refs/heads/master"},"e9c70598f33af40791c2c14a9c84b415ac374c58":{"kind":"REWORK","_number":2,"created":"2015-03-12 00:49:18.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/80/163280/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/80/163280/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/80/163280/2"}}},"commit":{"parents":[{"commit":"876a3bd80ae59baec9a924d1a6843d5f8e23bb6d","subject":"Merge \"Add functional testing README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/876a3bd80ae59baec9a924d1a6843d5f8e23bb6d"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-03-11 04:29:14.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2015-03-12 00:49:04.000000000","tz":660},"subject":"Add Client object to documentation","message":"Add Client object to documentation\n\nAfter wanting to do a rather simple thing -- figure out of the\n\"timeout\" argument to nodepool was a int or a float, it lead me down\nthe rabbit-hole to python-novaclient.\n\nIt turns out the timeout does get passed through to requests as a\nfloat so that mystery was solved.\n\nBut the \"Client\" class seems to be missing from the documentation as\nit\u0027s not included in the class list.  So add that and also at least\ndocument the types of the arguments.\n\nHowever, then I noticd that this wasn\u0027t showing up; turns out sphinx\nrequires \"autoclass_content \u003d both\" if you want it to document\n__init__() functions.  Several other classes had their init args\ndocumented but they weren\u0027t showing up because of this.\n\nChange-Id: I8f44e92f2a0f25a75926b1813a8b374e79b4f5db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e9c70598f33af40791c2c14a9c84b415ac374c58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e9c70598f33af40791c2c14a9c84b415ac374c58"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
