)]}'
{"id":"openstack%2Fpython-novaclient~163545","triplet_id":"openstack%2Fpython-novaclient~master~Ibd3c1e8d48ae57994d023bf18dd53a298466f6cb","project":"openstack/python-novaclient","branch":"master","topic":"bug/1430935","hashtags":[],"change_id":"Ibd3c1e8d48ae57994d023bf18dd53a298466f6cb","subject":"Fix typo in socket attribute name","status":"MERGED","created":"2015-03-11 17:54:36.000000000","updated":"2015-03-11 21:39:53.000000000","submitted":"2015-03-11 21:39:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8588a16406035fb7c21e2318d2ecdbf922f5426d","_number":163545,"virtual_id_number":163545,"owner":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2015-03-11 21:39:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-03-11 18:48:57.000000000","_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2015-03-11 18:35:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":2,"date":"2015-03-11 17:57:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2015-03-11 18:35:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-11 17:57:16.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-03-11 18:35:54.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-03-11 21:39:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7241073259cd77ca46bd8f8c65b01c0439a2102d","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-03-11 17:54:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f42308b7c2fc50eba68293d0d14f59d4b636f4c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-11 17:57:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9044da6e5976400d32a2c750bce138c83b678e78","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-03-11 18:35:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThanks for fixing this.\n\nIdeally I wish for unit tests with every patch, but understand this is a really obvious bug. So I put up a patch for a test to follow this one.","accounts_in_message":[],"_revision_number":1},{"id":"3dcdff076cd881e18a43fde77d4406c3f64ee9bf","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-03-11 18:48:57.000000000","message":"Patch Set 1:\n\n@melanie - Agreed on the unit tests. I did not add any due to the nature of the bug and because this specific class is not covered very well. It\u0027s a good idea to follow up with improved test coverage in a later patch.","accounts_in_message":[],"_revision_number":1},{"id":"ed0d78c06efa6457c215fc778e000fe6d76c49ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 20:47:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/45/163545/1/check/gate-python-novaclient-python26/68a443b/ : SUCCESS in 1m 10s\n- gate-python-novaclient-pep8 http://logs.openstack.org/45/163545/1/check/gate-python-novaclient-pep8/5ce57f6/ : SUCCESS in 46s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/45/163545/1/check/gate-python-novaclient-docs/4066c49//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-novaclient-python27 http://logs.openstack.org/45/163545/1/check/gate-python-novaclient-python27/cf74223/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python34 http://logs.openstack.org/45/163545/1/check/gate-python-novaclient-python34/e39edb5/ : SUCCESS in 3m 05s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/45/163545/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/d670df3/ : SUCCESS in 23m 30s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/45/163545/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/80e3678/ : SUCCESS in 46m 51s\n- gate-python-novaclient-pypy http://logs.openstack.org/45/163545/1/check/gate-python-novaclient-pypy/a62a015/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/45/163545/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/e04807c/ : SUCCESS in 52m 56s\n- check-novaclient-dsvm-functional http://logs.openstack.org/45/163545/1/check/check-novaclient-dsvm-functional/e6ae51d/ : SUCCESS in 19m 16s","accounts_in_message":[],"_revision_number":1},{"id":"8546505e0f919a7b954e4ee9cf44f7d2351915bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 20:47:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dbabace14f3e51f37eeaa8017b76a74e77eca2f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 21:39:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/45/163545/1/gate/gate-python-novaclient-python26/18102fe/ : SUCCESS in 1m 13s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/45/163545/1/gate/gate-python-novaclient-docs/1dc7358//doc/build/html/ : SUCCESS in 57s\n- gate-python-novaclient-pep8 http://logs.openstack.org/45/163545/1/gate/gate-python-novaclient-pep8/048d491/ : SUCCESS in 33s\n- gate-python-novaclient-python27 http://logs.openstack.org/45/163545/1/gate/gate-python-novaclient-python27/c9d8712/ : SUCCESS in 1m 36s\n- gate-python-novaclient-python34 http://logs.openstack.org/45/163545/1/gate/gate-python-novaclient-python34/14ee76b/ : SUCCESS in 2m 19s\n- gate-python-novaclient-pypy http://logs.openstack.org/45/163545/1/gate/gate-python-novaclient-pypy/b433d35/ : SUCCESS in 1m 43s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/45/163545/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/daa662d/ : SUCCESS in 51m 33s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/45/163545/1/gate/gate-novaclient-dsvm-functional/f991020/ : SUCCESS in 20m 44s","accounts_in_message":[],"_revision_number":1},{"id":"d58475b31bccc60f491cae73eb9067b6cfa9a402","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 21:39:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"689a884e18deef696a7734b4d77eca8f699e12d0","revisions":{"689a884e18deef696a7734b4d77eca8f699e12d0":{"kind":"REWORK","_number":1,"created":"2015-03-11 17:54:36.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/45/163545/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/45/163545/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/45/163545/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/45/163545/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/45/163545/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/45/163545/1"}}},"commit":{"parents":[{"commit":"876a3bd80ae59baec9a924d1a6843d5f8e23bb6d","subject":"Merge \"Add functional testing README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/876a3bd80ae59baec9a924d1a6843d5f8e23bb6d"}]}],"author":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-03-11 17:49:20.000000000","tz":-240},"committer":{"name":"David Moreau Simard","email":"dmsimard@iweb.com","date":"2015-03-11 17:53:24.000000000","tz":-240},"subject":"Fix typo in socket attribute name","message":"Fix typo in socket attribute name\n\nThe proper attribute name is \u0027IPPROTO_TCP\u0027, not \u0027IPROTO_TCP\u0027.\nThis would lead to an AttributeError since socket does\nnot have an attribute named \u0027IPROTO_TCP\u0027.\n\nChange-Id: Ibd3c1e8d48ae57994d023bf18dd53a298466f6cb\nCloses-Bug: 1430935\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/689a884e18deef696a7734b4d77eca8f699e12d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/689a884e18deef696a7734b4d77eca8f699e12d0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}