)]}'
{"id":"openstack%2Fpython-novaclient~16441","triplet_id":"openstack%2Fpython-novaclient~master~Icce811caf637fc92c6d6374bfb846ea9525a7e05","project":"openstack/python-novaclient","branch":"master","topic":"add-extra-opts-to-nova-ssh-command","hashtags":[],"change_id":"Icce811caf637fc92c6d6374bfb846ea9525a7e05","subject":"Added --extra-opts to the nova ssh command","status":"MERGED","created":"2012-11-19 16:45:24.000000000","updated":"2012-11-21 17:12:05.000000000","submitted":"2012-11-21 17:12:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3a0062b13b7629773393c69856c6ff50f5ed9d27","_number":16441,"virtual_id_number":16441,"owner":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2012-11-21 17:12:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2012-11-21 16:52:20.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-11-19 20:14:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2012-11-21 16:52:20.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-11-19 20:14:53.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-19 20:14:53.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-11-21 16:52:20.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-11-21 17:12:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8eac40d33c8f72fe0820a8869d463e50d71827b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-19 17:04:11.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/16441/1/check/gate-python-novaclient-merge/665 : SUCCESS\n- http://logs.openstack.org/16441/1/check/gate-python-novaclient-docs/344 : SUCCESS\n- http://logs.openstack.org/16441/1/check/gate-python-novaclient-pep8/652 : FAILURE\n- http://logs.openstack.org/16441/1/check/gate-python-novaclient-python26/451 : SUCCESS\n- http://logs.openstack.org/16441/1/check/gate-python-novaclient-python27/664 : SUCCESS\n- http://logs.openstack.org/16441/1/check/gate-tempest-devstack-vm/19122 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"22b3a29805d595911b979e7c8ebeba9f3df798cb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-11-19 17:04:30.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(5 inline comments)\n\nIt would also be kinda nice if you included some tests for this.  If none currently exist, that\u0027s fine, but extra points if you add tests…","accounts_in_message":[],"_revision_number":1},{"id":"7b85c72183d497e802c1a13b75895c993ab47aba","author":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"date":"2012-11-19 19:03:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"37296cf61b3eb673c02ade7c79a0e65b84ccfa60","author":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"date":"2012-11-19 19:23:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"27ca16b86cce2e318aee1dc64fff607a8f3053c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-19 19:45:44.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/16441/3/check/gate-python-novaclient-merge/667 : SUCCESS\n- http://logs.openstack.org/16441/3/check/gate-python-novaclient-docs/346 : SUCCESS\n- http://logs.openstack.org/16441/3/check/gate-python-novaclient-pep8/654 : SUCCESS\n- http://logs.openstack.org/16441/3/check/gate-python-novaclient-python26/453 : SUCCESS\n- http://logs.openstack.org/16441/3/check/gate-python-novaclient-python27/666 : SUCCESS\n- http://logs.openstack.org/16441/3/check/gate-tempest-devstack-vm/19158 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"ae6da92fcb4efdcc0943414dfb27da7821f2de93","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-11-19 20:14:53.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nYou could still stand to format the commit message a bit better, e.g.:\n\n    The goal is to support ssh commands like\n\n        nova ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 \\\n            --extra-opts\u003d\u0027-NfnMS ~/.ssh/master-fe55adc9-cb1e-44a4-bd36-6a537b238172\u0027\n\nThat said, what you have is fine as far as I\u0027m concerned.","accounts_in_message":[],"_revision_number":3},{"id":"bf76cd09dbde9e0043e7b06556024312c9380d3d","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-11-21 16:52:20.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"83eb7f2f44ba175b1ce6938f59bd223b405c7d88","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-21 16:53:24.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":3},{"id":"a6d412b6627beff4433426f5dc4443ec1571b7a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-21 17:12:04.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- http://logs.openstack.org/16441/3/gate/gate-python-novaclient-merge/679 : SUCCESS\n- http://logs.openstack.org/16441/3/gate/gate-python-novaclient-docs/358 : SUCCESS\n- http://logs.openstack.org/16441/3/gate/gate-python-novaclient-pep8/666 : SUCCESS\n- http://logs.openstack.org/16441/3/gate/gate-python-novaclient-python26/465 : SUCCESS\n- http://logs.openstack.org/16441/3/gate/gate-python-novaclient-python27/678 : SUCCESS\n- http://logs.openstack.org/16441/3/gate/gate-tempest-devstack-vm/19531 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"89b77a2e41d1cb1412c57445695395987049c93c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-21 17:12:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3ea4ba9fc97b05ad93af8f9aa6f6bc2a638b9a36","revisions":{"9c4360907e692df4ab9bbe9f17405257ef103d83":{"kind":"REWORK","_number":1,"created":"2012-11-19 16:45:24.000000000","uploader":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"ref":"refs/changes/41/16441/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/16441/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/1"}}},"commit":{"parents":[{"commit":"aa8d44c551643bb97e039624d602bd4ad07cbe9c","subject":"Adding support to filter instances by tenant from the admin api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa8d44c551643bb97e039624d602bd4ad07cbe9c"}]}],"author":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-17 10:26:08.000000000","tz":-360},"committer":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-17 10:26:08.000000000","tz":-360},"subject":"Added --extra-opts to the nova ssh command This will allow for remote command execution and advanced ssh options like portforwarding and connection sharing. The goal is to support ssh commands like nova ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-NfnMS ~/.ssh/master-fe55adc9-cb1e-44a4-bd36-6a537b238172\u0027 and ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-t \"sudo puppet agent --test\"\u0027. This will alow easier scripting of the cli... It is not intended however to replace using the nova python api. Therefore I kept it simple.","message":"Added --extra-opts to the nova ssh command\nThis will allow for remote command execution and advanced ssh options like portforwarding and connection sharing. The goal is to support ssh commands like nova ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-NfnMS ~/.ssh/master-fe55adc9-cb1e-44a4-bd36-6a537b238172\u0027 and ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-t \"sudo puppet agent --test\"\u0027. This will alow easier scripting of the cli... It is not intended however to replace using the nova python api. Therefore I kept it simple.\n\nChange-Id: Icce811caf637fc92c6d6374bfb846ea9525a7e05\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9c4360907e692df4ab9bbe9f17405257ef103d83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9c4360907e692df4ab9bbe9f17405257ef103d83"}]},"branch":"refs/heads/master"},"1274739d9e4fc6edd9bfe2cff9de8b87d52ac31b":{"kind":"REWORK","_number":2,"created":"2012-11-19 19:03:20.000000000","uploader":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"ref":"refs/changes/41/16441/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/16441/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/2"}}},"commit":{"parents":[{"commit":"aa8d44c551643bb97e039624d602bd4ad07cbe9c","subject":"Adding support to filter instances by tenant from the admin api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa8d44c551643bb97e039624d602bd4ad07cbe9c"}]}],"author":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-17 10:26:08.000000000","tz":-360},"committer":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-19 19:01:34.000000000","tz":-360},"subject":"Added --extra-opts to the nova ssh command","message":"Added --extra-opts to the nova ssh command\n\nThis will allow for remote command execution and advanced ssh options\nlike portforwarding and connection sharing.\nThe goal is to support ssh commands like\nnova ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-NfnMS ~/.ssh/master-fe55adc9-cb1e-44a4-bd36-6a537b238172\u0027\nand ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-t \"sudo puppet agent --test\"\u0027\nThis will alow easier scripting of the cli... It is not intended\nhowever to replace using the nova python api. Therefore I kept it simple.\n\nChange-Id: Icce811caf637fc92c6d6374bfb846ea9525a7e05\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1274739d9e4fc6edd9bfe2cff9de8b87d52ac31b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1274739d9e4fc6edd9bfe2cff9de8b87d52ac31b"}]},"branch":"refs/heads/master"},"3ea4ba9fc97b05ad93af8f9aa6f6bc2a638b9a36":{"kind":"REWORK","_number":3,"created":"2012-11-19 19:23:13.000000000","uploader":{"_account_id":6265,"name":"Nicholas Shobe","email":"nickshobe@gmail.com","username":"nickshobe"},"ref":"refs/changes/41/16441/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/41/16441/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/41/16441/3"}}},"commit":{"parents":[{"commit":"aa8d44c551643bb97e039624d602bd4ad07cbe9c","subject":"Adding support to filter instances by tenant from the admin api","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa8d44c551643bb97e039624d602bd4ad07cbe9c"}]}],"author":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-17 10:26:08.000000000","tz":-360},"committer":{"name":"Nick Shobe","email":"nickshobe@gmail.com","date":"2012-11-19 19:23:05.000000000","tz":-360},"subject":"Added --extra-opts to the nova ssh command","message":"Added --extra-opts to the nova ssh command\n\nThis will allow for remote command execution and advanced ssh options\nlike portforwarding and connection sharing.\nThe goal is to support ssh commands like\nnova ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-NfnMS ~/.ssh/master-fe55adc9-cb1e-44a4-bd36-6a537b238172\u0027\nand ssh fe55adc9-cb1e-44a4-bd36-6a537b238172 --extra-opts\u003d\u0027-t \"sudo puppet agent --test\"\u0027\nThis will alow easier scripting of the cli... It is not intended\nhowever to replace using the nova python api. Therefore I kept it simple.\n\nChange-Id: Icce811caf637fc92c6d6374bfb846ea9525a7e05\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3ea4ba9fc97b05ad93af8f9aa6f6bc2a638b9a36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3ea4ba9fc97b05ad93af8f9aa6f6bc2a638b9a36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}