)]}'
{"id":"openstack%2Fpython-novaclient~164778","triplet_id":"openstack%2Fpython-novaclient~master~Ifdcab63b26084838e9fe093b18cf882e493fc139","project":"openstack/python-novaclient","branch":"master","topic":"pep8_H404","hashtags":[],"change_id":"Ifdcab63b26084838e9fe093b18cf882e493fc139","subject":"Enable pep8 H404 rule","status":"ABANDONED","created":"2015-03-16 16:50:47.000000000","updated":"2015-06-12 19:20:09.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e95c677b664902a4808003ab131d556f9d366e3b","_number":164778,"virtual_id_number":164778,"owner":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2015-05-08 20:33:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-03-16 18:07:47.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"date":"2015-03-18 21:17:28.000000000","_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"all":[{"value":-1,"date":"2015-03-17 18:31:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2015-03-18 18:44:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-16 18:07:47.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-03-17 18:31:18.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-03-18 18:44:15.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2015-05-08 20:33:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"52f573dede45476833f79bcddff605ecab4dd09d","author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"date":"2015-03-16 16:50:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c8beecfdb7384ea23c4f225ee513600d3dbf3ae","author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"date":"2015-03-16 17:53:35.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"70dd20cdcfd46db18398976f9bb7c2521e6c0f4b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-16 18:07:47.000000000","message":"Patch Set 2:\n\nSoft -1 from me—I don\u0027t like that rule.","accounts_in_message":[],"_revision_number":2},{"id":"91bb67232012c9123a10ea17e7da2271dda2d65a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-16 19:33:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/78/164778/2/check/gate-python-novaclient-python26/77b706a/ : SUCCESS in 1m 32s\n- gate-python-novaclient-pep8 http://logs.openstack.org/78/164778/2/check/gate-python-novaclient-pep8/cee9eca/ : SUCCESS in 37s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/78/164778/2/check/gate-python-novaclient-docs/b9f2fc4//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-novaclient-python27 http://logs.openstack.org/78/164778/2/check/gate-python-novaclient-python27/c30d995/ : SUCCESS in 1m 25s\n- gate-python-novaclient-python34 http://logs.openstack.org/78/164778/2/check/gate-python-novaclient-python34/a7651d6/ : SUCCESS in 3m 40s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/78/164778/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/99fd1f9/ : SUCCESS in 34m 30s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/78/164778/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/314ebfa/ : SUCCESS in 50m 06s\n- gate-python-novaclient-pypy http://logs.openstack.org/78/164778/2/check/gate-python-novaclient-pypy/27406d0/ : SUCCESS in 2m 08s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/78/164778/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/3c52a63/ : SUCCESS in 55m 02s\n- check-novaclient-dsvm-functional http://logs.openstack.org/78/164778/2/check/check-novaclient-dsvm-functional/aef7820/ : SUCCESS in 22m 06s","accounts_in_message":[],"_revision_number":2},{"id":"63e604b5a357bcbb6123d1b656ad0570374fa7b6","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-03-17 18:31:18.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI\u0027m okay with this rule, but I found at least a few places where this patch is mixing H404 changes with H405 changes, and I think this patch should stick to H404 as indicated in the commit message. The patch is large and doesn\u0027t need any noise in it.","accounts_in_message":[],"_revision_number":2},{"id":"44b75db0d242578c61987b2ce8ec5c50f5c63906","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-03-18 18:44:15.000000000","message":"Patch Set 2: Code-Review-1\n\nI actually don\u0027t think we need to enable these two rules. They haven\u0027t been a point of review nit picking, so if it isn\u0027t hurting us lets just leave them off.","accounts_in_message":[],"_revision_number":2},{"id":"0ab7942e26cc4edf736ea7531507437fc4b9465d","author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"date":"2015-03-18 21:17:28.000000000","message":"Patch Set 2:\n\nThanks for review, guys!\n\nThe second rule (H405) is more complicated, it needs to add some text description in too many functions.\n\nBut this is rather simple and cleanup. I can improve this patch to correct only H404 rule (as it is mentioned in comments above). So, what do you think about it?","accounts_in_message":[],"_revision_number":2},{"id":"2bda9a2868ab633a0397ec2df86446caff0321bc","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-03-18 21:23:50.000000000","message":"Patch Set 2:\n\nI still don\u0027t think this is really needed, but if you clean it up I won\u0027t -1  it","accounts_in_message":[],"_revision_number":2},{"id":"6b28322a69cd87d743ada95532b35f1d467e5330","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-18 22:48:47.000000000","message":"Patch Set 2:\n\nAs I said, I\u0027m soft -1 on this, meaning I won\u0027t vote on it other than registering my dislike of the rule.","accounts_in_message":[],"_revision_number":2},{"id":"6ccadc7e7707a413a724f830f45b14e1eb9845e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-08 20:33:29.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"43eb9e929ec132bedf3ce1b67c25302e09c42f43","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-29 20:07:31.000000000","message":"Patch Set 2:\n\nThis change has been idle since mid-March.  Do you intend to continue working on it?  If not, please abandon it.","accounts_in_message":[],"_revision_number":2},{"id":"e1473a278fd1fed247d69bb03862edd24fcd427b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-06-12 19:20:09.000000000","message":"Abandoned\n\nIdle since mid-March and in merge conflict.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e52a8b82ab36ece81e730b7d8add5fd6a343bbc6","revisions":{"d118e4f38954959e40c28e30c4cc991f9bd9e1ac":{"kind":"REWORK","_number":1,"created":"2015-03-16 16:50:47.000000000","uploader":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"ref":"refs/changes/78/164778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/78/164778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/1"}}},"commit":{"parents":[{"commit":"b41d319308cbc8dbcdb4a2fd34f9d03d0de64066","subject":"Merge \"Add missing servers.create parameter documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b41d319308cbc8dbcdb4a2fd34f9d03d0de64066"}]}],"author":{"name":"Pavel Kholkin","email":"pkholkin@mirantis.com","date":"2015-03-16 16:48:26.000000000","tz":180},"committer":{"name":"Pavel Kholkin","email":"pkholkin@mirantis.com","date":"2015-03-16 16:50:30.000000000","tz":180},"subject":"Enable pep8 H404 rule","message":"Enable pep8 H404 rule\n\nH405 multi line docstring summary not separated with an empty line\n\nChange-Id: Ifdcab63b26084838e9fe093b18cf882e493fc139\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d118e4f38954959e40c28e30c4cc991f9bd9e1ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d118e4f38954959e40c28e30c4cc991f9bd9e1ac"}]},"branch":"refs/heads/master"},"e52a8b82ab36ece81e730b7d8add5fd6a343bbc6":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-03-16 17:53:35.000000000","uploader":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"ref":"refs/changes/78/164778/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/78/164778/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/78/164778/2"}}},"commit":{"parents":[{"commit":"b41d319308cbc8dbcdb4a2fd34f9d03d0de64066","subject":"Merge \"Add missing servers.create parameter documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b41d319308cbc8dbcdb4a2fd34f9d03d0de64066"}]}],"author":{"name":"Pavel Kholkin","email":"pkholkin@mirantis.com","date":"2015-03-16 16:48:26.000000000","tz":180},"committer":{"name":"Pavel Kholkin","email":"pkholkin@mirantis.com","date":"2015-03-16 17:53:35.000000000","tz":0},"subject":"Enable pep8 H404 rule","message":"Enable pep8 H404 rule\n\nH404 multi line docstring should start without a leading new line\n\nChange-Id: Ifdcab63b26084838e9fe093b18cf882e493fc139\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e52a8b82ab36ece81e730b7d8add5fd6a343bbc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e52a8b82ab36ece81e730b7d8add5fd6a343bbc6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}