)]}'
{"novaclient/shell.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"34487b253c562ad5541b60c81ee4ccb76eff8979","unresolved":false,"context_lines":[{"line_number":58,"context_line":"from novaclient.openstack.common import cliutils"},{"line_number":59,"context_line":"from novaclient import utils"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_d1c6a567","line":61,"updated":"2015-03-25 21:14:43.000000000","message":"It seems to me \"compute version\" and \"compute endpoint\" shouldn\u0027t be controlled independently. For example, the way this patch has it, by default we would be setting default version as 2 but the default endpoint will be something point at version 2.1. That doesn\u0027t make sense.","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"aeae42c3da082bfa69acad3f7725257f7d72e37f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"from novaclient.openstack.common import cliutils"},{"line_number":59,"context_line":"from novaclient import utils"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_e26751b5","line":61,"in_reply_to":"1a6ced46_d1c6a567","updated":"2015-03-25 21:17:52.000000000","message":"Argh, sorry, I didn\u0027t mean to post this comment. After looking through the code some more, I learned this version is for selecting which client class to use. It\u0027s inherently confusing to have \"api version\" which means \"client class\" along with \"service type\" which means \"endpoint\" in my opinion, but I understand that\u0027s already part of novaclient.","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c74e4f738364e7139c316803dafc3004d342d2c3","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_31f1b902","line":63,"updated":"2015-03-25 19:59:54.000000000","message":"service type should never have version encoded in it. I know DevStack does that, but it really shouldn\u0027t be. And the fact that it does should not mean we push that on everyone.","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"cd03bc71b31ddbac8a45730fbf868ae34dc3d4a4","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_6fd83254","line":63,"in_reply_to":"1a6ced46_29d05bf5","updated":"2015-03-27 14:16:14.000000000","message":"Actually, both \u0027compute\u0027 and \u0027computev21\u0027 are correct and needed.\n\nNow, what each means is this:\n\n   \u0027compute\u0027 - tells nova-api to use old contrib modules.\n   \u0027computev21\u0027 - tells nova-api to use new plugins/v3 modules. (including microversions)\n\nBasically, DEFAULT_NOVA_SERVICE_TYPE will be used if no --os-compute-api-version is given. If it is given, it should decide based on the value:\n\n    if -os-compute-api-version 2.0 \u003d\u003e \u0027compute\u0027 should be used.\n    if -os-compute-api-version 2.1 or higher \u003d\u003e \u0027computev21\u0027 should be used.\n\nAnyways, this is basically a discussion on which service type to use as default.\n\nI actually have no preference, since api versions 2.0 and 2.1 should be pretty much the same. As far as I know, that was the intention. But let\u0027s say I prefer \u0027computev21\u0027.","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"34487b253c562ad5541b60c81ee4ccb76eff8979","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_87ddcfe2","line":63,"in_reply_to":"1a6ced46_31f1b902","updated":"2015-03-25 21:14:43.000000000","message":"I don\u0027t think we can use anything other than \u0027compute\u0027 for the default.\n\nThe documentation for defining services [1] describes the essentials, one of which is \u0027compute\u0027. I think we can\u0027t assume anyone will have a service named \u0027computev21\u0027 by default -- I think most likely they wouldn\u0027t have it.\n\n[1] http://docs.openstack.org/developer/keystone/configuringservices.html#defining-services","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5c4223b9cf7bc65b6662af00aaf733a6e19bdcc8","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"DEFAULT_OS_COMPUTE_API_VERSION \u003d \"2\""},{"line_number":62,"context_line":"DEFAULT_NOVA_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":63,"context_line":"DEFAULT_NOVA_SERVICE_TYPE \u003d \u0027computev21\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_29d05bf5","line":63,"in_reply_to":"1a6ced46_87ddcfe2","updated":"2015-03-26 12:01:43.000000000","message":"Was it planned for Kilo to use microversions by such redundant way:\n\n nova --service-type computev21 --os-compute-api-version latest ...\n\nI suppose that many deployments will have both v2 and v2.1 endpoints. For example due to compatibility reasons. So an end-user couldn\u0027t omit service-type parameter.","commit_id":"58e2661cf90dda215b57c0cc757f76ec784c827e"}]}