)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3e00ceaa6ad3f2231b9f7b69ce571d00fecf9a54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajiv Kumar \u003crajiv.kumar@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-31 08:41:48 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addition of test case for response to nova rate-limit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova rate-limit returns absolute limits too, but novaclient does"},{"line_number":10,"context_line":"not show absolute limit,a bug"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_ef2d2947","line":7,"updated":"2015-03-31 19:14:10.000000000","message":"This should say something about combining the tests into one. For example \"Combine test cases for checking nova limits response\"","commit_id":"c63341eece4e0ebf046b693dbb6ec57062bf6b65"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3e00ceaa6ad3f2231b9f7b69ce571d00fecf9a54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"not show absolute limit,a bug"},{"line_number":11,"context_line":"(https://bugs.launchpad.net/python-novaclient/+bug/1172254) has"},{"line_number":12,"context_line":"been filed for this one. But nova client does not contains any"},{"line_number":13,"context_line":"test cases which assert on abolute limit returned."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test case which only assert onto absolute limit returned by the"},{"line_number":16,"context_line":"server is asserted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_4a48832d","line":13,"updated":"2015-03-31 19:14:10.000000000","message":"This isn\u0027t true -- the \"test_absolute_limits\" asserts on absolute limits returned. What you\u0027re doing is asserting on rate limits and absolute limits in the same test.","commit_id":"c63341eece4e0ebf046b693dbb6ec57062bf6b65"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3e00ceaa6ad3f2231b9f7b69ce571d00fecf9a54","unresolved":false,"context_lines":[{"line_number":13,"context_line":"test cases which assert on abolute limit returned."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test case which only assert onto absolute limit returned by the"},{"line_number":16,"context_line":"server is asserted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia635f32eefc46e22e3f4e45a7885f492bb967a99"},{"line_number":19,"context_line":"Closes-Bug: #1436653"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_ead4f720","line":16,"updated":"2015-03-31 19:14:10.000000000","message":"This sentence is confusing and I don\u0027t think is necessary. If you want to summarize, you can say similar as above, that you\u0027re adding a test that checks both rate limits and absolute limits at the same time.","commit_id":"c63341eece4e0ebf046b693dbb6ec57062bf6b65"}],"novaclient/tests/unit/v2/test_limits.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4d81cc0edb49b9fc066305820decd1f781945676","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/limits?tenant_id\u003d1234\u0027)"},{"line_number":33,"context_line":"        self.assertIsInstance(obj, limits.Limits)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_absolute_limits(self):"},{"line_number":36,"context_line":"        obj \u003d self.cs.limits.get()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_fd11c05e","line":35,"updated":"2015-03-26 17:25:16.000000000","message":"Isn\u0027t your test identical to this already existing one?","commit_id":"37026afcde172c49d7288c206d18acb312bb80dc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"30868d7b29d13a159df8939af62e852040fd880e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/limits?tenant_id\u003d1234\u0027)"},{"line_number":33,"context_line":"        self.assertIsInstance(obj, limits.Limits)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_absolute_limits(self):"},{"line_number":36,"context_line":"        obj \u003d self.cs.limits.get()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_63871f10","line":35,"in_reply_to":"fa963961_a6ad558a","updated":"2015-03-30 22:39:32.000000000","message":"Okay, if that\u0027s what you aimed to do, then you would have had a test that assertEqual on both the rate limits and the absolute limits (like a combination of test_rate_limits and test_absolute_limits). Your test wouldn\u0027t be identical to any existing test.\n\nI don\u0027t think another test case is \"necessary\" because the call is the same (self.cs.limits.get()) and one test is checking for the rate limit data and the other test is checking for the absolute limit data, which together means that for the same call, both data is present as expected.\n\nHowever, I don\u0027t think it would hurt to combine two of the tests into one, to make it clearer that both data is returned from one get call, if you want to do that.","commit_id":"37026afcde172c49d7288c206d18acb312bb80dc"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e5e3ac3e3957437da29d9737287dfde4ae637d6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/limits?tenant_id\u003d1234\u0027)"},{"line_number":33,"context_line":"        self.assertIsInstance(obj, limits.Limits)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_absolute_limits(self):"},{"line_number":36,"context_line":"        obj \u003d self.cs.limits.get()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        expected \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_a6ad558a","line":35,"in_reply_to":"fa963961_fd11c05e","updated":"2015-03-27 03:09:48.000000000","message":"yes, you are right. i wanted to call get() once and test for both rate limits and absolute rate limit in the same test, because that is what finally returned by get function. None of the test cases does it right now. I got suggestion somewhere else that you can not right test that does two things but  i think in this case, i should. \n\nNow my question is, does it make sense to write one?\n\nshould i do it?","commit_id":"37026afcde172c49d7288c206d18acb312bb80dc"}]}