)]}'
{"id":"openstack%2Fpython-novaclient~168237","triplet_id":"openstack%2Fpython-novaclient~master~I68bba17b4c3e3cca4c6be0bd939b36f7dee1eb99","project":"openstack/python-novaclient","branch":"master","topic":"bug/1436763","hashtags":[],"change_id":"I68bba17b4c3e3cca4c6be0bd939b36f7dee1eb99","subject":"Flavor list shows default value for swap field","status":"ABANDONED","created":"2015-03-27 06:18:33.000000000","updated":"2015-07-24 21:26:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c87985980d2be9984f7eca80e196b9ad6977948a","_number":168237,"virtual_id_number":168237,"owner":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":1,"date":"2015-03-27 07:28:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"date":"2015-03-27 15:33:54.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2015-03-28 02:52:30.000000000","_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":-1,"date":"2015-03-27 16:17:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-03-27 07:09:21.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-03-27 07:09:47.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},{"value":0,"date":"2015-03-27 07:09:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"date":"2015-03-27 07:09:28.000000000","_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"date":"2015-03-27 07:10:11.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"date":"2015-03-27 07:10:31.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-27 07:09:21.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-03-27 07:09:28.000000000","updated_by":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"reviewer":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"state":"REVIEWER"},{"updated":"2015-03-27 07:09:38.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2015-03-27 07:09:47.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2015-03-27 07:10:11.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-03-27 07:10:31.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2015-03-27 07:28:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-03-27 15:33:54.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-03-27 16:17:05.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"}],"messages":[{"id":"64c8a467259dc6ba2d65eb8dfbfdbaca7e672012","author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"date":"2015-03-27 06:18:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b1cdf9aeca954f73b60b52a536b7887deddce417","author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"date":"2015-03-27 06:22:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2dba1d68209beaa016ab63167a5b9bd694f0d783","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-27 07:28:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/37/168237/2/check/gate-python-novaclient-python26/199e248/ : SUCCESS in 1m 18s\n- gate-python-novaclient-pep8 http://logs.openstack.org/37/168237/2/check/gate-python-novaclient-pep8/dcddf70/ : SUCCESS in 41s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/37/168237/2/check/gate-python-novaclient-docs/39e9bc4//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-novaclient-python27 http://logs.openstack.org/37/168237/2/check/gate-python-novaclient-python27/61e6f64/ : SUCCESS in 1m 35s\n- gate-python-novaclient-python34 http://logs.openstack.org/37/168237/2/check/gate-python-novaclient-python34/57440be/ : SUCCESS in 2m 36s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/37/168237/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/7356df0/ : SUCCESS in 39m 14s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/37/168237/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/c950169/ : SUCCESS in 43m 51s\n- gate-python-novaclient-pypy http://logs.openstack.org/37/168237/2/check/gate-python-novaclient-pypy/9204072/ : SUCCESS in 2m 12s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/37/168237/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/2c3196d/ : SUCCESS in 53m 17s\n- check-novaclient-dsvm-functional http://logs.openstack.org/37/168237/2/check/check-novaclient-dsvm-functional/a7e011c/ : SUCCESS in 18m 06s","accounts_in_message":[],"_revision_number":2},{"id":"9e38408fa5ac81383d2588ded8b3516f1da43c74","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-03-27 15:33:54.000000000","message":"Patch Set 2:\n\nI did some poking around in the nova API, and what I found is that the \"swap\" is only included in a flavor if the V3ViewBuilder is used…but as far as I can tell, V3ViewBuilder isn\u0027t referenced anywhere, and may be a vestige of the v3 API that nova has dropped; the upshot would be that no released version of nova would ever include the \"swap\" attribute of a flavor, at least at present.  I\u0027m hoping that Christopher Yeoh or Ken\u0027ichi Ohmichi could comment on my impression, as they\u0027re quite a bit more familiar with the current state of the nova API than I am at present…","accounts_in_message":[],"_revision_number":2},{"id":"db80d392dcd21fba77884284dd5b41c606642ec4","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2015-03-27 16:17:05.000000000","message":"Patch Set 2: Code-Review-1\n\nI believe the correct place to ensure appropriate default values is on the Nova server side, not the python-novaclient.\n\nBest,\n\n-jay","accounts_in_message":[],"_revision_number":2},{"id":"8192f070a8568af672d623725646f75ef8c7d16d","author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"date":"2015-03-28 02:52:30.000000000","message":"Patch Set 2:\n\nshould i make changes on server side?","accounts_in_message":[],"_revision_number":2},{"id":"920709e948fe7e2fe1c21bf619d1aae9bdfde9ae","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-06-12 19:26:17.000000000","message":"Patch Set 2:\n\nHmmm, nobody\u0027s responded to the OP\u0027s question since March.  Sorry to have dropped the ball on you.  Anyway, I think Jay is right that defaults should be done on the nova server side.","accounts_in_message":[],"_revision_number":2},{"id":"88ef424546214b69b96967f7672aeb2ec998df96","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-07-24 21:26:40.000000000","message":"Abandoned\n\nAssuming that no further work is going to be done on this change.  If that assumption is incorrect, please feel free to re-open…","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7a1ec7ebeaa7bec906632bcfaf707e48dd14f5cb","revisions":{"5a8c5dd25736fa74a9a97df4062e9b37a1840bb1":{"kind":"REWORK","_number":1,"created":"2015-03-27 06:18:33.000000000","uploader":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"ref":"refs/changes/37/168237/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/37/168237/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/1"}}},"commit":{"parents":[{"commit":"5a6f8717f7319cbad16584a8f33044fc40493e4b","subject":"Merge \"Corrected help for nova boot when attaching block device\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a6f8717f7319cbad16584a8f33044fc40493e4b"}]}],"author":{"name":"Rajiv Kumar","email":"rajiv.kumar@nectechnologies.in","date":"2015-03-27 06:09:23.000000000","tz":330},"committer":{"name":"Rajiv Kumar","email":"rajiv.kumar@nectechnologies.in","date":"2015-03-27 06:17:39.000000000","tz":330},"subject":"Flavor list shows default value for swap field","message":"Flavor list shows default value for swap field\n\nFlavor list does not show default value for swap, if you don\u0027t\nprovide it at flavor creation time. But ephemeral field shows\ndefault value. To make \u0027nova flavor-list\u0027 display default value\nfor swap, this patch has been submitted\n\nList of objects arrived at do_flavor_list in shell.py does not\ncontains swap attribute, if value is default. I checked, if\nattribute exist or not and if it does not then i assigned \u00270\u0027\nvalue to swap attribute. Which made flavor list to display\ndefault value for swap.\n\nChange-Id: I68bba17b4c3e3cca4c6be0bd939b36f7dee1eb99\nCloses-bug: #1436763\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a8c5dd25736fa74a9a97df4062e9b37a1840bb1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a8c5dd25736fa74a9a97df4062e9b37a1840bb1"}]},"branch":"refs/heads/master"},"7a1ec7ebeaa7bec906632bcfaf707e48dd14f5cb":{"kind":"REWORK","_number":2,"created":"2015-03-27 06:22:51.000000000","uploader":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"ref":"refs/changes/37/168237/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/37/168237/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/37/168237/2"}}},"commit":{"parents":[{"commit":"5a6f8717f7319cbad16584a8f33044fc40493e4b","subject":"Merge \"Corrected help for nova boot when attaching block device\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a6f8717f7319cbad16584a8f33044fc40493e4b"}]}],"author":{"name":"Rajiv Kumar","email":"rajiv.kumar@nectechnologies.in","date":"2015-03-27 06:09:23.000000000","tz":330},"committer":{"name":"Rajiv Kumar","email":"rajiv.kumar@nectechnologies.in","date":"2015-03-27 06:22:07.000000000","tz":330},"subject":"Flavor list shows default value for swap field","message":"Flavor list shows default value for swap field\n\nFlavor list does not show default value for swap, if you don\u0027t\nprovide it at flavor creation time. But ephemeral field shows\ndefault value. To make \u0027nova flavor-list\u0027 display default value\nfor swap, this patch has been submitted\n\nList of objects arrived at do_flavor_list in shell.py does not\ncontains swap attribute, if value is default. I checked, if\nattribute exist or not and if it does not then i assigned \u00270\u0027\nvalue to swap attribute. Which made flavor list to display\ndefault value for swap.\n\nChange-Id: I68bba17b4c3e3cca4c6be0bd939b36f7dee1eb99\nCloses-bug: #1436763\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a1ec7ebeaa7bec906632bcfaf707e48dd14f5cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a1ec7ebeaa7bec906632bcfaf707e48dd14f5cb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}