)]}'
{"id":"openstack%2Fpython-novaclient~171067","triplet_id":"openstack%2Fpython-novaclient~master~I15879d56db2ec88a9bef99b6af8924ebd4ad169b","project":"openstack/python-novaclient","branch":"master","topic":"public_discover_extensions","hashtags":[],"change_id":"I15879d56db2ec88a9bef99b6af8924ebd4ad169b","subject":"Make _discover_extensions public","status":"MERGED","created":"2015-04-07 07:26:53.000000000","updated":"2015-05-06 18:34:17.000000000","submitted":"2015-05-06 18:34:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d221f42f44a8242d34ae6eef564e1087e887dd02","_number":171067,"virtual_id_number":171067,"owner":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":2,"date":"2015-05-06 18:34:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},{"value":0,"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},{"value":0,"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2015-05-06 17:49:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},{"value":0,"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},{"value":0,"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},{"value":2,"date":"2015-05-06 15:46:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2015-05-06 08:08:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":1,"date":"2015-05-06 11:19:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2015-05-06 17:49:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},{"value":0,"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},{"value":0,"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},{"value":0,"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},{"value":0,"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"value":0,"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-30 15:23:23.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2015-04-30 15:50:02.000000000","updated_by":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"reviewer":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"state":"REVIEWER"},{"updated":"2015-04-30 16:03:32.000000000","updated_by":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"reviewer":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"state":"REVIEWER"},{"updated":"2015-05-06 03:38:08.000000000","updated_by":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"reviewer":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"state":"REVIEWER"},{"updated":"2015-05-06 08:08:08.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-05-06 11:19:28.000000000","updated_by":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"reviewer":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"state":"REVIEWER"},{"updated":"2015-05-06 15:46:37.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-05-06 17:49:34.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-05-06 18:34:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6225f15c23a9e37b5baf437713e70592593c69dd","author":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"date":"2015-04-07 07:26:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc05cf52982351f6263501c9b9a75a465e1ef2c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-07 07:40:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python26/2694b55/ : SUCCESS in 1m 20s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pep8/fca5a76/ : SUCCESS in 47s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/1/check/gate-python-novaclient-docs/0db7de8//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python27/601fdf8/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python34/7c8897e/ : SUCCESS in 2m 58s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/1d5921b/ : FAILURE in 7m 51s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/95bfbc7/ : FAILURE in 7m 55s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pypy/47ddb7e/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/05cf5fc/ : FAILURE in 8m 08s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/1/check/check-novaclient-dsvm-functional/3267294/ : FAILURE in 8m 27s","accounts_in_message":[],"_revision_number":1},{"id":"97e0a96434750e74e56f104ca6a03f149a5624fd","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-04-07 15:59:53.000000000","message":"Patch Set 1: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d542e8309107eede6e6f3e175a7ec29783e1ac23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-07 17:49:12.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python26/2f1630a/ : SUCCESS in 1m 16s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pep8/46ca1bd/ : SUCCESS in 41s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/1/check/gate-python-novaclient-docs/5cab68c//doc/build/html/ : SUCCESS in 46s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python27/74bc5ff/ : SUCCESS in 1m 16s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python34/910d051/ : SUCCESS in 2m 32s\n- gate-tempest-dsvm-neutron-src-python-novaclient-icehouse http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-icehouse/1f5a598/ : FAILURE in 13m 21s\n- gate-tempest-dsvm-neutron-src-python-novaclient-juno http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-juno/07f7cdb/ : FAILURE in 14m 23s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pypy/8830d8e/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/e062ae4/ : FAILURE in 50m 24s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/1/check/check-novaclient-dsvm-functional/9390a78/ : SUCCESS in 18m 31s","accounts_in_message":[],"_revision_number":1},{"id":"dfdad7f50755ae234ce3e6db3ce4f720699b2d38","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-04-10 08:59:56.000000000","message":"Patch Set 1: Code-Review-1\n\nImo, shell methods should not be used outside novaclient, so I prefer to move discover methods from shell to novaclient.client module.","accounts_in_message":[],"_revision_number":1},{"id":"c327b751f300823aa95d4d97641dc1549278b0ca","author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"date":"2015-04-15 16:15:26.000000000","message":"Patch Set 1: Code-Review-1\n\nLooks like heat use now this method: https://github.com/openstack/heat/blob/master/heat/engine/clients/os/nova.py#L66\nusage of private method definitely shouldn\u0027t be, but this patch shouldn\u0027t be merged while it breaks heat","accounts_in_message":[],"_revision_number":1},{"id":"af93ecb6ed8bee6bdfbfe9df81b0a16477e0fea0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-04-21 00:33:07.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"2530326f5f1a802cf659d54d6b8fdef80e494630","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-21 01:57:46.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python26/fff4b6b/ : SUCCESS in 1m 26s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pep8/ccd6280/ : SUCCESS in 42s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/1/check/gate-python-novaclient-docs/bd2c97d//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python27/ef9934b/ : SUCCESS in 1m 20s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-python34/4faed12/ : SUCCESS in 2m 44s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/1/check/gate-python-novaclient-pypy/4124b13/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/d5cbef6/ : FAILURE in 51m 54s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/1/check/check-novaclient-dsvm-functional/a4c4407/ : SUCCESS in 19m 40s","accounts_in_message":[],"_revision_number":1},{"id":"6e24208f3c4018f9bf1cf64eae84e87b07615adb","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2015-04-30 15:23:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c2a99684ab787456e1435523120b94bb600f3b26","author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"date":"2015-04-30 15:50:02.000000000","message":"Patch Set 1: Code-Review-1\n\nAs heat uses this method, there are should be dependent patch to heat","accounts_in_message":[],"_revision_number":1},{"id":"50af0321f865384005c99bed8b696b948d66db37","author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"date":"2015-04-30 16:03:32.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"48696e55482ed23aa1f741c78af5b155c42deeb0","author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"date":"2015-04-30 16:04:16.000000000","message":"Patch Set 1:\n\nAgree with Eugeniya Kudryashova","accounts_in_message":[],"_revision_number":1},{"id":"fb6a932474e269e85427d5c12b38769980223f67","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-01 21:56:51.000000000","message":"Patch Set 1:\n\nHm, this is circular. The gate-tempest-dsvm-neutron-src-python-novaclient job fails because the heat client tempest uses can\u0027t find _discover_extensions:\n\nhttp://logs.openstack.org/67/171067/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/d5cbef6/console.html.gz#_2015-04-21_01_57_07_053\n\nI was thinking maybe we could add discover_extensions as an additional function that calls _discover_extensions for now, then patch heat, then remove _discover_extensions.","accounts_in_message":[],"_revision_number":1},{"id":"e38b3abc19c344eae988a18b7f7a8247e5b8f8f0","author":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"date":"2015-05-04 01:23:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"96549c275e3a9361cbb3b81d0272a0992b883617","author":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"date":"2015-05-04 01:25:25.000000000","message":"Patch Set 2:\n\nChanged as melanie suggested.","accounts_in_message":[],"_revision_number":2},{"id":"28554f1df972eb345e365fcb457027e6a8b06278","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-04 02:27:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/2/check/gate-python-novaclient-python26/7711106/ : FAILURE in 1m 29s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/2/check/gate-python-novaclient-pep8/d669ba2/ : SUCCESS in 51s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/2/check/gate-python-novaclient-docs/468b729//doc/build/html/ : SUCCESS in 58s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/2/check/gate-python-novaclient-python27/3525b0a/ : FAILURE in 1m 37s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/2/check/gate-python-novaclient-python34/b7925be/ : FAILURE in 3m 48s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/2/check/gate-python-novaclient-pypy/322ed03/ : FAILURE in 2m 45s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/2/check/gate-tempest-dsvm-neutron-src-python-novaclient/77abae3/ : SUCCESS in 1h 04m 41s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/2/check/check-novaclient-dsvm-functional/63b7cf7/ : SUCCESS in 20m 42s","accounts_in_message":[],"_revision_number":2},{"id":"e6af8b25c64c66422f12836e8fba0b9ca2980be5","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-04 15:38:35.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"78b224a6d6335dd701b1b543b10e7239b510a5dc","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-04 17:39:37.000000000","message":"Patch Set 2:\n\nWhat Kevin said. And also, I think I should have reversed what I said, change _discover_extensions to discover_extensions (like your original change) and then have _discover_extensions call discover_extensions. That way the followup change after patching heat will be to simply remove the _discover_extensions block.","accounts_in_message":[],"_revision_number":2},{"id":"148cf5cfd911cf4d19f7dde4963fc8b42f49e1ca","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-05-05 09:42:15.000000000","message":"Patch Set 2: Code-Review-1\n\nStill -1 from me. Such public function should be outside novaclient.shell module(novaclient.client or novaclient.utils are better places).","accounts_in_message":[],"_revision_number":2},{"id":"fd54c1a845c806fb22bcfacf466fd06982dd5a5d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-05 19:18:49.000000000","message":"Patch Set 2:\n\nAndrey, I agree it would be ideal to move them. I think they would be better to go under novaclient/utils.py though, since extensions is a kwarg passed to the client (when I look at the heat code). Else they have to be staticmethods in novaclient/client.py.","accounts_in_message":[],"_revision_number":2},{"id":"2b37f83231501a3cb65db2e800ce3fccb5987735","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-05-05 19:44:47.000000000","message":"Patch Set 2:\n\nOn the one hand, novaclient.utils is a right place, since _discover_extensions methods look like utils, but on the other hand, novaclient.client module is used as entry point to novaclient across all projects and it would be nice if we reduce number of imports required to use novaclient.\n\nIt does not matter what module will be chosen from proposed, I\u0027ll be satisfied:)","accounts_in_message":[],"_revision_number":2},{"id":"3b53e3e8c39f0fc3747095f54aedfd9876e0a916","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-05 21:09:58.000000000","message":"Patch Set 2:\n\nHm, yeah. Statics in client.py might be better then, to avoid the extra imports and the extensions are directly related to the client object","accounts_in_message":[],"_revision_number":2},{"id":"5519fd1f63c38cd378d514c32609f8e2f1519505","author":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"date":"2015-05-06 03:49:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"25a9da65852c653c262dbe8e0fc87e364c554b5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 04:42:35.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/3/check/gate-python-novaclient-python26/b07a727/ : FAILURE in 1m 34s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/3/check/gate-python-novaclient-pep8/01747db/ : SUCCESS in 1m 07s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/3/check/gate-python-novaclient-docs/6e3c928//doc/build/html/ : SUCCESS in 1m 22s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/3/check/gate-python-novaclient-python27/f02dc82/ : FAILURE in 1m 54s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/3/check/gate-python-novaclient-python34/48f960c/ : FAILURE in 3m 41s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/3/check/gate-python-novaclient-pypy/2fe1377/ : FAILURE in 2m 38s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/c9ad732/ : SUCCESS in 52m 55s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/3/check/check-novaclient-dsvm-functional/c832316/ : SUCCESS in 18m 36s","accounts_in_message":[],"_revision_number":3},{"id":"5691ebd70220148c19d060bae665a5a51b2fe5c1","author":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"date":"2015-05-06 06:11:14.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"61162e416461735b7ce500210b21b0bcab163715","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 07:01:10.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/4/check/gate-python-novaclient-python26/103d371/ : SUCCESS in 2m 24s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/4/check/gate-python-novaclient-pep8/b925ec8/ : SUCCESS in 55s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/4/check/gate-python-novaclient-docs/3bb041e//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/4/check/gate-python-novaclient-python27/9a32fce/ : SUCCESS in 1m 41s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/4/check/gate-python-novaclient-python34/ad9675b/ : SUCCESS in 3m 54s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/4/check/gate-python-novaclient-pypy/51c91a0/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/4/check/gate-tempest-dsvm-neutron-src-python-novaclient/3dc14aa/ : SUCCESS in 49m 48s\n- check-novaclient-dsvm-functional http://logs.openstack.org/67/171067/4/check/check-novaclient-dsvm-functional/42871ad/ : SUCCESS in 16m 03s","accounts_in_message":[],"_revision_number":4},{"id":"3c2e2182b55f8be5cced95fbcdbc677e01065a18","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-05-06 08:08:08.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"904ee99364a239492198812258cf6e96db1bf822","author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"date":"2015-05-06 11:19:28.000000000","message":"Patch Set 4: Code-Review+1\n\nLooks good now, thanks!","accounts_in_message":[],"_revision_number":4},{"id":"21eb19cff4eb66e95382781d6a35aae61f483c75","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-06 15:46:37.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"6a3d2808bc7dc6ab50df12c1a051ba5e76e75eb4","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-06 17:49:34.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nLooks good, thanks for working on this","accounts_in_message":[],"_revision_number":4},{"id":"3e5796bd8fb167ddbbb1e5bf69fe30778d69d06d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 17:49:45.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"54cd3123aff18be3c4a4dfa16f7f8c32e35ecb31","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 18:34:13.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/67/171067/4/gate/gate-python-novaclient-python26/b6f3e2a/ : SUCCESS in 1m 28s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/67/171067/4/gate/gate-python-novaclient-docs/5ee1ce9//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-novaclient-pep8 http://logs.openstack.org/67/171067/4/gate/gate-python-novaclient-pep8/18849cb/ : SUCCESS in 59s\n- gate-python-novaclient-python27 http://logs.openstack.org/67/171067/4/gate/gate-python-novaclient-python27/3b123f0/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/67/171067/4/gate/gate-python-novaclient-python34/ca075f1/ : SUCCESS in 3m 32s\n- gate-python-novaclient-pypy http://logs.openstack.org/67/171067/4/gate/gate-python-novaclient-pypy/ae25065/ : SUCCESS in 2m 37s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/67/171067/4/gate/gate-tempest-dsvm-neutron-src-python-novaclient/79703be/ : SUCCESS in 44m 17s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/67/171067/4/gate/gate-novaclient-dsvm-functional/de74f9a/ : SUCCESS in 15m 32s","accounts_in_message":[],"_revision_number":4},{"id":"ccde923515095478b1339ac43a053d1dad3d4549","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-06 18:34:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"02c04c5658dcd968b91f7256b749755abb9d2074","revisions":{"4eb84f2e3176841a1fe977a622e31a7ea41ead80":{"kind":"REWORK","_number":1,"created":"2015-04-07 07:26:53.000000000","uploader":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"ref":"refs/changes/67/171067/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/171067/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/1"}}},"commit":{"parents":[{"commit":"3681c186f784b0b64f871050a0dfdb3b1bed37b8","subject":"Merge \"Combine test cases for checking nova limits response\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3681c186f784b0b64f871050a0dfdb3b1bed37b8"}]}],"author":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-04-07 07:23:14.000000000","tz":480},"committer":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-04-07 07:26:47.000000000","tz":480},"subject":"Make _discover_extensions public","message":"Make _discover_extensions public\n\nHeat uses `novaclient.shell.OpenStackComputeShell._discover_extensions`\nfunction, which is private currently. It\u0027s better to change this method\nto public for public use.\n\nChange-Id: I15879d56db2ec88a9bef99b6af8924ebd4ad169b\nCloses-bug: #1440779\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4eb84f2e3176841a1fe977a622e31a7ea41ead80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4eb84f2e3176841a1fe977a622e31a7ea41ead80"}]},"branch":"refs/heads/master"},"340d3a659ec7fb5f1862a6788810d043ecc3b557":{"kind":"REWORK","_number":2,"created":"2015-05-04 01:23:09.000000000","uploader":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"ref":"refs/changes/67/171067/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/171067/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/2"}}},"commit":{"parents":[{"commit":"2a7c2f14c2cf55db590a58704192497fbd48e2b5","subject":"Merge \"Don\u0027t lookup service url when bypass_url is given\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2a7c2f14c2cf55db590a58704192497fbd48e2b5"}]}],"author":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-04-07 07:23:14.000000000","tz":480},"committer":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-05-04 01:22:54.000000000","tz":480},"subject":"Make _discover_extensions public","message":"Make _discover_extensions public\n\nHeat uses `novaclient.shell.OpenStackComputeShell._discover_extensions`\nfunction, which is private currently. It\u0027s better to change this method\nto public for public use.\n\nChange-Id: I15879d56db2ec88a9bef99b6af8924ebd4ad169b\nCloses-bug: #1440779\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/340d3a659ec7fb5f1862a6788810d043ecc3b557"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/340d3a659ec7fb5f1862a6788810d043ecc3b557"}]},"branch":"refs/heads/master"},"7103913bcf37341bf82c4ea406ba38a565a817c7":{"kind":"REWORK","_number":3,"created":"2015-05-06 03:49:29.000000000","uploader":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"ref":"refs/changes/67/171067/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/171067/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/3"}}},"commit":{"parents":[{"commit":"2a7c2f14c2cf55db590a58704192497fbd48e2b5","subject":"Merge \"Don\u0027t lookup service url when bypass_url is given\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2a7c2f14c2cf55db590a58704192497fbd48e2b5"}]}],"author":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-04-07 07:23:14.000000000","tz":480},"committer":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-05-06 03:48:31.000000000","tz":480},"subject":"Make _discover_extensions public","message":"Make _discover_extensions public\n\nHeat uses `novaclient.shell.OpenStackComputeShell._discover_extensions`\nfunction, which is private currently. It\u0027s better to change this method\nto public for public use.\n\nChange-Id: I15879d56db2ec88a9bef99b6af8924ebd4ad169b\nCloses-bug: #1440779\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7103913bcf37341bf82c4ea406ba38a565a817c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7103913bcf37341bf82c4ea406ba38a565a817c7"}]},"branch":"refs/heads/master"},"02c04c5658dcd968b91f7256b749755abb9d2074":{"kind":"REWORK","_number":4,"created":"2015-05-06 06:11:14.000000000","uploader":{"_account_id":3191,"name":"Kylin CG","email":"kylin7.sg@gmail.com","username":"kylin7-sg"},"ref":"refs/changes/67/171067/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/67/171067/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/67/171067/4"}}},"commit":{"parents":[{"commit":"2a7c2f14c2cf55db590a58704192497fbd48e2b5","subject":"Merge \"Don\u0027t lookup service url when bypass_url is given\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2a7c2f14c2cf55db590a58704192497fbd48e2b5"}]}],"author":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-04-07 07:23:14.000000000","tz":480},"committer":{"name":"kylin7-sg","email":"kylin7.sg@gmail.com","date":"2015-05-06 06:10:59.000000000","tz":480},"subject":"Make _discover_extensions public","message":"Make _discover_extensions public\n\nHeat uses `novaclient.shell.OpenStackComputeShell._discover_extensions`\nfunction, which is private currently. It\u0027s better to change this method\nto public for public use.\n\nChange-Id: I15879d56db2ec88a9bef99b6af8924ebd4ad169b\nCloses-bug: #1440779\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/02c04c5658dcd968b91f7256b749755abb9d2074"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/02c04c5658dcd968b91f7256b749755abb9d2074"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}