)]}'
{"novaclient/tests/functional/test_readonly_nova.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0b0b4b3aa8e83c5a16c22a79dce0438f5cd86820","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.nova(\u0027volume-type-list\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_admin_help(self):"},{"line_number":145,"context_line":"        self.nova(\u0027help\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_admin_list_extensions(self):"},{"line_number":148,"context_line":"        self.nova(\u0027list-extensions\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_b67320e7","line":145,"updated":"2015-05-01 05:08:48.000000000","message":"Note this test is also about testing the help command. I suggest to name the new test on L168 something more descriptive, like \"test_help_output\" for example","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a4e3cb2262d959e42e42d7ba1d92cbf1096a76a9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.nova(\u0027volume-type-list\u0027)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_admin_help(self):"},{"line_number":145,"context_line":"        self.nova(\u0027help\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_admin_list_extensions(self):"},{"line_number":148,"context_line":"        self.nova(\u0027list-extensions\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_b10faa2d","line":145,"in_reply_to":"3acd31a7_b67320e7","updated":"2015-05-28 09:12:59.000000000","message":"Valuable input, will do in next thanks :)","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0b0b4b3aa8e83c5a16c22a79dce0438f5cd86820","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def test_bash_completion(self):"},{"line_number":166,"context_line":"        self.nova(\u0027bash-completion\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_nova_help(self):"},{"line_number":169,"context_line":"        help_text \u003d self.nova(\u0027help\u0027)"},{"line_number":170,"context_line":"        lines \u003d help_text.split(\u0027\\n\u0027)"},{"line_number":171,"context_line":"        self.assertFirstLineStartsWith(lines, \u0027usage: nova\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_36671027","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":22},"updated":"2015-05-01 05:08:48.000000000","message":"I think this could be named better. See comment on L144.","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a4e3cb2262d959e42e42d7ba1d92cbf1096a76a9","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def test_bash_completion(self):"},{"line_number":166,"context_line":"        self.nova(\u0027bash-completion\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_nova_help(self):"},{"line_number":169,"context_line":"        help_text \u003d self.nova(\u0027help\u0027)"},{"line_number":170,"context_line":"        lines \u003d help_text.split(\u0027\\n\u0027)"},{"line_number":171,"context_line":"        self.assertFirstLineStartsWith(lines, \u0027usage: nova\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_911eee61","line":168,"in_reply_to":"3acd31a7_36671027","updated":"2015-05-28 09:12:59.000000000","message":"Thanks :) will be done in next patch.","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0b0b4b3aa8e83c5a16c22a79dce0438f5cd86820","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        wanted_commands \u003d set((\u0027absolute-limits\u0027, \u0027fixed-ip-get\u0027,"},{"line_number":184,"context_line":"                               \u0027dns-domains\u0027, \u0027fixed-ip-reserve\u0027,"},{"line_number":185,"context_line":"                               \u0027flavor-show\u0027, \u0027host-describe\u0027, \u0027help\u0027))"},{"line_number":186,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Optional arguments:"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_5064d420","line":186,"updated":"2015-05-01 05:08:48.000000000","message":"I don\u0027t think this is working as intended. This statement is evaluating to false, even though the set is not empty. \n\nThis is assuming I understand what you\u0027re trying to do. The set \"commands\" is going to be large, many more commands than you have listed in \"wanted_commands.\" It appears you are doing a set difference to verify that \u0027nova help\u0027 is listing the commands we expect.\n\nTo test for empty set, you can do:\n\n self.assertEqual(0, len(wanted_commands - commands))\n\nBut locally I did this which shows the difference, which would aid in debugging when a developer adds a new command to novaclient and finds this test failing because they didn\u0027t add the command name here:\n\n self.assertEqual(wanted_commands, commands)","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"a4e3cb2262d959e42e42d7ba1d92cbf1096a76a9","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        wanted_commands \u003d set((\u0027absolute-limits\u0027, \u0027fixed-ip-get\u0027,"},{"line_number":184,"context_line":"                               \u0027dns-domains\u0027, \u0027fixed-ip-reserve\u0027,"},{"line_number":185,"context_line":"                               \u0027flavor-show\u0027, \u0027host-describe\u0027, \u0027help\u0027))"},{"line_number":186,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Optional arguments:"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_9e9ec6b6","line":186,"in_reply_to":"3acd31a7_5064d420","updated":"2015-05-28 09:12:59.000000000","message":"This think implementation is correct. If we are talking about debugging and others when adding new tests, then we should take care of this also.\n\nBut in case of master this is valid I think.","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"21e6fde4987917487dfb285bb2424767f40fa5fc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        wanted_commands \u003d set((\u0027absolute-limits\u0027, \u0027fixed-ip-get\u0027,"},{"line_number":184,"context_line":"                               \u0027dns-domains\u0027, \u0027fixed-ip-reserve\u0027,"},{"line_number":185,"context_line":"                               \u0027flavor-show\u0027, \u0027host-describe\u0027, \u0027help\u0027))"},{"line_number":186,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Optional arguments:"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_7650b532","line":186,"in_reply_to":"7a016987_9e9ec6b6","updated":"2015-05-28 21:00:43.000000000","message":"I must be missing your intention then. Can you explain what this test aims to do?","commit_id":"3356ecb20d3d7c9f7309af26c507f1c844cec6cc"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"93f83616d36da364d4d03529bf290e09cd5e4d2c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        wanted_commands \u003d set((\u0027absolute-limits\u0027, \u0027fixed-ip-get\u0027,"},{"line_number":177,"context_line":"                               \u0027dns-domains\u0027, \u0027fixed-ip-reserve\u0027,"},{"line_number":178,"context_line":"                               \u0027flavor-show\u0027, \u0027host-describe\u0027, \u0027help\u0027))"},{"line_number":179,"context_line":"        self.assertFalse(wanted_commands - commands)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    # Optional arguments:"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_42cdc82f","line":179,"updated":"2015-05-29 20:24:59.000000000","message":"What exactly is your intention with this test?  Do you want to check that wanted_commands and commands are the same?  If so, I\u0027d vastly prefer you use an assertEqual() here.  If, on the other hand, you\u0027re simply wanting to ensure that all elements of wanted_commands are listed in commands, I\u0027d suggest including the \u0027msg\u0027 parameter to the assertFalse() to explain that.","commit_id":"905076f359b7052841838a0707314453bc3d899e"}]}