)]}'
{"novaclient/shell.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b7465e2e1b633c3236d411e9969523bc3b71ffb0","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_99208c4b","line":686,"updated":"2015-04-17 02:29:05.000000000","message":"Emm... this is just fix the command line. What about user use novaclient.v2.client.Client directly?","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"eac2049bcfdfa728e186344e63e3d7a1ae0e28ab","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_334648c0","line":686,"in_reply_to":"3ab451fb_3263cd1c","updated":"2015-04-19 12:26:41.000000000","message":"Yea, I think we should fixed it in novaclient/v3/versions.py\n\nI just quick write as below:\n\nfrom six.moves import urllib\n\ndef list(self):\n\n   endpoint \u003d self.api.client.get_endpoint()\n\n   url \u003d urllib.parse.urlparse(endpoint)\n\n   return self._list(\u0027%s://%s/\u0027 % (url.scheme, url.netloc), \"versions\")\n\nDoes make sense to you?","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"724fa4ce1d68ee56bf777dd86c03de0ccf76f189","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_3263cd1c","line":686,"in_reply_to":"3ab451fb_72903596","updated":"2015-04-17 05:27:14.000000000","message":"Maybe you mean we need to change novaclient/v2/versions.py and make it use client.Client instead of changing shell.py, right?","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"60c2275fac7766791adc5e0886b92258ee7e90ba","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_d9e614e8","line":686,"in_reply_to":"3ab451fb_99208c4b","updated":"2015-04-17 02:40:57.000000000","message":"@Alex\n\nThanks for reviewing, but I could not understand your comment correctly.\nThat means here should call novaclient.v2.client.Client instead of setting False as use_session?","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c62226887606dc0025840cbb50dab8e5a4f1a0e9","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_72903596","line":686,"in_reply_to":"3ab451fb_d9e614e8","updated":"2015-04-17 04:46:49.000000000","message":"I mean use client as SDK. Use client as this comment https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/client.py#L71\n\nAs my understand it\u0027s not controlled by \u0027use_session\u0027.","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"863289489d35c0e22367fdda6ac1a72f468ea265","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        # SessionClient is based on the endpoint \"/v2/{project-id}/...\"."},{"line_number":684,"context_line":"        # So use_session should be False here."},{"line_number":685,"context_line":"        if \u0027version-list\u0027 in argv:"},{"line_number":686,"context_line":"            use_session \u003d False"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # FIXME(usrleon): Here should be restrict for project id same as"},{"line_number":689,"context_line":"        # for os_username or os_password but for compatibility it is not."}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_7323a006","line":686,"in_reply_to":"dac4157f_334648c0","updated":"2015-04-19 12:34:43.000000000","message":"oops, sorry, \"novaclient/v3/versions.py\" should be \"novaclient/v2/versions.py\"","commit_id":"cb3cb8902dcd0daa0f320e1d9468811e6a3c850b"}],"novaclient/v2/versions.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ebe7203d1cea397efd5e2b3f7cf92825f1deaba9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def list(self):"},{"line_number":36,"context_line":"        \"\"\"List all versions.\"\"\""},{"line_number":37,"context_line":"        endpoint \u003d self.api.client.get_endpoint()"},{"line_number":38,"context_line":"        url \u003d urllib.parse.urlparse(endpoint)"},{"line_number":39,"context_line":"        return self._list(\u0027%s://%s/\u0027 % (url.scheme, url.netloc), \"versions\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_51aacf71","line":38,"updated":"2015-04-21 01:02:54.000000000","message":"It\u0027s better to add note to explain why we doing like this","commit_id":"58f18f5c06aa8fab6ea05d1e7437cc96c522d780"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"10da6214a2097c1e2c24d003bb1dcfa001e3135b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # etc.) and a hostname."},{"line_number":41,"context_line":"        endpoint \u003d self.api.client.get_endpoint()"},{"line_number":42,"context_line":"        url \u003d urllib.parse.urlparse(endpoint)"},{"line_number":43,"context_line":"        return self._list(\u0027%s://%s/\u0027 % (url.scheme, url.netloc), \"versions\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab921fb_8a6ac97f","line":43,"updated":"2015-04-26 01:05:52.000000000","message":"oops, I forget test the HTTPClient. How about we add some code like this:\n\nversion_url \u003d None\n\nIf  isinstance(self.api.client, client.SessionClient):\n\n    endpoint \u003d self.api.client.get_endpoint()\n    url \u003d urllib.parse.urlparse(endpoint)\n    version_url \u003d \u0027%s://%s/\u0027 % (url.scheme, url.netloc)\n\nreturn self._list(version_url, \"vresions\")","commit_id":"98d069bce9382e7212e262be2ed8fdbd79ee163c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a4d382d797f723e5ac15ca17cf7aeef9183f8f2e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # etc.) and a hostname."},{"line_number":41,"context_line":"        endpoint \u003d self.api.client.get_endpoint()"},{"line_number":42,"context_line":"        url \u003d urllib.parse.urlparse(endpoint)"},{"line_number":43,"context_line":"        return self._list(\u0027%s://%s/\u0027 % (url.scheme, url.netloc), \"versions\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab921fb_ac97e246","line":43,"in_reply_to":"bab921fb_8a6ac97f","updated":"2015-04-27 04:42:15.000000000","message":"Nice idea, thanks!","commit_id":"98d069bce9382e7212e262be2ed8fdbd79ee163c"}]}