)]}'
{"id":"openstack%2Fpython-novaclient~180234","triplet_id":"openstack%2Fpython-novaclient~master~Ia83bc16a676e1cd7d91577661b0d3bb4a24c693f","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"Ia83bc16a676e1cd7d91577661b0d3bb4a24c693f","subject":"Add qualifier \"Rackspace-specific feature\u0027 to agent help","status":"ABANDONED","created":"2015-05-05 17:00:17.000000000","updated":"2015-07-06 13:49:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"57e76d5be1edab56d9a564f00151ae2b5d33d53a","_number":180234,"virtual_id_number":180234,"owner":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"date":"2015-05-05 20:57:15.000000000","_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2015-05-05 22:59:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"date":"2015-05-05 18:31:06.000000000","_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"date":"2015-05-05 19:26:38.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"all":[{"value":-1,"date":"2015-05-05 20:11:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2015-05-05 21:14:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":-1,"date":"2015-05-05 18:26:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-05-05 18:38:38.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"date":"2015-05-05 18:38:57.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-05 17:03:34.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2015-05-05 17:23:19.000000000","updated_by":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"reviewer":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"state":"REVIEWER"},{"updated":"2015-05-05 18:26:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2015-05-05 18:38:38.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-05-05 18:38:57.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-05-05 19:26:38.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-05-05 20:57:15.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-05-05 21:14:49.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2015-05-05 22:59:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7d41879798b92b653ff0959d22e9904be0e3592d","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 17:00:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1115c189f4459f0f3457646d4a95c0ff9e10b0f9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-05 17:03:34.000000000","message":"Patch Set 1:\n\nI\u0027d suggest rephrasing these as \"(Rackspace-specific feature)\" instead of \"-- this is only for Rackspace\"…","accounts_in_message":[],"_revision_number":1},{"id":"eebf2a5a8e2852ebc4bc8762a026f57efcfc8ede","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-05 17:05:22.000000000","message":"Patch Set 1:\n\nworks for me","accounts_in_message":[],"_revision_number":1},{"id":"bf8be8114bff9954450f65b5af95ab850cb1186e","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 17:05:49.000000000","message":"Patch Set 1:\n\nI can do that. Thanks Kevin.","accounts_in_message":[],"_revision_number":1},{"id":"40a90070b5838360ac16525dd050073635a1c5f9","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 17:15:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f2398f518edc40b43c6c9b82f813372ad38da3fa","author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"date":"2015-05-05 17:23:19.000000000","message":"Patch Set 2: Code-Review+1\n\nGood clarification.","accounts_in_message":[],"_revision_number":2},{"id":"9a4d4180dabf40aab18cd8694ad9ce72d1843bef","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 17:26:20.000000000","message":"Patch Set 3: Commit message was updated","accounts_in_message":[],"_revision_number":3},{"id":"3f9db5d528ffab1fff058d0542b94412f4dc66e2","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-05 18:08:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8659565c41a5840c3d68eff48ec9feda7302e762","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 18:26:24.000000000","message":"Patch Set 3: Code-Review-1\n\nAnita, the below comments are directed at the fact that we have these at all, not you:\n\nCan we just drop these features from the client? I think it\u0027s extremely confusing for them to be here, and especially annotated as such.\n\nCan I add an HP-specific API here if I annotate it? If not, why not? RAX has some!","accounts_in_message":[],"_revision_number":3},{"id":"4f85f496474ff67d4e3aa0bae8f62548a9dd3e22","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-05 18:28:30.000000000","message":"Patch Set 3:\n\nDan I am all for dropping this from the client as it is misleading. But lets get some input from one or two rackspace devs first.","accounts_in_message":[],"_revision_number":3},{"id":"593c4968ab1d9691a145a51769b12a898dc7ffc7","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 18:29:36.000000000","message":"Patch Set 3:\n\nWell, I\u0027m pretty sure they\u0027d like them to stay and be annotated, but.. sure :)\n\nMaybe we should get some HP input too, or is that you? :D","accounts_in_message":[],"_revision_number":3},{"id":"50dcabc3bf909b6f0de9cc2c1a5c22bf95c05f7a","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 18:31:06.000000000","message":"Patch Set 3:\n\nMy motivation is to improve the user experience (mine) however that comes about. Thanks for letting me know the basis for your -1, Dan. If removing them is the way to go I will happily abandon this patch.","accounts_in_message":[],"_revision_number":3},{"id":"64b948271a227d57130e8e884195f600488b4966","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-05 18:31:44.000000000","message":"Patch Set 3:\n\nif we remove this lets at least make sure they are aware we are doing it.","accounts_in_message":[],"_revision_number":3},{"id":"26e17dbe9c20e3af41251d3a6a4cc1417ebd28fe","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 18:31:47.000000000","message":"Patch Set 3:\n\nAnita, please don\u0027t abandon it just change it to drop the things if that\u0027s what we decide :)","accounts_in_message":[],"_revision_number":3},{"id":"9a7f32bf6c3b9d07f4b3d4408348e698a3b1d74d","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 18:41:00.000000000","message":"Patch Set 3:\n\n/me stands by for a decision","accounts_in_message":[],"_revision_number":3},{"id":"cc17b5ded1327d005c86b9ef10ddb1a8340cf53a","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-05-05 19:26:38.000000000","message":"Patch Set 3:\n\nSo... I think our deprecation policy would mean what we really should do is deprecate for removal instead of a straight delete. That being said, I agree with Joe that we should be nice about this and figure out how much that\u0027s going to hurt RAX to yank this.","accounts_in_message":[],"_revision_number":3},{"id":"0bef2a7d17d59d782960c6da6d8f8e5c1944901d","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 19:32:33.000000000","message":"Patch Set 3:\n\nI didn\u0027t really mean to imply that we should drop-drop it in a single patch in my response to anita, hence the smiley.\n\nBut yeah, I think this should be marked as deprecated instead of RAX-specific and then dropped at some point. Not sure when that happens on the client given the epoch-less nature of it.\n\nIn the API discussions, it sounded like RAX was going to get everything they needed into v2.1 eventually. So maybe we actually drop this when we drop v2 from the server side?","accounts_in_message":[],"_revision_number":3},{"id":"a17ded8e1d0431d9f0979056a6010146c69d5d5c","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-05-05 20:11:56.000000000","message":"Patch Set 3: Code-Review-1\n\nI don\u0027t think it\u0027s accurate to say that this is Rackspace specific, though I can understand why it seems that way.  The agent API and code to interface with a guest agent is all in Nova.  There is however no official OpenStack agent, and Rackspace does have an opensource agent which is what I suspect most people would use.  Additionally this functionally is only fully implemented for the xenapi virt driver and it\u0027s possible that Rackspace is the only public cloud that provides it.\n\nI would be in favor of removing the current Nova API and offering the functionality via a separate admin endpoint, but I think getting to a point like that is a ways off.  But as long as this API extension is in Nova it needs to stay in the client.","accounts_in_message":[],"_revision_number":3},{"id":"cccadb10d64c9b096eb3c427498605c0fe0289af","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-05 20:15:57.000000000","message":"Patch Set 3:\n\nI\u0027m a user, I know zip about nova. I ask nova help for some help. I see nova agent. I look it up, wasting a lot of time. Finally ask some people what it is. Turns out if I\u0027m not Rackspace I can\u0027t use it.\n\nAs a user I would like the nova help to tell me that to save me time. Or not have it there, either is fine with me.","accounts_in_message":[],"_revision_number":3},{"id":"525f0f56fb8e18e4e6349cae7a83968eb54d5711","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 20:16:12.000000000","message":"Patch Set 3:\n\nOh, this is *that* agent. For some reason I thought this was related to the weirdo auth/regions/whatever stuff.\n\nSo this is indeed not RAX-specific and at worse, only \"implemented by one virt driver\". However, we (sadly) have lots of those sorts of features.\n\nIn summary, I don\u0027t think we need this annotation (nor one for being xen-specific) so I think this should just be abandoned.","accounts_in_message":[],"_revision_number":3},{"id":"05f36077b04d368440eb2a529c86f7bc9c5629b7","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-05-05 20:18:10.000000000","message":"Patch Set 3:\n\nAnita: A private cloud could offer this funtionality, there\u0027s nothing Rackspace specific about it except that we might be the only public cloud to have it.","accounts_in_message":[],"_revision_number":3},{"id":"40f7b48e316e5c33c0f523ccdc4d586239b9afee","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-05-05 20:53:48.000000000","message":"Patch Set 3:\n\nok, so I get not removing it, it\u0027s part of the Nova API.\n\nHowever, it\u0027s an interface with no upstream implementation, and a rax opensource (but not openstack owned) one. I\u0027m not sure how that doesn\u0027t warrant annotation?","accounts_in_message":[],"_revision_number":3},{"id":"aa99c141ee9f02652712228bfc98ddd29ca53697","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-05 20:57:15.000000000","message":"Patch Set 3:\n\nAnd here\u0027s the doc for the os-agents API:\n\nhttp://developer.openstack.org/api-ref-compute-v2-ext.html#os-agents\n\nIt does mention only Xen has an implementation, so at best we could say Xen-specific. That said, there are a number of commands that only work for nova-network (security group default rules) or neutron (tenant networks) and aren\u0027t annotated that way as of yet.","accounts_in_message":[],"_revision_number":3},{"id":"fd02dc54ccc08ca0aceaededffa686582a8fafba","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 20:57:23.000000000","message":"Patch Set 3:\n\nIt\u0027s not a RAX concept, it\u0027s a xenserver one, IIRC. I think there is some generic xen agent you can run, or the openstacky rackspace one, or anything else, if I recall correctly.\n\nI think this just actually lets you manage the presence and version of an executable in the image, and has nothing actually to do with nova or rackspace, or anything. Is that right, RAX peoples?","accounts_in_message":[],"_revision_number":3},{"id":"7603a9fa6aa0fd71dcd41b56ced3e0ead4e85444","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 20:59:50.000000000","message":"Patch Set 3:\n\nI\u0027m specifically -2 on annotating commands in the client as $virt-specific because we\u0027re supposed to be aiming for virt-independent operation here. Noting that \"at the time this version of the client was released only $virt driver supported this thing\" is neither timeless nor should it be required knowledge for the user.\n\nWe could totally implement the libvirt side of this if we wanted it. Magnum has prescribed using a specific agent inside a nova guest, which could, AFAIK, use this mechanism to do so.","accounts_in_message":[],"_revision_number":3},{"id":"4ac07b3eb504987388874188603a380731755ef6","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-05 21:14:49.000000000","message":"Patch Set 3: -Code-Review\n\nwhatever  we decide,  I think its safe to say the current help message is  useless.\n\nDo we just include a link to http://developer.openstack.org/api-ref-compute-v2-ext.html#os-agents ? etc?","accounts_in_message":[],"_revision_number":3},{"id":"7293d780a467327fb0e322fd7cbae2db4999f549","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-05 21:24:27.000000000","message":"Patch Set 3:\n\nCould we maybe say \"(hypervisor-specific feature)\" same way the api reference doc does?","accounts_in_message":[],"_revision_number":3},{"id":"7a48414b35defd054799ab1f3a408f46bbb17e91","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-05 21:28:39.000000000","message":"Patch Set 3:\n\nAre we going to do that for all features that are currently hypervisor-specific?\n\nI think the problem is: Anita tripped over this one rather oddball feature, and I failed to read much of the code to see that it was the os-agents stuff and jumped the gun.\n\nI expect that if she had tripped over something slightly less obscure (like swap volume or something) that only works on a subset of drivers, we\u0027d be writing it off as just a mistake.","accounts_in_message":[],"_revision_number":3},{"id":"c44a696b662fd3a683a5612e388dee8d2a494528","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-05 22:59:00.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python26/b8de9f1/ : SUCCESS in 1m 41s\n- gate-python-novaclient-pep8 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-pep8/9a90fde/ : SUCCESS in 48s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/34/180234/3/check/gate-python-novaclient-docs/c4d000e//doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-novaclient-python27 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python27/eca1db1/ : SUCCESS in 1m 51s\n- gate-python-novaclient-python34 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python34/f498879/ : SUCCESS in 2m 50s\n- gate-python-novaclient-pypy http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-pypy/08f8feb/ : SUCCESS in 2m 23s\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/34/180234/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/102ea4a/ : FAILURE in 18m 33s\n- check-novaclient-dsvm-functional http://logs.openstack.org/34/180234/3/check/check-novaclient-dsvm-functional/a013f1b/ : FAILURE in 18m 40s","accounts_in_message":[],"_revision_number":3},{"id":"3112fc824cc4a49f94407e87eb49979c75ace1e0","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-06 18:13:14.000000000","message":"Patch Set 3:\n\nI see your point. I\u0027m not familiar about which and how many hypervisor-specific features there are. If we add any annotation, it should be consistent on all of them and not just this one.\n\nI\u0027m curious, what happened to bring about this patch? I just did an agent-create and agent-list with devstack and those seem to work. I don\u0027t know how to use a guest agent and it seems like if you do, you might probably also know whether it\u0027s enabled in your cloud.","accounts_in_message":[],"_revision_number":3},{"id":"b8a0377d70e12e5e10d6a14f6cf3f2fa8cd02011","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-06 18:26:07.000000000","message":"Patch Set 3:\n\nWhich features apply to which hypervisors changes daily. The client should be mostly timeless, IMHO, and thus not really reflect the state of a virt driver\u0027s support for a thing at any point in time.\n\nFurther, I think part of our mission is to abstract these operations so that the user does not (and should not) need to know what hypervisor is in use. If a thing is not supported for some environment, we communicate that back with a status code, not by making the client help reflect some point in time.","accounts_in_message":[],"_revision_number":3},{"id":"13e9c739225da9a7655f66b9a66c97a0a680813a","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-12 20:11:52.000000000","message":"Patch Set 3:\n\nMelanie asked: I\u0027m curious, what happened to bring about this patch?\n\n\"I\u0027m a user, I know zip about nova. I ask nova help for some help. I see nova agent. I look it up, wasting a lot of time. Finally ask some people what it is. Turns out if I\u0027m not Rackspace I can\u0027t use it.\n\nAs a user I would like the nova help to tell me that to save me time. Or not have it there, either is fine with me.\" That is what happened. We can call me a stupid user, which I am. But I don\u0027t think I\u0027m alone here.","accounts_in_message":[],"_revision_number":3},{"id":"c4e2e81c144d735cd9c8b1f5bb1541f4944d13f1","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-12 20:14:56.000000000","message":"Patch Set 3:\n\nJust to be clear: the person that told you it was RAX-specific was wrong.\n\nI think, based on your process, the failing here is lack of documentation of what the agents functionality is and does, right? If you had googled and found something that explained that the agents thing was \"to manage an in-guest agent, which as of Kilo was only useful on XenServer platforms using version X or newer\". Is that right?","accounts_in_message":[],"_revision_number":3},{"id":"1300a3eb73abcabe3aed6a10d037e6213cd49953","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-05-12 23:37:52.000000000","message":"Patch Set 3:\n\nIf you had googled and found something that explained that the agents thing was \"to manage an in-guest agent, which as of Kilo was only useful on XenServer platforms using version X or newer\". Is that right?\n\nYes.\n\nI found a few blog posts all of which thought I already knew what this was and nothing that gave me the sentence you just offered in your comment. I asked a few people and had some support to offer this patch, which if it is unnecessary I will abandon and apologize for the noise.","accounts_in_message":[],"_revision_number":3},{"id":"35183bc81b7b434a7482d426c4442a7b82606831","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-13 01:26:13.000000000","message":"Patch Set 3:\n\nGot it. I think it\u0027s a tall order for client help to explain all of the server functionality but I get that a hint could help save a lot of headache. It sounds like what might be a good compromise here would be if we add a link to official documentation, such as the API reference, to the usage text. Like after where it already says \"Command-line interface to the OpenStack Nova API.\" I think attempting to use the client without any reference to the API docs is something I wouldn\u0027t recommend anyone do.\n\nAttempting to use the client without the API reference is not something I would personally","accounts_in_message":[],"_revision_number":3},{"id":"fec7a3432f3c450310bfd5683efc92be7a96136e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2015-05-13 15:35:29.000000000","message":"Patch Set 3:\n\nMelanie, I think that\u0027s a fine idea, as long as the link is long-lived and (probably) not version-specific. I think we have CURRENT aliases or something in the URLs, which would work well.","accounts_in_message":[],"_revision_number":3},{"id":"82ea22fccdeaee2f0be8e9cad12dd810e233dbc9","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-05-14 13:31:44.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"a0c40f6985558b5ed50fb23f7d957126a7ecbca3","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2015-05-14 13:48:57.000000000","message":"Patch Set 3:\n\nI very much like the idea proposed by Melanie of linking to extensive docs for the client.\n\nTo be very clear on the agent, all this allows you to do is call an upstream Nova extension which updates the database with versioning and location information for agents.  There is no communication with an agent taking place.  The database allows a virt driver to choose which agent to install, and I think there\u0027s some mechanism by which agents can query this info and update themselves.  There is nothing Rackspace specific in this except that no other public cloud seems to use it, and the only thing Xenserver specific is that it\u0027s the only virt driver that takes advantage of it.  Nothing prevents this from working for any cloud/virt driver.\n\nIf anything it should be marked as an admin feature and not for general use, and hopefully an admin would understand whether or not it\u0027s something that will work for them.","accounts_in_message":[],"_revision_number":3},{"id":"8f7fe571d9037c981dbff7d84769e17f333c39ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-14 14:22:26.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-python26 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python26/e0293bc/ : SUCCESS in 1m 29s\n- gate-python-novaclient-pep8 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-pep8/633a01f/ : SUCCESS in 58s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/34/180234/3/check/gate-python-novaclient-docs/298470c//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-novaclient-python27 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python27/0e28970/ : SUCCESS in 1m 46s\n- gate-python-novaclient-python34 http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-python34/32af8e2/ : SUCCESS in 1m 56s\n- gate-python-novaclient-pypy http://logs.openstack.org/34/180234/3/check/gate-python-novaclient-pypy/f8f9086/ : FAILURE in 1m 00s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/34/180234/3/check/gate-tempest-dsvm-neutron-src-python-novaclient/06747af/ : SUCCESS in 50m 32s\n- check-novaclient-dsvm-functional http://logs.openstack.org/34/180234/3/check/check-novaclient-dsvm-functional/3a8d4e2/ : FAILURE in 16m 41s","accounts_in_message":[],"_revision_number":3},{"id":"57e76d5be1edab56d9a564f00151ae2b5d33d53a","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2015-07-06 13:49:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b85de272829d0393dd00d7b209e007e7bef6adca","revisions":{"ff1aad2b67c1228b70886490df7d69c99161dbfd":{"kind":"REWORK","_number":1,"created":"2015-05-05 17:00:17.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/34/180234/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/34/180234/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/1"}}},"commit":{"parents":[{"commit":"99fcc6939e37b796f60097030fe07511a4aa2058","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/99fcc6939e37b796f60097030fe07511a4aa2058"}]}],"author":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 16:58:53.000000000","tz":-240},"committer":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 16:58:53.000000000","tz":-240},"subject":"Add qualifier \"only for Rackspace\u0027 to agent help","message":"Add qualifier \"only for Rackspace\u0027 to agent help\n\nRight now the agent help doesn\u0027t inform the user that agent is\na feature meant only for Rackspace to consume. This patch adds\na qualifier to agent help strings.\n\nChange-Id: Ia83bc16a676e1cd7d91577661b0d3bb4a24c693f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff1aad2b67c1228b70886490df7d69c99161dbfd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff1aad2b67c1228b70886490df7d69c99161dbfd"}]},"branch":"refs/heads/master"},"f44367a71c3c72a4bfd75626746ef773b9409b25":{"kind":"REWORK","_number":2,"created":"2015-05-05 17:15:12.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/34/180234/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/34/180234/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/2"}}},"commit":{"parents":[{"commit":"99fcc6939e37b796f60097030fe07511a4aa2058","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/99fcc6939e37b796f60097030fe07511a4aa2058"}]}],"author":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 16:58:53.000000000","tz":-240},"committer":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 17:15:04.000000000","tz":-240},"subject":"Add qualifier \"only for Rackspace\u0027 to agent help","message":"Add qualifier \"only for Rackspace\u0027 to agent help\n\nRight now the agent help doesn\u0027t inform the user that agent is\na feature meant only for Rackspace to consume. This patch adds\na qualifier to agent help strings.\n\nChange-Id: Ia83bc16a676e1cd7d91577661b0d3bb4a24c693f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f44367a71c3c72a4bfd75626746ef773b9409b25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f44367a71c3c72a4bfd75626746ef773b9409b25"}]},"branch":"refs/heads/master"},"b85de272829d0393dd00d7b209e007e7bef6adca":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-05-05 17:26:20.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/34/180234/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/34/180234/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/34/180234/3"}}},"commit":{"parents":[{"commit":"99fcc6939e37b796f60097030fe07511a4aa2058","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/99fcc6939e37b796f60097030fe07511a4aa2058"}]}],"author":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 16:58:53.000000000","tz":-240},"committer":{"name":"Anita Kuno","email":"anteaya@anteaya.info","date":"2015-05-05 17:26:20.000000000","tz":0},"subject":"Add qualifier \"Rackspace-specific feature\u0027 to agent help","message":"Add qualifier \"Rackspace-specific feature\u0027 to agent help\n\nRight now the agent help doesn\u0027t inform the user that agent is\na feature meant only for Rackspace to consume. This patch adds\na qualifier to agent help strings.\n\nChange-Id: Ia83bc16a676e1cd7d91577661b0d3bb4a24c693f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b85de272829d0393dd00d7b209e007e7bef6adca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b85de272829d0393dd00d7b209e007e7bef6adca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}