)]}'
{"id":"openstack%2Fpython-novaclient~1806","triplet_id":"openstack%2Fpython-novaclient~master~I3d8abea8d99c406f237b8e500e1decf8d24f22d9","project":"openstack/python-novaclient","branch":"master","topic":"gerrit_uuid_autocomplete","hashtags":[],"change_id":"I3d8abea8d99c406f237b8e500e1decf8d24f22d9","subject":"Adding UUID cache for bash autocompletion.","status":"MERGED","created":"2011-11-20 00:14:19.000000000","updated":"2011-11-28 00:24:57.000000000","submitted":"2011-11-28 00:24:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0fbe5ad0e2c2d52919ed74f8cad51d399ace87de","_number":1806,"virtual_id_number":1806,"owner":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":1,"date":"2011-11-28 00:24:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"recommended":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2011-11-28 00:24:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2011-11-22 20:04:11.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":2,"date":"2011-11-28 00:24:44.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-21 19:17:14.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2011-11-22 20:04:11.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2011-11-28 00:24:44.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2011-11-28 00:24:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6a6adeed2d3a7a4c7c1ddcb2abb853bb295f99e2","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-21 15:29:50.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nI like the direction of this, but there are some small functional tweaks that we should consider:\n\n1) When booting an image, I expect to be able to autocomplete the options (image, flavor, etc). If I currently do \u0027nova boot --image\u003d1\u003ctab\u003e\u0027, it will not autocomplete. If I \u0027nova boot --image 1\u003ctab\u003e\u0027, it will autocomplete to any of my cached uuids, not just my images. \n\n2) I don\u0027t think we should append to the cache on a show. If I \u0027nova boot\u0027 an instance, then subsequently \u0027nova show\u0027 it 100000 times, the cache will have 100001 identical entries in it. Trying to tab complete with that cache took about 20 seconds on my machine.","accounts_in_message":[],"_revision_number":1},{"id":"651b4acf039d9d5718bd7816cd7d5850e39ff1bb","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-11-21 16:35:24.000000000","message":"Patch Set 1:\n\nBrian: Thanks for the comments.\n\n\u003e 1) When booting an image, I expect to be able to autocomplete the options \u003e (image, flavor, etc). If I currently do \u0027nova boot --image\u003d1\u003ctab\u003e\u0027, it will\n\u003e not autocomplete. If I \u0027nova boot --image 1\u003ctab\u003e\u0027, it will autocomplete to \u003e any of my cached uuids, not just my images.\n\nI like that idea too, but I\u0027m not sure how to implement that without significantly increasing the complexity of this patch. Any suggestions for how this could be done?\n\n(BTW, I\u0027m all for doing more research into bash completion and introducing a context-aware autocompletion patch down the road.)\n\n\u003e 2) I don\u0027t think we should append to the cache on a show. If I \u0027nova boot\u0027\n\u003e an instance, then subsequently \u0027nova show\u0027 it 100000 times, the cache will \u003e have 100001 identical entries in it. Trying to tab complete with that cache \u003e took about 20 seconds on my machine.\n\nInteresting, thanks for testing that out.  Yeah, skipping show seems like the right idea.","accounts_in_message":[],"_revision_number":1},{"id":"bb2db80a0a78557c7baf65c6d86a1c61674cb399","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-11-21 18:14:04.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nNice work. This is much cleaner than I was expecting.","accounts_in_message":[],"_revision_number":1},{"id":"c6656632dab9ea5dad50d5bfe3b0e2a6218029f5","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-21 18:29:42.000000000","message":"Patch Set 1:\n\nI\u0027m fine leaving the argument completion to a later patch, but could you remove the cache append on show here?","accounts_in_message":[],"_revision_number":1},{"id":"afa14ab201a124a99a018aa6583db1561b89830f","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-11-21 19:12:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4fd9b8946871a6e2bdcd7e82a2cb6b92f669d09f","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-11-21 19:14:41.000000000","message":"Patch Set 2:\n\nUpdated patch 1) Removes caching on GET and 2) cleans up the docstring a bit.","accounts_in_message":[],"_revision_number":2},{"id":"6cfdd50772d1eb506fa3a324302d350953b7907b","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-11-21 19:17:14.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"93e1cd817eeb04bf4874f4d7fedb958067648d95","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-21 20:24:18.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c3d9c8c76b8fa22109bc94b6443ebffd72e5b261","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-21 20:24:31.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/7/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/7/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/7/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"fecbcd99e3f5b9af98b59c5554f8e86731025280","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-11-21 21:51:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"83915918d67fdf4b1967e5c11bd77ab2bf11e746","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-11-22 20:04:11.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"c128270ddc971980676ad48837b032d24f3a3246","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-11-28 00:24:44.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"59a7cc6e3f5c6e0d3690718f56bbcb9f42c82c29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-28 00:24:57.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/9/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/9/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/9/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b20f72e274f5be6148434f22e920cfa92f786f6f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-11-28 00:24:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"58af45c9471107ce54cea5fe5d4ca7cc0bff56fa","revisions":{"354d03bee3d704ace5f06cf20794b02970555376":{"kind":"REWORK","_number":1,"created":"2011-11-20 00:14:19.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/06/1806/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/06/1806/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/1"}}},"commit":{"parents":[{"commit":"0e1e38d2e43fddb90b8010bd3e43b3da641cf643","subject":"Revert api_key change in novaclient Client argument","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0e1e38d2e43fddb90b8010bd3e43b3da641cf643"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-20 00:14:10.000000000","tz":-360},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-20 00:14:10.000000000","tz":-360},"subject":"Adding UUID cache for bash autocompletion.","message":"Adding UUID cache for bash autocompletion.\n\nChange-Id: I3d8abea8d99c406f237b8e500e1decf8d24f22d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/354d03bee3d704ace5f06cf20794b02970555376"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/354d03bee3d704ace5f06cf20794b02970555376"}]},"branch":"refs/heads/master"},"9ab7ee6f0708a052df05e829a0f7aecb023569ad":{"kind":"REWORK","_number":2,"created":"2011-11-21 19:12:36.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/06/1806/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/06/1806/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/2"}}},"commit":{"parents":[{"commit":"0e1e38d2e43fddb90b8010bd3e43b3da641cf643","subject":"Revert api_key change in novaclient Client argument","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0e1e38d2e43fddb90b8010bd3e43b3da641cf643"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-20 00:14:10.000000000","tz":-360},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-21 19:11:33.000000000","tz":0},"subject":"Adding UUID cache for bash autocompletion.","message":"Adding UUID cache for bash autocompletion.\n\nChange-Id: I3d8abea8d99c406f237b8e500e1decf8d24f22d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ab7ee6f0708a052df05e829a0f7aecb023569ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9ab7ee6f0708a052df05e829a0f7aecb023569ad"}]},"branch":"refs/heads/master"},"58af45c9471107ce54cea5fe5d4ca7cc0bff56fa":{"kind":"REWORK","_number":3,"created":"2011-11-21 21:51:57.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/06/1806/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/06/1806/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/06/1806/3"}}},"commit":{"parents":[{"commit":"0e1e38d2e43fddb90b8010bd3e43b3da641cf643","subject":"Revert api_key change in novaclient Client argument","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0e1e38d2e43fddb90b8010bd3e43b3da641cf643"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-20 00:14:10.000000000","tz":-360},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2011-11-21 21:51:53.000000000","tz":0},"subject":"Adding UUID cache for bash autocompletion.","message":"Adding UUID cache for bash autocompletion.\n\nChange-Id: I3d8abea8d99c406f237b8e500e1decf8d24f22d9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/58af45c9471107ce54cea5fe5d4ca7cc0bff56fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/58af45c9471107ce54cea5fe5d4ca7cc0bff56fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}