)]}'
{"id":"openstack%2Fpython-novaclient~18412","triplet_id":"openstack%2Fpython-novaclient~master~I1706ad993059e70ca0e2f3bcf7b1d06cbcc39f2d","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I1706ad993059e70ca0e2f3bcf7b1d06cbcc39f2d","subject":"Make --tenant a required arg for quota-show","status":"MERGED","created":"2012-12-19 20:19:30.000000000","updated":"2012-12-20 11:04:03.000000000","submitted":"2012-12-20 11:04:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"01f6e4d9fafb6a3116d99233c3f6d89d6ed02607","_number":18412,"virtual_id_number":18412,"owner":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-12-20 11:04:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-12-20 10:47:52.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":2,"date":"2012-12-19 20:39:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-12-20 10:32:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-12-20 10:47:52.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"date":"2012-12-19 20:39:09.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-19 20:39:09.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-12-20 10:47:52.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2012-12-20 11:04:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"80d0dc8d94ab7917e9390cb96ecbcb8e6ba872b0","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-12-19 20:39:09.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI\u0027m wondering, though, if we should make the argument a positional argument rather than an option, i.e., should the syntax be:\n\n  nova quota-show --tenant\u003d\u003ctenant-id\u003e\n\nor should it be:\n\n  nova quota-show \u003ctenant-id\u003e","accounts_in_message":[],"_revision_number":1},{"id":"a6be3ac61612cf71a97bb49f783252b702f63e8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-19 20:41:58.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18412/1/check/gate-python-novaclient-docs/453 : SUCCESS\n- http://logs.openstack.org/18412/1/check/gate-python-novaclient-pep8/761 : SUCCESS\n- http://logs.openstack.org/18412/1/check/gate-python-novaclient-python26/559 : SUCCESS\n- http://logs.openstack.org/18412/1/check/gate-python-novaclient-python27/773 : SUCCESS\n- http://logs.openstack.org/18412/1/check/gate-tempest-devstack-vm/23071 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"8106e14250958584ffcb7ace45ab339a76e91ea3","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2012-12-20 10:32:51.000000000","message":"Patch Set 1:\n\n@vek\n\nYes, I had a similar thought initially, but decided to stick with the existing syntax to avoid breaking existing scripts that are already using the quota-show verb correctly.\n\nWhereas breaking scripts that are using the bare \u0027nova quota-show\u0027 verb is OK as such scripts were already broken (in the sense of getting incorrect information back from nova-api).\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":1},{"id":"c91f458237cffc1aacfab51b480fe5f7100f8428","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-20 10:47:52.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://zuul.openstack.org/","accounts_in_message":[],"_revision_number":1},{"id":"f41a4899f27d9ddbebc5be05f0cde797c14a5bc8","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2012-12-20 10:47:52.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nYes it\u0027s probably best not to infer the tenant ID when we can,\nas then you\u0027d have an interface that could fail sometimes.","accounts_in_message":[],"_revision_number":1},{"id":"a9523281f21e8277c4002654c6dbfbd59b32484c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-20 11:04:03.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"01f6e4d9fafb6a3116d99233c3f6d89d6ed02607","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-20 11:04:03.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/18412/1/gate/gate-python-novaclient-docs/456 : SUCCESS\n- http://logs.openstack.org/18412/1/gate/gate-python-novaclient-pep8/764 : SUCCESS\n- http://logs.openstack.org/18412/1/gate/gate-python-novaclient-python26/562 : SUCCESS\n- http://logs.openstack.org/18412/1/gate/gate-python-novaclient-python27/776 : SUCCESS\n- http://logs.openstack.org/18412/1/gate/gate-tempest-devstack-vm/23167 : SUCCESS\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e6e22dbe77cbcb9e2078ab8574ebb75575ab2168","revisions":{"e6e22dbe77cbcb9e2078ab8574ebb75575ab2168":{"kind":"REWORK","_number":1,"created":"2012-12-19 20:19:30.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/12/18412/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/12/18412/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/12/18412/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/12/18412/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/12/18412/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/12/18412/1"}}},"commit":{"parents":[{"commit":"8d3650048a34f5c900b01d2f72d8fc50beff87ac","subject":"Merge \"Add optional argument to include reservations in os-used-limits\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8d3650048a34f5c900b01d2f72d8fc50beff87ac"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-12-19 20:07:41.000000000","tz":0},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-12-19 20:07:41.000000000","tz":0},"subject":"Make --tenant a required arg for quota-show","message":"Make --tenant a required arg for quota-show\n\nFixes LP 1088519\n\nPreviously, novaclient was incorrectly defaulting to the tenant name\nas the tenant ID when retrieving quota thresholds via the os-quota-sets\nAPI extension, in an apparent attempt to default to the current tenant\nif no specific tenant is explicitly requested.\n\nAs a result, the default quotas were always returned, regardless of\nwhether there were specific overridden quotas for this tenant.\n\nWe now require that the --tenant option is always specified for the\nquota-show verb, as a sensible default isn\u0027t always possible\n(because the tenant ID may be opaque to the client, for example when\nthe auth token is cached in the keyring from a previous call out to\nkeystone - now the tenant ID is of course generally embedded in the\nnova publicURL retrieved from the service catalog, but that is not\nguaranteed to be the case, i.e. I don\u0027t think we can safely make\nassumptions about that URL format).\n\nThis change also makes the quota-show verb more consistent with the\nquota-update verb, which currently requires that the tenant is\nalways explicitly specified.\n\nChange-Id: I1706ad993059e70ca0e2f3bcf7b1d06cbcc39f2d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e6e22dbe77cbcb9e2078ab8574ebb75575ab2168"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e6e22dbe77cbcb9e2078ab8574ebb75575ab2168"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}