)]}'
{"id":"openstack%2Fpython-novaclient~184917","triplet_id":"openstack%2Fpython-novaclient~master~I2cc8979e720740eae81692a60e30a3d95dce2a2c","project":"openstack/python-novaclient","branch":"master","topic":"eliminate-test-comprehensions","hashtags":[],"change_id":"I2cc8979e720740eae81692a60e30a3d95dce2a2c","subject":"Eliminate test comprehensions","status":"MERGED","created":"2015-05-22 00:12:50.000000000","updated":"2015-05-22 17:48:38.000000000","submitted":"2015-05-22 17:48:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"844ca4162960fbe08c0148d6f0bccb3750ba1f16","_number":184917,"virtual_id_number":184917,"owner":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-05-22 05:38:23.000000000","_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2015-05-22 17:48:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-05-22 15:56:51.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"recommended":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"all":[{"value":1,"date":"2015-05-22 05:39:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},{"value":2,"date":"2015-05-22 16:51:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2015-05-22 16:35:08.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},{"value":1,"date":"2015-05-22 16:51:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2015-05-22 00:15:17.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2015-05-22 00:13:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"date":"2015-05-22 00:13:52.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-22 00:13:43.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-05-22 00:13:52.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-05-22 00:15:17.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2015-05-22 05:38:23.000000000","updated_by":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"reviewer":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"state":"REVIEWER"},{"updated":"2015-05-22 16:51:40.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2015-05-22 17:48:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"72cf55f5f72b1ded194a8af877a8cd7c4f0d08a4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-22 00:12:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"298bfd684cc579c8ee6f9b4f361db61787fb93ad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 01:32:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/17/184917/1/check/gate-python-novaclient-python26/79006ae/ : SUCCESS in 1m 26s\n- gate-python-novaclient-pep8 http://logs.openstack.org/17/184917/1/check/gate-python-novaclient-pep8/586a657/ : SUCCESS in 52s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/17/184917/1/check/gate-python-novaclient-docs/15d9200//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-novaclient-python27 http://logs.openstack.org/17/184917/1/check/gate-python-novaclient-python27/e1a2c6d/ : SUCCESS in 1m 33s\n- gate-python-novaclient-python34 http://logs.openstack.org/17/184917/1/check/gate-python-novaclient-python34/4d47b63/ : SUCCESS in 2m 05s\n- gate-python-novaclient-pypy http://logs.openstack.org/17/184917/1/check/gate-python-novaclient-pypy/152b463/ : SUCCESS in 2m 24s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/17/184917/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/69d49db/ : SUCCESS in 1h 19m 19s\n- check-novaclient-dsvm-functional http://logs.openstack.org/17/184917/1/check/check-novaclient-dsvm-functional/fc09c3f/ : SUCCESS in 19m 49s","accounts_in_message":[],"_revision_number":1},{"id":"c8c436a89782cff251369d1efe40ccdde894f869","author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"date":"2015-05-22 05:38:23.000000000","message":"Patch Set 1:\n\nOften a HACKING rule is requested along with changes of this nature. You could search for [.*assert.* for .* in .*] ?","accounts_in_message":[],"_revision_number":1},{"id":"f953c776e942e00b8b2ae4ca39c05982e8445794","author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"date":"2015-05-22 05:39:19.000000000","message":"Patch Set 1: Code-Review+1\n\nThat said, I\u0027m a big believer in progress over perfection - ship it.","accounts_in_message":[],"_revision_number":1},{"id":"fb43041aa8520e2b18ab1a21baab4d0deaa8fa5d","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-22 15:56:51.000000000","message":"Patch Set 1:\n\nTBH, this isn\u0027t usually a problem, it\u0027s just something that had arisen in novaclient, largely as a result of c\u0026p.  When I see someone propose a patch with the comprehension, I make them change it, so I\u0027m not really worried about needing a hacking rule.","accounts_in_message":[],"_revision_number":1},{"id":"a40f5931f393ca0ab739e0baf374adae55e1fb3f","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2015-05-22 16:35:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4fbf83adea738022647fc5539444aee53a7d4c72","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2015-05-22 16:51:40.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"629ef2b256b6944f97aea0acb97077dd7fac5ee8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 16:51:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1e22ae3517d9ae4f0dd9b809b32da3ccd5cc7c7d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 17:48:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/17/184917/1/gate/gate-python-novaclient-python26/45b8fc1/ : SUCCESS in 1m 27s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/17/184917/1/gate/gate-python-novaclient-docs/d560141//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-novaclient-pep8 http://logs.openstack.org/17/184917/1/gate/gate-python-novaclient-pep8/42b041e/ : SUCCESS in 1m 01s\n- gate-python-novaclient-python27 http://logs.openstack.org/17/184917/1/gate/gate-python-novaclient-python27/fb9cc11/ : SUCCESS in 1m 44s\n- gate-python-novaclient-python34 http://logs.openstack.org/17/184917/1/gate/gate-python-novaclient-python34/dc17c9f/ : SUCCESS in 1m 55s\n- gate-python-novaclient-pypy http://logs.openstack.org/17/184917/1/gate/gate-python-novaclient-pypy/1f0b05c/ : SUCCESS in 2m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/17/184917/1/gate/gate-tempest-dsvm-neutron-src-python-novaclient/67b3477/ : SUCCESS in 56m 50s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/17/184917/1/gate/gate-novaclient-dsvm-functional/d263b3c/ : SUCCESS in 20m 44s","accounts_in_message":[],"_revision_number":1},{"id":"ad4c171b1afb49e4d0aa449abc641c767c31f04a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-22 17:48:38.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0a327ce3752736dbc91535355b05fc09a43c7110","revisions":{"0a327ce3752736dbc91535355b05fc09a43c7110":{"kind":"REWORK","_number":1,"created":"2015-05-22 00:12:50.000000000","uploader":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"ref":"refs/changes/17/184917/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/17/184917/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/17/184917/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/17/184917/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/17/184917/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/17/184917/1"}}},"commit":{"parents":[{"commit":"c5b850fb1ec2d7aefeda357ed1d0826e9bf83b19","subject":"Merge \"Use clouds.yaml for functional test credentials\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c5b850fb1ec2d7aefeda357ed1d0826e9bf83b19"}]}],"author":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2015-05-22 00:12:35.000000000","tz":-300},"committer":{"name":"Kevin L. Mitchell","email":"kevin.mitchell@rackspace.com","date":"2015-05-22 00:12:35.000000000","tz":-300},"subject":"Eliminate test comprehensions","message":"Eliminate test comprehensions\n\nThe novaclient tests are rife with examples of using a list comprehension\nto perform a series of asserts, when a simple for loop would be more\nappropriate and more idiomatic; part of the problem is the propensity\nfor people to cut and paste.  Eliminating the existing examples should\nremove the temptation for developers to use this non-idiom to perform\ntests.\n\nChange-Id: I2cc8979e720740eae81692a60e30a3d95dce2a2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0a327ce3752736dbc91535355b05fc09a43c7110"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0a327ce3752736dbc91535355b05fc09a43c7110"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}