)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"185419891f9eae3724f97e176025a8edb3b4419b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"low level detail is really not something that makes sense exposed through"},{"line_number":13,"context_line":"the public API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We can\u0027t phase it out as easily from the API, but we can easily"},{"line_number":16,"context_line":"disallow it in the CLI as a first step towards removing it\u0027s usage."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6dd534c659d0b548375405b5589fbad0197125bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_60d74ec0","line":15,"updated":"2015-05-25 19:58:44.000000000","message":"are you going to propose a spec for liberty to change the REST API?  seems like technically it would be just a microversion, no?\n\nThe bigger issue is whether anyone is actually using this.  If they are, then it\u0027s arguably a mistake to remove it from the CLI as well.","commit_id":"e4c95c49bb4d547b40180cf9f3e33109ba7521fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"9afe5bcf99631802f62530b7bed24a1e743beae8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"low level detail is really not something that makes sense exposed through"},{"line_number":13,"context_line":"the public API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We can\u0027t phase it out as easily from the API, but we can easily"},{"line_number":16,"context_line":"disallow it in the CLI as a first step towards removing it\u0027s usage."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6dd534c659d0b548375405b5589fbad0197125bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_4e71eb43","line":15,"in_reply_to":"7a016987_4480c646","updated":"2015-05-27 10:44:05.000000000","message":"Xen does afaiu in a certain subset of cofigurations (PV guests - meaning PV enabled kernels or PV drivers - granted this is the majority of real world use casesd). Exposing it in the API was surely a mistake since there is no reasonable way to support it with libvirt/kvm (I assume it came from copying the EC2 API verbatim).","commit_id":"e4c95c49bb4d547b40180cf9f3e33109ba7521fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"c566c9f50ecd36e4118f0be9d81396fa2cea2301","unresolved":false,"context_lines":[{"line_number":12,"context_line":"low level detail is really not something that makes sense exposed through"},{"line_number":13,"context_line":"the public API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We can\u0027t phase it out as easily from the API, but we can easily"},{"line_number":16,"context_line":"disallow it in the CLI as a first step towards removing it\u0027s usage."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6dd534c659d0b548375405b5589fbad0197125bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_72e39d06","line":15,"in_reply_to":"7a016987_60d74ec0","updated":"2015-05-26 07:41:31.000000000","message":"I might do a patch for the API - it\u0027s pretty simple to do with microversions.\n\nCLI is supposed to be used by humans and there are no stability guarantees, so not sure why you think it would be a mistake.","commit_id":"e4c95c49bb4d547b40180cf9f3e33109ba7521fa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"4526856236d6e4c3f7af331f85567a3a2e6285d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"low level detail is really not something that makes sense exposed through"},{"line_number":13,"context_line":"the public API."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We can\u0027t phase it out as easily from the API, but we can easily"},{"line_number":16,"context_line":"disallow it in the CLI as a first step towards removing it\u0027s usage."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6dd534c659d0b548375405b5589fbad0197125bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_4480c646","line":15,"in_reply_to":"7a016987_72e39d06","updated":"2015-05-26 17:55:48.000000000","message":"It\u0027s my understanding that one or more of the hypervisors (Xen maybe?) actually supports specifying the device.\n\nIf people are actually actively using the CLI with such hypervisors to specify the device then it seems not very nice to remove that capability from them when it\u0027s still present in the REST API.","commit_id":"e4c95c49bb4d547b40180cf9f3e33109ba7521fa"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7cc903383034deff9fe789997f3bed59cfa064e3","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"@cliutils.arg("},{"line_number":2093,"context_line":"    \u0027device\u0027, metavar\u003d\u0027\u003cdevice\u003e\u0027, default\u003dNone, nargs\u003d\u0027?\u0027,"},{"line_number":2094,"context_line":"    help\u003d_(\u0027Name of the device e.g. /dev/vdb. \u0027"},{"line_number":2095,"context_line":"           \u0027Use \"auto\" for autoassign (if supported)\u0027))"},{"line_number":2096,"context_line":"def do_volume_attach(cs, args):"},{"line_number":2097,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":2098,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_df192324","side":"PARENT","line":2095,"updated":"2015-05-26 18:23:54.000000000","message":"We really should put this through a deprecation cycle, I think, if we\u0027re going to continue forward with removing this functionality.  That would basically involve including \"DEPRECATED\" in the help text and emitting a warning message if the argument is provided.","commit_id":"0a327ce3752736dbc91535355b05fc09a43c7110"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"9afe5bcf99631802f62530b7bed24a1e743beae8","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"@cliutils.arg("},{"line_number":2093,"context_line":"    \u0027device\u0027, metavar\u003d\u0027\u003cdevice\u003e\u0027, default\u003dNone, nargs\u003d\u0027?\u0027,"},{"line_number":2094,"context_line":"    help\u003d_(\u0027Name of the device e.g. /dev/vdb. \u0027"},{"line_number":2095,"context_line":"           \u0027Use \"auto\" for autoassign (if supported)\u0027))"},{"line_number":2096,"context_line":"def do_volume_attach(cs, args):"},{"line_number":2097,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":2098,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c4725d49","side":"PARENT","line":2095,"in_reply_to":"7a016987_df192324","updated":"2015-05-27 10:44:05.000000000","message":"Fair enough - I think quite a few people are against this so will probably abandon for now and re-think the approach","commit_id":"0a327ce3752736dbc91535355b05fc09a43c7110"}]}