)]}'
{"id":"openstack%2Fpython-novaclient~185438","triplet_id":"openstack%2Fpython-novaclient~master~I6dd534c659d0b548375405b5589fbad0197125bf","project":"openstack/python-novaclient","branch":"master","topic":"remove_device_from_volume_attach","hashtags":[],"change_id":"I6dd534c659d0b548375405b5589fbad0197125bf","subject":"Remove device arg from nova volume-attach","status":"ABANDONED","created":"2015-05-25 18:22:55.000000000","updated":"2015-05-27 11:08:30.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8172fc11203177bf6019b860d809575173b77eaf","_number":185438,"virtual_id_number":185438,"owner":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},{"date":"2015-05-25 19:58:44.000000000","_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":1,"date":"2015-05-25 19:21:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-05-26 18:23:54.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2015-05-26 07:41:31.000000000","_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"all":[{"value":-1,"date":"2015-05-26 12:35:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2015-05-26 12:15:48.000000000","_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"date":"2015-05-26 12:36:41.000000000","_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"date":"2015-05-26 18:19:28.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2015-05-26 12:16:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"date":"2015-05-26 12:37:23.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"date":"2015-05-26 12:17:57.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-25 19:21:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-25 19:58:44.000000000","updated_by":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"reviewer":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"state":"REVIEWER"},{"updated":"2015-05-26 12:15:48.000000000","updated_by":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"reviewer":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"state":"REVIEWER"},{"updated":"2015-05-26 12:16:02.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2015-05-26 12:17:57.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-05-26 12:36:41.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2015-05-26 12:37:23.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2015-05-26 18:19:28.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2015-05-26 18:23:54.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"}],"messages":[{"id":"b946e2f965427953e24caaead9e83b87a4bf32b7","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2015-05-25 18:22:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"85ef4dee9ed76a309e5683e959204dc0090f1e16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-25 19:21:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/38/185438/1/check/gate-python-novaclient-python26/ce42f1d/ : SUCCESS in 1m 25s\n- gate-python-novaclient-pep8 http://logs.openstack.org/38/185438/1/check/gate-python-novaclient-pep8/db0bcc8/ : SUCCESS in 56s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/38/185438/1/check/gate-python-novaclient-docs/d1aab84//doc/build/html/ : SUCCESS in 54s\n- gate-python-novaclient-python27 http://logs.openstack.org/38/185438/1/check/gate-python-novaclient-python27/7a62d08/ : SUCCESS in 1m 27s\n- gate-python-novaclient-python34 http://logs.openstack.org/38/185438/1/check/gate-python-novaclient-python34/b575f06/ : SUCCESS in 2m 10s\n- gate-python-novaclient-pypy http://logs.openstack.org/38/185438/1/check/gate-python-novaclient-pypy/9ff3c89/ : SUCCESS in 2m 22s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/38/185438/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/8821633/ : SUCCESS in 58m 19s\n- check-novaclient-dsvm-functional http://logs.openstack.org/38/185438/1/check/check-novaclient-dsvm-functional/6af1238/ : SUCCESS in 25m 47s","accounts_in_message":[],"_revision_number":1},{"id":"185419891f9eae3724f97e176025a8edb3b4419b","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-05-25 19:58:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c566c9f50ecd36e4118f0be9d81396fa2cea2301","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2015-05-26 07:41:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d2b79237441fad5d3244b1c782509dc979c58115","author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"date":"2015-05-26 12:35:52.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Nikola, I\u0027m sorry you couldn\u0027t attend the summit. There were some talks and decisions in this regard.\nThe device names in BDM is one of the features required for EC2 API.\nUnfortunately in your absence nobody else could\u0027ve commented upon the fate of the device names which started to disintegrate before our eyes ever since bdm v2 was introduced (please forgive me if I\u0027m not exactly precise in some facts).\nThe thing is, right now nova\u0027s EC2 API being officially deprecated and all of the accent put into making external EC2 API (the one on stackforge) ready for production, it is required for some really important features to have device names, because they are the key for various operations performed by EC2 API. As it is, before the bdm v2 there was almost all we needed in terms of this functionality in public APIs present. Since then we\u0027re struggling.\nWhat was discussed during the summit is that we\u0027ll need to bring back necessary features, providing required specs and reviews:\nhttps://etherpad.openstack.org/p/YVR-nova-contributor-meetup\nI suggest to understand what are the causes actually making you to go on removing all this stuff. Am I correct that it\u0027s caused by you thinking that there is no demand for it in the public APIs and that since it was not universally supported by some backends it should be removed everywhere?\nIf that\u0027s the case, I believe we should go the other way around and restore all of this, adding maybe tickets or limitations for some backends not supporting it.\nOur features we have problems with now are device names everywhere, modification of deleteOnTermination flag, ability to change parameters upon volume attach and  deleteOnTermination and size attributes not stored anymore in snapshots.\nSorry if this review is not the very best place for this discussion we can move it anywhere else, but it just came up right after the summit talks, so it might be a good place to start.","accounts_in_message":[],"_revision_number":1},{"id":"704dae185f7893d0a18784c1cc27dd5e517d1bf2","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2015-05-26 16:06:08.000000000","message":"Patch Set 1:\n\nHey Alexandre:\n\nYes - this is not the right place to have this discussion - I propose we take it to the ML - I will respond in short tho.\n\n1) This patch only removes it from the CLI - it is still available in the API - so you can remove the -1. If someone is using this client he is most certainly using the OpenStack API so any issues related to the EC2 API are orthogonal to this patch\n\n2) Most of the concerns you mention in your comment seem to be either bugs that are probably easy to fix (delete on termination for example), or just stem from not understanding what BDM v2 does (it removes nothing, it\u0027s still possible to use old syntax and never worry about it)\n\n3) Device names are problematic because they DO NOT WORK for KVM guests. Exposing them in the API may make your API look like it\u0027s doing what you want but it doesn\u0027t. People using the EC2 API for Nova clouds need to be aware of this.\n\nLet\u0027s take it to the ML for some further discussion - but it seems to me that whatever is missing for the EC2 API to work is fixing bugs that snuck in when the new extended format was added.","accounts_in_message":[],"_revision_number":1},{"id":"4526856236d6e4c3f7af331f85567a3a2e6285d8","author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"date":"2015-05-26 17:55:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7cc903383034deff9fe789997f3bed59cfa064e3","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2015-05-26 18:23:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8b64b03567dadf805f6096591298d76493bc884a","author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"date":"2015-05-26 20:28:45.000000000","message":"Patch Set 1:\n\nI can remove -1 if you think I should. But I\u0027m still personally against such changes and drops of existing functionality partially because some people might use it and as you mentioned some bugs can sneak in. Overall I\u0027m against this until it\u0027s collectively decided in nova what should be done with this functionality in all of the affected areas - for example, if it should somehow (maybe with inconsistencies and limitations) work for EC2 API, then maybe it should provide the same functionality in native API as well. From what I understood during the summit this matter is rather vague for everyone so can we first clarify it and then move on with reviews?","accounts_in_message":[],"_revision_number":1},{"id":"9afe5bcf99631802f62530b7bed24a1e743beae8","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2015-05-27 10:44:05.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nAlexander - Fair enough. If we aim to provide good support the EC2 API we need to carefully rethink where we go with this. Let me start a thread about this on the ML and we can coordinate there.","accounts_in_message":[],"_revision_number":1},{"id":"b849a9c3dc7fe8d3ecd0afed925e8373738460c0","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2015-05-27 10:44:21.000000000","message":"Abandoned\n\nAs per the discussion inline","accounts_in_message":[],"_revision_number":1},{"id":"93a81384d45f9654aceda47e8b9932fe848f789e","author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"date":"2015-05-27 11:08:30.000000000","message":"Patch Set 1:\n\nThank you Nikola. I\u0027ve started the thread earlier.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e4c95c49bb4d547b40180cf9f3e33109ba7521fa","revisions":{"e4c95c49bb4d547b40180cf9f3e33109ba7521fa":{"kind":"REWORK","_number":1,"created":"2015-05-25 18:22:55.000000000","uploader":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"ref":"refs/changes/38/185438/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/38/185438/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/38/185438/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/38/185438/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/38/185438/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/38/185438/1"}}},"commit":{"parents":[{"commit":"0a327ce3752736dbc91535355b05fc09a43c7110","subject":"Eliminate test comprehensions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0a327ce3752736dbc91535355b05fc09a43c7110"}]}],"author":{"name":"Nikola Dipanov","email":"ndipanov@redhat.com","date":"2015-05-25 18:15:49.000000000","tz":60},"committer":{"name":"Nikola Dipanov","email":"ndipanov@redhat.com","date":"2015-05-25 18:21:19.000000000","tz":60},"subject":"Remove device arg from nova volume-attach","message":"Remove device arg from nova volume-attach\n\nFor libvirt only clouds - passing this is almost always a mistake, for\nother hypervisors, it\u0027s not mandatory anyway (Nova will choose an\navailable one because it\u0027s needed by the database) - but this kind of\nlow level detail is really not something that makes sense exposed through\nthe public API.\n\nWe can\u0027t phase it out as easily from the API, but we can easily\ndisallow it in the CLI as a first step towards removing it\u0027s usage.\n\nChange-Id: I6dd534c659d0b548375405b5589fbad0197125bf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e4c95c49bb4d547b40180cf9f3e33109ba7521fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e4c95c49bb4d547b40180cf9f3e33109ba7521fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}