)]}'
{"id":"openstack%2Fpython-novaclient~18578","triplet_id":"openstack%2Fpython-novaclient~master~I447e49e5fce0afba8a9c1a5df6dfa7200cc93e18","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I447e49e5fce0afba8a9c1a5df6dfa7200cc93e18","subject":"Unify Manager._update behaviour","status":"MERGED","created":"2012-12-22 18:15:27.000000000","updated":"2013-01-04 18:02:46.000000000","submitted":"2013-01-04 18:02:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d40bb1d6add53ef3d44d6f056ee0908c0227c068","_number":18578,"virtual_id_number":18578,"owner":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2013-01-04 18:02:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2013-01-02 17:16:44.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-04 09:09:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":2,"date":"2013-01-04 16:42:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2013-01-02 17:16:44.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-12-23 12:53:25.000000000","_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":1,"date":"2013-01-04 16:42:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-02 17:16:44.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-01-04 16:42:10.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-01-04 18:02:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6b7c315eee3e9ec8705f03478bd247bd504f838f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-22 18:43:51.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/18578/1/check/gate-python-novaclient-docs/470 : SUCCESS\n- http://logs.openstack.org/18578/1/check/gate-python-novaclient-pep8/778 : FAILURE\n- http://logs.openstack.org/18578/1/check/gate-python-novaclient-python26/576 : SUCCESS\n- http://logs.openstack.org/18578/1/check/gate-python-novaclient-python27/790 : SUCCESS\n- http://logs.openstack.org/18578/1/check/gate-tempest-devstack-vm/23444 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"c4c21a7b1eda3239a1af0fb9f2b92c5899d1b246","author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"date":"2012-12-23 12:53:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b41d136d91c4efe7e5fbea20255cbac789bb7039","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-23 13:17:45.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18578/2/check/gate-python-novaclient-docs/472 : SUCCESS\n- http://logs.openstack.org/18578/2/check/gate-python-novaclient-pep8/780 : SUCCESS\n- http://logs.openstack.org/18578/2/check/gate-python-novaclient-python26/578 : SUCCESS\n- http://logs.openstack.org/18578/2/check/gate-python-novaclient-python27/792 : SUCCESS\n- http://logs.openstack.org/18578/2/check/gate-tempest-devstack-vm/23471 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"04445b6e81956646bceef9c03d6f992cecb2b628","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-02 17:16:44.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"35cbc3df82311858352e752410758aaeb9fa23d7","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-03 17:09:49.000000000","message":"Patch Set 2:\n\nIt looks to me like there are two different changes in this patch—the _update() call changes, and the switch between \"service\" and \"binary\".  Am I correct?  Is there any way to split the patch into two changes?\n\nMind you, I\u0027m inclined to approve the patch anyway, but it\u0027s worth asking the question to be sure…","accounts_in_message":[],"_revision_number":2},{"id":"0829e26727d873e31d5ecea33b2c301a913a2ea3","author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"date":"2013-01-04 09:09:57.000000000","message":"Patch Set 2:\n\nKevin, this patch shouldn\u0027t be split into two parts. I\u0027ve noticed several inconsistencies in Nova API, described, and fixed them in If50a6b6e20f9b3fe66d486bb9b15d3eb4b62daf9. \"service\" -\u003e \"binary\" replacement is only one of changes caused by updated API.\n\nThank you for approval!","accounts_in_message":[],"_revision_number":2},{"id":"fba52ca1f725ce42e5b460c2340355185bbc1dbe","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-04 16:42:10.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3ce137534ef74ee87a6b5c6d14b2232dbb6005f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-04 16:42:11.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://zuul.openstack.org/","accounts_in_message":[],"_revision_number":2},{"id":"033460067e0529f597426c38a8c7c96b1e3194fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-04 18:02:45.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/18578/2/gate/gate-python-novaclient-docs/496 : SUCCESS\n- http://logs.openstack.org/18578/2/gate/gate-python-novaclient-pep8/804 : SUCCESS\n- http://logs.openstack.org/18578/2/gate/gate-python-novaclient-python26/602 : SUCCESS\n- http://logs.openstack.org/18578/2/gate/gate-python-novaclient-python27/816 : SUCCESS\n- http://logs.openstack.org/18578/2/gate/gate-tempest-devstack-vm/24233 : SUCCESS\n- http://logs.openstack.org/18578/2/gate/gate-devstack-vm-quantum/759 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"d40bb1d6add53ef3d44d6f056ee0908c0227c068","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-04 18:02:46.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"63073104665ee4597cf3b7aa8dc2295a8a7db794","revisions":{"de454c07ddca390e8f098e0023dec596faed2d5c":{"kind":"REWORK","_number":1,"created":"2012-12-22 18:15:27.000000000","uploader":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"ref":"refs/changes/78/18578/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/78/18578/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/1"}}},"commit":{"parents":[{"commit":"fba20df12c376185eecfa21a4f54b66a72fc5365","subject":"add num_instances option for nova boot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fba20df12c376185eecfa21a4f54b66a72fc5365"}]}],"author":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2012-12-22 16:12:20.000000000","tz":240},"committer":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2012-12-22 18:15:18.000000000","tz":120},"subject":"Unify Manager._update behaviour","message":"Unify Manager._update behaviour\n\nNow _update call usually returns an instance of self.resource_class.\nThis simplifies the code and makes novaclient closer to keystoneclient.\n\nAlso, update hosts and services API according to changes on nova.\n(If50a6b6e20f9b3fe66d486bb9b15d3eb4b62daf9).\n\nChange-Id: I447e49e5fce0afba8a9c1a5df6dfa7200cc93e18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de454c07ddca390e8f098e0023dec596faed2d5c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de454c07ddca390e8f098e0023dec596faed2d5c"}]},"branch":"refs/heads/master"},"63073104665ee4597cf3b7aa8dc2295a8a7db794":{"kind":"REWORK","_number":2,"created":"2012-12-23 12:53:25.000000000","uploader":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"ref":"refs/changes/78/18578/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/78/18578/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/78/18578/2"}}},"commit":{"parents":[{"commit":"fba20df12c376185eecfa21a4f54b66a72fc5365","subject":"add num_instances option for nova boot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fba20df12c376185eecfa21a4f54b66a72fc5365"}]}],"author":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2012-12-22 16:12:20.000000000","tz":240},"committer":{"name":"Alessio Ababilov","email":"aababilov@griddynamics.com","date":"2012-12-23 12:50:38.000000000","tz":120},"subject":"Unify Manager._update behaviour","message":"Unify Manager._update behaviour\n\nNow _update call usually returns an instance of self.resource_class.\nThis simplifies the code and makes novaclient closer to keystoneclient.\n\nAlso, update hosts and services API according to changes on nova.\n(If50a6b6e20f9b3fe66d486bb9b15d3eb4b62daf9).\n\nChange-Id: I447e49e5fce0afba8a9c1a5df6dfa7200cc93e18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63073104665ee4597cf3b7aa8dc2295a8a7db794"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/63073104665ee4597cf3b7aa8dc2295a8a7db794"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}