)]}'
{"id":"openstack%2Fpython-novaclient~18673","triplet_id":"openstack%2Fpython-novaclient~master~I47c4f2ff9adbab5da4697270dcf024ac88e24529","project":"openstack/python-novaclient","branch":"master","topic":"bug/1088835","hashtags":[],"change_id":"I47c4f2ff9adbab5da4697270dcf024ac88e24529","subject":"Check tenant_id\u0027s format in \"nova quota-update\"","status":"MERGED","created":"2012-12-27 00:53:31.000000000","updated":"2013-01-29 20:04:36.000000000","submitted":"2013-01-29 20:04:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":24,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d93821ed5b7dfaab9db5b2ae59a5a73a5d9b8bbd","_number":18673,"virtual_id_number":18673,"owner":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},{"value":2,"date":"2013-01-29 20:04:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2013-01-29 18:32:55.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-24 14:02:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":2,"date":"2013-01-24 16:18:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-01-24 16:22:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2013-01-29 18:32:55.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2013-01-24 16:18:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2013-01-24 16:22:09.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-12 16:42:50.000000000","updated_by":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"reviewer":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"state":"REVIEWER"},{"updated":"2013-01-24 14:02:15.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-01-24 16:18:17.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-01-24 16:22:09.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-01-29 18:32:55.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2013-01-29 20:04:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"990da9cd13ce1fd220236e9156618fc507a110c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-27 01:17:28.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18673/1/check/gate-python-novaclient-docs/481 : SUCCESS\n- http://logs.openstack.org/18673/1/check/gate-python-novaclient-pep8/789 : SUCCESS\n- http://logs.openstack.org/18673/1/check/gate-python-novaclient-python26/587 : SUCCESS\n- http://logs.openstack.org/18673/1/check/gate-python-novaclient-python27/801 : SUCCESS\n- http://logs.openstack.org/18673/1/check/gate-tempest-devstack-vm/23595 : SUCCESS\n- http://logs.openstack.org/18673/1/check/gate-devstack-vm-quantum/22 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"f28a515119d9726563485a06d876fef62016713f","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2012-12-27 01:56:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"541de03e2c9429d3e2084a4dd6bf7733fdf60829","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2012-12-27 01:56:52.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"9b0096be34613425b2d4cfc3b8fd532103d4b247","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-27 02:20:18.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18673/2/check/gate-python-novaclient-docs/482 : SUCCESS\n- http://logs.openstack.org/18673/2/check/gate-python-novaclient-pep8/790 : SUCCESS\n- http://logs.openstack.org/18673/2/check/gate-python-novaclient-python26/588 : SUCCESS\n- http://logs.openstack.org/18673/2/check/gate-python-novaclient-python27/802 : SUCCESS\n- http://logs.openstack.org/18673/2/check/gate-tempest-devstack-vm/23599 : SUCCESS\n- http://logs.openstack.org/18673/2/check/gate-devstack-vm-quantum/26 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"9bf6d3efc53399d985c7f72a98ee62a2474fabf9","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-02 17:19:16.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"117596237726ff44bd245a6e78cc347ea1ad306b","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-01-02 17:42:30.000000000","message":"Patch Set 2: (1 inline comment)\n\nShould is_uuid_like support str uuids containing \u0027-\u0027 characters?","accounts_in_message":[],"_revision_number":2},{"id":"da6e39c1934c2a59eb79bcfe51b4ec04afc52f22","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-03 17:24:34.000000000","message":"Patch Set 2:\n\nWell, one, we don\u0027t seem to be validating tenant IDs anywhere else.  Two, this code looks very similar to (but not the same as) the is_uuid_like() in oslo-incubator, which may reflect a deliberate decision to disallow \u0027-\u0027 in the name.  I think I need more convincing that this is a legitimate way of testing the tenant ID field…","accounts_in_message":[],"_revision_number":2},{"id":"ab2a4fad69c8b48324d72c64ef7106a531101318","author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"date":"2013-01-06 09:30:20.000000000","message":"Patch Set 2:\n\none, like Kevin L. Mitchel said, we don\u0027t seem to be validating tenant IDs anywhere else. So I am not sure this is necessary. Two, if it\u0027s necessary, I think the validation also need ensure the tenant with this ID exists, rather than just validating the ID format.","accounts_in_message":[],"_revision_number":2},{"id":"61aa987277f9ccdf669cfb00cf42bba438c43294","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-07 00:16:11.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"f5e035462fed833aa8dd47318c2d4b963178ef29","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-07 00:35:13.000000000","message":"Patch Set 2:\n\nOne, I think it\u0027s necessary to validate the format of the UUID and especially the UUID with \u0027-\u0027.Because if not,the id like \"a0eebc999c0b4ef8bb6d6bb9bd380a11\" and \"a0eebc99-9c0b-4ef8-bb6d-6bb9bd380a11\" will be considered as the different ones when the \"nova quota-update\" command is executed.\nTwo, I also think whether the tenant exists or not should be validated, and it will be modified later.","accounts_in_message":[],"_revision_number":2},{"id":"34dbf016f1325d1023f153a584dccef15aae62b7","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-01-09 22:15:54.000000000","message":"Patch Set 2: (3 inline comments)\n\nI like the direction of this patch.  Can we use the same logic for other cases where tenant_id is passed into a command.\n\nAlso I think checking if tenant_id is uuid and not checking if it valid in keystone is better than no check at all.","accounts_in_message":[],"_revision_number":2},{"id":"1efbd4173f4a5038126e1e6c1b7adf3bb7afd50a","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-10 03:39:34.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"9deffbb1e5efbc647137dc90f5564e27c987c5df","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-10 04:01:57.000000000","message":"Patch Set 2:\n\nThe tenant_ids in the keystone database are all made of numbers and lower characters, and doesn\u0027t contain \u0027-\u0027.\nI think all the uuids should be in the same format, so what about controlling them in the format of tenant_id.","accounts_in_message":[],"_revision_number":2},{"id":"580a2370c8119d65b09e5311133380644ecfdf01","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-10 10:22:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c55241e4a456ba3d4879e131bcf905e8513ee2de","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-10 10:30:04.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"acf4400955eaed27c3fd1c12117868acb92903b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-10 10:53:18.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/18673/3/check/gate-python-novaclient-docs/504 : SUCCESS\n- http://logs.openstack.org/18673/3/check/gate-python-novaclient-pep8/812 : SUCCESS\n- http://logs.openstack.org/18673/3/check/gate-python-novaclient-python26/610 : SUCCESS\n- http://logs.openstack.org/18673/3/check/gate-python-novaclient-python27/824 : SUCCESS\n- http://logs.openstack.org/18673/3/check/gate-tempest-devstack-vm/25787 : SUCCESS\n- http://logs.openstack.org/18673/3/check/gate-devstack-vm-quantum/2426 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"ed16b5335d65b937ac236ce4efc30abfa22d4ac5","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-01-10 22:36:22.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"0fe016eef35c16e98ac1cff75093c8e2d99b5efa","author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"date":"2013-01-12 16:42:50.000000000","message":"Patch Set 3: (1 inline comment)\n\nI still think we should check if it valid, but this is better than no check, as Joe said.","accounts_in_message":[],"_revision_number":3},{"id":"605180fee369959149488174d93fc5ec98fe4544","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-15 07:53:21.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"cf85a730691c7171ecb2df76cc0b75c25e8a2702","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-15 18:54:55.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"24ff3c896cd8650722db4debd1dd4c546f9d47e2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-21 23:01:11.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"898d0157c8c18f156bb55080adc720ab25fbf809","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-22 09:37:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"18708c656e8f1c444e3253537d1050696aa18ec0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 10:10:42.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/18673/4/check/gate-python-novaclient-docs/570 : SUCCESS\n- http://logs.openstack.org/18673/4/check/gate-python-novaclient-pep8/878 : SUCCESS\n- http://logs.openstack.org/18673/4/check/gate-python-novaclient-python26/676 : FAILURE\n- http://logs.openstack.org/18673/4/check/gate-python-novaclient-python27/890 : FAILURE\n- http://logs.openstack.org/18673/4/check/gate-tempest-devstack-vm/27718 : SUCCESS\n- http://logs.openstack.org/18673/4/check/gate-tempest-devstack-vm-quantum/2077 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"fc3aeceb5cb58c5b5a5d214fd7f1632ea0d7f110","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-01-22 14:28:16.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nOne whitespace nitpick inline.  Otherwise LGTM.","accounts_in_message":[],"_revision_number":4},{"id":"a4b4da3978814e4ac2c2da44f406e831a1533bd5","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-22 16:31:48.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"1c00306f853f10100b74b6e0fc83be927d3f0d54","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-23 02:41:30.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"55c189be35007b868863b9c63deb9391a15a9db1","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-24 07:31:39.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"3ec3dcf19bcf3da78f1405d310595d17cd3bdaec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-24 07:59:52.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/18673/5/check/gate-python-novaclient-docs/589 : SUCCESS\n- http://logs.openstack.org/18673/5/check/gate-python-novaclient-pep8/897 : SUCCESS\n- http://logs.openstack.org/18673/5/check/gate-python-novaclient-python26/695 : SUCCESS\n- http://logs.openstack.org/18673/5/check/gate-python-novaclient-python27/909 : SUCCESS\n- http://logs.openstack.org/18673/5/check/gate-tempest-devstack-vm/28086 : SUCCESS\n- http://logs.openstack.org/18673/5/check/gate-tempest-devstack-vm-quantum/2542 : SUCCESS\n","accounts_in_message":[],"_revision_number":5},{"id":"f59fb14942316b08ef814f0c46ebc29d7c947373","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2013-01-24 08:11:08.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"4454a973f32b67d16670786a432fdcb816582d3f","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-01-24 08:11:15.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"11bc28a02294ba330fdea06d8133f7db4adae5da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-24 08:36:05.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/18673/6/check/gate-python-novaclient-docs/590 : SUCCESS\n- http://logs.openstack.org/18673/6/check/gate-python-novaclient-pep8/898 : SUCCESS\n- http://logs.openstack.org/18673/6/check/gate-python-novaclient-python26/696 : SUCCESS\n- http://logs.openstack.org/18673/6/check/gate-python-novaclient-python27/910 : SUCCESS\n- http://logs.openstack.org/18673/6/check/gate-tempest-devstack-vm/28087 : SUCCESS\n- http://logs.openstack.org/18673/6/check/gate-tempest-devstack-vm-quantum/2543 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"8b67fca9e10635f2bddcefed1bfc1ae0c925247e","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-01-24 14:02:15.000000000","message":"Patch Set 6: (4 inline comments)\n\nA few small things inline.  Otherwise LGTM.","accounts_in_message":[],"_revision_number":6},{"id":"1fd618df67741d3fc25dece6120d0932e18084ef","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-24 16:18:17.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n(4 inline comments)\n\nDavid, all your comments are on code that isn\u0027t part of the patch.  Did you compare this patch to a previous patch set and get confused by the rebasing?","accounts_in_message":[],"_revision_number":6},{"id":"db74adb146c4a8c0542337e040a59852d155ea45","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-01-24 16:19:58.000000000","message":"Patch Set 6:\n\nThe Patch Sets view in Gerrit isn\u0027t very useful; it frequently gets confused by rebasing.  I will stop using it.","accounts_in_message":[],"_revision_number":6},{"id":"79a196f99779e04e23fabf8b09b553b81d8af465","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-01-24 16:22:09.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"966fb90745f94c5745bd4859ca6a8f8fd5c30928","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-24 16:26:30.000000000","message":"Patch Set 6:\n\nDavid: Well, it is useful, you just have to be aware of its limitations :)  What I\u0027ve started doing is going through once using the patch set comparison feature, making my comments, then going through quickly a second time without using the patch set comparison—i.e., just comparing to the base revision—and altering my comments appropriately.  That\u0027s how I discovered that your comments were unrelated to his patch :)","accounts_in_message":[],"_revision_number":6},{"id":"ed7dce22d2c9ab34c4a35836101823565cb9205b","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2013-01-29 18:32:55.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"428c6bbf403a4d37118c7dfbb34617c644d71305","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 18:33:24.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"237eef340572e4893678342a76d66c800de1ccad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 20:04:35.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/18673/6/gate/gate-python-novaclient-docs/628 : SUCCESS\n- http://logs.openstack.org/18673/6/gate/gate-python-novaclient-pep8/936 : SUCCESS\n- http://logs.openstack.org/18673/6/gate/gate-python-novaclient-python26/734 : SUCCESS\n- http://logs.openstack.org/18673/6/gate/gate-python-novaclient-python27/948 : SUCCESS\n- http://logs.openstack.org/18673/6/gate/gate-tempest-devstack-vm/28793 : SUCCESS\n- http://logs.openstack.org/18673/6/gate/gate-tempest-devstack-vm-quantum/3400 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"09077ff7676a8af9b8ebe4902c908fe8aa5fbb56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 20:04:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"168636e744012f264310897603eb4e3dde6d1df8","revisions":{"e4f6793f919c1fb816fe09e2462d7b19516af5a6":{"kind":"REWORK","_number":1,"created":"2012-12-27 00:53:31.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/1"}}},"commit":{"parents":[{"commit":"fba20df12c376185eecfa21a4f54b66a72fc5365","subject":"add num_instances option for nova boot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fba20df12c376185eecfa21a4f54b66a72fc5365"}]}],"author":{"name":"vagrant","email":"vagrant@precise64.(none)","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"xu-haiwei","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-27 00:51:55.000000000","tz":0},"subject":"Adds novaclient support. Fixes bug 1088835 \"nova quota-update\" command is executed without checking the form of the project_id argument.The project_id should be in the form of UUID. The project_id of quotas should be in accord with the form of keystone\u0027s tenant_id.So this patch checks the form of the project_id when \"nova quota-update\" command is executed.","message":"Adds novaclient support.\nFixes bug 1088835\n\"nova quota-update\" command is executed without checking the form of\nthe project_id argument.The project_id should be in the form of UUID.\nThe project_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id.So this patch checks the form of the project_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e4f6793f919c1fb816fe09e2462d7b19516af5a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e4f6793f919c1fb816fe09e2462d7b19516af5a6"}]},"branch":"refs/heads/master"},"8cb3b08f0e2284a0976af3d4b9a7bd48f30ae194":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-12-27 01:56:45.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/2"}}},"commit":{"parents":[{"commit":"fba20df12c376185eecfa21a4f54b66a72fc5365","subject":"add num_instances option for nova boot.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fba20df12c376185eecfa21a4f54b66a72fc5365"}]}],"author":{"name":"vagrant","email":"vagrant@precise64.(none)","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"xu-haiwei","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-27 01:54:20.000000000","tz":0},"subject":"Fix bug in \"nova quota-update\" command","message":"Fix bug in \"nova quota-update\" command\n\nFix bug 1088835\n\"nova quota-update\" command is executed without checking the form of\nthe project_id argument.The project_id should be in the form of UUID.\nThe project_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id.So this patch checks the form of the project_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8cb3b08f0e2284a0976af3d4b9a7bd48f30ae194"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8cb3b08f0e2284a0976af3d4b9a7bd48f30ae194"}]},"branch":"refs/heads/master"},"7e9b99b9677d3d11e1ba6327ff844edfd549d9fc":{"kind":"REWORK","_number":3,"created":"2013-01-10 10:22:53.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/3"}}},"commit":{"parents":[{"commit":"4410339a453f8385809cd62a3a0289efc3964157","subject":"Merge \"Unify Manager._update behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4410339a453f8385809cd62a3a0289efc3964157"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2013-01-10 10:10:18.000000000","tz":0},"subject":"Fix bug in \"nova quota-update\" command","message":"Fix bug in \"nova quota-update\" command\n\nFix bug 1088835\n\"nova quota-update\" command is executed without checking the form of\nthe project_id argument.The project_id should be in the form of UUID.\nThe project_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id.So this patch checks the form of the project_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7e9b99b9677d3d11e1ba6327ff844edfd549d9fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7e9b99b9677d3d11e1ba6327ff844edfd549d9fc"}]},"branch":"refs/heads/master"},"ce0caa599f07a320ed3ee1ad26ca40e03b62b75e":{"kind":"REWORK","_number":4,"created":"2013-01-22 09:37:50.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/4"}}},"commit":{"parents":[{"commit":"4410339a453f8385809cd62a3a0289efc3964157","subject":"Merge \"Unify Manager._update behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4410339a453f8385809cd62a3a0289efc3964157"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2013-01-22 09:23:35.000000000","tz":0},"subject":"Fix bug in \"nova quota-update\" command","message":"Fix bug in \"nova quota-update\" command\n\nFix bug 1088835\n\"nova quota-update\" command is executed without checking the form of\nthe project_id argument.The project_id should be in the form of UUID.\nThe project_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id.So this patch checks the form of the project_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ce0caa599f07a320ed3ee1ad26ca40e03b62b75e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ce0caa599f07a320ed3ee1ad26ca40e03b62b75e"}]},"branch":"refs/heads/master"},"ff56720e784adca88b0c0d70b49695dfbe234d0f":{"kind":"REWORK","_number":5,"created":"2013-01-24 07:31:39.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/5"}}},"commit":{"parents":[{"commit":"5b8099cd0e86443697192fcdd58633a2550b4d4c","subject":"Add support for get_spice_console RPC API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5b8099cd0e86443697192fcdd58633a2550b4d4c"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2013-01-24 07:23:35.000000000","tz":0},"subject":"\"nova quota-update\" command is executed without checking the form of project_id","message":"\"nova quota-update\" command is executed without checking the form of project_id\n\nFix bug 1088835\n\"nova quota-update\" command is executed without checking the form of\nthe project_id argument.The project_id should be in the form of UUID.\nThe project_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id.So this patch checks the form of the project_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff56720e784adca88b0c0d70b49695dfbe234d0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff56720e784adca88b0c0d70b49695dfbe234d0f"}]},"branch":"refs/heads/master"},"168636e744012f264310897603eb4e3dde6d1df8":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2013-01-24 08:11:08.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/73/18673/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/73/18673/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/73/18673/6"}}},"commit":{"parents":[{"commit":"5b8099cd0e86443697192fcdd58633a2550b4d4c","subject":"Add support for get_spice_console RPC API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5b8099cd0e86443697192fcdd58633a2550b4d4c"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2012-12-26 11:24:55.000000000","tz":0},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2013-01-24 08:04:28.000000000","tz":0},"subject":"Check tenant_id\u0027s format in \"nova quota-update\"","message":"Check tenant_id\u0027s format in \"nova quota-update\"\n\nFix bug 1088835\n\"nova quota-update\" command is executed without checking the format of\nthe tenant_id argument. The tenant_id should be in the format of UUID.\nThe tenant_id of quotas should be in accord with the form of keystone\u0027s\ntenant_id. So this patch checks the format of the tenant_id when \"nova\nquota-update\" command is executed.\n\nChange-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/168636e744012f264310897603eb4e3dde6d1df8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/168636e744012f264310897603eb4e3dde6d1df8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}