)]}'
{"novaclient/tests/unit/v2/test_servers.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"77ee936a8a7df711142f0c5eb64a7092047dda25","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            key_name\u003dtest_key"},{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers\u0027)"},{"line_number":219,"context_line":"        self.assertIsInstance(s, servers.Server)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_create_server_userdata_bin(self):"},{"line_number":222,"context_line":"        with tempfile.TemporaryFile(mode\u003d\u0027wb+\u0027) as bin_file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a2c0392b","line":219,"updated":"2015-06-09 03:57:08.000000000","message":"Would you mind adding verification of the password in the request payload to this test? You can use the following the get the request body:\n\n body \u003d jsonutils.loads(self.requests.last_request.body)","commit_id":"ab3e48f8e668877d57773f9d9c98c6e5ca797ca1"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"fad57acea7a293105be949c8113692207c2b68f2","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            key_name\u003dtest_key"},{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers\u0027)"},{"line_number":219,"context_line":"        self.assertIsInstance(s, servers.Server)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_create_server_userdata_bin(self):"},{"line_number":222,"context_line":"        with tempfile.TemporaryFile(mode\u003d\u0027wb+\u0027) as bin_file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_bd917a9b","line":219,"in_reply_to":"3afb71cf_a2c0392b","updated":"2015-06-09 05:01:00.000000000","message":"Thank you for your comment.\nI added the verification to patch set 2.","commit_id":"ab3e48f8e668877d57773f9d9c98c6e5ca797ca1"}],"novaclient/v2/servers.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"76073ef14ea13056cf37c8d993a25d892cc717d8","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if config_drive:"},{"line_number":461,"context_line":"            body[\"server\"][\"config_drive\"] \u003d config_drive"},{"line_number":462,"context_line":"        if admin_pass:"},{"line_number":463,"context_line":"            body[\"server\"][\"adminPass\"] \u003d admin_pass"},{"line_number":464,"context_line":"        if not min_count:"},{"line_number":465,"context_line":"            min_count \u003d 1"},{"line_number":466,"context_line":"        if not max_count:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_5f125058","line":463,"updated":"2015-06-09 20:29:40.000000000","message":"This is where the kwarg gets added to the request body","commit_id":"953a12e986449a3bfa8b80409ecf88d93b8becd0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a87320baf9c348212c0be16a4dcf06c059e0bc93","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            max_count\u003dmax_count, security_groups\u003dsecurity_groups,"},{"line_number":911,"context_line":"            key_name\u003dkey_name, availability_zone\u003davailability_zone,"},{"line_number":912,"context_line":"            scheduler_hints\u003dscheduler_hints, config_drive\u003dconfig_drive,"},{"line_number":913,"context_line":"            disk_config\u003ddisk_config, admin_pass\u003dadmin_pass, **kwargs)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        if block_device_mapping:"},{"line_number":916,"context_line":"            resource_url \u003d \"/os-volumes_boot\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_4d8e2dd1","line":913,"updated":"2015-06-09 20:25:10.000000000","message":"If I am reading the nova code correctly, the parameter is expected to be named \"adminPass\", not \"admin_pass\" (nova/api/openstack/compute/servers.py line 1128).  I only found \"admin_pass\" mentioned in the test suite and in the virt drivers, but not in the API portions of nova.","commit_id":"953a12e986449a3bfa8b80409ecf88d93b8becd0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"76073ef14ea13056cf37c8d993a25d892cc717d8","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            max_count\u003dmax_count, security_groups\u003dsecurity_groups,"},{"line_number":911,"context_line":"            key_name\u003dkey_name, availability_zone\u003davailability_zone,"},{"line_number":912,"context_line":"            scheduler_hints\u003dscheduler_hints, config_drive\u003dconfig_drive,"},{"line_number":913,"context_line":"            disk_config\u003ddisk_config, admin_pass\u003dadmin_pass, **kwargs)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        if block_device_mapping:"},{"line_number":916,"context_line":"            resource_url \u003d \"/os-volumes_boot\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_7f3cecc7","line":913,"in_reply_to":"3afb71cf_4d8e2dd1","updated":"2015-06-09 20:29:40.000000000","message":"admin_pass is just the name of the kwarg variable doing to the create function","commit_id":"953a12e986449a3bfa8b80409ecf88d93b8becd0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"643a3ddc8551082748e35e9f03a17c46ccd30099","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            max_count\u003dmax_count, security_groups\u003dsecurity_groups,"},{"line_number":911,"context_line":"            key_name\u003dkey_name, availability_zone\u003davailability_zone,"},{"line_number":912,"context_line":"            scheduler_hints\u003dscheduler_hints, config_drive\u003dconfig_drive,"},{"line_number":913,"context_line":"            disk_config\u003ddisk_config, admin_pass\u003dadmin_pass, **kwargs)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        if block_device_mapping:"},{"line_number":916,"context_line":"            resource_url \u003d \"/os-volumes_boot\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_7fa50ca0","line":913,"in_reply_to":"3afb71cf_7f3cecc7","updated":"2015-06-09 20:37:53.000000000","message":"Ah ha!  Thanks for correcting me :)","commit_id":"953a12e986449a3bfa8b80409ecf88d93b8becd0"}]}