)]}'
{"novaclient/client.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"564307625bc64233e1e54e4a9ca3957c2986d5fd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                                            method,"},{"line_number":100,"context_line":"                                                            raise_exc\u003dFalse,"},{"line_number":101,"context_line":"                                                            **kwargs)"},{"line_number":102,"context_line":"        if not self.api_version.is_null() and \\"},{"line_number":103,"context_line":"                not resp.headers.get(\u0027X-OpenStack-Nova-API-Version\u0027):"},{"line_number":104,"context_line":"            raise exceptions.UnsupportedVersion("},{"line_number":105,"context_line":"                \"API doesn\u0027t support microversions\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_93eb7478","line":102,"updated":"2015-06-08 12:10:12.000000000","message":"If only major version(2.0, 3.0), microversions will not be used, so we should not check header for such situations.\n\nAlso, it would be nice to move this check to separate function in `novaclient.api_versions` module, since it used in two places.","commit_id":"a12f7eec4b08edb32d2a90c3a1a31e5286d258cd"},{"author":{"_account_id":9550,"name":"Eugeniya Kudryashova","email":"ekudryashova@mirantis.com","username":"ekudryashova"},"change_message_id":"f5a97f4ab5530ebafecca1b9d959dba7d198d984","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                                            method,"},{"line_number":100,"context_line":"                                                            raise_exc\u003dFalse,"},{"line_number":101,"context_line":"                                                            **kwargs)"},{"line_number":102,"context_line":"        if not self.api_version.is_null() and \\"},{"line_number":103,"context_line":"                not resp.headers.get(\u0027X-OpenStack-Nova-API-Version\u0027):"},{"line_number":104,"context_line":"            raise exceptions.UnsupportedVersion("},{"line_number":105,"context_line":"                \"API doesn\u0027t support microversions\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c885ba07","line":102,"in_reply_to":"3afb71cf_93eb7478","updated":"2015-06-08 13:02:22.000000000","message":"Done","commit_id":"a12f7eec4b08edb32d2a90c3a1a31e5286d258cd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"de6f88af8cf23fbdc481345c8e937d3aa0d958e8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                                            **kwargs)"},{"line_number":102,"context_line":"        api_versions.check_support_api_version("},{"line_number":103,"context_line":"            self.api_version,"},{"line_number":104,"context_line":"            resp.headers.get(\u0027X-OpenStack-Nova-API-Version\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if raise_exc and resp.status_code \u003e\u003d 400:"},{"line_number":107,"context_line":"            raise exceptions.from_response(resp, body, url, method)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_d2aa6570","line":104,"updated":"2015-06-29 21:41:42.000000000","message":"It would be better, if you transmit all headers to `check_support_api_version` method, since `update_headers` method is written in such way. It will help isolate all versioning stuff in one module.\n\nAlso, it would be nice to create a const string variable with \u0027X-OpenStack-Nova-API-Version\u0027 which will be used in all places.","commit_id":"a3ad234165db9666159152f7b6378489b1b60d59"}]}