)]}'
{"id":"openstack%2Fpython-novaclient~201629","triplet_id":"openstack%2Fpython-novaclient~master~I46b50df69ce0c353d2dc221ad0e6484957561bf9","project":"openstack/python-novaclient","branch":"master","topic":"mock_fix","hashtags":[],"change_id":"I46b50df69ce0c353d2dc221ad0e6484957561bf9","subject":"patch open in a context manager instead of decorator","status":"ABANDONED","created":"2015-07-14 15:24:22.000000000","updated":"2015-07-15 00:07:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"61cdd0cedb39dc14b00f78b72cf35f4e1573a344","_number":201629,"virtual_id_number":201629,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2015-07-14 17:31:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-07-14 15:27:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-14 15:27:41.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2015-07-14 17:31:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"cca395ddc8765dd8e3794828e946877a87e5fdd8","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-07-14 15:24:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e0bc1d2aecba08692e6240d2f13dbc289803125","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-07-14 15:27:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0320bb63b3fa24dfcc32ca5a162209562431275a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-14 17:31:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-python26 http://logs.openstack.org/29/201629/1/check/gate-python-novaclient-python26/77b9956/ : SUCCESS in 1m 40s\n- gate-python-novaclient-pep8 http://logs.openstack.org/29/201629/1/check/gate-python-novaclient-pep8/982db29/ : SUCCESS in 59s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/29/201629/1/check/gate-python-novaclient-docs/a8c6045//doc/build/html/ : SUCCESS in 59s\n- gate-python-novaclient-python27 http://logs.openstack.org/29/201629/1/check/gate-python-novaclient-python27/86bd6ba/ : SUCCESS in 1m 16s\n- gate-python-novaclient-python34 http://logs.openstack.org/29/201629/1/check/gate-python-novaclient-python34/c2d2fab/ : SUCCESS in 2m 18s\n- gate-python-novaclient-pypy http://logs.openstack.org/29/201629/1/check/gate-python-novaclient-pypy/9f0d980/ : SUCCESS in 2m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-novaclient http://logs.openstack.org/29/201629/1/check/gate-tempest-dsvm-neutron-src-python-novaclient/70a4a15/ : SUCCESS in 46m 21s\n- gate-novaclient-dsvm-functional http://logs.openstack.org/29/201629/1/check/gate-novaclient-dsvm-functional/e4c94e2/ : SUCCESS in 24m 57s","accounts_in_message":[],"_revision_number":1},{"id":"c44ebdefda344842a0e12292de413eb4e1d08218","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-07-15 00:07:32.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"830659d12a36915bd6fa2c8cc31b0f4868925af6","revisions":{"830659d12a36915bd6fa2c8cc31b0f4868925af6":{"kind":"REWORK","_number":1,"created":"2015-07-14 15:24:22.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/29/201629/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/29/201629/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/29/201629/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/29/201629/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/29/201629/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/29/201629/1"}}},"commit":{"parents":[{"commit":"607835980895b13a4c602fade71ec4e80d571545","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/607835980895b13a4c602fade71ec4e80d571545"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-07-14 15:13:08.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-07-14 15:21:44.000000000","tz":-240},"subject":"patch open in a context manager instead of decorator","message":"patch open in a context manager instead of decorator\n\nBecause of the test inheritance test_keypair_import is getting called\n3 times. It appears that the mock for open builtins is getting torn\ndown after it\u0027s first use, and not correctly built again on subsequent calls.\n\nIn the gate, this is a race, because we have 3 tests and 8 workers,\nand this will only fail if 2 or more of the tests happen to be\nallocated to the same worker. This can be reproduced locally with:\n\n  tox -e py27 -- --concurrency\u003d1\n\nConverting this to the context manager usage of mock appears to\nresolve the issue.\n\nChange-Id: I46b50df69ce0c353d2dc221ad0e6484957561bf9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/830659d12a36915bd6fa2c8cc31b0f4868925af6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/830659d12a36915bd6fa2c8cc31b0f4868925af6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
