)]}'
{"novaclient/client.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"90537aa79218dd2ee9db9811d88929c6c09eaee4","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                \u0027auth\u0027: {"},{"line_number":390,"context_line":"                    \u0027token\u0027: {\u0027id\u0027: self.auth_token},"},{"line_number":391,"context_line":"                },"},{"line_number":392,"context_line":"            }"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            body \u003d {\"auth\": {"},{"line_number":395,"context_line":"                    \"passwordCredentials\": {\"username\": self.user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUbg%3D","line":392,"updated":"2013-01-29 04:01:29.000000000","message":"Since another fix is needed I\u0027ll politely ask that this formatting be consistent with the formatting in the else block :)","commit_id":"849d6938046d42b3c04d20fb3f55bfc0c0354b49"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"c0af0a11bc4d43fe08afeac61155e77184d9f038","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                \u0027auth\u0027: {"},{"line_number":390,"context_line":"                    \u0027token\u0027: {\u0027id\u0027: self.auth_token},"},{"line_number":391,"context_line":"                },"},{"line_number":392,"context_line":"            }"},{"line_number":393,"context_line":"        else:"},{"line_number":394,"context_line":"            body \u003d {\"auth\": {"},{"line_number":395,"context_line":"                    \"passwordCredentials\": {\"username\": self.user,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUYM%3D","line":392,"in_reply_to":"AAAAM3%2F%2FUbg%3D","updated":"2013-01-29 05:19:14.000000000","message":"Not sure if that was politely enough, haha :-P","commit_id":"849d6938046d42b3c04d20fb3f55bfc0c0354b49"}],"novaclient/shell.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"90537aa79218dd2ee9db9811d88929c6c09eaee4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        key \u003d self.key_functor()"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            keyring.set_password(\"novaclient_auth\", key, value)"},{"line_number":95,"context_line":"        except:"},{"line_number":96,"context_line":"            pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUbs%3D","line":95,"updated":"2013-01-29 04:01:29.000000000","message":"At a minimum this should be \u0027except Exception\u0027 but ideally should be more specific. Do we know when and how this will throw exceptions?\n\nShould a warning be printed if this fails?","commit_id":"849d6938046d42b3c04d20fb3f55bfc0c0354b49"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"607c57169eeb0d38a32ccc3f2d7864fc6d166d9b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        key \u003d self.key_functor()"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            keyring.set_password(\"novaclient_auth\", key, value)"},{"line_number":95,"context_line":"        except:"},{"line_number":96,"context_line":"            pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUXk%3D","line":95,"in_reply_to":"AAAAM3%2F%2FUX0%3D","updated":"2013-01-29 05:24:27.000000000","message":"Actually, just will let the top level error handler catch this since it already logs and such.","commit_id":"849d6938046d42b3c04d20fb3f55bfc0c0354b49"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"bc9c4a973997e6b436d9c37689d1df17130033c6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        key \u003d self.key_functor()"},{"line_number":93,"context_line":"        try:"},{"line_number":94,"context_line":"            keyring.set_password(\"novaclient_auth\", key, value)"},{"line_number":95,"context_line":"        except:"},{"line_number":96,"context_line":"            pass"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FUX0%3D","line":95,"in_reply_to":"AAAAM3%2F%2FUbs%3D","updated":"2013-01-29 05:22:05.000000000","message":"The library doesn\u0027t seem to specify what could be thrown, will add in a warning + catch.","commit_id":"849d6938046d42b3c04d20fb3f55bfc0c0354b49"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"88975daf016af981c4d5b3efc7ca582019e7aec9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        token \u003d None"},{"line_number":145,"context_line":"        if HAS_KEYRING:"},{"line_number":146,"context_line":"            try:"},{"line_number":147,"context_line":"                block \u003d keyring.get_password(\u0027novaclient_auth\u0027, self._make_key())"},{"line_number":148,"context_line":"                if block:"},{"line_number":149,"context_line":"                    token, _management_url \u003d block.split(\u0027|\u0027, 1)"},{"line_number":150,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FTtk%3D","line":147,"updated":"2013-01-29 16:16:27.000000000","message":"pep8 reports that this line is too long.  You are running the test suite before submitting, right?","commit_id":"2156264ca08cda4058ad6498a0cd72784c736b75"}]}