)]}'
{"id":"openstack%2Fpython-novaclient~20708","triplet_id":"openstack%2Fpython-novaclient~master~I76c5454952824dc9c238d82af74f82ae5fc888b5","project":"openstack/python-novaclient","branch":"master","topic":"bug/1065366","hashtags":[],"change_id":"I76c5454952824dc9c238d82af74f82ae5fc888b5","subject":"Added homedir path expansion for keypair-add.","status":"MERGED","created":"2013-01-29 16:39:39.000000000","updated":"2013-01-30 01:32:42.000000000","submitted":"2013-01-30 01:32:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ddc75caf3240f2cfff535d7ec2930492e5fd648f","_number":20708,"virtual_id_number":20708,"owner":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-01-30 01:32:42.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-01-29 21:02:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2013-01-29 21:06:43.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2013-01-29 20:58:02.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-01-29 21:02:02.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-01-29 21:06:43.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-29 21:02:02.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-01-29 21:06:43.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-01-30 01:32:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"731027dc64068497ca08c89d16c1925dfdd1ab28","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-29 16:45:21.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e277142fd555569e5282627d422b0a70643633be","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-01-29 16:56:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a09732afc27f0623b86e2e08cd9ea17b1da5f6b7","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-29 16:59:16.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nSame comment as before.","accounts_in_message":[],"_revision_number":2},{"id":"715aa2a41ce21ddbae7f21d1d6f4fe4817c33692","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-29 17:00:16.000000000","message":"Patch Set 2:\n\nAlso, while I\u0027m thinking about it, you should add a test for this…making sure that both the with --pub-key and without --pub-key cases are exercised.","accounts_in_message":[],"_revision_number":2},{"id":"7aade646d491b146da27915323fd122df82ed024","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-01-29 17:11:21.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7c588440723e573bb0dd07cfd76e2e66a173f2ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 17:24:11.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20708/2/check/gate-python-novaclient-docs/612 : SUCCESS\n- http://logs.openstack.org/20708/2/check/gate-python-novaclient-pep8/920 : SUCCESS\n- http://logs.openstack.org/20708/2/check/gate-python-novaclient-python26/718 : SUCCESS\n- http://logs.openstack.org/20708/2/check/gate-python-novaclient-python27/932 : SUCCESS\n- http://logs.openstack.org/20708/2/check/gate-tempest-devstack-vm/28704 : SUCCESS\n- http://logs.openstack.org/20708/2/check/gate-tempest-devstack-vm-quantum/3308 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"99e34c13a185f5701fd4401e09f1db973908c6c4","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-01-29 20:57:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8ac1a58a2f6c01dcef211e94f1c50890b9d85d6f","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-01-29 20:58:02.000000000","message":"Patch Set 3:\n\nI looked at tests and the two scenarios are already covered: https://github.com/openstack/python-novaclient/blob/master/tests/v1_1/test_keypairs.py#L25\n\nI am open to suggestions for how to improve the tests if you could provide guidance.\n\nThanks Kevin.","accounts_in_message":[],"_revision_number":3},{"id":"26f3612773151d29ff3d73c734622db34093a6de","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-01-29 21:02:02.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"bb41202f5b91b2f4cad3b7fcf57b8baaf30472d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 21:06:43.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"12352379e9165d54ddc4bf8c536e663d7b18d3ec","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-01-29 21:06:43.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"fe8f08b03a501babb602e6807f6474ba54633cbf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-29 21:17:21.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20708/3/check/gate-python-novaclient-docs/632 : SUCCESS\n- http://logs.openstack.org/20708/3/check/gate-python-novaclient-pep8/940 : SUCCESS\n- http://logs.openstack.org/20708/3/check/gate-python-novaclient-python26/738 : SUCCESS\n- http://logs.openstack.org/20708/3/check/gate-python-novaclient-python27/952 : SUCCESS\n- http://logs.openstack.org/20708/3/check/gate-tempest-devstack-vm/28831 : SUCCESS\n- http://logs.openstack.org/20708/3/check/gate-tempest-devstack-vm-quantum/3445 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"2f9029d2da1ddf1f0248bf17fd6f34ea42bb924b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 00:18:14.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-docs/637 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-pep8/944 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-python26/740 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-python27/957 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-tempest-devstack-vm/28929 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-tempest-devstack-vm-quantum/3547 : FAILURE\n","accounts_in_message":[],"_revision_number":3},{"id":"7451591c0f649a85b05101340c15a4b804362966","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 00:40:06.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"416982d69420c4280304d8781784fcbe0e79c4a8","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-01-30 00:40:06.000000000","message":"Patch Set 3:\n\nreverify","accounts_in_message":[],"_revision_number":3},{"id":"10a65d25f2cfc19355e1869088b57cb4723d0521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 01:32:42.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"ab8a8e35819232a529ebb2d6c61231fd29b9d647","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-30 01:32:42.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-docs/639 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-pep8/946 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-python26/742 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-python-novaclient-python27/959 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-tempest-devstack-vm/28969 : SUCCESS\n- http://logs.openstack.org/20708/3/gate/gate-tempest-devstack-vm-quantum/3590 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b0e0319c6656a42040c7d5a0670548249634b665","revisions":{"76da706b693442af4237aa8646594c8d05168b86":{"kind":"REWORK","_number":1,"created":"2013-01-29 16:39:39.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/08/20708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/08/20708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/1"}}},"commit":{"parents":[{"commit":"7b6f0be8004bad874f642efaabee72dd60ad92c4","subject":"Merge \"Ensure list output function can support non-sorting printing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7b6f0be8004bad874f642efaabee72dd60ad92c4"}]}],"author":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 16:38:36.000000000","tz":0},"committer":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 16:38:36.000000000","tz":0},"subject":"Added homedir path expansion for keypair-add.","message":"Added homedir path expansion for keypair-add.\n\nChange-Id: I76c5454952824dc9c238d82af74f82ae5fc888b5\nFixes: Bug #1065366\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/76da706b693442af4237aa8646594c8d05168b86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/76da706b693442af4237aa8646594c8d05168b86"}]},"branch":"refs/heads/master"},"567320df0bd6a9ee60bbb7bf0d7a056df9411138":{"kind":"REWORK","_number":2,"created":"2013-01-29 16:56:01.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/08/20708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/08/20708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/2"}}},"commit":{"parents":[{"commit":"7b6f0be8004bad874f642efaabee72dd60ad92c4","subject":"Merge \"Ensure list output function can support non-sorting printing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7b6f0be8004bad874f642efaabee72dd60ad92c4"}]}],"author":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 16:38:36.000000000","tz":0},"committer":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 16:56:05.000000000","tz":0},"subject":"Added homedir path expansion for keypair-add.","message":"Added homedir path expansion for keypair-add.\n\nChange-Id: I76c5454952824dc9c238d82af74f82ae5fc888b5\nFixes: Bug #1065366\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/567320df0bd6a9ee60bbb7bf0d7a056df9411138"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/567320df0bd6a9ee60bbb7bf0d7a056df9411138"}]},"branch":"refs/heads/master"},"b0e0319c6656a42040c7d5a0670548249634b665":{"kind":"REWORK","_number":3,"created":"2013-01-29 20:57:03.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/08/20708/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/08/20708/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/08/20708/3"}}},"commit":{"parents":[{"commit":"7b6f0be8004bad874f642efaabee72dd60ad92c4","subject":"Merge \"Ensure list output function can support non-sorting printing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7b6f0be8004bad874f642efaabee72dd60ad92c4"}]}],"author":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 16:38:36.000000000","tz":0},"committer":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-01-29 20:57:03.000000000","tz":0},"subject":"Added homedir path expansion for keypair-add.","message":"Added homedir path expansion for keypair-add.\n\nChange-Id: I76c5454952824dc9c238d82af74f82ae5fc888b5\nFixes: Bug #1065366\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b0e0319c6656a42040c7d5a0670548249634b665"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b0e0319c6656a42040c7d5a0670548249634b665"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}