)]}'
{"novaclient/tests/functional/base.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"15424a9011c357ebe249683c0d555f46e21c00e3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        while time.time() - start_time \u003c timeout:"},{"line_number":187,"context_line":"            volume \u003d self.client.volumes.get(volume.id)"},{"line_number":188,"context_line":"            if volume.status \u003d\u003d status:"},{"line_number":189,"context_line":"                break"},{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            self.fail(\"Volume %s did not reach status %s after %d s\""},{"line_number":192,"context_line":"                      % (volume.id, status, timeout))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ebd8e881","line":189,"updated":"2015-07-30 11:49:30.000000000","message":"can we add a short configurable sleep here at the end of every iteration? otherwise, we\u0027ll be aggressively polling the API for no good reason","commit_id":"e46898c587266129f502787729c789b6a5d8ad47"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"15424a9011c357ebe249683c0d555f46e21c00e3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            self.fail(\"Volume %s did not reach status %s after %d s\""},{"line_number":192,"context_line":"                      % (volume.id, status, timeout))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def get_volume_property(self, output, property_name):"},{"line_number":195,"context_line":"        \"\"\"Extract volume property value from CLI output."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        :param output: given CLI output"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ebaa28d2","line":194,"updated":"2015-07-30 11:49:30.000000000","message":"why do you introduce this function here, if it\u0027s not used anywhere?","commit_id":"e46898c587266129f502787729c789b6a5d8ad47"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9af75dc22e4970a113c6863f7bb2d8f0643c6cc7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import time"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import fixtures"},{"line_number":17,"context_line":"import novaclient.client"},{"line_number":18,"context_line":"import os_client_config"},{"line_number":19,"context_line":"import tempest_lib.cli.base"},{"line_number":20,"context_line":"import testtools"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_e9b46936","line":17,"updated":"2015-07-30 14:39:35.000000000","message":"nit: please return this to the third group of imports (aka, local imports)","commit_id":"bff9cca1a3f12b7a4a357120f1789af29891e577"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"9af75dc22e4970a113c6863f7bb2d8f0643c6cc7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                                     **kwargs)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def wait_for_volume_status(self, volume, status, timeout\u003d60,"},{"line_number":175,"context_line":"                               poll_interval\u003d1):"},{"line_number":176,"context_line":"        \"\"\"Wait until volume reaches given status."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        :param volume_id: uuid4 id of given volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_69f619fb","line":175,"updated":"2015-07-30 14:39:35.000000000","message":"please document the new argument here","commit_id":"bff9cca1a3f12b7a4a357120f1789af29891e577"}],"novaclient/tests/functional/test_instances.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"15424a9011c357ebe249683c0d555f46e21c00e3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from novaclient.tests.functional import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def volume_id_from_cli_create(output):"},{"line_number":20,"context_line":"    \"\"\"Scrape the volume id out of the \u0027volume create\u0027 command"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    The cli for Nova automatically routes requests to the volumes"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0b24345e","side":"PARENT","line":19,"updated":"2015-07-30 11:49:30.000000000","message":"this looks like another non-related change","commit_id":"9efeb79660b387a66820f3af5af3ce33753ddd98"}]}