)]}'
{"id":"openstack%2Fpython-novaclient~21002","triplet_id":"openstack%2Fpython-novaclient~master~I2d509ed383fd8d6cef91dd0c58a51eafc6995bda","project":"openstack/python-novaclient","branch":"master","topic":"pep8","hashtags":[],"change_id":"I2d509ed383fd8d6cef91dd0c58a51eafc6995bda","subject":"Fixed 7 pep8 errors.","status":"MERGED","created":"2013-02-01 14:44:57.000000000","updated":"2013-02-01 21:42:22.000000000","submitted":"2013-02-01 21:42:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3ef1707cdfd92b86e37ff3b9bf18371e6474d061","_number":21002,"virtual_id_number":21002,"owner":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-02-01 21:42:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-02-01 15:46:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2013-02-01 19:56:22.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2013-02-01 15:53:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":1,"date":"2013-02-01 16:33:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-02-01 15:46:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2013-02-01 19:56:22.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2013-02-01 15:38:40.000000000","_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":0,"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-01 15:46:33.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-02-01 16:33:16.000000000","updated_by":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"reviewer":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"state":"REVIEWER"},{"updated":"2013-02-01 19:56:22.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-02-01 21:42:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3b17c8937deddb2367144588312e9151a649eed2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-01 15:19:09.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nThanks, but this isn\u0027t quite the way I want to see this done.  Also, why were these errors ignored by the test suite run of pep8?  I consider that a bug, and would like to see that fixed as well.","accounts_in_message":[],"_revision_number":1},{"id":"cf600662e1e13e46f273675db7b023ae67f7c459","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 15:38:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"73caad7274b2b88fbf0bad0cd68365224adfb7e5","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 15:40:33.000000000","message":"Patch Set 1:\n\nThanks for your guidance on format, Kevin, I appreciate it.\n\n\"Also, why were these errors ignored by the test suite run of pep8? I consider that a bug, and would like to see that fixed as well.\"\n\nDo you mean in Tempest, is that the test suite run you are referencing? I have never addressed Tempest before, if this is the suite you mean, I guess there is no time like the present. If you have a link to get me started, I am grateful.","accounts_in_message":[],"_revision_number":1},{"id":"74fa0d7bedd8610228104588aec98f0e94f9392e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-01 15:46:33.000000000","message":"Patch Set 2:\n\nEr, no, not tempest.  The python-novaclient test suite includes a run of pep8.  (You are running the test suite before submitting patch sets, right?  I use \"tox -e py26,pep8\" (or \"py27\" when I only have Python 2.7 available).)  It\u0027s pretty clear to me that the function calls you changed were longer than 79 characters, which pep8 should have caught and prevented from merging, so the fact that it did not implies that there\u0027s some sort of failure here.","accounts_in_message":[],"_revision_number":2},{"id":"1a98ce6bb5a751c42df5ed080b5649195b5e1775","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-01 15:46:56.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"07f1f92e14bdae6b00f43c37e269e0d2b049e076","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 15:53:28.000000000","message":"Patch Set 2:\n\nIt\u0027s pretty clear to me that the function calls you changed were longer than 79 characters, which pep8 should have caught and prevented from merging, so the fact that it did not implies that there\u0027s some sort of failure here.\n\nAh, yes, I hadn\u0027t changed these function calls originally. I got them like this in my git pull, I just got tired of looking at them. Personally I wouldn\u0027t push a patch that gave pep8 errors, I don\u0027t know who did. I just wanted to fix the pep8 errors.","accounts_in_message":[],"_revision_number":2},{"id":"d5568d800e2004d7c9e14278a289e976a963aa22","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 16:03:33.000000000","message":"Patch Set 2:\n\nI don\u0027t think pep8 errors prevent a patch from being merged, do you feel they should?\n\nIf so, I think this would affect all projects and I would need some input from more sources on this before I headed in that direction.","accounts_in_message":[],"_revision_number":2},{"id":"f6be90898f9aa316c25237f7e63db343a5fcfa99","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-01 16:06:06.000000000","message":"Patch Set 2:\n\nActually, pep8 errors *do* prevent the patch from merging; the fact that this pep8 error did not do so indicates a problem somewhere.","accounts_in_message":[],"_revision_number":2},{"id":"e5b86efebb77c811e616d61bb000e73cb1c63a4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 16:20:06.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-docs/666 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-pep8/973 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python26/769 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python27/986 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-full/397 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-quantum/4206 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"e53a633b4d64da2141241b2251089e2b047d2dca","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 16:31:12.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"bef6c47f942ef0e5b957d0993dbe77616f50f2e1","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 16:32:35.000000000","message":"Patch Set 2:\n\nActually, pep8 errors *do* prevent the patch from merging; the fact that this pep8 error did not do so indicates a problem somewhere.\n\nThank you, Kevin, I didn\u0027t know this. Hmmm, where to start looking for the issue? I will see what I come up with, thank you.","accounts_in_message":[],"_revision_number":2},{"id":"ecb68194520803d29a58de1f4978ab448ef0f36f","author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"date":"2013-02-01 16:33:16.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"4813605e9cfecc4d86f3248c24dcabf6cd9b05ff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 18:09:40.000000000","message":"Patch Set 2:\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-docs/669 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-pep8/976 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python26/772 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python27/989 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-full/407 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-quantum/4219 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"b2ad560dc4f1932c85ca66d8d15b663dc86c11cf","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2013-02-01 18:31:12.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"96cdeeebc13fbb126ba0773ea986066a1554adb0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 19:53:40.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-docs/671 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-pep8/978 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python26/774 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-python-novaclient-python27/991 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-full/421 : SUCCESS\n- http://logs.openstack.org/21002/2/check/gate-tempest-devstack-vm-quantum/4234 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"408249a58da42d1996060dbde5fa7561ef5b1ef6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 19:56:22.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"dc9b4194ab5b16969836aaaeacd83e808b4cc407","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-02-01 19:56:22.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nIt looks like the tox.ini file needs to be updated to gate on this. Fixing in forthcoming patch","accounts_in_message":[],"_revision_number":2},{"id":"936b67ea3519d9cf94406b91c11c2076ef1324ec","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 20:00:02.000000000","message":"Patch Set 2:\n\nIt looks like the tox.ini file needs to be updated to gate on this. Fixing in forthcoming patch\n\nclarkb had suggested I upgrade pep8 to 1.3.3 in novaclient - I started working on this. Are you saying you already are working on upgrading novaclient to pep8 1.3.3? If so, I will stop what I am doing, no sense duplicating work.","accounts_in_message":[],"_revision_number":2},{"id":"4d931ae7d064cdb791e83d83f5734a7e2040389a","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2013-02-01 21:14:48.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"eb57a12b45ecd149d6586c358ffc4a3d46f3498f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 21:42:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"612c910a3ad8c76143c9cdaf2a98a30a6c8952be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-01 21:42:22.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21002/2/gate/gate-python-novaclient-docs/672 : SUCCESS\n- http://logs.openstack.org/21002/2/gate/gate-python-novaclient-pep8/979 : SUCCESS\n- http://logs.openstack.org/21002/2/gate/gate-python-novaclient-python26/775 : SUCCESS\n- http://logs.openstack.org/21002/2/gate/gate-python-novaclient-python27/992 : SUCCESS\n- http://logs.openstack.org/21002/2/gate/gate-tempest-devstack-vm-full/432 : SUCCESS\n- http://logs.openstack.org/21002/2/gate/gate-tempest-devstack-vm-quantum/4248 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3ca976d4a076c13c7d68de859a8821cc281c9271","revisions":{"098e422f3f242e7e95a63d07607fa1261851bffa":{"kind":"REWORK","_number":1,"created":"2013-02-01 14:44:57.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/02/21002/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/21002/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/1"}}},"commit":{"parents":[{"commit":"0c55976957169e07a317969b10cb4282ad518587","subject":"Merge \"Add usage command to show usage for single tenant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0c55976957169e07a317969b10cb4282ad518587"}]}],"author":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-02-01 14:44:51.000000000","tz":0},"committer":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-02-01 14:44:51.000000000","tz":0},"subject":"Fixed 7 pep8 errors.","message":"Fixed 7 pep8 errors.\n\nChange-Id: I2d509ed383fd8d6cef91dd0c58a51eafc6995bda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/098e422f3f242e7e95a63d07607fa1261851bffa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/098e422f3f242e7e95a63d07607fa1261851bffa"}]},"branch":"refs/heads/master"},"3ca976d4a076c13c7d68de859a8821cc281c9271":{"kind":"REWORK","_number":2,"created":"2013-02-01 15:38:40.000000000","uploader":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"ref":"refs/changes/02/21002/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/21002/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/21002/2"}}},"commit":{"parents":[{"commit":"0c55976957169e07a317969b10cb4282ad518587","subject":"Merge \"Add usage command to show usage for single tenant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0c55976957169e07a317969b10cb4282ad518587"}]}],"author":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-02-01 14:44:51.000000000","tz":0},"committer":{"name":"Anita Kuno","email":"akuno@lavabit.com","date":"2013-02-01 15:35:21.000000000","tz":0},"subject":"Fixed 7 pep8 errors.","message":"Fixed 7 pep8 errors.\n\nChange-Id: I2d509ed383fd8d6cef91dd0c58a51eafc6995bda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3ca976d4a076c13c7d68de859a8821cc281c9271"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3ca976d4a076c13c7d68de859a8821cc281c9271"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}