)]}'
{"id":"openstack%2Fpython-novaclient~21690","triplet_id":"openstack%2Fpython-novaclient~master~If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6","project":"openstack/python-novaclient","branch":"master","topic":"bug/1116302","hashtags":[],"change_id":"If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6","subject":"Fix IOError with gnomekeyring.find_network_password_sync","status":"MERGED","created":"2013-02-11 20:58:55.000000000","updated":"2013-02-15 02:02:50.000000000","submitted":"2013-02-14 23:03:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9f4ad43ad91dac24dc847d63a81c65e274f12aec","_number":21690,"virtual_id_number":21690,"owner":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2013-02-14 23:03:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2013-02-14 18:26:58.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2013-02-14 16:59:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":1,"date":"2013-02-14 18:55:08.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"date":"2013-02-14 16:59:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-11 21:05:39.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2013-02-13 14:49:22.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-02-13 15:18:22.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2013-02-14 16:59:36.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-02-14 18:55:08.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-02-14 23:03:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7cc6c85f4a82215e71bbaba1a567d5cfacb7aa17","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2013-02-11 21:05:39.000000000","message":"Patch Set 1:\n\nMay want to do something like this:\n\nhttp://paste.openstack.org/show/31027/\n\nas we may be enforcing module-only imports soon","accounts_in_message":[],"_revision_number":1},{"id":"8827a7254b394bd94fde287aa400866cae7bb5a1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-11 21:06:25.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n","accounts_in_message":[],"_revision_number":1},{"id":"cd9ebcc6b56ec38f73abd63faacec373dd8fc386","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-11 21:10:13.000000000","message":"Patch Set 1:\n\nEr, meant to include a comment…I agree with Chris.  Also, I want more explanation of what this patch actually does and why it\u0027s necessary in the commit message…","accounts_in_message":[],"_revision_number":1},{"id":"be1325b745d3c1f014a052e4789ecdacd6f807fb","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-11 21:24:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a9cae1e55fd463923e380d510cfe69c5c17e28ef","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-11 21:54:52.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n(1 inline comment)\n\nInline is just an observation; I\u0027m happy with this as it is.","accounts_in_message":[],"_revision_number":2},{"id":"c8ae8b7af5ba6a70a41881801718398f9be0ce1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-11 22:38:44.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21690/2/check/gate-python-novaclient-docs/720 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-python-novaclient-pep8/1027 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-python-novaclient-python26/822 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-python-novaclient-python27/1040 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-tempest-devstack-vm-full/2088 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-tempest-devstack-vm-postgres-full/1814 : SUCCESS\n- http://logs.openstack.org/21690/2/check/gate-tempest-devstack-vm-quantum/6230 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"8d7fd0cd53012c05593e9ccf9b4d003f391f1c3f","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-02-13 14:49:22.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nConfirmed that it fixes the problem","accounts_in_message":[],"_revision_number":2},{"id":"e2bc349ed9ecec4f2b06daf8ad1cd4b7d65a909d","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2013-02-13 15:18:22.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nSo if I have my keyring configured to something thats not gnomekeyring (but say this import still works) this will cause it to start using gnomekeyring ioerrors, that seems sorta wrong.\n\nWhy not determine why implemenation the underlying keyring is going to use. aka keyring.get_backend() and at least alter your exception based on that instead.\n\nOr we can submit code back to the keyring library to translate that exception u are seeing being uncaught in the keyring library.\n\nhttps://bitbucket.org/kang/python-keyring-lib/src/9ee2c9bfcad7db163728a0eb9618c7fdba73a801/keyring/backends/Gnome.py?at\u003ddefault#cl-26","accounts_in_message":[],"_revision_number":2},{"id":"cab2212e944ec0314d96c75b8bc83508903617a1","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 14:26:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9e89a5d62833a99b000cf8b9606f6d88f762fa1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 14:27:20.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21690/3/check/gate-python-novaclient-pep8/1047 : FAILURE\n- gate-python-novaclient-docs : SKIPPED\n- gate-python-novaclient-python26 : SKIPPED\n- gate-python-novaclient-python27 : SKIPPED\n- gate-tempest-devstack-vm-full : SKIPPED\n- gate-tempest-devstack-vm-postgres-full : SKIPPED\n- gate-tempest-devstack-vm-quantum : SKIPPED\n","accounts_in_message":[],"_revision_number":3},{"id":"8260b0c148ef6be54bb000a34929eed0ab8e7312","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 14:27:37.000000000","message":"Patch Set 2: (1 inline comment)\n\nincorporated feedback from Kevin and Joshua\u0027s comments.","accounts_in_message":[],"_revision_number":2},{"id":"03afd70511b2255af7820231aa3ae6d7331431e6","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 14:28:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8fd1f5e30e59e0bf62d6c38edda0981f11f3ae41","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-14 14:28:42.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":4},{"id":"c9d482d52143a8e6bb147a29169f41efe732f411","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 14:40:50.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"0e4b1e39d2e79688226be08e29fb55b4b115bb85","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 14:41:38.000000000","message":"Patch Set 4:\n\nIn addition to this review, i\u0027ve submitted a pull request against the hg repo for keyring. we need this till they fix the problem and a new release is available.\n\nhttps://bitbucket.org/kang/python-keyring-lib/pull-request/23/catch-gnomekeyringioerror-please-see/diff","accounts_in_message":[],"_revision_number":4},{"id":"35443c4c2313069749e4680ccee247904436a220","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-14 15:55:50.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"2b2bcd941ab5dfd69d075016e9cc692866413fc8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 16:18:06.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21690/4/check/gate-python-novaclient-pep8/1048 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-python-novaclient-docs/739 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-python-novaclient-python26/840 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-python-novaclient-python27/1059 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-tempest-devstack-vm-full/2783 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-tempest-devstack-vm-postgres-full/2509 : SUCCESS\n- http://logs.openstack.org/21690/4/check/gate-tempest-devstack-vm-quantum/7026 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"ba15870f3562be437903e190ec469883f5d8da0b","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 16:48:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"6dd4ab21d388f5d877cf963b43a82bebd6f1440f","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 16:49:57.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"02054d528f09a08e29a865197ac6e200aa53fe25","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-14 16:56:04.000000000","message":"Patch Set 5: (1 inline comment)\n\nOne last picked nit…","accounts_in_message":[],"_revision_number":5},{"id":"8f0a6fb9b1a3a544e5d49abf3bbab8876fc1ff3d","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 16:58:20.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"aca71b7a748b65dee45241cb4ab9eac7513dbdc0","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-14 16:59:02.000000000","message":"Patch Set 5: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"aa9c688491aefc08d6e14aa731ef84ebd0af2f6e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-14 16:59:36.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"2ede0dc7d97f11f6bdbe0302c59c9cbb381a0e9e","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-14 18:26:58.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"b83245aa04e91a4f668435ee3688f1e38e44ca2d","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-14 18:27:13.000000000","message":"Patch Set 6:\n\nwaiting on the gate","accounts_in_message":[],"_revision_number":6},{"id":"5e5883601fda6a971decf8905be6a4a4307574c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 18:41:33.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21690/6/check/gate-python-novaclient-pep8/1050 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-python-novaclient-docs/741 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-python-novaclient-python26/842 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-python-novaclient-python27/1061 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-tempest-devstack-vm-full/2833 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-tempest-devstack-vm-postgres-full/2559 : SUCCESS\n- http://logs.openstack.org/21690/6/check/gate-tempest-devstack-vm-quantum/7080 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"cf7aeaeb10ab3e2e47b1190f204f1137ed657d10","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 18:55:08.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"1ed91b2b1d8a24af96f51e668b90882c8eab7b86","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-14 18:55:08.000000000","message":"Patch Set 6: Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"5033c89106d006702a8b3217bf2f5b14f8ed6d30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 23:03:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6},{"id":"43f8216f9ab35d9a0e4aa0a614cf272b4adf2157","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 23:03:14.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21690/6/gate/gate-python-novaclient-docs/746 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-python-novaclient-pep8/1055 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-python-novaclient-python26/847 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-python-novaclient-python27/1066 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-tempest-devstack-vm-full/2892 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-tempest-devstack-vm-postgres-full/2618 : SUCCESS\n- http://logs.openstack.org/21690/6/gate/gate-tempest-devstack-vm-quantum/7145 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"5c55ba1c5eff9a6b3b748a7230e802824d32822d","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2013-02-15 00:49:46.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"c7e92823ff1dfb8283b1a2b947ccb31d206f97e5","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-15 01:03:44.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"0fc2a9df851ea7313eef4e08f448ed4a3fd714b6","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-15 01:15:59.000000000","message":"Patch Set 6: (2 inline comments)\n\nouch, gerritt is not letting me amend. will open a fresh bug when this gets in.","accounts_in_message":[],"_revision_number":6},{"id":"36051e7f39dadb10e21d890074e29624a0e3d55d","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-02-15 02:02:50.000000000","message":"Patch Set 6:\n\nfollow on review - https://review.openstack.org/#/c/22009/","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"d1d4f33aca4f9753dd31972ea53ddc831b52fbfc","revisions":{"bc48af25d0a716a1d72f86852ea995603f9a40ee":{"kind":"REWORK","_number":1,"created":"2013-02-11 20:58:55.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/1"}}},"commit":{"parents":[{"commit":"0db2ff24c6e7e9104fbe1edc867297a40642ffcb","subject":"Merge \"Fix run_tests.sh --coverage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0db2ff24c6e7e9104fbe1edc867297a40642ffcb"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:58:52.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nProblem occurs when a non-root user tries to run nova client\nfrom a ssh console\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bc48af25d0a716a1d72f86852ea995603f9a40ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bc48af25d0a716a1d72f86852ea995603f9a40ee"}]},"branch":"refs/heads/master"},"edc9289504624cbe1c5756e86c4ecbf00e352ea3":{"kind":"REWORK","_number":2,"created":"2013-02-11 21:24:32.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/2"}}},"commit":{"parents":[{"commit":"0db2ff24c6e7e9104fbe1edc867297a40642ffcb","subject":"Merge \"Fix run_tests.sh --coverage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0db2ff24c6e7e9104fbe1edc867297a40642ffcb"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 21:20:39.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nfind_network_password_sync throws a gnomekeyring.IOError\nwhen a non-root user tries to run nova client\nfrom a ssh console. If we don\u0027t catch this exception nova client\nthrows the traceback (shown in the bug report) and stops.\nIf we catch this exception (just like we catch ValueError),\nand return None, Nova client executes just fine.\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/edc9289504624cbe1c5756e86c4ecbf00e352ea3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/edc9289504624cbe1c5756e86c4ecbf00e352ea3"}]},"branch":"refs/heads/master"},"47272590fb2b2cf227c6a6766aa2db0d05b12c6e":{"kind":"REWORK","_number":3,"created":"2013-02-14 14:26:32.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/3"}}},"commit":{"parents":[{"commit":"67b3db2bbcf2813f3ea99e28a445cb5e0c92f618","subject":"Merge \"Corrects 2nd argument type for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67b3db2bbcf2813f3ea99e28a445cb5e0c92f618"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-14 14:26:28.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nfind_network_password_sync throws a gnomekeyring.IOError\nwhen a non-root user tries to run nova client\nfrom a ssh console. If we don\u0027t catch this exception nova client\nthrows the traceback (shown in the bug report) and stops.\nIf we catch this exception (just like we catch ValueError),\nand return None, Nova client executes just fine.\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/47272590fb2b2cf227c6a6766aa2db0d05b12c6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/47272590fb2b2cf227c6a6766aa2db0d05b12c6e"}]},"branch":"refs/heads/master"},"76632f051a30231c8e60f87d536d162449c9fbae":{"kind":"REWORK","_number":4,"created":"2013-02-14 14:28:36.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/4"}}},"commit":{"parents":[{"commit":"67b3db2bbcf2813f3ea99e28a445cb5e0c92f618","subject":"Merge \"Corrects 2nd argument type for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67b3db2bbcf2813f3ea99e28a445cb5e0c92f618"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-14 14:28:26.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nfind_network_password_sync throws a gnomekeyring.IOError\nwhen a non-root user tries to run nova client\nfrom a ssh console. If we don\u0027t catch this exception nova client\nthrows the traceback (shown in the bug report) and stops.\nIf we catch this exception (just like we catch ValueError),\nand return None, Nova client executes just fine.\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/76632f051a30231c8e60f87d536d162449c9fbae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/76632f051a30231c8e60f87d536d162449c9fbae"}]},"branch":"refs/heads/master"},"599f6326d6832db5bf602f708d2065b25b0608b3":{"kind":"REWORK","_number":5,"created":"2013-02-14 16:48:45.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/5"}}},"commit":{"parents":[{"commit":"67b3db2bbcf2813f3ea99e28a445cb5e0c92f618","subject":"Merge \"Corrects 2nd argument type for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67b3db2bbcf2813f3ea99e28a445cb5e0c92f618"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-14 16:48:31.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nfind_network_password_sync throws a gnomekeyring.IOError\nwhen a non-root user tries to run nova client\nfrom a ssh console. If we don\u0027t catch this exception nova client\nthrows the traceback (shown in the bug report) and stops.\nIf we catch this exception (just like we catch ValueError),\nand return None, Nova client executes just fine.\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/599f6326d6832db5bf602f708d2065b25b0608b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/599f6326d6832db5bf602f708d2065b25b0608b3"}]},"branch":"refs/heads/master"},"d1d4f33aca4f9753dd31972ea53ddc831b52fbfc":{"kind":"REWORK","_number":6,"created":"2013-02-14 16:58:20.000000000","uploader":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"ref":"refs/changes/90/21690/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/90/21690/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/90/21690/6"}}},"commit":{"parents":[{"commit":"67b3db2bbcf2813f3ea99e28a445cb5e0c92f618","subject":"Merge \"Corrects 2nd argument type for logging\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/67b3db2bbcf2813f3ea99e28a445cb5e0c92f618"}]}],"author":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-11 20:55:33.000000000","tz":-300},"committer":{"name":"Davanum Srinivas","email":"dims@linux.vnet.ibm.com","date":"2013-02-14 16:58:08.000000000","tz":-300},"subject":"Fix IOError with gnomekeyring.find_network_password_sync","message":"Fix IOError with gnomekeyring.find_network_password_sync\n\nfind_network_password_sync throws a gnomekeyring.IOError\nwhen a non-root user tries to run nova client\nfrom a ssh console. If we don\u0027t catch this exception nova client\nthrows the traceback (shown in the bug report) and stops.\nIf we catch this exception (just like we catch ValueError),\nand return None, Nova client executes just fine.\n\nFixes LP# 1116302\n\nChange-Id: If6937b3f8eafb1dc55224b2ca2bd0f93ae07f8c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d1d4f33aca4f9753dd31972ea53ddc831b52fbfc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d1d4f33aca4f9753dd31972ea53ddc831b52fbfc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}